There was an error where if two auto-brightness changes came in quick
succession, the first could be treated as a user-initiated brightness
change.
1. First float change comes in: Xf
2. We write the brightness to the int-setting: Xi
3. Second float change comes in: Yf
4. Notification of the Xi change comes back to us and because X is
different from Y, we treat it as a user-change.
The result of this is that auto-brightness learned from these erroneous
"user inputs" and both the short and long term model get affected
negatively for the user. Often manifesting in brightness learning to
be too low.
The quick succession changes can happen in various situations, but
were most prominent on startup before and after a valid lux is read.
The fix is the revamp the data synchronization algorithm we use in
BrightnessSynchronizer to have updates + confirmation callback be
treated as an atomic operation before executing any other updates
that come in. In the example above, that means we run (1) (2) and (4)
before handling the new update found in (3).
Fixes: 227483176
Test: Manually verify through debug logging.
Test: atest BrightnessSynchronizerTest
Change-Id: I93856fd74e50bcda04e88a7b7e736e02faa76c8e
The feature punts to QPR so disable or remove code from the build
time.
Bug: 222185402
Test: build pass and can boot to home
Test: make sure the toolbar using local implementation
Change-Id: Idad82c3c46ddce0731a26f4599de01eecb0e52c3
This is so the soures can be accessed both fom framework and modules.
The implementation needs the local StatsLog, so cannot be reused.
Test: m
Test: atest SystemUITests
Test: make statsd_testdrive $ANDROID_HOST_OUT/bin/statsd_testdrive 90
Bug: 218862369
Change-Id: I27ebffa6817575f1377beb80f4092287d9b12c49
Merged-In: I27ebffa6817575f1377beb80f4092287d9b12c49
Since data usage related code is going to move to mainline module,
hidden classes and methods can no longer be accessed. However,
some of the hidden classes in the platform are still needed, and
cannot be moved because of other callers.
Thus, create a shared srcs filegroup to allow these classes
build with the module to solve the dependencies.
Test: TH
Bug: 204830222
Change-Id: I3813bc2177b2f0b4237056f64c57c63fa29c3081
WakeLock uses this API to add listener of type WakelockStateListener,
whenever framework enable/disable this wake lock, the onStateChanged()
callback on this listener is called.
This API can be called before or afte acquiring the wakelock. It can be
called multiple times to change to another listener.
Add test cases testNotifyWakeLockCallback() and
testNotifyWakeLockCallbackChange() in PowerManagerServiceTest.java.
Bug: 213925462
Test: atest cts/tests/tests/os/src/android/os/cts/PowerManager_WakeLockTest.java.
Change-Id: Ic59303c59e53eb974e2765e3036002ac97ce8aa5
Bug: 197684182
Created a new system service that aggregates information about:
1) signed partitions on device
2) APEXs installed on device
3) Modules installed on device
Introduces new adb shell commands as below:
adb shell cmd transparency get image_info [-a]
adb shell cmd transparency get apex_info [-v]
adb shell cmd transparency get module_info [-v]
Test: Built and tested locally on a bramble - the device boots.
Issuing adb shell commands as above provides correct outputs.
Change-Id: I2cae1bd794456688779c70c65b3f5ec8bcd7c6b3
The LogcatManagerService monitors all privileged (in AID_LOG group)
access to logd. Only Root and System Server can read the logd data
without tracking. Whenever the logd recieve privileged read data request,
the request is forwarded to the LogcatManagerService.
The LogcatManagerService can approve or decline the request via
binder RPC on logd service. The binder call is enforced by sepolicy.
That means only LogcatManagerService can use the logd binder service.
And only logd can use the logcat binder service.
The next step will add user consent requirement for the logd access.
Bug: 197901557
Test: Reboot the device, then run "adb logcat" multiple times
both during the booting and after the booting. The control flow goes
correctly as we expected.
Ignore-AOSP-First: pending fix for logcat privacy issue
Change-Id: I5e225b65357e7bfacd5c6c9cb4fab5f309803193
This is required by cameraservice_test_host. Other filegroups in this
.bp file have associated libraries, but none exists for
activity_manager_procstate_aidl.
Bug: 207411352
Test: Built libactivity_manager_procstate_aidl-cpp.
Change-Id: I24cd93271c83e825166f212e033ec5dbb05d8681
Create aidl_interface for files needed for libstatsbootstrap.
Bug: 206644307
Test: manually verified atoms could be logged
Change-Id: Ic970e99b588c9e1494a390f6c18e7925e199d5a4
StateMachine stand-alone library will replace all specific filegroup
created for module.
It will be then moved into modules-utils
precondition is not used in telephony
Bug: 198418216
Tag: #refactor
Test: Build
Change-Id: I82f45294d7f073d15f988f8ffce979096b6e51d0
StateMachine stand-alone library will replace all specific filegroup
created for module.
It will be then moved into modules-utils
Bug: 198418216
Tag: #refactor
Test: Build
Merged-In: I07260fec2c8ec4bee9ddc1ce6004622976182109
Change-Id: I07260fec2c8ec4bee9ddc1ce6004622976182109
StateMachine stand-alone library will replace all specific filegroup
created for module.
It will be then moved into modules-utils
Bug: 198418216
Tag: #refactor
Test: Build
Change-Id: I07260fec2c8ec4bee9ddc1ce6004622976182109
This library is a temporary work to link all mainline module using
statemachine.
Once this is done, we will be able to move the library to
frameworks/libs/modules-utils
also fix some typo in state* files
Cherry picked from aosp/1818896
Bug: 198418216
Tag: #refactor
Test: None
Merged-In: I1bec7c7bdb25bf3397a742a356aa1f18fddf7d89
Change-Id: I1bec7c7bdb25bf3397a742a356aa1f18fddf7d89
StateMachine stand-alone library will replace all specific filegroup
created for module.
It will be then moved into modules-utils
Preconditions and handlerExecutor are arlready moved in modules-utils
Bug: 198418216
Tag: #refactor
Test: Build
Change-Id: Ia72c92d6be150edfee3743878d988f21a585e808
This library is a temporary work to link all mainline module using
statemachine.
Once this is done, we will be able to move the library to
frameworks/libs/modules-utils
also fix some typo in state* files
Bug: 198418216
Tag: #refactor
Test: None
Change-Id: I1bec7c7bdb25bf3397a742a356aa1f18fddf7d89
For the service to be able to check permission, the AIDL interface is
exported to the virt APEX where virtualizationservice is in.
In addition, the VM permissions are granted to shell so that developers
can use the 'vm' tool on the shell.
Bug: 168588769
Test: /apex/com.android.virt/bin/vm run-app --log /dev/null
/data/local/tmp/virt/MicrodroidDemoApp.apk
/data/local/tmp/virt/MicrodroidDemoApp.apk.idsig assets/vm_config.json
Change-Id: I00db58ba9cef3b83f43db68ef86f062b59a0e6e1
This requires removal of all hidden APIs from the framework code.
Preconditions are jarjar'd into the jar.
Other APIs are replaced with system-visible equivalents.
Bug: 181787682
Bug: 146218515
Test: Presubmit
Change-Id: I6649bed3260ac08a0f66abd7a8ec545c401761fe
These annotations have been relocated to frameworks/libs/modules-utils.
This CL removes the files and updates necessary build rules.
Bug: 183133670
Test: TH
Merged-In: I024252070bd806d50d54377190fdc5cd5b4445e1
Change-Id: I834b9f5320e0b6fe8cb9feb7194c82085b805e07
These annotations have been relocated to frameworks/libs/modules-utils.
This CL removes the files and updates necessary build rules.
Bug: 183133670
Test: m
Merged-In: I834b9f5320e0b6fe8cb9feb7194c82085b805e07
Change-Id: I834b9f5320e0b6fe8cb9feb7194c82085b805e07
This change adds a "BluetoothPermissionChecker" that ensures that
all Bluetooth permission annotations are consistent. In addition, it
verifies that all Bluetooth public APIs have been audited to be
permission protected where relevant.
We've currently standardized on saying that APIs that return device
or Bluetooth state information (without sharing details about any
particular remote Bluetooth device) do not need to be permission
protected.
This change is only annotations and has no behavior changes.
Bug: 183626724
Test: ./build/soong/soong_ui.bash --make-mode Bluetooth RUN_ERROR_PRONE=true
Change-Id: Ie80b15b058359bf1e9a6ee881b89cb3e5b584ca1
The top-level Android.bp is large and difficult to navigate. Move rules
that don't have any "top level" things in them down in the core/java
directory.
Bug: 185128417
Test: m
Change-Id: I3fd90c2d5140e5716474ff1f8c58cbc1b3319e5b
The top-level Android.bp is large and difficult to navigate. Move rules
that don't have any "top level" things in them down in the core/java
directory.
Bug: 185128417
Test: m
Merged-In: I3fd90c2d5140e5716474ff1f8c58cbc1b3319e5b
Change-Id: I3fd90c2d5140e5716474ff1f8c58cbc1b3319e5b
All the java code used to build the framework jar and run metalava
was previously defined in the toplevel Android.bp files. Move these
into the subdirs where the source actually lives.
This simplifies the rules themselves (no path and needless prefix) and
declutters the top level Android.bp.
Test: m
Change-Id: I97086e309eacb879d16facb8497d9940fa5ddaf6
Introduces a new SystemService to act as intermediary between the
Perfetto trace daemon and Traceur.
Bug: 175591887
Test: adb shell service call 1 i32 0/1
Change-Id: Idea7761a8479827f0cfa561e56ba2beac3072939
The CarStatsPuller class is not needed because CarStatsService will now
directly register the VMS_CLIENT_STATS puller with StatsManager.
Test: m -j
Bug: 148123503
Change-Id: Icd46af829c8f559315f72feab1eda3b687c57148
This commit moves "IConfirmationPromptCallback.aidl" and
"IKeystoreService.aidl" to "system/security/keystore/binder" so that
"libkeystore_aidl" can be built in PDK builds.
Test: Run `cts-tradefed run cts -m CtsKeystoreTestCases` on Pixel 2017
and the test results are idential with and without this CL.
Test: Build PDK with special manifest described in
http://b/69539820#comment18 and http://b/69539820#comment19.
Test: Build a target (described in http://b/72961456) with
`platform.zip` built from master FSK source tree.
Bug: 69539820
Bug: 72961456
Change-Id: I7350f0ca943b15a6f3e40023a6cc299bdf8aed0e
Convert libs/services/Android.mk into a blueprint module so it can be
linked by other blueprint modules.
Test: mmm frameworks/base
Change-Id: I7acf9aa084d262a5aba5a58e45d9647e15c6dffb
