Commit Graph

150 Commits

Author SHA1 Message Date
Android (Google) Code Review
83b8678dd4 Merge change 5319 into donut
* changes:
  Add new APIs to LauncherActivity to be used elsewhere.
2009-06-24 20:29:21 -07:00
Dianne Hackborn
2bacbdfb51 Add new APIs to LauncherActivity to be used elsewhere. 2009-06-24 19:03:15 -07:00
Dianne Hackborn
9c8dd55a9d Fix bug 1829561 ("am profile" with bad filename kills process).
The am command is now the one that takes care of opening the target file,
handling the opened file descriptor to the process that will be profiled.
This allows you to send profile data to anywhere the shell can access, and
avoids any problems coming up from the target process trying to open the
file.
2009-06-24 16:23:14 -07:00
Mike LeBeau
35df87c631 Fix the weird anchoring of the search dropdown when pivoting into an
app for search. (This started when we moved to system process, not sure
why then, but we should be getting the dropdown to update at this point
regardless.)
2009-06-24 13:06:39 -07:00
Mike LeBeau
6f8e592347 Move to a single dropdown background for the search dialog. This one
is full-screen width but has rounded corners on the bottom so it doesn't
look crappy if the list is not full-screen height. This was already
being used for in-app search, so I just got rid of the old global search
background and use the in-app one for everything.

By removing the lines in SearchDialog, I'm causing it to rely on the
value specified for the dropdown background in
frameworks/base/core/res/res/layout/search_bar.xml.
2009-06-24 09:56:16 -07:00
Bjorn Bringert
544450b4ee Fix NPE in SuggestionsAdapter when cursor is null.
Fixes http://b/issue?id=1940013
2009-06-24 15:16:30 +01:00
Bjorn Bringert
5f80605a0b Include user query in search intents
This change adds a new intent extra field USER_QUERY set in intents
launched by the search dialog. It contains the query as typed by
the user, unaffected by query jamming or search suggestions.

Fixes http://b/issue?id=1939592
2009-06-24 12:54:28 +01:00
Bjorn Bringert
b0ae27f4e1 Store correct state in SearchDialog.onSaveInstanceState()
Adds this to the instance state bundle:
- mStoredComponentName
- mStoredAppSearchData
- mPreviousComponents

All the UI selection fields that were previously saved were removed.
It's not necessarily useful to restore the
selection, and it's hard to get right. The old code was buggy
(see http://b/issue?id=1911660) and did not restore the
list selection because that's quite hard.

Fixes http://b/issue?id=1926174
2009-06-23 13:47:31 +01:00
Android (Google) Code Review
54f156c7c4 Merge change 5006 into donut
* changes:
  Pass the originating app's versionCode along with a restore set
2009-06-22 16:47:06 -07:00
Christopher Tate
5cbbf5652a Pass the originating app's versionCode along with a restore set
This change amends the doRestore() / onRestore() interface to backup agents to
provide the integer android:versionCode of the app that stored the backup set.
This should help agents figure out how to handle whatever historical data set
they're handed at restore time.
2009-06-22 16:44:51 -07:00
Satish Sampath
662df0b963 Launch user-entered URLs directly without a web search.
This is to fix bug http://b/issue?id=1931983

Instead of changing the keyboard button from search to carriage return,
I have changed it from search to 'Go' which I find more useful since
it indicates that the user can now go to that URL.
2009-06-22 23:40:10 +01:00
Joe Onorato
06290a4bb9 Helper API cleanup. Allows multiple helpers to function,
because they'll always go in the same order, and this lets
us not have to write headers to keep them paired.
2009-06-22 13:02:24 -07:00
Bjorn Bringert
8d15382378 Make all static methods in SearchManager non-static.
They were only static because of a now removed restriction that
only activity contexts could instantiate SearchManager.
This only changes hidden APIs, but all users of the changed methods
must be updated to use them non-statically before this is submitted.
2009-06-22 13:51:48 +01:00
Bjorn Bringert
97325db856 Add non-static version of SearchManager.getSuggestions(). 2009-06-22 13:51:35 +01:00
Bjorn Bringert
a68ca641e6 Remove checks for Activity Context when creating SearchManager
Since https://android-git.corp.google.com/g/3880
all activities create a SearchManager object, to handle
saving and restoring the search dialog. This broke
ActivityUnitTestCase, since ApplicationContext.getSearchManager()
threw an exception in non-activity contexts.
This change removes the activity context check from
getSearchManager(). Since SearchManager is now just a thin
wrapper for SearchManagerService, there shouldn't be anything
activity-specific in it.

Fixes http://b/issue?id=1926254
2009-06-22 10:05:48 +01:00
Android (Google) Code Review
b4e456bf18 Merge change 4785 into donut
* changes:
  Fix issue #1753079: running instrumentation in shared processes.
2009-06-19 14:24:39 -07:00
Android (Google) Code Review
4d1b5bd148 Merge change 4808 into donut
* changes:
  Fixes #1928566. Prevents runtime restart upon configuration change.
2009-06-19 13:31:14 -07:00
Romain Guy
e35c235145 Fixes #1928566. Prevents runtime restart upon configuration change.
Managed dialogs could cause dispatchOnCreate() to be called twice, which
would cause an exception.
2009-06-19 13:18:12 -07:00
Dianne Hackborn
d97c7adfc2 Fix issue #1753079: running instrumentation in shared processes.
The check for allowing the start of an activity was broken, it was
comparing the process of that activity's application vs. the current
instrumentation target package name.  Okay it was utterly insane.

Now this check is that the target activity will be running in the
same process as the instrumentation, which is really what we want.
2009-06-19 11:37:35 -07:00
Suchi Amalapurapu
bc806f65ed Remove deprecated api. Aptly rename freeStorageWithIntent to freeStorage. 2009-06-19 10:25:37 -07:00
Android (Google) Code Review
63e7155c7d Merge change 4696 into donut
* changes:
  Fix targetSdkVersion, make resize mode a flag, delayed dexopt, easy ApplicationInfo.
2009-06-18 19:33:33 -07:00
Dianne Hackborn
5c1e00b14d Fix targetSdkVersion, make resize mode a flag, delayed dexopt, easy ApplicationInfo.
- Fix a bug where targetSdkVersion could not be set if minSdkVersion.  Stupid, stupid.
  Also make sure to fail if minSdkVersion is for a code name.  Really stupid.

- Change the API for resize compatibility mode to be a bit in the flags field, instead
  of a separate boolean.

- Implement delayed dexopting, to avoid the looong full dexopt during boot.  This is
  only enabled for "eng" builds.  When in this mode, the activity manager will make
  sure that a dexopt has been done before loading an .apk into a process, and will
  try to avoid displaying ANRs if they are due to the dexopt causing some operation
  to take longer than it normally would (though I make no guarantees about this
  totally working).

- Add API to Context to get the ApplicationInfo for its package, for easy access to
  things like targetSdkVersion.
2009-06-18 17:10:57 -07:00
Mike LeBeau
cce7dbc31e Re-enable query jamming. 2009-06-18 10:52:31 -07:00
Dianne Hackborn
c14b9ccdf1 Extend Intent/Uri conversion for use by Browser
This introduces a new Uri form of Intent with an "intent:" scheme, and a
corresponding update to the parser to handle these, so that the browser
can use this generic facility for starting activities based on the links
that are clicked and allow for web pages to link to arbitrary intents.

There is also a new "package" field on Intent which allows you to limit
the components it finds to a given package.  This replaces the new method
that was added to PackageManger for doing this when resolving activities,
and implements it for all Intent queries against the package manager.
2009-06-17 21:48:14 -07:00
Joe Onorato
83248c432f backup fixes:
- BackupTestAgent calls the DispatchHelper
- Make BackupAgent.onRestore take a BackupDataInput, not just a
  generic ParcelFileDescriptor.
2009-06-17 17:57:30 -07:00
Romain Guy
764d5331d1 Fixes #1924909. When restoring managed dialogs, do exactly the same thing as when showing a dialog. 2009-06-17 17:04:09 -07:00
Jacek Surazski
f829a78f6c add exception message to ApplicationErrorReport
useful signal for clustering
2009-06-17 21:48:17 +02:00
Suchi Amalapurapu
1ccac75e1f Remove circular dependency in PackageManager. api freeStorage uses PendingIntent from android.app
Create a new public IntentSender class that can be used by PackageManager instead.
This new class uses IIntentSender internally and can only be created by PendingIntent for now.
Provide a new getIntentSender api in PendingIntent to create an instance of this class.
Move IIntentSender and IIntentReceiver from android.app to android.content
Change imports of IIntentSender and IIntentReceiver to reflect the new package name
The PackageManager api has been named as freeStorageWithIntent and will be renamed as freeStorage
once the older api(which has been deprecated) will be removed shortly.
2009-06-17 11:31:26 -07:00
Satish Sampath
bf23fe062a Prepare SearchManager framework for adding Genie logging.
- Instead of passing the suggest provider component name as the field
  EXTRA_DATA, we now pass via the field COMPONENT_NAME
- Kept EXTRA_DATA field as is so we can use it for real extra data.
2009-06-17 13:33:12 +01:00
Android (Google) Code Review
528a29f886 Merge change 4326 into donut
* changes:
  Don't get location in search dialog.
2009-06-17 00:58:19 -07:00
Mitsuru Oshima
d9aef73f72 Squashed commit of the following:
commit 9798cd23605c96c1d6a29202f4d31f5454079b61
Author: Mitsuru Oshima <oshima@google.com>
Date:   Tue Jun 16 13:50:44 2009 -0700

    Made other toShortString in performDestroyActivity safe.

commit 19bf973df81d9d01210effb39c99e5236f2229c1
Author: Mitsuru Oshima <oshima@google.com>
Date:   Fri Jun 12 15:50:03 2009 -0700

    * component can be null after destory?
     This was causing NPE in catch block, which hides the actual exception.

Conflicts:

	core/java/android/app/ActivityThread.java
2009-06-16 20:22:12 -07:00
Android (Google) Code Review
5633034f79 Merge change 4115 into donut
* changes:
  * component can be null after destory?  This was causing NPE in catch block, which hides the actual exception.
2009-06-16 13:14:09 -07:00
Bjorn Bringert
6d3d9892c2 Don't get location in search dialog.
This change removes all location code from the
system search dialog. The code was out of sync with
the EnhancedGoogleSearchprovider, and was possibly
responsible for some network location provider
crashes.

Instead we will try to make EnhancedGoogleSearch persistent, so that
it has a reasonable location most of the time.
2009-06-16 14:50:20 +01:00
Bjorn Bringert
8d17f3f24b Run search dialog in the system process.
Fixes http://b/issue?id=1905863

This is needed to address two security issues with global search:
http://b/issue?id=1871088 (Apps can read content providers through GlobalSearch)
http://b/issue?id=1819627 (Apps can use GlobalSearch to launch arbirtrary intents)

This also fixes http://b/issue?id=1693153 (SearchManager.OnDismissListener
never gets called)

To fix the security issues, GlobalSearch also needs to require
a non-app permission to access its content provider and launch intents.
2009-06-15 09:05:26 +01:00
Joe Onorato
1cf587496f Add RestoreFileHelper, BackupDataInput, and add java wrappers for the methods on BackupDataOutput. 2009-06-12 16:21:24 -07:00
Mitsuru Oshima
12172baa6b * component can be null after destory?
This was causing NPE in catch block, which hides the actual exception.
2009-06-12 15:52:53 -07:00
Satish Sampath
7f50c08fb9 Show proper suggestion item hilite on selection.
With the new implementation of using a SuggestionItemView, we no longer need to draw a solid background for all items in the suggestion listview. Hence removing the code to draw a default white background, and make the item transparent so the listview-drawn selection hilite shows through.
2009-06-12 11:58:46 +01:00
Joe Onorato
23ecae3bbb Fix SharedPrefsBackupHelper so it doesn't hard code the paths to the files.
This took quite a bit of refactoring.
2009-06-11 11:29:57 -07:00
Satish Sampath
aba34d96fd Fix display of the selection background for search results.
I've used a simple approach of not drawing the solid background color for the selected item, thereby letting the default selection background to show through properly. This works by using the item's 'pressed' state and redraw code which are used by the listview during the tapping operation.
2009-06-11 10:24:26 +01:00
Mike LeBeau
ce0959df5c Add SUGGEST_SPINNER_WHILE_REFRESHING column constant to the SearchManager
for use in implementing Google suggestion refreshing in global search.
2009-06-11 00:41:55 +01:00
Karl Rosaen
048d1a4821 Show progress spinner while waiting for results in in app search. 2009-06-10 14:17:21 +01:00
Karl Rosaen
d4c98c4c45 Track clicks that occur after pivoting into an app from global search.
(framework portion).

Global search has a write-only content provider for reporting clicks that SearchDialog
makes use of.

update: addressed code review feedback
2009-06-09 18:51:05 +01:00
Satish Sampath
1c5fa0f310 Adds UI support for custom search widget item backgrounds.
- A new column was added to SearchManager cursors to specify background color (optional)
- Two new colour references added to the theme for normal and search widget corpus items (we need both to be opaque for the items to render properly)
- SuggestionAdapter was updated to choose the right theme colour for each item
2009-06-09 14:02:36 +01:00
Satish Sampath
f9acde2748 Include web search providers in Searchables.
- Along with ACTION_SEARCH we now enumate ACTION_WEB_SEARCH as well so web search providers are covered in the searchables list. This fixes a broken unit test.
- Moved get/setPreferredWebSearchActivity and get-all-web-search-providers implementation to this module when the searchables list gets updated, so that it happens on boot and on package add/remove events and remains up to date. The duplicate code in WebSearchProvider will be removed in a separate change.
- Also made Searchables broadcast an intent when the searchables list got rebuilt, so components such as GlobalSearch/SuggestionSources no longer need to do this on their own.
2009-06-05 10:34:53 +01:00
Christopher Tate
1885b37913 Fix backup agent unbind
The handwritten binder transaction passing wasn't propagating the agent-destroy
transaction to the client side.  Oops.

Also, remove obsolete run-one-agent code from the backup manager service.
2009-06-04 15:02:37 -07:00
Karl Rosaen
320b2eeeea SearchDialog should only do DialogCursorProtocol stuff when in global search mode. 2009-06-04 17:59:44 +01:00
Karl Rosaen
1c54cf0903 Detect impressions, and cleanup the SearchDialog / SuggestionCursor communication.
(framework portion)

There are now 4 times the search dialog will check with the cursor:
- after data set changed
- when an item is clicked
- when the cursor is about to be closed
- when an item at a particular position is detected as showing

these are now the points where we can add data in either direction, which we use to accomplish:
- finding out whether there are any pending results
- find out if there is a position at which to notify when it is displayed (the "more results" triggering)
- toggling the "more results" button
- sending the max position that was displayed when the cursor is done

the new behavior (in addition to the refactoring) is improved detection of "more results" to trigger the additional sources
(it is now precise), and detection of which items were displayed to the user.
2009-06-04 16:11:47 +01:00
Bjorn Bringert
3250fa7371 Remove support for bitmap icons in search suggestions.
This is no longer needed, since content providers can now return
AssetFileDescriptors for in-memory data.
Bitmaps in the suggestion cursor was resopnsible for lots of
unnecessary copying, since all rows are copied out of the database
regardless of how many are displayed in the UI.
2009-06-04 15:04:38 +01:00
Android (Google) Code Review
f762589d1f Merge change 3145 into donut
* changes:
  Add INTENT_ACTION_WEB_SEARCH_SETTINGS (thereby fixing the build too :)).
2009-06-04 06:10:37 -07:00
Mike LeBeau
3a27803b29 Add INTENT_ACTION_WEB_SEARCH_SETTINGS (thereby fixing the build too :)). 2009-06-04 14:09:42 +01:00