Commit Graph

28063 Commits

Author SHA1 Message Date
Hongwei Wang
37c91d5ef5 Merge "Start PiP dismiss from SysUI via TaskOrganizer" into rvc-dev 2020-03-27 19:27:08 +00:00
TreeHugger Robot
9dbc2b7ee4 Merge "Make BadgedImageView selectable when talkback is on" into rvc-dev 2020-03-27 19:10:03 +00:00
Matt Pietal
ad9c1a8816 Merge "Controls Ui - Do not update controls without STATUS_OK" into rvc-dev 2020-03-27 18:01:57 +00:00
Fabian Kozynski
9b77b19311 Merge "Fix overlap of text and star in controls" into rvc-dev 2020-03-27 17:22:59 +00:00
Fabian Kozynski
1f8d91de8c Merge "Add Secure Setting for Controls" into rvc-dev 2020-03-27 17:16:48 +00:00
Lucas Dupin
a8a6e27153 Merge "Announce when bouncer becomes visible" into rvc-dev 2020-03-27 17:03:07 +00:00
mincheli
7f17c70d03 Make BadgedImageView selectable when talkback is on
The bubble icons can be focused when using a11y service.

Bug: 152009675
Test: manual test
Change-Id: I39e0a6ea6f1d47fa266e9675d7020fbfd1b48235
2020-03-27 16:50:28 +00:00
Fabian Kozynski
c359f87e86 Merge "Prevent NPE in PagedTileLayout" into rvc-dev 2020-03-27 16:20:08 +00:00
Matt Pietal
1a209dbf44 Controls Ui - Do not update controls without STATUS_OK
Stateful controls returned from applications will have their status
flag set to indicate the state of the Control. For all non STATUS_OK
states, assume the control information isn't meant to be persisted and
do not store it.

Bug: 152525430
Test: atest ControlsControllerImplTest
Change-Id: I70c7a8f180561fff281a641b8d547af7cef17520
2020-03-27 11:58:24 -04:00
TreeHugger Robot
56ea9e9487 Merge changes I28153a56,I620224b9 into rvc-dev
* changes:
  Remove window animations for shutdown UI on TV
  Opaque background for shutdown UI on TV
2020-03-27 15:38:22 +00:00
Josh Tsuji
eb7da42d27 Merge "Assorted dot-wrangling." into rvc-dev 2020-03-27 14:45:29 +00:00
Fabian Kozynski
9b972e8ac6 Fix overlap of text and star in controls
This makes sure that the text only extends as far as the star (for
subtitle). The title text is constrained to be on top of the star.

Also:
* Make whole tile clickable
* Add ripple to tile on click

Test: manual
Fixes: 152496155

Change-Id: I284aaf5b8eb3ce761680808f93b19627cb9cc479
2020-03-27 09:28:58 -04:00
Robert Horvath
2f58649bff Remove window animations for shutdown UI on TV
If reboot happens too quickly, the video output freezes during the
fade in window enter animation. This leads to the text on the shutdown
UI being hard to read, as the window is still transparent and text from
underneath might shine through.
To resolve this, this change removes the window animations from the
shutdown UI for TVs, so that the UI appears instantly without a fade.

Bug: 152509487
Test: flash build and reboot / factory reset
Change-Id: I28153a56f3b5cfc4f89b06fcc8fe6fba935eb30b
2020-03-27 14:26:45 +01:00
Robert Horvath
d6ce2ccac7 Opaque background for shutdown UI on TV
The background of the shutdown UI was transparent.
This lead to the text on the shutdown UI being hard
to read, as text from  underneath might shine through.

This change makes the background of the shutdown UI opaque for TVs.

Bug: 152509487
Test: flash build and then factory reset / reboot the device
Change-Id: I620224b9c7b289fbf4db3ffec78007653bea0d71
2020-03-27 14:25:56 +01:00
John Li
4b1af29149 Merge "Change field type for reverse" into rvc-dev 2020-03-27 11:10:02 +00:00
Kevin Chyn
4cf90e8a83 Merge "ClearBiometricRecognized when user switches" into rvc-dev 2020-03-27 05:43:05 +00:00
John Li
e3366397af Change field type for reverse
Bug: 149984767
Test: manual
Change-Id: If80063a473efaaedc6f9d9b03e7f28ffad0279a1
2020-03-27 13:26:39 +08:00
Winson Chung
fa6a50484b Merge "Skip excluded MW mode tasks from recents and running tasks" into rvc-dev 2020-03-27 02:37:10 +00:00
Matt Pietal
e1e4e04ffe Merge "Controls UI - Support remaining confirmation dialogs" into rvc-dev 2020-03-26 23:06:36 +00:00
Matt Pietal
04dfb4263f Merge "Controls UI - Prevent parent scroll while using dragging control" into rvc-dev 2020-03-26 23:06:13 +00:00
Matt Pietal
f77d4b3d3e Merge "Controls UI - Fix routine icons" into rvc-dev 2020-03-26 23:05:35 +00:00
Lucas Dupin
ec239b9da5 Announce when bouncer becomes visible
Before we were only announcing when inflation ends, but we won't
inflate it every time it becomes visible.

Test: manual
Test: atest KeyguardBouncerTest
Fixes: 145172036
Change-Id: Iafbce10738a0906b251721a4ce4483e503ad6d91
2020-03-26 16:02:00 -07:00
Etan Cohen
79754e7519 Merge "[WIFI][SYSUI] Display Wi-Fi icon in status bar if it is the default network" into rvc-dev 2020-03-26 22:13:07 +00:00
Kevin Chyn
505eb89618 ClearBiometricRecognized when user switches
User unlock states should be cleared whenever user switches. Otherwise,
it's possible for the following sequence of events

1) Unlock first user via biometrics
2) Do not dismiss keyguard, switch to second user
3) Switch back to first user - can unlock without authenticating

Fixes: 151906507

Test: Repeat steps above, does not occur anymore
Test: atest KeyguardUpdateMonitorTest
Change-Id: I1d8e5867a18a680e85be8c335f09d4cb4209612e
2020-03-26 14:32:59 -07:00
Curtis Belmonte
8c28971edc Merge "Fix display of BiometricPrompt wipe warning dialogs" into rvc-dev 2020-03-26 20:47:38 +00:00
Joshua Tsuji
2ed260ef27 Assorted dot-wrangling.
- Fixes issue with dots showing up on the wrong side, because code assumed the stack starts on the right when it actually starts on the left now.
- Animates dots out when they're behind the stack/when collapsing from expanded state.
- Animates dots out when expanding.

Remaining issues include: hiding the app badge (deceptively hard), updating state for DND as soon as it changes (vs. when a new bubble is posted, also hard).

Test: manual
Bug: 145245204
Bug: 137213469
Change-Id: I9e2ff29c62ba8c8d0f052e42386b5d517952984e
2020-03-26 16:02:41 -04:00
Fabian Kozynski
f4674d00c6 Merge "Add more information to removed controls" into rvc-dev 2020-03-26 19:57:11 +00:00
Matt Pietal
ea87e741f1 Controls UI - Support remaining confirmation dialogs
Add support passphrase and ack dialogs. Passphrase should use the
exact same text and dialog as the PIN dialog, only defaulting to text
input.

Bug: 152517004
Test: Controls Mock App supports launching all dialog types
Change-Id: I3ebd51d656818f8edad9b70ccc8f0b89d6d8acc6
2020-03-26 14:55:20 -04:00
Maryam Karimzadehgan
4f9ab82c08 Proto changes and binary for adding more logs to the Back
Gesture. Design document:
go/logging-back-gesture.

Test: manual
Bug: 148104018
Change-Id: I63b745f30b7581306150d2d7ab1fe3cccfe5147f
2020-03-26 17:01:22 +00:00
Fabian Kozynski
a9803044be Add more information to removed controls
Removed controls should have as much cached information as possible.
This adds structure name and subtitle.
Also, if the structure is not set it would cause issues (as empty
structure is a valid structure).

Fixes: 151089232
Test: atest ControlsControllerImplTest
Test: manual
Change-Id: I6cf5f285fe85ddc78ae59133dcf406793293a3f7
2020-03-26 12:11:42 -04:00
Matt Pietal
1cbf78de6a Controls UI - Prevent parent scroll while using dragging control
Any vertical diff while dragging would stop the drag, and scroll the
parent. Request the parent to let the child maintain focus.

Bug: 152493182
Test: manual, dim a light with enough controls to scroll
Change-Id: I4b00db3501c16521dc3156dc4631aa533fdf17ae
2020-03-26 11:16:42 -04:00
Fabian Kozynski
9073ef0a5e Prevent NPE in PagedTileLayout
This CL prevents fake drag by checking ViewPager#isFakeDragging, which
is enabled by ViewPager#beginFakeDrag.

This is not a fix of the underlying issue (which is not known) but a
patch to prevent crashing.

Fixes: 149979063
Test: adb shell monkey --throttle 1000 --pct-nav 0 --pct-majornav 0 \
        --pct-touch 30 --ignore-crashes --ignore-timeouts \
        --ignore-security-exceptions -v 2000000
Change-Id: I7da764eaf20fc9d971afe2cb89b232b4efd65a3b
2020-03-26 09:29:08 -04:00
Matt Pietal
f8cc0fa2ad Controls UI - Fix routine icons
App icons may not respond well to tinting, as currently defined, and
the spec calls for them to remain untouched. Make sure to limit the
icon size.

Bug: 152397193
Test: visual

Change-Id: I36afecfc440fb82814c5bd00ca20e4d71ce40789
2020-03-26 09:28:32 -04:00
TreeHugger Robot
80a6f30ad8 Merge "Auto-expand overflow bubbles on promote" into rvc-dev 2020-03-26 02:11:56 +00:00
TreeHugger Robot
6b55cef934 Merge "Registering DeviceCallback too much" into rvc-dev 2020-03-25 21:50:12 +00:00
TreeHugger Robot
7f7f19e7d3 Merge "Enable PIP Stretch Resize." into rvc-dev 2020-03-25 21:47:52 +00:00
Lyn Han
89274b4905 Auto-expand overflow bubbles on promote
Fixes: 151766943
Test: manual - promoted bubble auto-expands
Test: atest BubbleControllerTest

Change-Id: I1b2dff17f1853ce9a3fa04bb09f2152a9eb4d578
2020-03-25 14:22:16 -07:00
Curtis Belmonte
1e6a356911 Fix display of BiometricPrompt wipe warning dialogs
Ensure that both local wipe dialogs are shown by the BiometricPrompt
credential view as appropriate:
- A "last attempt" warning dialog when the user is one failure from a wipe
- The "now wiping" dialog shows before the prompt is dismissed

Test: Manual:
1. Create a work profile via TestDPC (go/testdpc)
2. Set a work profile lock pattern/PIN/password via Settings > Security
3. Launch the work profile instance of TestDPC
4. Scroll down to "Lock screen"
5. Tap "Lock screen restrictions"
6. Select the "Work profile" tab
7. Set "Max password failures for local wipe" to 3
8. Lock & unlock the screen
9. Launch work profile app
10. Enter the wrong pattern/PIN/password three times

Fixes: 152016710
Change-Id: I3771d222aaaacef5fa70c1246432a6fd1afdcd42
2020-03-25 13:32:49 -07:00
Lucas Dupin
587562b251 Merge "Require a more specific intent" into rvc-dev 2020-03-25 20:15:56 +00:00
Robert Snoeberger
b2f07e8ba4 Registering DeviceCallback too much
Fixes: 149753846
Test: manual - play music and toggle dark mode a few times
Change-Id: I9f5ddefee23d780072fe6c57bad187c3c2ddddbb
2020-03-25 16:02:21 -04:00
Hongwei Wang
d39583af0e Start PiP dismiss from SysUI via TaskOrganizer
following ag/10570572, dismiss PiP is driven by SysUI as following
- SysUI issues WindowContainerTransaction and set the child windowing
mode at the beginning
- SysUI continues the animation
- SysUI issues WindowContainerTransaction and set the final windowing
mode at the end

This solves also the black background issue while exiting from PiP to
fullscreen mode.

Known issues
- app does not receive fullscreen configuration when transitioning from
PiP to fullscreen mode
- saving of the reentry bounds should be originated from SysUI rather
than WM going forward

Bug: 149947030
Bug: 151866274
Test: atest PinnedStackTests PipAnimationControllerTest
Change-Id: I7ed0d8b47dcc26653ebe2f3c08acab9e8b835db4
2020-03-25 12:54:08 -07:00
TreeHugger Robot
e174ee831e Merge "Separate updating views from deriving state" into rvc-dev 2020-03-25 18:56:06 +00:00
Lucas Dupin
a9afc32ddc Require a more specific intent
Fixes: 147606347
Test: run poc, device didn't reboot
Change-Id: I8f721ca659d58271880a7adbf386b270b331e55b
2020-03-25 10:46:44 -07:00
Tiger Huang
d10a12cf27 Merge "Make canBeImeTarget be compatible with legacy behavior" into rvc-dev 2020-03-25 17:36:56 +00:00
Robert Snoeberger
d8643f4fca Separate updating views from deriving state
The benefit is that icon colors and icon scaling can be performed on a
background thread and then all of the views updated on the main thread.

Bug: 150454272
Test: atest KeyguardMediaPlayerTest.kt
Test: manual - play music and look at lock screen controls
Change-Id: I2423233f1ddeb081ab420053964c2b1cb2185514
2020-03-25 13:10:00 -04:00
Etan Cohen
74b650b992 [WIFI][SYSUI] Display Wi-Fi icon in status bar if it is the default network
Wi-Fi icon was removed from status bar if it doesn't have internet
access. Rationale was that it gives users incorrect impression that
wi-Fi is enabled whereas in reality cellular is used.

However, in cases where there is no cellular Wi-Fi may be the default
network even if it has no internet access. In such cases, Wi-Fi is the
default network, always show it in the status bar.

Bug: 136473125
Test: atest NetworkControllerWifiTest
Test: visual inspection
Change-Id: I0ec189e2340d3280165cafd8747a7456f7e950f5
2020-03-25 09:41:19 -07:00
Winson Chung
e5ab0170f8 Skip excluded MW mode tasks from recents and running tasks
- Skip multi-window mode tasks with the exclude-from-recents flag from
  the visible recent tasks list
- Expose a method in LauncherApps to be able to start a shortcut with
  additional intent flags (to add the exclude-from-recents flag)
- Remove unused ActMan path (only ActTaskMan call is used now)
- Refactor the call to get the running tasks, there are currently only
  two usages of getFilteredTasks(), one is to get all the tasks, the
  other is really to get tasks that we will end up using for transitioning
  into the task in recents.

  As such, we can remove the individual ignore flags (it would get more
  complicated if we wanted to filter based on logic like MW mode +
  excluded recents only), and instead have a boolean that filters the
  running tasks based on whether they would ever show in recents at all,
  with the exception of the home and recent tasks.

Bug: 152133859
Test: atest WmTests:RunningTasksTest
Test: atest WmTests:RecentTasksTest
Change-Id: Ia4f5fd37228c72ce449490f948e923afba821bb2
Signed-off-by: Winson Chung <winsonc@google.com>
2020-03-25 09:29:29 -07:00
Ned Burns
dc3919ab66 Merge "Move inactive user filtering to its own filter" into rvc-dev 2020-03-25 16:29:21 +00:00
Josh Tsuji
040c89290b Merge "Adds SYSUI_STATE_BUBBLES_EXPANDED to QuickStepContract." into rvc-dev 2020-03-25 14:16:48 +00:00
Fabian Kozynski
bcaf0efea3 Add Secure Setting for Controls
Also:
* added to backed up settings.
* fixed imports

Test: build
Test: change setting through adb.
Bug: 152212779
Change-Id: Ia6cc7e9fb7f93842cfbf248f3e88c1d964656409
2020-03-25 09:30:13 -04:00