Commit Graph

7546 Commits

Author SHA1 Message Date
Fabian Kozynski
22a01eca60 Merge "Store state of active TileService" into sc-dev 2021-06-17 14:40:52 +00:00
Dave Mankoff
d2455e0c75 Merge "Remove listeners when destroying GlobalActionsDialog." into sc-dev 2021-06-17 13:56:15 +00:00
Josh Tsuji
f3dd83dbae Merge "Disable screen off animation in situations where it currently looks bad." into sc-dev 2021-06-17 13:45:21 +00:00
TreeHugger Robot
0ec737dab8 Merge "KeyguardIndication text updates" into sc-dev 2021-06-17 12:48:23 +00:00
Bill Lin
789f014c04 Merge "Allow one-handed mode shortcut expand notification" into sc-dev 2021-06-16 23:59:28 +00:00
TreeHugger Robot
603ade2fcc Merge "Coordinate circle reveal with authRipple" into sc-dev 2021-06-16 22:42:56 +00:00
Josh Tsuji
77484f3500 Disable screen off animation in situations where it currently looks bad.
- Use DozeParameters as source of truth for whether we will control unlocked screen off.
- Update controlScreenOff when rotation/expansion change, not just when keyguard visibility changes.

Fixes: 190478850
Fixes: 189803757
Test: screen on/off with shade expanded/collapsed and in portrait/landscape
Change-Id: I89e3dc626090580a832af296bb6665a52980640c
2021-06-16 17:53:36 -04:00
Beth Thibodeau
c1d7a61b2f Merge "Remove recommendations when setting is disabled" into sc-dev 2021-06-16 21:26:45 +00:00
Mady Mellor
4de2f90856 Merge "Fix tests - needed a reasonable max set in bubble positioner" into sc-dev 2021-06-16 20:36:05 +00:00
Caitlin Cassidy
ae8d7cff27 Merge "[Status Bar] Fix NPE in #dumpBarTransitions." into sc-dev 2021-06-16 20:21:27 +00:00
Mady Mellor
36810e7002 Merge "ignore a flaky test" into sc-dev 2021-06-16 19:16:48 +00:00
Dave Mankoff
efe6ab0fbb Remove listeners when destroying GlobalActionsDialog.
Fixes memory leaks.

Bug: 191150828
Test: atest SystemUITests
Merged-In: I04c2acf528c48eba17a828017de5f70424c09e51
Change-Id: I04c2acf528c48eba17a828017de5f70424c09e51
2021-06-16 15:11:43 -04:00
Mady Mellor
5dd3b070fc Fix tests - needed a reasonable max set in bubble positioner
Test: atest BubblesTest NewNotifPipelineBubblesTest
Bug: 191272711
Change-Id: I5806ff25b829d8d11b2c64cd528e505817ed5182
2021-06-16 12:03:16 -07:00
Josh Tsuji
87dc276313 Merge "Allow forcing status bar state changes and do so during a cancelled screen off." into sc-dev 2021-06-16 17:46:04 +00:00
Bill Lin
ca75e7e466 Allow one-handed mode shortcut expand notification
1) Add OneHandedEventCallback for WMShell to register
   callback, and if one handed mode settings set show
   notifications, when user tap one handed mode shortcut
   notify WMShell send KEYCODE_SYSTEM_NAVIGATION_DOWN
   through OneHandedEventCallback with SysUIMainExecutor.

2) Add isReady() flag in OneHandedDisplayAreaOrganizer
   and Simplify the flow of onActivatedActionChanged()
   to prevent potential race problem while auto-enable
   One-handed and immeditately startOneHanded(), however,
   DisplayAreaOrganizer#onDisplayAreaAppeared() may not
   ready for transtion yet, and result mState keep in
   unfinsihed STATE_ENTERING.

3) Adjust the transiton duration from 800ms to 600ms
   800ms is a little bit long to affect timing of
   apply runtime overlay package.

4) DelayExecute setEnabledGesturalOverlay() until
   transition finised and at most delay once.
   - onSwipeToNotificationEnabledChanged() : DelayExecute
   - onEnabledSettingChanged() : DelayExecute
   - Ctor setupGesturalOverlay() : No DelayExecute
   - mState.isTransitioning() : DelayExecute

Test: WMShellUnitTests
Bug: 182425480
Change-Id: I2615c3b30ad95a858510b4bcc73d8f343843fc96
2021-06-17 01:12:32 +08:00
Mady Mellor
179fce0fb5 ignore a flaky test
Test: treehugger
Bug: 191264972
Change-Id: I450a85406dfd4e8e6fecf878affa2c0440b8c36b
2021-06-16 10:10:03 -07:00
Josh Tsuji
b34e3b0cb7 Allow forcing status bar state changes and do so during a cancelled screen off.
During screen off, we show the AOD UI without fully switching to the KEYGUARD state. When screen off is cancelled, we ask all components to reset to the SHADE state, which should also reset the UI components we changed to show AOD. However, since the StatusBarState was already SHADE, this is ignored.

This adds a force flag, which we use when cancelling screen off to make sure that all UI components are reset to the SHADE state regardless.

Test: cancel screen off, pull down the shade
Fixes: 190986023
Change-Id: I79baeb71ac5d1ed45602ac55cdca996b3bed0ac3
2021-06-16 12:00:43 -04:00
Beth Thibodeau
6962b10349 Merge "[DO NOT MERGE] Open QS when swiping from status bar in power menu" into sc-dev 2021-06-16 15:42:18 +00:00
Caitlin Cassidy
2f583ee73a [Status Bar] Fix NPE in #dumpBarTransitions.
Test: atest
Fixes: 190927484
Change-Id: I7b0962b1240fde81c256f93a9aec479205f47101
2021-06-16 15:20:21 +00:00
Beverly
51a565fa9e KeyguardIndication text updates
- update show/hide logic of text areas on AOD and lock screen so that
the transition isn't as jumpy
- increase minimum time to show a message from 600 to 1500 (now there
are animations playing that obscure the text)
- make auth errors show in red
- update fingerprint listening state on lockout changes (still a bug
where resetLockout isn't called for udfps: b/189802462)

Test: manual
Fixes: 187675377
Bug: 190459902
Bug: 189802462
Fixes: 189072438
Change-Id: I5862ce8d0e139f0d045d77b6a7b9797aeb573186
2021-06-16 11:14:28 -04:00
Fabian Kozynski
e30529d714 Store state of active TileService
These tiles don't get polled on device startup or user change. Persist
their state (minus the icon) and retrieve when the CustomTile is
created.

Add an initialize method for QSTileImpl that gets handled in a
background thread.

Test: manual
Test: atest com.android.systemui.qs
Test: atest TileServiceTest ActiveTileServiceTest BooleanTileServiceTest
Fixes: 176789277
Change-Id: Id7775f4f2df56c25c13e2192d1bb824cb3b6a22a
2021-06-16 10:33:09 -04:00
Selim Cinek
4721ef7c65 Merge changes from topic "notif_smooth_dismissal" into sc-dev
* changes:
  Animating when the qs boundary changes due to notification interactions
  When swiping notifications it doesn't clip early anymore
  Modified the way the notifications clip to the boundary
2021-06-16 13:29:14 +00:00
Selim Cinek
a21cbcdf03 When swiping notifications it doesn't clip early anymore
Previously notifications started to clip before reaching
the edge. We're now changinging the flags to dismiss with
translation instead of clipping the contents.

This is change 1/2 as the notification container should
clip the notification now, which is especially noticeable
in split shade.

Bug: 181887261
Test: dismiss notifications, visually observe no clipping
Change-Id: I003b1486ce64dd127a90ca2d9f982230eba79f60
2021-06-16 13:40:59 +02:00
Selim Cinek
07045f95e0 Modified the way the notifications clip to the boundary
Previously the notification shade didn't clip at all to
the qs - notification boundary, which could lead to
content peaking outside of the boundary during dismissal
or other situations. We now clip to the boundary
using rounded rect clipping. This also allows us to
remove various complex clipping logic that was updating
the clipping on the top for individual notification views.

This also fixes some bugs on the split shade where the
notifications were wrongly clipped previously.

This is change 2/2 to improve the notification dismissal.

Fixes: 181887261
Test: atest SystemUITests
Merged-In: I1ebe777c50b85a500ecce22823d547c6d9c3c6d5
Change-Id: I1ebe777c50b85a500ecce22823d547c6d9c3c6d5
2021-06-16 13:40:57 +02:00
mincheli
5c8b13c47f Calculates the window height fraction on screen by the draggable bounds for magnification switch button
In the previous change ag/14776093, the window height fraction used
"windowHeightFraction = (float) mParams.y / mWindowHeight;". And it
causes the  Y-position deviated after the rotation is changed.
To correct this, we used the draggable bounds to calculate the window
height fraction.
See b/189715285#comment3

Bug: 189715285
Test: atest MagnificationModeSwitchTest
Change-Id: I1adcea12f0a96c64c9c6e386dc2feb8e3a9ffcf3
2021-06-16 01:59:16 +00:00
Beverly
28a01ca458 Coordinate circle reveal with authRipple
Move CircleReveal from StatusBar to AuthRippleController so we
can coordinate the light reveal scrim with the auth ripple when
the user uses fingerprint to authenticate on AOD.

Test: manual
Fixes: 190617092
Change-Id: If210cebb801ca0f66405401710bac6087a313eea
2021-06-15 15:36:01 -04:00
TreeHugger Robot
39e1e04a04 Merge "Disable screenOffUdfps by default" into sc-dev 2021-06-15 17:42:50 +00:00
TreeHugger Robot
199596b110 Merge "Enable a user to collapse QS directly from the home handle" into sc-dev 2021-06-15 16:16:40 +00:00
Mady Mellor
faee2e6b03 Merge "Fix launching bubbles from widgets" into sc-dev 2021-06-15 16:08:52 +00:00
TreeHugger Robot
a3b91578ee Merge "Show chevron on ScreenRecordTile" into sc-dev 2021-06-15 15:56:49 +00:00
Selim Cinek
f89a860c9d Enable a user to collapse QS directly from the home handle
Previously, this was taken by qs during collapsing.
We now allow for direct collapse when starting on the handle.

Fixes: 189427159
Test: expand qs, swipe from home handle, observe collapsing
Change-Id: Ied55a14027f003ef4fe2f6f2d4f3cf3c40070b63
2021-06-15 14:42:08 +00:00
Fabian Kozynski
33a9b54f69 Show chevron on ScreenRecordTile
Only show chevron when clicking will open a dialog.

Test: atest ScreenRecordTileTest
Fixes: 191097250
Change-Id: I752d79ebd30391d68fcce2c59ac7c68a15f8098c
2021-06-15 09:41:37 -04:00
Mady Mellor
e57920820e Fix launching bubbles from widgets
There were a couple of issues:
1) onActivityRestart wasn't checking for bubbles in the overflow
   so there were cases where we could open a bubble but weren't
2) delay opening the bubble until after the transitions have
   happened when launching from a widget, the transition could
   alter the placement of the bubble's surface resulting in
   weird UI.

Test: atest LaunchConversationActivityTest
Test: manual 1) have a bubble & convo widget for it
             2) tap on the widget => bubble opens normally, close
                the bubble & repeat that a bunch

             1) have an unopened bubble & convo widget for it
             2) get enough bubbles to push it out of the stack &
                out of the overflow
             3) tap on the widget => bubble opens

             1) have a bubble & convo widget for it, dismiss bubble
             2) tap on the widget => bubble opens normally
Bug: 188306336

Change-Id: Id68ccbfbfc6fc6949cfc257df4706b470fb78569
2021-06-14 18:25:25 -07:00
TreeHugger Robot
ff8bdd8808 Merge "Update major/minor from longpress sensor" into sc-dev 2021-06-14 18:01:48 +00:00
TreeHugger Robot
d031c6a3ce Merge "Make clock in QS not clickable" into sc-dev 2021-06-14 17:36:31 +00:00
Beverly
a276827748 Update major/minor from longpress sensor
Fixes: 190815324
Test: manual, auth from AOD works
Test: atest DozeTriggersTest
Change-Id: I6d920d541a1bea427775d53cacfbda8b24d2ca1b
2021-06-14 10:43:17 -04:00
TreeHugger Robot
c4399d63f5 Merge "Split NPVC#mQsExpansionEnabled" into sc-dev 2021-06-14 14:20:53 +00:00
TreeHugger Robot
39e9e83e00 Merge "Update text, colors, and suppression" into sc-dev 2021-06-14 12:28:00 +00:00
Michał Brzeziński
e896d41311 Merge "Adding automated test for ag/14874758" into sc-dev 2021-06-14 11:30:21 +00:00
TreeHugger Robot
40ee59c0fc Merge "Cache Typeface for later animation" into sc-dev 2021-06-13 06:14:36 +00:00
TreeHugger Robot
a59bbb7451 Merge "Fix test failure due to missing Roboto VF font" into sc-dev 2021-06-13 01:58:57 +00:00
Matt Pietal
507fe6f104 KeyguardClockPositionAlgorithm Test updates
Remove the concept of a 'preferred clock y'... not in use
anymore. Existing algo tests were designed around everything being
centered on the screen and isn't relevant. Update to reflect
everything being top-aligned.

Fixes: 190849712
Test: atest KeyguardClockPositionAlgorithmTest
Change-Id: I0a5fafb5ec36ffe6f98fdc6a44e46a65c821cc0c
2021-06-11 17:07:54 -04:00
Sally Yuen
77ea3710bb Merge "Unregister IA11yManagerClient in ToastPresenter" into sc-dev 2021-06-11 19:14:45 +00:00
Fabian Kozynski
77ec71a437 Make clock in QS not clickable
Test: manual
Test: atest QuickStatusBarHeaderControllerTest
Fixes: 188572076
Change-Id: I2fd897d42218b87881579695cb57323d98459eaa
2021-06-11 13:59:39 -04:00
Michal Brzezinski
a4ea039f05 Adding automated test for ag/14874758
Bug: 190032145
Test: NotificationPanelViewTest
Change-Id: Ib2c33a4c72cfc6bff9ef448a9aa46b5b33a87345
2021-06-11 18:26:06 +01:00
Anna Zappone
0fd70f6ad6 Update text, colors, and suppression
Bug: 190496101
Fixes: 188900924, 189147129
Test: PeopleSpaceWidgetManagerTest, local
Change-Id: Idc1cd72d698d4eccea0ea2dca9bcbada58463e87
2021-06-11 15:49:26 +01:00
Fabian Kozynski
a7a9e8d680 Split NPVC#mQsExpansionEnabled
Split it into its two inputs. It's enabled when both are.

Test: manual using LockTaskUI test
Fixes: 189191151
Change-Id: I263e9899ac0d0e8eba48de61572fe97ec925cec7
2021-06-10 16:37:55 -04:00
Beth Thibodeau
66bf998085 [DO NOT MERGE] Open QS when swiping from status bar in power menu
When there is a downward scroll or fling event that starts in the status bar
area, close the power menu and open the shade (QS if on lockscreen,
notification shade otherwise, to match behavior outside of power menu)
Single tap anywhere outside the dialog will still close it.

Fixes: 190506673
Test: manual
Test: atest GlobalActionsDialogLiteTest
Change-Id: I32239e1751e0e6f14a09e9ab6727e685e8af1008
2021-06-10 20:27:35 +00:00
Seigo Nonaka
80d73fa4eb Cache Typeface for later animation
The Paint#setFontvariationSettings always creates new Typeface instance
from scratch. To avoid unnecessary Typeface creation for the same weight
variant, cache the Typeface and use it later same animation.

Bug: 189867246
Test: atest TextAnimatorTest TextInterpolatorTest

Change-Id: I67ca72f2c54ca9caf4bcf562557ac4f24b44f01e
2021-06-10 13:01:20 -07:00
Lucas Dupin
0af4538527 Merge "Apply colors when a non managed user is added" into sc-dev 2021-06-10 15:22:02 +00:00