Add null check on EglDisplay in case unexpected NPE
Fixes: 139195633
Fixes: 139113237
Test: Run Forest for CTS x86 CtsAppTestCases on cf_x86_phone-userdebug
Test: atest com.android.systemui.glwallpaper.EglHelperTest
Change-Id: Iefb17082746bacf46b664b253a8baa8ee4b7cd68
Previously we were using a fixed duration and as a result the
scrims duration was much shorter right after boot when the
fading away duration takes 2 seconds. We're now always using
the fading away duration which simplifies also the bypass
transition.
Fixes: 138305791
Test: atest SystemUITests
Change-Id: I2eba68c75c9777ab1ba6ffadadafed3836eb74e3
My descendants will vilify this CL for generations to come. We'll
clean it up for R, but this is our last, best hope for fixing things
in Q.
Bug: 138775282
Test: manual
Change-Id: I615b2f7fddca30dae67dbaab0e5d54a824a4c441
The dynamic privacy state would briefly switch during
unlocking, leading to the view appearing even though
it was already visible.
Fixes: 138620551
Test: enable dynamic privacy, unlock with face, then unlock by dragging down, observe no weird animation
Change-Id: I3cc0945af0b83ee18cd173545a099af45b442e56
The user can now use the expand buttons and also clear
all is invisible while locked down.
The can also drag down normally to reveal the
contents of a notification.
Also, the section clear button is also properly updated
once dynamic privacy changes.
Fixes: 138671060
Fixes: 138669307
Test: drag down with notif hidden and bypass on on a sensitive notification
Change-Id: I8743400d0b46583802a8663f6723dfa6beee95c9
If there's an invalid sim that does not have a corresponding sub, the
text "Invalid card" should be appended to the current carrierText. As
this was assembled after this step (when it was empty), it ended up
replacing the correct carrierText instead of being appended.
Test: atest CarrierTextControllerTest
Bug: 138605164
Change-Id: Ibe0e2c3a218ea5c50f94e79cc46bd985b9646af0
To save power, now it's possible to specify a preferred refresh rate for
the lock screen. It's -1 by default, and should be configured on a
device overlay whenever required.
Test: manual
Test: atest StatusBarWindowControllerTest
Fixes: 138303350
Change-Id: I4d1ca210b50d32d937b0fea2fcb9e28a7c50c0b3
We cannot dismiss the bouncer when the device cannot be unlocked,
otherwise we'll be stuck looking since gatekeeper is not unlocked.
Test: face auth from AOD2 encrypted
Test: face auth from lock screen encrypted
Test: face auth from AOD2
Test: atest BiometricsUnlockControllerTest
Fixes: 138093575
Change-Id: I5c5b89ee9fa1a10cedceaf1ab227e26910beed2a
Previously the notification would be hidden so if the user would pull
out the phone from the pocket, they might not see what notification
actually alerted.
Bug: 138336424
Test: add notification while on AOD, block prox sensor, see icon
Change-Id: I8f7bd7a6a0562942ed3e12f28705043722d177e8
Scrims might be light if the wallpaper is light, but when
turning on the screen, we should always fade from black,
otherwise the display will bright up before dimming down.
Test: pulse with light wallpaper and AOD on/off
Test: press power with AOD on/off
Test: atest ScrimControllerTest
Fixes: 138097741
Change-Id: Icc1ce276c839bce248ab9362a5d8cf4905201e0e
Previous code assumed that "isHighPriority" == "is in top section",
which is not always true. Media notifs and some other notifs can appear
in the top section even if they're not high priority. Because we detect
section boundaries by iterating through the list until we find the first
notif where isHighPriority == false, we were sometimes drawing the
section boundary way too high. This change creates a new propery,
isInTopSection() that accurately tracks this state.
Setting this value in the proper location would require some seriously
destabilizing refactors, so instead we set it in the list comparator,
which is awful but here are.
Test: manual
Bug: 136709564
Change-Id: I19223720bac534ab92219a2962169097819e8efb
Test: atest KeyguardBouncerTest
Test: tap screen when unlocking without bypass mode
Fixes: 138125943
Change-Id: I9d2b58aebf42fc0d3ff3e39e97cb8734b3bbed71
User should still be able to swipe up to retry or still see
the bypass lock screen when face auth is disabled or sim
card is locked. Having different UX on those cases is
confusing.
Bug: 138125943
Change-Id: Iece4d28e7a988af846c9e8aa9eb0fff5a1d74249
When notifications were blocked due to proximity, the heads
up would never show until unlocked. We're now showing it
when the screen turns on.
This also avoids the header to be shown while the
notifications are fully collapsed, since that was the
only element that changed before.
Fixes: 137711785
Test: get hun in pocket, pull out, observe notification visible
Change-Id: I9c3d0cdc341eb2d95bcb76099e59b0d561f81210
This change stops the animation because there isn't a
transition from the no-header state to the music header
state when turning the screen off (to AOD). Since there
isn't a transition, there isn't an animation.
This assumes that there isn't a transition from unlocked to
lock screen. If there is, then there would be an animation
of the music going away while arriving at the lock screen.
Fixes: 137383007
Test: Checked repro steps in bug, clock doesn't animate.
Test: Also checked repro steps when audio is paused, clock doesn't
animate.
Test: atest KeyguardSliceProviderTest.java
Change-Id: If39777340b72bc623d6690bc4f784c7f5c26ea8d
KeyguardUpdateMonitor#isUnlockWithFacePossible was returning true
when the user had disabled face unlock.
This was causing bypass to still be enabled (hiding all notifications)
and bouncer was also being delayed, even though we were not scanning.
Fixes: 134977472
Test: auth with bypass (toggling face auth setting on/off)
Test: auth without bypass (toggling face auth setting on/off)
Change-Id: I234eb303db87fe0dafa2073a9bdf819c665018d6
This also ensures that the FalsingManagerProxy cleans up its internal instance
whenever a Phenotype flag changes.
Bug: 71762354
Test: atest SystemUITests
Change-Id: I9fa4d1344bb184dea00f92f8d265667f0be11466
Use slower animation when turning on the display, and request
a black frame when going to sleep.
Fixes: 137398766
Test: Wake up with presence sensor
Test: Wake up by uncovering prox sensor
Test: Wake up by pressing power (with AOD on or off)
Test: Receive notification from AOD
Change-Id: Ic3201e4c6b9de3d1322c9473897bca21fe63f773
Test: atest BiometricsUnlockControllerTest
Test: dismiss bouncer after hitting reply button
Test: hit back on bouncer on shade_locked
Test: tap on padlock on camera app, swipe up to retry
Bug: 134096479
Fixes: 137517676
Change-Id: I12e5bbd2c5ceac642a281fc16c5398e09e65ca9d
Previously the notification panel was fading away all together,
which doesn't work when the notifications need to stay around.
We're now fading the whole panel away.
Bug: 134952761
Test: pick up phone and unlock, observe normal behavior
Change-Id: I48d12776dc8b4bd51c1a35c2b822caeef38eb850
- Created separate path for fingerprint devices
- Restored NPV animation for fingerprint
- Created keyguard bypass mode
- Fixed issue where bypass wouldn't dismiss lock screen
Fixes: 136568545
Bug: 134952761
Test: atest BiometricUnlockControllerTest
Test: unlock with SIM PIN
Test: face unlock from LS (no bypass)
Test: face unlock from AOD2 (no bypass)
Test: face unlock from bouncer (no bypass)
Test: face unlock from shade (no bypass)
Test: face unlock from LS (bypass)
Test: face unlock from AOD2 (bypass)
Test: face unlock from bouncer (bypass)
Test: face unlock from shade (bypass)
Test: fingerprint unlock from encrypted LS
Test: fingerprint unlock from LS
Test: fingerprint unlock from AOD2
Test: fingerprint unlock from bouncer
Test: fingerprint unlock from shade
Change-Id: I28052dcb7d9701beb1eeecb6312e55e96d748614
Because of our refactoring, we would crash whenever the
user clicked on reply while pulsing and not bypassing.
Also, the user would be sent to the shade when replying
from the bypass hun or smart replying, which is wrong.
Last, the logic wasn't working when the user didn't
have security.
Fixes: 67475697
Fixes: 135958017
Test: receive HUN on AOD and other surfaces, observe normal behavior
Change-Id: I68163ccfaa2dc2d998b2d68b29168e369670fb17
