Commit Graph

7785 Commits

Author SHA1 Message Date
Tetsutoki Shiozawa
3c2cafb1cb Merge "Remove unnecessary right padding from time picker" am: 71a1e5cfe1
am: 314a239612

Change-Id: Ie5896c17bb41efbd4a627b14876abca0f177771e
2019-01-09 05:41:49 -08:00
Tetsutoki Shiozawa
7cbd19435c Remove unnecessary right padding from time picker
Symptom:
When the device language was set to Spanish, "A.M." label was not fully
displayed on the time picker widget. "M." was lacked.

Root cause:
There are unnecessary right paddings on the layout definition of time
picker. It uselessly consumes the room for ampm_layout.

Bug: 64498105
Change-Id: Ie52fafc0fb7d6d6ea5b0ca2eaeb53755d4aebc19
2019-01-08 12:14:05 +09:00
Abodunrinwa Toki
adcd10f10f RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters.
am: a69950ce18

Change-Id: I0830e1c1a1cea2fd93f0b1ed8a1a792260201bb2
2019-01-07 17:10:30 -08:00
Abodunrinwa Toki
a69950ce18 RESTRICT AUTOMERGE Do not linkify text with RLO/LRO characters.
Also don't show smart actions for selections in text with unsupported
characters.

Bug: 116321860
Test: atest android.view.textclassifier.TextClassificationManagerTest \
            android.text.util.cts.LinkifyTest \
	    android.text.util.LinkifyTest \
	    android.widget.TextViewActivityTest

Change-Id: I01b5e936aa4dfc937a98f50e9fc8171666861a61
2019-01-03 14:20:30 +00:00
Mathew Inwood
8501ae1763 Merge "Limit access to suspected false positives." am: aeda49d185
am: 152d5a5dcd

Change-Id: I8e10322e69d2d479079df5cf8fec0287c7c117f1
2019-01-02 05:00:54 -08:00
Mathew Inwood
55418eada5 Limit access to suspected false positives.
Members modified herein are suspected to be false positives: i.e. things
that were added to the greylist in P, but subsequent data analysis
suggests that they are not, in fact, used after all.

Add a maxTargetSdk=P to these APIs. This is lower-risk that simply
removing these things from the greylist, as none of out data sources are
perfect nor complete.

For APIs that are not supported yet by annotations, move them to
hiddenapi-greylist-max-p.txt instead which has the same effect.

Exempted-From-Owner-Approval: Automatic changes to the codebase
affecting only @UnsupportedAppUsage annotations, themselves added
without requiring owners approval earlier.

Bug: 115609023
Test: m
Change-Id: Ia937d8c41512e7f1b6e7f67b9104c1878b5cc3a0
Merged-In: I020a9c09672ebcae64c5357abc4993e07e744687
2018-12-28 14:26:35 +00:00
Xin Li
15b123ef45 DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into master
Bug: 120502534
Change-Id: Idc8bfb6d97a869b76cfb87ca1a494201baf9e8bd
2018-12-11 14:13:44 -08:00
Nathan Harold
41e2d7494f Merge "Move some members to the "Q blacklist"." am: f5cf9f24ed
am: 13c9e7e2f3

Change-Id: Ia2419cce28d26d9464da2a5172cb332b629e943e
2018-10-24 16:14:06 -07:00
Nathan Harold
f5cf9f24ed Merge "Move some members to the "Q blacklist"." 2018-10-23 21:53:51 +00:00
Mathew Inwood
45d2c252b1 Move some members to the "Q blacklist".
Based on some analysis, these fields/methods are likely false positives.
Set maxTargetSdk=P so that any apps using them are required to migrate off
them in future. See the bug for more details.

Exempted-From-Owner-Approval: Automatic changes to the codebase
affecting only @UnsupportedAppUsage annotations, themselves added
without requiring owners approval earlier.

Bug: 115609023
Test: m
Merged-In: I719b5c94e5b1f4fa562dd5d655953422958ad37e
Change-Id: I719b5c94e5b1f4fa562dd5d655953422958ad37e
(cherry picked from commit 8c854f86a4)
2018-10-22 17:28:24 -07:00
David Castro
8bb6b0a7fc Merge "docs: Removes reference to the clock displaying seconds" into pi-dev
am: 02bc7c2228

Change-Id: If238e952c1a923f7ac5c251c7e5c2429bf890ddd
2018-09-21 12:53:01 -07:00
TreeHugger Robot
02bc7c2228 Merge "docs: Removes reference to the clock displaying seconds" into pi-dev 2018-09-21 19:40:38 +00:00
kopriva
d366837e05 Merge "docs: fixed five typos" into pi-dev
am: 82b413428e

Change-Id: I4af571d6bcfa151235223b51cb8135fbacb62c82
2018-09-18 12:00:24 -07:00
kopriva
7ecfe31427 docs: fixed five typos
Test: make ds-docs

Bug: 37095452
Bug: 37001217
Bug: 37004068
Bug: 37015340
Bug: 37044652

Change-Id: Ib305df88b63286810d7722e73321ddb238b45e8e
Exempt-From-Owner-Approval: Docs-only change
2018-09-17 15:17:50 -07:00
David Castro
3e10355b99 docs: Removes reference to the clock displaying seconds
Test: make ds-docs

Bug: 115691112

Change-Id: Ic87d6c2806b20ed682ad0ca7e8e52e8096c9ac07
Exempt-From-Owner-Approval: Docs-only change
2018-09-17 09:38:14 -04:00
kopriva
9b641cbc71 docs: fixed instances of typo in 'overridden'
am: debd4ee72d

Change-Id: Idde6240486463dee51cdc27b8cd066a80fb869e0
2018-09-13 14:57:25 -07:00
kopriva
debd4ee72d docs: fixed instances of typo in 'overridden'
This affects several files beyond those mentioned in the bug.

I didn't fix some instances because the files had code
problems that blocked presubmit checks.

Test: make ds-docs

Bug: 37094741

Change-Id: I642f0384fef2b267ebc970bae1b4fb90bae667e7
Exempt-From-Owner-Approval: Docs-only change
2018-09-13 11:40:59 -07:00
Chih-hung Hsieh
26b072d20d Merge "Use multiple patterns and emails in per-file syntax." am: 62d0edc6ef
am: f16ded6120

Change-Id: I76a342fdc7097ba5941f78873145999612379e6c
2018-08-24 13:13:34 -07:00
Chih-hung Hsieh
f16ded6120 Merge "Use multiple patterns and emails in per-file syntax."
am: 62d0edc6ef

Change-Id: I15a2aaf9dd002f1164146d81e8adbbe2bca74231
2018-08-24 12:48:10 -07:00
Chih-Hung Hsieh
002a574a7d Use multiple patterns and emails in per-file syntax.
Test: build/make/tools/checkowners.py -c -v OWNERS
Change-Id: Ia3e1df3f5ba8ad29489a017e55890b4dbb23a64d
2018-08-23 14:53:16 -07:00
David Brazdil
e10a083e57 Merge "Greylist requested hidden API" am: 473654c377
am: 9582cf7c1b

Change-Id: I635076240a90acd213a4ec73460e882b6a1a2a74
2018-08-22 07:32:03 -07:00
David Brazdil
9582cf7c1b Merge "Greylist requested hidden API"
am: 473654c377

Change-Id: I01c25f8570851fee7f5db6f355de071acc1f095d
2018-08-22 06:08:03 -07:00
David Brazdil
473654c377 Merge "Greylist requested hidden API" 2018-08-22 09:14:05 +00:00
Mathew Inwood
5d1b9f6ef8 Merge "Add @UnsupportedAppUsage annotations" am: 6d891937a3
am: 4373a4d763

Change-Id: Ie6ca6dd36cf3fc769ce04db3de9bf762ddb97d4d
2018-08-21 13:34:09 -07:00
Mathew Inwood
4373a4d763 Merge "Add @UnsupportedAppUsage annotations"
am: 6d891937a3

Change-Id: I919b9dddda7d848dc96c83d0cfb0aa4e3179fb12
2018-08-21 13:20:01 -07:00
David Brazdil
47451322ee Greylist requested hidden API
Greylist APIs from public requests which used to be off-limits because
the classes were not discovered by Doclava.

Bug: 79904498
Bug: 79902686
Test: N/A
Change-Id: If6678bed5c2da076f97e3de7ff0bc4e7ebaf1965
2018-08-21 16:59:24 +01:00
Mathew Inwood
a85f4eb6c6 Add @UnsupportedAppUsage annotations
For packages:
  android.widget

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Change-Id: Idf7ccc7a850fa984ea16f91cdd70159087274e5c
Merged-In: Ic61019b1df85448a158fc2ba55c326353222c6b9
2018-08-21 16:08:34 +01:00
Mathew Inwood
dc236d5fce Merge "Code reformatting for upcoming automated code changes." am: 661facc2f1
am: aca9678a86

Change-Id: I153eca69dcddd809f11ebc398380a5dca9408041
2018-08-21 03:07:25 -07:00
Mathew Inwood
aca9678a86 Merge "Code reformatting for upcoming automated code changes."
am: 661facc2f1

Change-Id: Ie2c10b5d6afadec937400f651aecc08a9aa494df
2018-08-21 02:54:18 -07:00
Mathew Inwood
986d790edb Code reformatting for upcoming automated code changes.
Adding annotations to individual fields cannot be easily done when there
are two fields defined in a single statement. Put each definition in a
statement of its own.

See go/UnsupportedAppUsage for more context.

Bug: 110868826
Test: m
Change-Id: If3adee4136f3c406e9cebd9d2845b22b979b8353
2018-08-20 14:55:21 +01:00
Mathew Inwood
640fa1526d Merge "Code reformatting for upcoming automated code changes." am: d68f003c67
am: d48ec695d3

Change-Id: Ic0c27635bc63b0cfdf437fc819b52b9cb2d5244e
2018-08-17 01:54:58 -07:00
Mathew Inwood
d48ec695d3 Merge "Code reformatting for upcoming automated code changes."
am: d68f003c67

Change-Id: I4c95500cddf7659b13ada0ad70584aef190ced7f
2018-08-17 01:44:55 -07:00
Mathew Inwood
74e7aed9c6 Code reformatting for upcoming automated code changes.
Adding annotations to individual fields cannot be easily done when there
are two fields defined in a single statement. Put each definition in a
statement of its own.

See go/UnsupportedAppUsage for more context.

Bug: 110868826
Test: m
Change-Id: I7756185bdfdca15fa8f73ef4b76c4f70abcd8ea6
2018-08-16 17:29:31 +01:00
Joshua Baxter
b8a1004a72 Merge "docs: fixed typo" into pi-dev
am: 9ef8b6521c

Change-Id: I0f187f9d208d37dccc3b221fe41130173db951b1
2018-08-14 13:31:20 -07:00
Joshua Baxter
9ef8b6521c Merge "docs: fixed typo" into pi-dev 2018-08-14 20:02:53 +00:00
Vu Thanh Cong
bc7b84e463 Merge "Fix edge effect not showing up on first scroll" am: 894d8cf470
am: 391a7c381d

Change-Id: Icda44b95c21c99dc1de794f83bc28995a001c55a
2018-07-25 10:35:10 -07:00
Vu Thanh Cong
391a7c381d Merge "Fix edge effect not showing up on first scroll"
am: 894d8cf470

Change-Id: I6ab2b6a141f3cd52e9732d8c9965dc1c22c303f5
2018-07-25 10:22:20 -07:00
Treehugger Robot
894d8cf470 Merge "Fix edge effect not showing up on first scroll" 2018-07-25 16:43:11 +00:00
Neil Fuller
3208539011 Merge "Avoid use of DateUtilsBridge.icuTimeZone()" am: e859c42e23
am: 25fd54f6f3

Change-Id: I0083ddcadbc391a26ae8d264f8626bdf3b8f988f
2018-07-16 01:58:14 -07:00
Neil Fuller
25fd54f6f3 Merge "Avoid use of DateUtilsBridge.icuTimeZone()"
am: e859c42e23

Change-Id: I6b6452f9609d88ce61959e7c4ae4f0fd8fa97e64
2018-07-16 01:50:04 -07:00
Shrijana Ghimire
9ef41ccf42 Merge "docs: Fixed typos in AdapterView Javadoc." into pi-dev 2018-07-13 19:03:24 +00:00
Neil Fuller
6d5c4a8d8d Avoid use of DateUtilsBridge.icuTimeZone()
DateUtilsBridge is only used in one place in framework.
The usage is avoidable by sticking to java.util. This
decreases the number of non-public libcore classes in
use by framework.

Test: build
Bug: 111055375
Change-Id: Ifd6576b5b6df1e154f16ec201a4575d0b95de66d
2018-07-13 19:54:29 +01:00
Laura Davis
3175696a46 docs: fixed broken link
Test: make ds-docs

Bug: 76021493
Change-Id: Ide61b82925270896e373083fdc1d5c27c9bdc819
2018-06-19 10:11:36 -07:00
Philip P. Moltmann
004e489a25 Abbreviate permission labels less aggressively
We switched the package installer app to always abbreviate all labels
loaded from foreign packages. This is done so that a foreign app cannot
crorrupt the UI via super-long strings.

The default abbreviation is very aggressive and abbreviates to ~5 cm.

When an app with a targetSDK <= M gets installed, all permissions will
get auto-granted. Hence when a user side-loads such an app, we show the
permissions during install so that the user is aware of this.

Unfortunately most permission labels and restrictions do not fit into a
single line.

This change allows much longer strings for permissions names and
descriptions. It still abbreviates eventually and handles permission
descriptions with weird characters (such as back-space) correctly.

Fixes: 110209410
Test: Side-loaded old app and verified that permission labels and
      descriptions are not abbreviated.

Change-Id: Ie1db240883c9f5cb9c1b74ca7bdcb80625e3f7f2
2018-06-14 11:52:14 -07:00
Shrijana Ghimire
fb53deca41 docs: Fixed typos in AdapterView Javadoc.
Replaced the word 'as' with 'has' and replaced 'id' with 'if'.

Test: make ds-docs

Bug: 36946939
Change-Id: I05828e2ee20309556ffbf56cff0093183dabc088
2018-06-12 09:34:30 -07:00
Selim Cinek
a2537b7269 Merge "Fix exception from DateTimeView unregisters receiver again" into pi-dev 2018-06-06 18:18:27 +00:00
Riddle Hsu
e8f0fe3140 Fix exception from DateTimeView unregisters receiver again
Although parent view may invoke onDetachedFromWindow incorrectly,
itself should guarantee to unregister receiver only when removing
the last attached view.

Change-Id: I4b701c223c6aa354896a4067f77aad9c98d88dfd
Fixes: 78506836
Test: atest FrameworksCoreTests:DateTimeViewTest
2018-06-06 07:54:21 +08:00
Clara Bayarri
038f7a8b09 Fix repeated calls into reportExtractedText
As part of adding the hint text feature in
I357dd5c74b61d149cf8612d1f52c7118ec70c696  I refactored
the code inside reportExtractedText to avoid nesting but lost one
of the condition checks in the process. Since onDraw calls into
this method on each frame, the missing check was causing calls to be
made into the IME even when no content or selection changes have
happened.

Test: CtsWidgetTestCases:.TextViewTest
Bug: 73613936
Change-Id: If56e3f1d45e64dccd052e4cff4d742f0cbecc07c
2018-06-05 13:41:58 +01:00
Joshua Baxter
df66bfaa0d docs: fixed typo
Test: make ds-docs

Bug: 78873111
Change-Id: I7c50d83ee0c55dae6aecadc676fe784c1727ef7a
2018-06-04 13:30:17 -07:00
Mihai Popa
6e8e27bf9a Fix monkey crash in smart selection animation
In Id65443e93d277c106ea955c867d39e94192cc55d we fixed a monkey crash
happening when the smart selected text had changed while the smart
selection animation was running. However, the change introduced a new
crash, happening when the smart selection result was null. This CL fixes
it, and lets startSelectionActionMode run even when the result is null,
as there seems to be some logic there which should happen in this case.

Bug: 80244201
Test: none
Change-Id: I7f0304446dec85578bdcd5011d2e9ea2737d3c36
(cherry picked from commit a9d27ea869)
Merged-in: I7f0304446dec85578bdcd5011d2e9ea2737d3c36
2018-05-25 14:01:23 +00:00