Commit Graph

14881 Commits

Author SHA1 Message Date
Joanne Chung
ae50c82e5d Merge "Made AutofillId.withoutSession is testable." 2020-06-04 01:50:18 +00:00
Robert Snoeberger
2948d93dae Merge "Revert "Exception if receive move withouth down"" into rvc-dev am: b1d2c79448 am: 10ec898b25 am: da72ee3c05 am: 4a3a89811f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11694777

Change-Id: Idc276d91f167edc2c6dea7e7b5bb14e511467f77
2020-06-03 20:57:28 +00:00
Robert Snoeberger
da72ee3c05 Merge "Revert "Exception if receive move withouth down"" into rvc-dev am: b1d2c79448 am: 10ec898b25
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11694777

Change-Id: I77e95fcc42c65c0adbcf01b5abedca3013c7b5d0
2020-06-03 20:31:49 +00:00
Robert Snoeberger
b1d2c79448 Merge "Revert "Exception if receive move withouth down"" into rvc-dev 2020-06-03 20:17:09 +00:00
Robert Snoeberger
0ef6f01bd1 Revert "Exception if receive move withouth down"
This reverts commit a0a20dc23b.

Reason for revert: This is causing a number of fatal crashes in SystemUI. See b/158081578, b/158057055, b/158060735, and b/158061923.

Fixes: 158081578
Fixes: 158057055
Fixes: 158060735
Fixes: 158061923
Change-Id: If7e6cd4ade3df540ba7d97d9265564132a235292
2020-06-03 20:15:44 +00:00
Joanne Chung
91c3c2a9f0 Made AutofillId.withoutSession is testable.
Bug: 156408900
Test: atest android.autofillservice.cts.inline.\
InlineAugmentedWebViewActivityTest

Change-Id: I27d1227f858aac83b3de1cb8ef719edf177524dc
2020-06-03 07:41:00 +00:00
TreeHugger Robot
e16da8b9fb Merge "Fix AugmentedAutofillService onFillRequest() wrong focused AutofillId for WebView" into rvc-dev am: cc4f13e0ab am: b1fe173f1f am: 29db7bbc0f am: 24b1d00e4d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11700779

Change-Id: I2b2c652efef5e0bab8779044b03adf168209625a
2020-06-02 22:01:52 +00:00
TreeHugger Robot
29db7bbc0f Merge "Fix AugmentedAutofillService onFillRequest() wrong focused AutofillId for WebView" into rvc-dev am: cc4f13e0ab am: b1fe173f1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11700779

Change-Id: I136fc09325e61766fcece3439c9ee4f41e442c57
2020-06-02 21:23:08 +00:00
TreeHugger Robot
cc4f13e0ab Merge "Fix AugmentedAutofillService onFillRequest() wrong focused AutofillId for WebView" into rvc-dev 2020-06-02 20:54:18 +00:00
TreeHugger Robot
cc253794cf Merge "Move TextureLayer into android.graphics" 2020-06-02 20:22:13 +00:00
Rob Carr
c28035a9e4 Merge "SurfaceView: Lock mDeferredDestroySurfaceControl" into rvc-dev am: 28fdf609dc am: 9f6a76be41 am: e2d843987f am: 5e211a2336
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11688831

Change-Id: Ib0084e842d7c347da4de7d5a05954194048e728f
2020-06-02 20:08:02 +00:00
Rob Carr
5e211a2336 Merge "SurfaceView: Lock mDeferredDestroySurfaceControl" into rvc-dev am: 28fdf609dc am: 9f6a76be41 am: e2d843987f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11688831

Change-Id: Idb9b29b27186cd967d5c256fac7697480b96235b
2020-06-02 19:53:58 +00:00
Rob Carr
af66d06d09 Merge "SurfaceView: Lock mDeferredDestroySurfaceControl" into rvc-dev am: 28fdf609dc am: 9f6a76be41
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11688831

Change-Id: I9e2020c53fadf96186be1d8bd2bdd064a216549c
2020-06-02 19:41:14 +00:00
Rob Carr
28fdf609dc Merge "SurfaceView: Lock mDeferredDestroySurfaceControl" into rvc-dev 2020-06-02 19:27:08 +00:00
TreeHugger Robot
e5ce72eb8e Merge "Exception if receive move withouth down" into rvc-dev am: 46c51b716d am: 073799ef7e am: 8d3d65da33 am: 69d772635b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11056879

Change-Id: I8fef6cb7a8aad16fe5f06df542a83b4fe0d0827a
2020-06-02 18:41:08 +00:00
TreeHugger Robot
69d772635b Merge "Exception if receive move withouth down" into rvc-dev am: 46c51b716d am: 073799ef7e am: 8d3d65da33
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11056879

Change-Id: Ifad03544675b1af9273c3cbb0907ddd55fa2ccb4
2020-06-02 18:23:27 +00:00
Leon Scroggins III
87d429262b Move TextureLayer into android.graphics
Bug: 155905258
Test: make and boot

It is tightly integrated with android.graphics.HardwareRenderer, and
this follows on I30d34055b6870dc1039f190a88f4a747cee17300, which moved
the native component into android_graphics_TextureLayer.cpp, and
Ifa044281a3c36cbc1b413175711e9b172cda640f, which registers its JNI along
with other graphics classes.

Make TextureLayer AutoCloseable, replacing destroy() with close(). Add
annotations where appropriate.

Change-Id: I1b146ff02a20751246636144c88fe6f8eec43514
2020-06-02 14:20:05 -04:00
Robert Carr
6ce9ffb2cd SurfaceView: Lock mDeferredDestroySurfaceControl
Since mDeferredDestroySurfaceControl is the same underlying
object as mSurfaceControl we also need to hold the mSurfaceControlLock
when writing to it.

Bug: 157657896
Test: Existing tests pass
Change-Id: Ie0da3ed5d94c7aae2593423fa2767dbc902da4c8
2020-06-02 18:11:51 +00:00
TreeHugger Robot
8926f912a0 Merge "Exception if receive move withouth down" into rvc-dev am: 46c51b716d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11056879

Change-Id: Ic1065ae4be0aaa260e016791d0b4f6b1146a1468
2020-06-02 17:53:05 +00:00
TreeHugger Robot
46c51b716d Merge "Exception if receive move withouth down" into rvc-dev 2020-06-02 17:40:24 +00:00
Joanne Chung
fbc89efee3 Fix AugmentedAutofillService onFillRequest() wrong focused AutofillId for WebView
When AutofillManagerService try to trigger AugmentedAutofill, it uses
AutofillId.withoutSession() to get the AutollId without session. It
will return invalid "parentId:NO_ID" if the virtual AutofillId is
created with FLAG_IS_VIRTUAL_INT. The virtual AutofillId flag should
be FLAG_IS_VIRTUAL_INT or FLAG_IS_VIRTUAL_LONG, we should get
mVirtualIntId for FLAG_IS_VIRTUAL_INT or mVirtualLongId for
FLAG_IS_VIRTUAL_LONG.

Bug: 156408900
Test: atest android.autofillservice.cts.augmented
Test: atest android.view.autofill.AutofillIdTest#\
testVirtual_Long_withoutSession
Test: atest android.view.autofill.AutofillIdTest#\
testVirtual_Int_withoutSession
Test: Manual. Write a simple cts test for webview and check the
focused AutofillId is correct while switching between the field.

Change-Id: I7ebb4d7cfb6d6f383724b798dae69269ae3a27be
2020-06-03 01:06:24 +08:00
arthurhung
a0a20dc23b Exception if receive move withouth down
Throw an IllegalStateException if recevie touch move without down,
that could give an explicit feedback about GestureDetector may not
receive the full touch stream.

Bug: 149578486
Test: manual
Change-Id: I644ec1bebbca66dd0f0c219b63a6478b1290d1e1
2020-06-02 10:27:11 +08:00
TreeHugger Robot
9952cb5f33 Merge "Remove additional sf transaction when constructing a leash" into rvc-dev am: 1b2dfb04c8 am: 4b706dd16b am: d1ced29285 am: 82d691df6f
Original change: undetermined

Change-Id: Ie680b269d42554fde8b8ab60ddd639ec04b2a96a
2020-06-02 00:53:32 +00:00
TreeHugger Robot
82d691df6f Merge "Remove additional sf transaction when constructing a leash" into rvc-dev am: 1b2dfb04c8 am: 4b706dd16b am: d1ced29285
Original change: undetermined

Change-Id: I27d47c024ce0fac44a7082e2f32090d328f88d47
2020-06-02 00:32:05 +00:00
Evan Rosky
629f35b32d Merge "Use boundsChangeTransaction to improve split-screen enter/exit" into rvc-dev am: 82352f9db8 am: eabcec5bf2 am: 1c32099b52 am: af08a6eefd
Original change: undetermined

Change-Id: I173df952538a9ee3d998e3ee57e54d63c616119f
2020-06-02 00:03:51 +00:00
TreeHugger Robot
6ef0f44cd6 Merge "Remove additional sf transaction when constructing a leash" into rvc-dev am: 1b2dfb04c8
Original change: undetermined

Change-Id: I92757af1f5f39b3691a074145108a18ae78ea94d
2020-06-01 23:55:49 +00:00
TreeHugger Robot
1b2dfb04c8 Merge "Remove additional sf transaction when constructing a leash" into rvc-dev 2020-06-01 23:41:12 +00:00
Evan Rosky
1c32099b52 Merge "Use boundsChangeTransaction to improve split-screen enter/exit" into rvc-dev am: 82352f9db8 am: eabcec5bf2
Original change: undetermined

Change-Id: If6e10ed11410345824417a2da9820c4e54bfb47a
2020-06-01 23:34:58 +00:00
Evan Rosky
015fdf2638 Merge "Use boundsChangeTransaction to improve split-screen enter/exit" into rvc-dev am: 82352f9db8
Original change: undetermined

Change-Id: I13d05a0941b9f5676668c3f94bf2ffcac1dc79f3
2020-06-01 23:18:12 +00:00
Evan Rosky
82352f9db8 Merge "Use boundsChangeTransaction to improve split-screen enter/exit" into rvc-dev 2020-06-01 22:55:20 +00:00
Steven Thomas
f075595bba Merge "Clarify FRAME_RATE_COMPATIBILITY_* params" into rvc-dev am: 061dec3e8d am: 39bdd7a712 am: edf7f828e4 am: 41807f06e3
Original change: undetermined

Change-Id: I7cd900f1782c3e2d3cd3618d941ba993d1e6dac8
2020-06-01 22:05:47 +00:00
Steven Thomas
edf7f828e4 Merge "Clarify FRAME_RATE_COMPATIBILITY_* params" into rvc-dev am: 061dec3e8d am: 39bdd7a712
Change-Id: I3d8ef49874f9d18c38bc9c99323ebb2dfce67737
2020-06-01 21:18:05 +00:00
Steven Thomas
cf89cad345 Merge "Clarify FRAME_RATE_COMPATIBILITY_* params" into rvc-dev am: 061dec3e8d
Original change: undetermined

Change-Id: I125d7c28abd8049036c02479ea2a5245689f9caf
2020-06-01 20:58:32 +00:00
Steven Thomas
061dec3e8d Merge "Clarify FRAME_RATE_COMPATIBILITY_* params" into rvc-dev 2020-06-01 20:44:30 +00:00
Evan Rosky
3613854d1b Use boundsChangeTransaction to improve split-screen enter/exit
Uses applySyncTransaction to synchronize all the surface
updates during split-screen enter/exit.

In Divider, all syncTransactions are serialized and runnables
can be posted to operate on the returned transactions so
they happen all at once.

This also required adding a "merge" functionality on
WindowContainerTransactions to handle racing between rotation
and other in-flight sync transactions (because they are
serialized, sometimes they got delayed).

Bug: 153579514
Test: Enter/exit split-screen and observe no flickers
Change-Id: I57df13489247f3c4fb3ca59efa26867a872e447f
2020-06-01 11:33:27 -07:00
Yara Hassan
297394e38d Add finish() method to DataShare Read and Write Adapters am: dc699fb8ce am: 6dd5caab66 am: feece5dae2 am: 8e07922b64
Change-Id: I4fd5540ecaf56afae4289bd9010ebbbfb5389875
2020-05-30 00:37:01 +00:00
Yara Hassan
8e07922b64 Add finish() method to DataShare Read and Write Adapters am: dc699fb8ce am: 6dd5caab66 am: feece5dae2
Change-Id: I6829c43d760e9441297344793e61dce6c8038074
2020-05-30 00:17:31 +00:00
Yara Hassan
795f3ee445 Add finish() method to DataShare Read and Write Adapters am: dc699fb8ce
Change-Id: Ie391d155a80ec2656d28bce9dc3ca2d9d0c05757
2020-05-29 23:51:08 +00:00
Yara Hassan
6dd5caab66 Add finish() method to DataShare Read and Write Adapters am: dc699fb8ce
Change-Id: I747217a8f7808a9dec4d5fb03daeeaec0bc107a8
2020-05-29 23:50:57 +00:00
Ahaan Ugale
44489b9680 Merge "AF Inline: Notify the registered AutofillCallback, also fix filtering." into rvc-dev am: 7f3570724d am: 8ea92c81c6 am: 3690f137a2 am: c9040026ef
Change-Id: Id0fd361837ca9396350c71e670f5a3129e4ffba6
2020-05-29 23:37:17 +00:00
Ahaan Ugale
4d8efece25 Merge changes from topic "Data Share Sender Crash" into rvc-dev
* changes:
  Handle sender's crash in Data Share API
  Add finish() method to DataShare Read and Write Adapters
2020-05-29 23:32:48 +00:00
Ahaan Ugale
c9040026ef Merge "AF Inline: Notify the registered AutofillCallback, also fix filtering." into rvc-dev am: 7f3570724d am: 8ea92c81c6 am: 3690f137a2
Change-Id: Ie7312b19bf2a1385a4ac750fd90b4b44e1c6e42d
2020-05-29 23:27:12 +00:00
Ahaan Ugale
b93b20a453 Merge "AF Inline: Notify the registered AutofillCallback, also fix filtering." into rvc-dev am: 7f3570724d
Change-Id: I40d4a4f6b99b57bd68427e82524af734615e5d8a
2020-05-29 23:07:37 +00:00
Joanne Chung
9e34dcd775 Merge "Update textclassifier OWNER file." am: d1182b54c3 am: e4e6a3fabb am: a65d687ac8 am: 531b0bd989 am: 5fa218937d
Change-Id: I53b83fc0dad5279b3f601718d7499a88bdb0b1f0
2020-05-29 22:57:55 +00:00
Joanne Chung
a65d687ac8 Merge "Update textclassifier OWNER file." am: d1182b54c3 am: e4e6a3fabb
Change-Id: Ib9657448666652e66956b2c1c3309bbcae352daa
2020-05-29 22:09:44 +00:00
Vishnu Nair
06cff30935 Remove additional sf transaction when constructing a leash
The leash needs to be visible on creation otherwise when reparenting
the leash, the leashed layer may be hidden for a moment. This is because
Transaction#show can be deferred but Transaction#reparent cannot.

This change adds a layer flag to allow creating effect layers without
a color fill so we can avoid an additional sf transaction.

Fixes: 157646690
Test: go/wm-smoke
Test: atest SurfaceFlinger_test
Change-Id: I3d8a4f4820d7b8fb05daab697c25cff8def612c1
2020-05-29 21:59:24 +00:00
Joanne Chung
e4e6a3fabb Merge "Update textclassifier OWNER file." am: d1182b54c3
Change-Id: I10e7864d1c2158d65615667640baa7f8224fa5f9
2020-05-29 21:46:08 +00:00
Yara Hassan
dc699fb8ce Add finish() method to DataShare Read and Write Adapters
The finish() method is used to clear hard references after
the data copy has ended. This fixes a bug where the references are cleared before onError() is attempted to be called.

Test: CTS tests in followup CL
Bug: 157136368
Fixes: 157136368
Change-Id: If924fe388762831af90579e6b00bdf223230e203
2020-05-29 14:35:13 -07:00
Ahaan Ugale
974c3114dc AF Inline: Notify the registered AutofillCallback, also fix filtering.
This is missing notifications on the suggestions being hidden/shown
while filtering, but that is a bit harder to solve as we have to pipe
this state back from AutofillInlineSessionController. (although, I'm not
certain we even want this behavior, however it is inconsistent with the
dropdown behavior for now)

See bugs linked for what is fixed for filtering (some are not marked as
fixed as they still might need cts tests).
The main change is to make the privacy protection mechanism a bit
smarter - it now only applies to text-matching based logic.

Fix: 157763435
Fix: 156930859
Bug: 155517211
Bug: 157762527
Test: atest CtsAutoFillServiceTestCases:DatasetFilteringInlineTest \
  CtsAutoFillServiceTestCases:InlineFilteringTest \
  CtsAutoFillServiceTestCases:DatasetFilteringDropdownTest
Test: atest android.autofillservice.cts.inline
Change-Id: Icf94e21ba0df3b15a32454038772967cc1f6da79
2020-05-29 14:12:27 -07:00
TreeHugger Robot
214e6f6c88 Merge "Remove @hide from Matrix" 2020-05-29 19:49:31 +00:00