Commit Graph

808 Commits

Author SHA1 Message Date
Hongwei Wang
3057504bee Merge "Fix letterbox issue when auto-enter-pip from landscape" into sc-dev am: 5a59072018
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15264487

Change-Id: Ibe24016daf3ee670b498a24eb80ae3dc2f1df0b3
2021-07-15 00:07:30 +00:00
Hongwei Wang
ebe8550d03 Fix letterbox issue when auto-enter-pip from landscape
Included in this CL
- Skip layout of window when in transition to PiP mode
- Pass display cutout info via TaskInfo
- Removed TaskInfoCompat

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/bpKcGg1eoOo5Jz5U6IwBYK
Bug: 191310680
Test: manual, auto-enter-pip from landscape with source rect hint being
      turned on, see the video
Change-Id: Ie657d15d9edb9d07555bd166b5919bb12cb217e6
Merged-In: Ie657d15d9edb9d07555bd166b5919bb12cb217e6
2021-07-13 15:07:18 -07:00
Winson Chung
cacc7541b0 Merge "Ensure that the pip transaction matrix has only scale & rotation info" into sc-dev am: 7780fa9e7c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15184134

Change-Id: I4ddbeafe604f4d6195efd43463154d73069c9864
2021-07-03 03:42:09 +00:00
Winson Chung
7780fa9e7c Merge "Ensure that the pip transaction matrix has only scale & rotation info" into sc-dev 2021-07-03 03:25:20 +00:00
Winson Chung
a4b441144d Ensure that the pip transaction matrix has only scale & rotation info
Bug: 191672541
Test: Swipe up from an app w/ auto-enter and no source hint rect
Change-Id: I4d8eccd56a31eea922e99ccb4dcbc64ed58e37d4
2021-07-02 14:10:33 -07:00
Winson Chung
e639eb9ee9 Merge "Fix strictmode error logs due to task snapshot hw buffer not being closed" into sc-dev am: 40902ab97b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15090192

Change-Id: Ibac90a5800af1c9edec519a2a0291fcead8843e5
2021-07-01 17:28:00 +00:00
Winson Chung
40902ab97b Merge "Fix strictmode error logs due to task snapshot hw buffer not being closed" into sc-dev 2021-07-01 17:14:25 +00:00
Winson Chung
1f770ee834 Fix strictmode error logs due to task snapshot hw buffer not being closed
- Wrapping the buffer into a bitmap will add a reference so we can
  close the buffer once we convert the TaskSnapshot into a
  ThumbnailData
- Also probably shouldn't be creating a new ThumbnailData for each
  local task stack listener (most of whom don't actually handle this
  method)

Fixes: 165825625
Test: Check logs
Change-Id: I4d881721692a960ac40be848e49188afddbbc9c3
2021-07-01 17:14:13 +00:00
Ryan Mitchell
2df59f17a5 Merge changes from topic "revert-15058002-SNQUARIDWJ" into sc-dev am: b3659d36b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15156470

Change-Id: Id89a53b584251a3476b6c7c8b88d6f70e9dc7940
2021-06-30 21:11:17 +00:00
Ryan Mitchell
b3659d36b0 Merge changes from topic "revert-15058002-SNQUARIDWJ" into sc-dev
* changes:
  Revert^2 "Apply overlay changes with config change"
  Revert^3 "Deprecate Context#createApplicationContext"
2021-06-30 20:58:43 +00:00
Hongwei Wang
0af8d67087 Merge "Exclude the split-secondary offsets when auto-enter-pip" into sc-dev am: 739425e56b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15132821

Change-Id: If539d6b847747ed44035eeed39ab17d2e2d75848
2021-06-30 20:41:42 +00:00
Hongwei Wang
739425e56b Merge "Exclude the split-secondary offsets when auto-enter-pip" into sc-dev 2021-06-30 20:23:23 +00:00
Ryan Mitchell
350c2669d6 Revert^3 "Deprecate Context#createApplicationContext"
This reverts commit cb5a80ea57.

Reason for revert: Was not the cause of the test failure

Fixes: 186622527
Test: atest FrameworksCoreTests:ContextTest
Change-Id: I705854f080200f0465d94a7754e710f05a3ec92c
2021-06-30 15:53:45 +00:00
Paul Hobbs
3053bd7ab0 Merge changes from topic "revert-15058002-SNQUARIDWJ" into sc-dev am: 8d440c0566
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15144638

Change-Id: I0612c824b412153bb571e5ff1f47d707269a05a6
2021-06-29 20:54:31 +00:00
Paul Hobbs
8d440c0566 Merge changes from topic "revert-15058002-SNQUARIDWJ" into sc-dev
* changes:
  Revert^2 "Deprecate Context#createApplicationContext"
  Revert "Version LoadedApk cache using base code path"
  Revert "Apply overlay changes with config change"
2021-06-29 20:36:15 +00:00
Paul Hobbs
cb5a80ea57 Revert^2 "Deprecate Context#createApplicationContext"
Bug: 192242649

5a41b45a85

Change-Id: Idcebd68e0079e7e87de04ae25069b3a9ff72093c
2021-06-29 20:06:45 +00:00
Colin Cross
ed1e6197c0 Update baseline for lint 7.1.0-dev
Add some duplicates of existing issues for which the message has changed
in lint 7.1.0-dev.

Bug: 192245952
Test: m lint-check
Change-Id: Ib1b78f3881632a2432e5bd8d4448a8c080a87279
2021-06-28 23:11:13 -07:00
Hongwei Wang
ce4912f78e Exclude the split-secondary offsets when auto-enter-pip
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/b1j4eK7BU18sOGfuDlKMFR
Bug: 190855091
Test: manual, see video
Change-Id: I22c2387d392ef2dd43269de4db1e2c2eb7bc155f
2021-06-28 16:02:09 -07:00
Ryan Mitchell
5a532f6eed Merge changes Icf81845d,Iea54abf3,I98656314 into sc-dev
* changes:
  Apply overlay changes with config change
  Version LoadedApk cache using base code path
  Revert "Deprecate Context#createApplicationContext"
2021-06-27 06:27:58 +00:00
Lucas Dupin
711cb5bacd Decouple SysUI blurs from cross window blur API
This way, enabling the API wouldn't necessarily enable blurs on sysui as
well.

Test: manual
Change-Id: If961d94d808bc9aacd8eb5de6a75e2cfabd6dcea
Bug: 192085653
2021-06-25 20:59:15 +00:00
Ryan Mitchell
5a41b45a85 Revert "Deprecate Context#createApplicationContext"
This reverts commit c54ebba25b.

Bug: 188059515
Test: atest FrameworksCoreTests:ContextTest
Change-Id: I986563142dac135281889e811e6e5219d728d5d1
2021-06-22 22:30:38 -07:00
TreeHugger Robot
29a7cd05d0 Merge "Using InteractionJankMonitor only in S+" into sc-dev 2021-06-17 20:13:38 +00:00
vadimt
672254422b Using InteractionJankMonitor only in S+
The methods signatures have changed in S.

Test: presubmit
Bug: 191124753
Change-Id: I2a7d61f049e2a30f9c8203d313eacd074da5e461
2021-06-15 19:15:53 -07:00
Hongwei Wang
6a92728699 Polish YT auto enter PiP transition
- Fixed the round corner radius calculation, take into account the
  insets, was applied to the destination bounds side
- Adjust the leash position based on the insets

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/eUpkH2il1vYBVBPt1Vks2u
Bug: 190748719
Test: auto-enter-pip from YT landscape, see video
Change-Id: I2f3f4ae807630c5ae6bcc9968c6b46cf4501ad07
2021-06-10 18:11:39 -07:00
Hongwei Wang
628002c70c Merge "Polish round corner for auto-enter-pip" into sc-dev 2021-06-09 01:41:10 +00:00
Hongwei Wang
6422ad45c9 Polish round corner for auto-enter-pip
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/b47ErxSscLnZl9clVncSY6
Bug: 187834841
Test: manual, see video
Change-Id: I59132ea50a3213a9caa2366c103fdddf642498e2
2021-06-08 13:13:39 -07:00
shawnlin
0304528265 Add a method to trigger the navigation bar animation in system
Bug: 189278432
Test: build
Change-Id: I9795c4cde805fdca29de3708e2d77f12932a1066
2021-06-07 16:03:28 +08:00
Wu Ahan
924618b41c Merge changes from topic "unlock_jank_instrument" into sc-dev
* changes:
  Instrument jank and latency of the unlock animation of lockscreen
  Support configuration as parameter while beginning the instrumentation
2021-06-04 04:19:38 +00:00
Galia Peycheva
2cd5b58dd4 Remove occurances of disable blurs sysprop
The disable blurs sysprop is no longer being used

Bug: 185580298
Test: m
Change-Id: I191d88f233818d76ad8f417e2806b3f3be3bfb45
2021-06-03 19:08:24 +02:00
Ahan Wu
c45abcf9db Support configuration as parameter while beginning the instrumentation
Support a custom configuration while beginning the instrumentation, also
support a custom tag for getting fine-grained CUJ in the trace.

Bug: 187495856
Test: take the trace, see the cuj section name.
Change-Id: Ife2554e0d7dbe4c01b7e4381a12a5f595e2f4364
2021-06-02 01:15:27 -08:00
Josh Tsuji
3ec95514eb Merge "Adds the initial SmartSpace shared element transition!" into sc-dev 2021-05-27 00:29:00 +00:00
Tracy Zhou
4427342093 Merge "Notify when quickstep gesture starts" into sc-dev 2021-05-21 02:24:21 +00:00
Lucas Dupin
7a9a236b53 Merge "Add setOpaque to TransactionCompat" into sc-dev 2021-05-20 23:11:46 +00:00
Tracy Zhou
73705bf07a Notify when quickstep gesture starts
Also rename notifyQuickSwitchToNewTask

Fixes: 188568083
Test: manual

Change-Id: Ic42825c60f69bcf1b13b92a096d182e82759d72a
2021-05-20 15:56:12 -07:00
TreeHugger Robot
ee438f960a Merge "Deprecate Context#createApplicationContext" into sc-dev 2021-05-19 15:35:09 +00:00
Lucas Dupin
9fa272ea29 Add setOpaque to TransactionCompat
So launcher can notify when to stop blurring

Bug: 187703092
Test: manual
Change-Id: I0e0c6ff89a44a2be801d0af36e0123399d4a7fbb
2021-05-18 20:11:03 -07:00
Ryan Mitchell
c54ebba25b Deprecate Context#createApplicationContext
If an application caches an ApplicationInfo and uses it to call
Context#createApplicationContext, the app will not get the most recent
version of the overlays for that application. To make things worse, the
LoadedApk stored in ActivityThread#mResourcePackages is updated using
the old ApplicationInfo causing further uses of the cached LoadedApk to
return outdated information.

Deprecate Context#createApplicationContext, convert all internal uses
to Context#createPackageContext(String packageName, ...) and log
whenever any one calls Context#createApplicationContext with an
outdated ApplicationInfo to detect debug issues in using old infos.

Bug: 188059515
Test: change wallpaper and observe widgets get reloaded with most
      recent overlays
Change-Id: I2aeefa8c0e66264859109975a54c4f73f76ad710
2021-05-18 09:07:58 -07:00
Evan Rosky
bd26d8f134 Merge "Add leashes in launcher adapters in lieu of cross-process sync" into sc-dev 2021-05-18 15:32:33 +00:00
Josh Tsuji
2da469ffdf Adds the initial SmartSpace shared element transition!
To see this in action, enable the remote animation (adb shell setprop persist.wm.enable_remote_keyguard_animation 1) and enhanced SmartSpace (adb shell device_config put launcher ENABLE_SMARTSPACE_ENHANCED true). Also, set your lock mode to swipe or some sort of non-bypass biometrics, so you can swipe to unlock.
KIs:
- It looks pretty janky on a fast swipe - this is the same root cause as b/186847064 so will have the same fix
- Launcher animates in with window-level animations (Launcher team is looking into helping)
- Screen off animation is not yet implemented (this is for unlock only)

Bug: 187025480
Test: unlock with every possible permutation of lock settings
Change-Id: I8c186fe57132ebc9a0bc5e3d8785e753e72c3bf2
2021-05-17 16:07:58 -04:00
Tracy Zhou
07756fb349 Merge "[Live Tile] Do not allow rotation in Overview when home rotation is off" into sc-dev 2021-05-17 17:18:42 +00:00
Winson Chung
79914dfbd5 Merge "Add fallback animation for auto-enter without source rect hint" into sc-dev 2021-05-14 23:44:23 +00:00
Tracy Zhou
7ffe7418ea [Live Tile] Do not allow rotation in Overview when home rotation is off
In live tile mode, the live tile app is considered the top window and therefore rotation proposals are sent even when home rotation is disabled. To detect this, launcher needs to send over home rotation state, besides the nav bar needs to listen to recents animation state.

Fixes: 185962767
Test: manual

Change-Id: Ibc873d1067a8a3b37b6c20672cdb32ea356d9f21
2021-05-14 11:21:46 -07:00
Cyrus Boadway
60dc9196e3 Add Widget CUJ parameter to jank monitoring
Android S introduces a new Quickstep animation for launching an activity
from an app widget. This is a similar but distinct CUJ to
LAUNCHER_APP_LAUNCH_FROM_ICON.

Bug: 169042867
Test: presubmit
Change-Id: I3338d31eb2ed74aef0b0697c6070ab7b422514ba
2021-05-13 13:04:42 +00:00
Winson Chung
8aa6016bb3 Add fallback animation for auto-enter without source rect hint
- Launcher will create a new surface which is faded in over the app,
  and as it finishes the recents animation, we transfer the overlay
  from the leash to the task (as with the transform), and when the
  pip task organizer receives it, it can fade out and remove the
  surface
- Fixes flash of status bar colors when going from light status bar
  to home (dark status bar) by deferring whether a task affects the
  sysui flag until it enters pip (only for autoenter)

https://recall.googleplex.com/projects/e3f080d7-2818-43f0-a087-405000b8fdf5/sessions/971a84c8-a622-4b34-a9de-4e595595da42

Bug: 184703546
Test: Swipe up from app with auto-enter but no source hint rect

Change-Id: I0a00cdb98d0a599ef065206e0cd2cfc0e6cc72b1
2021-05-12 23:53:25 -07:00
Ryan Lin
5ed9c4ca81 Merge "Fix hard dragging the window magnification from the bottom of the screen" into sc-dev 2021-05-12 03:00:13 +00:00
ryanlwlin
0b0634c4a9 Fix hard dragging the window magnification from the bottom of the screen
The window magnifier is hard to drag when it is at the bottom
of the screen. This is due to that launcher is detecting
swipe-up system gesture.

To fix it, we set the system ui state flag to true when
the window is overlapped with the gesture detection area.
We also update the gesture dection area via OnApplyWindowInsetsListener
Once the area is changed, we will update the flag again if necessary.

In the testing part, we use real WindowManager to verify the
functionality.

Bug: 179648683
Test: atest com.android.systemui.accessibility
      manually test and use the following command to check the flag
      adb shell dumpsys activity service TouchInteractionService
Change-Id: Ia09bd26b3eb164790614c173594d997d45f4ecdc
2021-05-11 21:29:27 +08:00
Hongwei Wang
57618b94ef Merge "Unify round corner radius in PipSurfaceTransactionHelper(s)" into sc-dev 2021-05-11 03:23:11 +00:00
Hongwei Wang
bec1c53ed9 Pass the float9 values in PictureInPictureSurfaceTransaction
For auto enter PiP from landscape when no source rect hint is specified,
we should actually use the skew instead scale values to set the matrix
transform.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/dpLVOQzIVjdJpn5kg7T4Fc
Bug: 179720719
Test: manual use ApiDemos app, see video
Change-Id: Ic7072e8354329584f9cb75876911c3d58d78e7f5
2021-05-07 14:26:43 -07:00
Winson Chung
cacddc52aa Merge "Lazy initialize the choreographer" into sc-dev 2021-05-07 00:05:01 +00:00
Vinit Nayak
c5535ff014 Merge "Pass IME visibility info to launcher" into sc-dev 2021-05-06 20:47:36 +00:00