Commit Graph

3 Commits

Author SHA1 Message Date
Peter Collingbourne
b3982fc8be Fix two problems in the ExecuteBinary function.
- If the process exits abnormally then we will leak the stdout and
  stderr FDs. Fix it by closing the FDs before returning.

- If another child process exits then we will incorrectly return the
  result from that process instead of waiting for our child. Fix it
  by using waitpid instead of wait.

Change-Id: I8974d5e4bd33f264cd2d364f55a60f1f5cb7eb1a
2021-04-15 21:47:07 -07:00
Ryan Mitchell
a8f13667c2 Set idmap2 binary uid and gid after forking
The file permissions of the idmap2 binary are currently not set
correctly when the system forks and execs the idmap binary during
zygote. This chnages sets the uid and gid after forking to the same uid
and gid of the parent process.

Bug: 134897503
Test: device boots and generates idmap
Change-Id: Ic7fac49e5982f3c47713603b905c3a6be117a05b
2019-07-01 21:19:21 +00:00
Mårten Kongstad
2503a49b96 libandroidfw: introduce ExecuteBinary (POSIX only)
Introduce a wrapper around fork and exec.

Test: make libandroidfw_tests
Change-Id: Iff0de5319bb6bb101a3fbef6413dfb4e77198f11
2018-10-04 03:45:32 +00:00