Commit Graph

93735 Commits

Author SHA1 Message Date
Jorim Jaggi
f76a0f8376 Merge "Fix overlapping remote and recents animations" into qt-r1-dev
am: b248a0343f

Change-Id: I65a0859aa03247262767107f3525b2b7490b5eb8
2019-08-05 11:39:03 -07:00
Jorim Jaggi
b248a0343f Merge "Fix overlapping remote and recents animations" into qt-r1-dev 2019-08-05 18:12:56 +00:00
Jorim Jaggi
589c5ba0fa Fix overlapping remote and recents animations
Test: Open app and immediately swipe up while opening. Verify
Thread prioties in systrace

Test: WindowProcessControllerTests
Fixes: 137881181
Change-Id: Ic1d7403d2a648e6f1d1b6a3d55b56bf37bc57a2c
2019-08-05 17:10:18 +02:00
Yin-Chia Yeh
1b1f14ebff Camera: fix getKeys impl for vendor keys
Test: partner testing
Bug: 137856586
Change-Id: Ie36db4f76e8b3d500aeea88d15e4e3295cc3d481
2019-08-02 22:14:40 +00:00
Adrian Roos
bde61e9acd Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev am: c9f4bcae57
am: 91ce40fa1a

Change-Id: Ib5f793e846c3a6cdd6eacb9455b8aa9f79df8e4a
2019-08-02 05:52:46 -07:00
Adrian Roos
91ce40fa1a Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev
am: c9f4bcae57

Change-Id: I0581305f01ebdaa121ce0e70ab9d44f142c9f99f
2019-08-02 05:42:10 -07:00
Adrian Roos
c9f4bcae57 Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev 2019-08-02 12:17:11 +00:00
Tao Bai
01006cc959 Merge "Update WebSettings.setSaveFormData deprecated doc" into qt-dev am: 7bb64fcf27
am: 22eceae195

Change-Id: I7a1fa6117e540a44db5b0c7a1b5e195d601873e8
2019-07-31 19:01:31 -07:00
Tao Bai
22eceae195 Merge "Update WebSettings.setSaveFormData deprecated doc" into qt-dev
am: 7bb64fcf27

Change-Id: Ife82891152d177e108db79f42fbe768fe8fb905a
2019-07-31 18:48:23 -07:00
Tao Bai
7bb64fcf27 Merge "Update WebSettings.setSaveFormData deprecated doc" into qt-dev 2019-08-01 01:17:10 +00:00
John Reck
1efbccc58d Merge "Fix regression in PFD#fromData" into qt-r1-dev
am: 1775a48935

Change-Id: Ib3830e489735019aaa0410bef2282ea80d70cc01
2019-07-29 15:10:49 -07:00
John Reck
1775a48935 Merge "Fix regression in PFD#fromData" into qt-r1-dev 2019-07-29 21:23:57 +00:00
Kevin Chyn
c3b9cf8966 Merge "Do not use canAuthenticate() to check if user can reset lockout" into qt-r1-dev
am: 8f0cd6547c

Change-Id: I8455a428024d60680461f33335c3b267f8021bf2
2019-07-26 18:12:09 -07:00
Kevin Chyn
8f0cd6547c Merge "Do not use canAuthenticate() to check if user can reset lockout" into qt-r1-dev 2019-07-27 00:33:33 +00:00
Kevin Hufnagle
22a9275850 Merge "docs: Fixed typo in SERVICE_META_DATA" into qt-dev am: d2e0e31dbb
am: 1947a05594

Change-Id: I3eabf4a82c42bae6788d74d2d3b6d2674987686e
2019-07-26 17:13:57 -07:00
TreeHugger Robot
71148077e8 Merge "Allow the down volume key to silence notifs" into qt-qpr1-dev 2019-07-27 00:09:10 +00:00
Kevin Hufnagle
1947a05594 Merge "docs: Fixed typo in SERVICE_META_DATA" into qt-dev
am: d2e0e31dbb

Change-Id: I89e312ae7ec294b19ded565e54768e8a290bc4c1
2019-07-26 16:41:40 -07:00
bsears
868ac4f3a1 Merge "Revert "SharedMemory: break Cleaner reference cycle." Bug: 138422309" into qt-dev
am: d4b0c9348a

Change-Id: Icef464ff04de9d1e300161383251e35d557ca973
2019-07-26 16:35:31 -07:00
bsears
de6bfd230c Merge "Revert "SharedMemory: clear file descriptor when explicitly closed." Bug: 138422309" into qt-dev
am: 480f1db9bc

Change-Id: Ib346fb19a7be0635fe9e15d0fc6a307a614fb1c5
2019-07-26 16:31:52 -07:00
Kevin Hufnagle
d2e0e31dbb Merge "docs: Fixed typo in SERVICE_META_DATA" into qt-dev 2019-07-26 23:20:51 +00:00
John Reck
12ea937f8f Fix regression in PFD#fromData
Don't rely on the GC to clean up FD resources when they can
just be cleaned up immediately. We know the MemoryFile isn't
going to be used any further, so just close it.

Bug: 138323667
Test: Repro steps in bug. Verified addresses FD leak in system_server from repeatedly opening & closing settings.
Change-Id: Ic82006c9cb48f580aaad942c4679e774186382c9
2019-07-26 23:19:05 +00:00
Kevin Chyn
27f9231e49 Do not use canAuthenticate() to check if user can reset lockout
canAuthenticate() is meant for apps so it will reflect the
FACE_UNLOCK_APP_ENABLED setting. If disabled, resetLockout will not be
run for that user.

Fixes: 138269776

Test: Disable unlocking for apps, get locked out, enter password.
      Lockout is reset now.

Change-Id: I5d7bf3abbac7c8982595d5733464a887ab5184ab
2019-07-26 13:10:47 -07:00
Julia Reynolds
1ceddc4ce3 Allow the down volume key to silence notifs
Additionally preserve existing behavior by passing
the keypress on.

Fixes: 130025623
Test: manual
Change-Id: I00f83275000369c1ab03bae63eb0a4b6170c4b53
(cherry picked from commit deb2d0b743)
2019-07-26 19:25:38 +00:00
Adam Seaton
b16411f83a Revert "SharedMemory: break Cleaner reference cycle."
Bug: 138422309

This reverts commit 390d9e6a18.

Reason for revert: crashes documented in b/138422309

Change-Id: I235f727d0fe87c09f6f05dddcae7759bab64dfd8
2019-07-26 17:17:16 +00:00
Adam Seaton
5966196515 Revert "SharedMemory: clear file descriptor when explicitly closed."
Bug: 138422309

This reverts commit 20ab1e3427.

Reason for revert: crashes documented in b/138422309

Change-Id: Ic9e33fdb24bad2b30f0eb357d6752c1834df41d5
2019-07-26 17:17:03 +00:00
Adrian Roos
e6feb7d198 GestureNav: Clarify javadoc in regards to exclusion limits
Bug: 124518180
Test: m checkapi
Change-Id: I43b0b890a763e339deb246cabf9adbf011eae088
2019-07-26 14:50:03 +02:00
Josh Gao
036d594c69 Merge changes I8bdb4c74,I613a7d03 into qt-dev
am: a09ee2d39f

Change-Id: I6ae25d6b3aa39ef6f9ed1ffcf6fce6e5920a5578
2019-07-25 16:54:20 -07:00
Josh Gao
20ab1e3427 SharedMemory: clear file descriptor when explicitly closed.
We run the Cleaner in close, but after the fix in commit 6ca916a6, this
no longer clears the value stored in the FileDescriptor, which means
that subsequent operations on an explicitly closed SharedMemory will
operate on a bogus fd number. Clearing the FileDescriptor value in close
is sufficient, because Cleaner.clean is idempotent, and the only other
case where it executes is when the FileDescriptor is phantom reachable,
which means no one can access it to get its integer value.

Bug: http://b/138392115
Bug: http://b/138323667
Test: treehugger
Change-Id: I8bdb4c745466532a0712976416184c53fcf0dbf6
(cherry picked from commit a7641806dd)
2019-07-25 14:08:58 -07:00
Josh Gao
390d9e6a18 SharedMemory: break Cleaner reference cycle.
Previously, the Cleaner we create to close the ashmem file descriptor
used a thunk that held a strong reference to the FileDescriptor we
wanted to clean up, which prevented the Cleaner from ever running.

Break the cycle by storing the integer value of the file descriptor
instead.

Bug: http://b/138323667
Test: treehugger
Change-Id: I613a7d035892032f9567d59acb04672957c96011
(cherry picked from commit 6ca916a657)
2019-07-25 12:13:15 -07:00
Vadim Caen
605e74c930 DO NOT MERGE Do not call drawableChanged pre Q
am: 843f9dee8b

Change-Id: I813f41905386da06e6eaebd6b7f85c17a6051456
2019-07-24 16:19:39 -07:00
Vadim Caen
843f9dee8b DO NOT MERGE Do not call drawableChanged pre Q
Some apps rely on not updating the window format when changing the
background of the DecorView. To keep the compatibilty with these app we
add only call DecoreView.drawableChanged() when the window background is
changed on app targetting Q and above.

Test: Manually test by lunching Instagram TV and pressing return twice.
The window should aninate with no flickering.
Bug: 136987724

Change-Id: I3593d30dc6f10519008151974e475f0dad86fc64
2019-07-24 21:29:12 +00:00
Selim Cinek
87592617ec Merge "Not asking for the password when dragging down and bypass" into qt-r1-dev 2019-07-24 16:47:47 +00:00
Selim Cinek
abcc201afb Not asking for the password when dragging down and bypass
Instead we'll just keep them in there looking like locked
notifications.

Fixes: 138225058
Test: add notifications, enable dynamic privacy, drag down
Change-Id: Ica49035ba3fe655c145f81be962817ddd294c48d
2019-07-23 18:44:07 -07:00
Winson Chung
7a545ae9cc Modify deferred recents animation cancel to work without screenshot
- Allow the recents animation runner to request deferring a cancel from
  stack order change until the next app transition start without using
  a screenshot. This allows launcher to set this state, then start an
  activity without a flash due to the animation not finishing immediately
- Always prepare a transition when using the deferred cancel to ensure
  an app transition callback
- Handle app transition canceled as well (if canceled, we continue to
  cancel recents the animation with/without the screenshot as requested)
- Remove internal lock and use the global WM lock when setting the defer
  cancel state
- Renamed a few methods to clarify the deferred cancel flow

Bug: 137196872
Test: atest FrameworksServicesTests:RecentsAnimationControllerTest
Test: atest WmTests:RecentsAnimationTest
Change-Id: Ie8f6f60b6bf6777e36f24749b30f90c8c26ee848
2019-07-23 15:50:33 -07:00
Kevin Hufnagle
21083088e9 Merge "docs: Fixed link in setCurrentTab() description" into qt-dev
am: 2839f24e64

Change-Id: I4d888ec589953a02238520de0594d751fda3e6d0
2019-07-22 15:23:56 -07:00
Kevin Hufnagle
2839f24e64 Merge "docs: Fixed link in setCurrentTab() description" into qt-dev 2019-07-22 22:01:49 +00:00
Nick Cook
82252f17d3 Merge "docs: Fix broken link." into qt-dev
am: 2aec022fd2

Change-Id: I52cd7a41c34a1f44b427029c651c29912b36da93
2019-07-22 10:43:27 -07:00
Nick Cook
2aec022fd2 Merge "docs: Fix broken link." into qt-dev 2019-07-22 17:24:07 +00:00
Lucas Dupin
bddf774dd1 Merge "Fixed the layout of media heads up notifications" into qt-r1-dev 2019-07-19 18:50:28 +00:00
Nick Cook
d0a4a594c5 Merge "docs: Fix broken link." into qt-dev
am: a2fe3be17d

Change-Id: I8618dd139fedc0af13bdb6e00b441b237a319784
2019-07-19 10:15:39 -07:00
Selim Cinek
16f334e5c1 Fixed the layout of media heads up notifications
Previously the heads up layout was strangely clipped
because we were using the expanded layout.
We're now using the collapsed layout instead. In order to allow this,
the media notification needs to wrap it's height properly.

Fixes: 136507638
Test: show heads up media notification
Change-Id: Ib091b0e776b5cd1a615c9ea0121a3115817b7f64
2019-07-18 18:11:54 -07:00
Nick Cook
42ece979a2 docs: Fix broken link.
Test: make ds-docs

Bug: 132635673
Change-Id: I9e6a493112418f7b1467d9d2926a1b2c106d4ad0
2019-07-18 21:44:50 +00:00
Lucas Dupin
7d95f154a0 Disable bypass and bouncer delay when no face auth
KeyguardUpdateMonitor#isUnlockWithFacePossible was returning true
when the user had disabled face unlock.

This was causing bypass to still be enabled (hiding all notifications)
and bouncer was also being delayed, even though we were not scanning.

Fixes: 134977472
Test: auth with bypass (toggling face auth setting on/off)
Test: auth without bypass (toggling face auth setting on/off)
Change-Id: I234eb303db87fe0dafa2073a9bdf819c665018d6
2019-07-18 14:24:08 -07:00
Nick Cook
0cbfc85ef7 docs: Fix broken link.
Test: make ds-docs

Bug: 79729313
Change-Id: I3f7b90457e9127380f2b8cbaf0f958823ba5488e
2019-07-18 20:42:25 +00:00
Kevin Hufnagle
b0becb2325 docs: Fixed typo in SERVICE_META_DATA
Test: make ds-docs

Bug: 137267707
Change-Id: I3f38362f028866f55b9009b6a0de15dcbcb96e0c
2019-07-18 20:20:34 +00:00
Kevin Hufnagle
e71346fa0a docs: Fixed link in setCurrentTab() description
Moving focus and selected tab requires focusCurrentTab(), not
setCurrentTab().

Test: make ds-docs

Bug: 137317608
Change-Id: I96f4f4c32cbf8a3dfa0aac8cfa6d6cd12e8f8259
2019-07-18 12:50:31 -07:00
Adrian Roos
7c77af6371 Merge "GestureNav: make reportSystemGestureExclusionChanged oneway" into qt-dev
am: d4a50e6e72

Change-Id: I9f837989727c263517aa0d2f3dfd47a830f6170c
2019-07-16 15:00:35 -07:00
TreeHugger Robot
d4a50e6e72 Merge "GestureNav: make reportSystemGestureExclusionChanged oneway" into qt-dev 2019-07-16 21:27:54 +00:00
Adrian Roos
e6911497de GestureNav: make reportSystemGestureExclusionChanged oneway
When the WindowManager lock is contended, reportSystemGestureExclusionChanged can cause
jank. Making it oneway avoids this.

Fixes: 137650591
Test: make droid
Change-Id: I5d96b7e2225745b146014ad11cafaf0ad9a1b734
Merged-In: I5d96b7e2225745b146014ad11cafaf0ad9a1b734
2019-07-16 20:29:03 +00:00
Adrian Roos
60d8434884 Merge "AM: make isHighEndGfx TestApi" into qt-dev
am: 2ac934280c

Change-Id: I6a9c2ce91b4971cab32cabdd5d25e9edc29e64b5
2019-07-16 09:30:16 -07:00