Commit Graph

17663 Commits

Author SHA1 Message Date
Ryan Mitchell
6cb79cdfb7 Merge changes from topic "invalidate_idmap" into rvc-dev
* changes:
  Fix InstallOverlayTests fail to install overlay
  Test that upgrading target apk invalidates idmap
  Invalidate idmap when target updates
2020-04-10 15:50:15 +00:00
Darryl Johnson
6c6d81a121 Merge "Temporal fix of the Android Auto orientation chaniging on phone's orientation change." into rvc-dev 2020-04-10 14:07:36 +00:00
Hui Yu
d0139b01dd Merge "Document process capability in AppOps.md." into rvc-dev 2020-04-09 19:42:09 +00:00
Selim Cinek
279238f3c2 Merge changes I7dc8f5fd,Ia5262ca7 into rvc-dev
* changes:
  Fixed the transformation of min priority notifications
  Always use the largeIcon as avatar replacement
2020-04-09 17:55:27 +00:00
Pavel Grafov
57c69d1e30 Copy the remaining policies on migration.
* accountTypesWithManagementDisabled
* disableScreenCapture

For security logging nothing has to be done since the state is
stored in a system property, just changed it so that the logging
will be started after the migration and only events for the
right user are logged.

Also removed the todo about hardening for power cut case, the
risk of additional complexity sees to outweight the benefit.

Bug: 149075700
Test: atest DevicePolicyManagerServiceMigrationTest
Change-Id: I3a58325f2d6f415e51998c5096c5fc123d26602d
2020-04-09 15:47:18 +01:00
Charles Chen
5c082c998f Merge "Fix WindowContext leak" into rvc-dev 2020-04-09 07:39:29 +00:00
Yvonne Jiang
eb31eb5bae Merge "Fix secondary lock screen implementation such that DevicePolicyKeyguardService calls are made on the main (UI) thread." into rvc-dev 2020-04-09 07:26:48 +00:00
TreeHugger Robot
ffce5f2b7c Merge "Make OPSTR_MANAGE_EXTERNAL_STORAGE test API" into rvc-dev 2020-04-08 23:21:23 +00:00
Hui Yu
3b1110b170 Document process capability in AppOps.md.
Bug: 153581565
Test: NA
Change-Id: I3c42cf5022c0e7e5b008570fdc656260bb13475f
2020-04-08 16:12:21 -07:00
Makoto Onuki
52c24bdedf Merge "Context.getSystemService() shouldn't return null..." into rvc-dev 2020-04-08 19:33:30 +00:00
shafik
2a20790621 Make OPSTR_MANAGE_EXTERNAL_STORAGE test API
We need that to enable CTS for Environment#isExternalStorageManager API

Test: build
Bug: 152478019
Change-Id: I8c24c08991558629c83a25b4bed89c817723d732
2020-04-08 17:49:47 +01:00
Charles Chen
4bff5be1a9 Fix WindowContext leak
The root causes of this issue are:
  1. WindowTokenClient#attachContext makes WindowTokenClient has strong
     reference to WindowContext, which leads to WindowContext cannot be
     GC'd.
  2. WMS#removeWindowToken needs MANAGE_APP_TOKEN permission which
     normal apps don't hold.

This CL does following things:
  1. Use weak reference instead on WindowTokenClient#mContext.
  2. Relax WMS#removeWindowToken to check callingUid if
     MANAGE_WINDOW_TOKEN permission is not held
  3. Deliver config changes to the client side in
     WMS#addWindowTokenWithOption
  4. Some minor fixes

fixes: 150812449
Bug: 150715095
Test: atest WindowContextTest
Test: atest WindowManagerServiceTests
Test: atest WindowTokenTests
Test: atest WindowManagerPermissionTests#testMANAGE_APP_TOKENS
Test: atest
WindowManagerPermissionTests#testADD_WINDOW_TOKEN_WITH_OPTIONS

Change-Id: I9f1d73af2abb78fc9844e6d9eb25e9f0293514e7
2020-04-08 21:30:24 +08:00
Yvonne Jiang
6d34642533 Fix secondary lock screen implementation such that DevicePolicyKeyguardService calls are made on the main (UI) thread.
For implementations of DevicePolicyKeyguardService to provide a SurfacePackage via SurfaceControlViewHost, they must be running on the UI thread.
Additionally, fix dismissal logic to bypass re-checking the secondary lockscreen, and add defensive null checks.

Bug: 136085151
Bug: 151365616
Test: atest AdminSecondaryLockScreenControllerTest
Test: atest KeyguardUpdateMonitorTest
Change-Id: Ibcd7090f50831cddbf952914adf020015750afd8
2020-04-08 05:31:20 -07:00
Makoto Onuki
a49b1e6260 Context.getSystemService() shouldn't return null...
Even when interrupted.

Fix: 153005526
Test: Manual code inspection...
Change-Id: I6747c6b5fb4956b95b43d6fcd3fd636853339b8a
2020-04-07 14:01:30 -07:00
Selim Cinek
cd274d9e5d Always use the largeIcon as avatar replacement
A few apps were targeting >P but not providing avatars yet.
Even though this was an app bug it lead to some weirdness in
our UI. We therefore always do the workaround of using
the largeicon for an avatar instead of generating one if we're
in a OneToOne conversation.

Bug: 153466270
Test: post hangouts message, observe normal person avatar
Change-Id: Ia5262ca7dfc20d265c2d0532e88932c878f38552
2020-04-07 12:24:23 -07:00
Ryan Mitchell
a90930528d Invalidate idmap when target updates
When the target package update, check if the idmap file must change.
If so, propagate the idmap changes to the targets overlay paths, and
invalidate cached overlay ApkAssets in ResourcesManager.

Bug: 147794117
Bug: 150877400
Test: OverlayRemountedTest
Test: libandroidfw_tests
Change-Id: I6115c30bae3672b188a5ff270720a0eea15b43b5
2020-04-07 12:14:51 -07:00
Evan Rosky
50ea8c15fa Remove some more dead-code from old split impl
Removed moveTasksToFullscreenStack (only a small piece of it
was used by pip, so just localized it).

Remove stack creation/reparenting from resizeTask since modes
don't work like that anymore.

Removed some always-false parameters in AS.setWindowingMode

Bug: 133381284
Test: tests pass
Change-Id: I22e846250196eb93b480a05bed1f66d34b51a092
2020-04-07 10:31:36 -07:00
Linus Tufvesson
b66684981f Merge "Use TYPE_PRIVATE_PRESENTATION for private presentations" into rvc-dev 2020-04-07 11:32:16 +00:00
Kholoud Mohamed
5ec3cbac4c Merge "Remove platform-signed apps from configurable cross profile apps" into rvc-dev 2020-04-07 09:55:18 +00:00
Selim Cinek
35910cacaa Merge changes I76df6529,I99594ae9 into rvc-dev
* changes:
  Fixed the heads up layout of conversations
  Fixed an issue where the conversation title was showing doubled
2020-04-07 01:22:04 +00:00
kholoud mohamed
9bbab6a6df Remove platform-signed apps from configurable cross profile apps
Most apps that declare the INTERACT_ACROSS_PROFILES permission do
not have it granted, but get the app-op instead. We do not
normally want platform-signed apps that are actually given the
permission to appear in the user-configurable section in Settings,
so we remove them from the return value of
canUserAttemptToConfigureInteractAcrossProfiles in this CL.

Note that OEM can choose to allow some platform-signed apps to be
user-configurable by including them in their OEM whitelist file.
This CL respects that and allows these apps to be configured by the user,
despite being granted the permission. If the user rejects the app-op,
PermissionChecker correctly returns false.

Bug: 149742043
Test: atest CrossProfileAppsServiceImplRoboTest
Change-Id: I693338507eec9cdc0ba10a3584e994a58d2d113c
2020-04-06 10:13:09 +00:00
Linus Tufvesson
ac272d5e9f Use TYPE_PRIVATE_PRESENTATION for private presentations
Detect if the Presenation is targeting a private virtual display, and if they
are use the windowType TYPE_PRIVATE_PRESENTATION.

Bug: 152652348
Bug: 141745510
Test: atest CtsWindowManagerDeviceTestCases:PresentationTest
Test: atest CtsDisplayTestCases:android.display.cts.VirtualDisplayTest
Change-Id: I58834636e092f992e403342e36b475dc60e8f20a
2020-04-06 09:43:41 +00:00
Selim Cinek
dcfa46c5ca Fixed an issue where the conversation title was showing doubled
For conversations, it's not necessary anymore to extract
the conversation title into the heads up layout.

Fixes: 152655946
Test: add conversation group, observe no double text
Change-Id: I99594ae9e503cf8589603899e0053793be96958a
2020-04-03 17:00:49 -07:00
Yara Hassan
e081caae5f Merge "Enabled Content Capture in Service" into rvc-dev 2020-04-03 16:53:42 +00:00
Amith Yamasani
040563da5f Merge "Mark secondary lockscreen API as SystemApi." into rvc-dev 2020-04-03 14:13:43 +00:00
Bernardo Rufino
884e9515d6 Merge "Rename test in TEST_MAPPING" into rvc-dev 2020-04-03 10:02:09 +00:00
Bernardo Rufino
434c17c0e6 Rename test in TEST_MAPPING
ToastTest became ToastWindowTest in ag/10919524, updating TEST_MAPPING
to reflect that.

Test: croot frameworks/base/core/java/android/app && atest --dry-run --test-mapping
Test: croot frameworks/base/core/java/android/widget && atest --dry-run --test-mapping
Test: croot frameworks/base/services/core/java/com/android/server && atest --dry-run --test-mapping
Bug: 152973950
Change-Id: I5b9e9b83d17c4a93a1e830c26d7f44001ccf175d
2020-04-03 08:48:00 +01:00
Jing Ji
e2757e64b7 Fix some Java doc errors
Bug: 148413462
Test: Manual
Change-Id: Idfabf5ac6548fd821bc69afb3588c1d124d0011b
2020-04-02 14:27:04 -07:00
Makoto Onuki
bea34c409f Merge "Add WTF when a system server wrapper can't be found" into rvc-dev 2020-04-02 20:39:32 +00:00
Adam Bookatz
2f559add63 Merge "Avoid getUserBadgeNoBackgroundResId if no badge" into rvc-dev 2020-04-02 18:42:07 +00:00
Yara Hassan
6b6c4b1889 Enabled Content Capture in Service
Bug: 150451947
Fix: 150451947
Test: Locally
Change-Id: Icbcbe4c46c4c5eb39b176b80c01dcce96f9dfbbd
2020-04-02 12:25:35 +01:00
Yvonne Jiang
70a62376d0 Mark secondary lockscreen API as SystemApi.
It is currently not meant for use by general enterprise device admins.

Bug: 152478326

Test: atest FrameworksServicesTests:DevicePolicyManagerTest
Test: atest KeyguardUpdateMonitorTest
Test: atest AdminSecondaryLockScreenControllerTest
Change-Id: I6d60bc35a4e8f74b1da55b042582a2f2fa89d57f
2020-04-02 08:41:04 +00:00
Makoto Onuki
a455e5e281 Add WTF when a system server wrapper can't be found
2nd try -- enable it only within the system server.

This is to detect someone trying to access system services too
early during a boot.

Bug: 149406139
Test: Boot with "adb logcat | grep -w SystemServiceRegistry" and make sure no wtf is logged
Change-Id: I64c6776cedaeb534d98621db2955d585e6846b8d
2020-04-01 17:27:58 -07:00
Steve Elliott
4605ca9daa Merge changes Ie5bfc2f6,I38e7dc8c,I9308a15a into rvc-dev
* changes:
  Reinflate notif when [un]marked as conversation
  Update conversation UI when importance changed
  Add unread count badge to conversation layout
2020-04-01 17:34:36 +00:00
Wale Ogunwale
adf116ec95 Add TestApi interfaces for window organizers
Enables testing the API surfaces from CTS.

Bug: 149338177
Test: they pass!
Change-Id: I7e1f2852585a10c20d299bd87e9a87f828d06d6a
2020-04-01 13:25:23 +00:00
Winson Chung
a531f922c9 Merge "Add task organizer based task embedder" into rvc-dev 2020-03-31 20:59:17 +00:00
Steve Elliott
239e6cb1df Add unread count badge to conversation layout
Fixes: 152303800
Test: manual, visual
Change-Id: I9308a15ab223086398ba073b08d60cb7c50d8c30
2020-03-31 16:20:39 -04:00
Selim Cinek
9bad85af2b Merge changes I0d79642d,If8756ac8,I29e73897,Ia8c5121a,I533b8f06 into rvc-dev
* changes:
  Indented the conversation action list
  Fixed some issues where conversation badges would not be visible
  Improved the animations of the conversation badges
  Important conversations now also transform into the shelf
  Adapted Shelf algorithm to also use conversation icons
2020-03-31 20:02:01 +00:00
Adam Bookatz
9b6d51e688 Avoid getUserBadgeNoBackgroundResId if no badge
Checks whether there actually is a badge before
calling getUserBadgeNoBackgroundResId.
(Otherwise a logcat error would have been logged, since
it is only expected to be called if there is indeed
a badge.)

Test: manual confirmation that logcat error is gone
Bug: 142482943
Change-Id: I635529d9c114b399e5626bdbb143aab29ae81a4b
2020-03-31 19:35:57 +00:00
Neil Fuller
71271db6bf Merge "Misc tidy up before adding geolocation classes" into rvc-dev 2020-03-31 14:52:09 +00:00
Winson Chung
a1f869d10e Add task organizer based task embedder
- Split TaskEmbedder into its current VirtualDisplay implementation
  and an implementation that uses task org to create and manage
  the task
- Use the task org embedder implementation in separate bubble task view
- Skip task org tasks from triggering task resizing
- Add task org callback for back press on task root if requested

Bug: 148977538
Test: atest CtsWindowManagerDeviceTestCases:ActivityViewTest
Test: atest WmTests:TaskOrganizerTests
Change-Id: Id422bb2547197c617f914ed7cf5085e02a1c3fb5
2020-03-30 23:29:08 +00:00
Selim Cinek
79d9863ebc Adapted Shelf algorithm to also use conversation icons
Previously the algorithm would only work with a header
and the icon wouldn't transform into the shelf.
This is now fixed.

Bug: 150905003
Test: add conversation notification, observe normal transition
Change-Id: I533b8f06bee29ee93888d748808b4313fef338e8
2020-03-30 16:18:09 -07:00
Michael Wright
603713009e Merge "Remove replaced BubbleMetadata methods from SDK." into rvc-dev 2020-03-30 20:58:43 +00:00
Patrick Baumann
3dfc45e593 Merge "Whitelist for package broadcasts" into rvc-dev 2020-03-30 20:28:59 +00:00
Michael Wright
b6ffb2293e Remove replaced BubbleMetadata methods from SDK.
Prior to finalization, we need to remove all methods which were
replaced but kept around for short-term compatibility purposes.
BubbleMetadata had a few methods that fell into this category that had
yet to be removed.

Bug: 152761169
Test: build
Change-Id: Ic9f8d600721e15119fc28d308ff1bc444d61e399
2020-03-30 19:02:37 +01:00
TreeHugger Robot
7f212788d1 Merge "Fix incorrectly assigned constant in AppOpsManager" into rvc-dev 2020-03-30 17:49:17 +00:00
Patrick Baumann
b66d65fa18 Whitelist for package broadcasts
This change adds a whitelist of UIDs that package change broadcasts may
be sent to. This must be pre-calculated and stored in memory before the
package is updated or modified as the visibility may change during that
transaction.

Test: atest PackageManagerTests AppsFilterTest AppEnumerationTests
Fixes: 143534210
Change-Id: I003c54528141d8b03033f8241559dd5895df064a
2020-03-30 09:47:55 -07:00
Ryan Mitchell
ad5a070a87 Merge "Synchronize before calling unstableRemoveIf" into rvc-dev 2020-03-30 15:44:00 +00:00
Stanislav Zholnin
5c88c73306 Fix incorrectly assigned constant in AppOpsManager
Fix: 152268751
Test: atest AppOpsUpgradeTest#testUpgradeFromNoVersion
Change-Id: Ie2bbe6d23d8860e15091b24040c2473151ca24fd
2020-03-29 21:46:35 +01:00
Alex Kershaw
9a8bf9a7f9 Remove the @hide from ContextImpl#bindServiceAsUser
The method is already public in Context, but the @hide wasn't removed
from the javadoc of the subclass.

Fixes: 150123286
Test: m -j
Change-Id: I53f999f99d2ad64f930beedb262affffbe13764f
2020-03-29 15:07:23 +01:00