Commit Graph

3732 Commits

Author SHA1 Message Date
Nathan Harold
2cdcd98379 Allow Cell Location for SYSTEM_UID and ROOT_UID
This change permits the system uid and root uid to
access cellular location information via the binder.
Previously this was restricted to the phone uid, but
running with uid=system is a privileged situation,
which makes me think this this wasn't intentional.

Also add a few lines of debug code to make issues
in LocationAccessPolicy easier to track down in the
future.

Bug: 110806860
Test: manual - ran with SL4A as SYSTEM_UID and
    verified access to getAllCellInfo.

Change-Id: Ie18be2cd72c49f1859d1434428f82f164bed8756
2018-06-27 18:52:15 +00:00
Amit Mahajan
12b08d00b8 Merge "Update comments for TelephonyManager.getUiccSlotsInfo()"
am: 3838ff457e

Change-Id: I46a8a708e949e134b8e4cb05fe315b058ad500fc
2018-06-25 16:31:55 -07:00
Treehugger Robot
3838ff457e Merge "Update comments for TelephonyManager.getUiccSlotsInfo()" 2018-06-25 22:22:25 +00:00
Brad Ebinger
057f582e09 Merge "Fix Possible Deadlock with getFeatureState"
am: 6bebb8418c

Change-Id: I675c116e54d961971d4a32f87dd247cca51b5069
2018-06-25 11:45:32 -07:00
Brad Ebinger
6bebb8418c Merge "Fix Possible Deadlock with getFeatureState" 2018-06-25 17:30:02 +00:00
Brad Ebinger
8f074959e5 Fix Possible Deadlock with getFeatureState
Use the ImsFeature lock for concurrency in MmTelFeature
instead of declaring its own lock.

Also, fixed up some other concurrency code.

Bug: 110507525
Test: Manual, Telephony Unit Tests
Change-Id: I5a7ef1beca619873a7c228bed0e1b82843d4de63
2018-06-22 16:14:17 -07:00
Jack Yu
65c04cd491 Merge "Fixed the incorrect permission for data/network service binding"
am: a9bf7a8810

Change-Id: Ic3c463d7e7755efcb048e84c338ffbe256475874
2018-06-18 18:49:09 -07:00
Jack Yu
063ed82eef Fixed the incorrect permission for data/network service binding
The permission renaming was done in ag/3552774. Other places
need to be fixed accordingly.

Test: Unit tests
Bug: 73659459
Change-Id: Ic325d666c333eef22dba95f8d2488fb172810c2c
2018-06-15 14:34:22 -07:00
Pengquan Meng
fdad4c89fb Merge changes from topic "clean"
am: 9f2362bb82

Change-Id: I9a0554d7cacd8c02d78ad08b7d05b074720dfe2a
2018-06-13 15:33:08 -07:00
yuemingw
457c62801b Remove internal ApnSetting.
Bug: 77511388
Test: atest FrameworksTelephonyTests
Change-Id: I0da354c7d55ac49f90ca1376e8f2034e65e4e274
Merged-In: I9757ef4aae269d828c98a7363c98629c9be74846
2018-06-13 12:52:25 +01:00
Benjamin Miller
ce3d429832 Docs: noted that setting proxy hostnames on an ApnSetting requires an internet connection for DNS.
Doc-only change.
Also improved the class descriptions and fixed some typos.

Bug: 80238372
Test: make ds-docs with visual inspection of generated HTML
Change-Id: I460d70d692cc1a04cf0efd6b9d0b1e13a9403968
Merged-In: Id4a00c1a44dc3cbbaefc94c0438eb1a077f06e5e
2018-06-13 12:50:57 +01:00
Brad Ebinger
0be0692691 Merge "Update Docs to clarify using a Message across IPC" 2018-06-11 19:56:07 +00:00
Brad Ebinger
7db23752ab Merge "Adds a private field to parceled data." 2018-06-08 17:03:14 +00:00
Brad Ebinger
442b546e2a Merge "Unhide @SystemApi Constructor" 2018-06-08 17:02:48 +00:00
Benjamin Miller
aaec389c2e Merge "Docs: noted that setting proxy hostnames on an ApnSetting requires an internet connection for DNS." into pi-dev
am: 0f5f09844d

Change-Id: I6c19f03debc6d15eece445dfd7fb0f5336d90407
2018-06-07 19:32:53 -07:00
Benjamin Miller
ab57d7fe6c Docs: noted that setting proxy hostnames on an ApnSetting requires an internet connection for DNS.
Doc-only change.
Also improved the class descriptions and fixed some typos.

Staged at:
  http://go/dac-stage/reference/android/telephony/data/ApnSetting_new
  http://go/dac-stage/reference/android/telephony/data/ApnSetting.Builder_new

Bug: 80238372
Test: make ds-docs with visual inspection of generated HTML
Change-Id: Id4a00c1a44dc3cbbaefc94c0438eb1a077f06e5e
2018-06-07 21:20:57 +00:00
Brad Ebinger
929772680a Update Docs to clarify using a Message across IPC
When using Message across IPC, the message must be sent
with a Messenger. Update Docs to reflect this.

Bug: 77870347
Test: Telephony Unit Tests
Merged-In: Ie1a0be63d26136f14cd30c354b889ec0311cc7ee
Change-Id: I27977a13f7ccb6875b5fdb7eb6c6836a84166eeb
2018-06-06 16:05:54 -07:00
Brad Ebinger
a54bdfad40 Adds a private field to parceled data.
Bug: 77957465
Test: Manual/GTS
Merged-In: Ib87a7af0654cc1ec0db052d8ee72f4c74c0aea04
Change-Id: I321b667f9186feaf2579bd4dd27ebf67fc2e0d52
2018-06-06 15:59:28 -07:00
Brad Ebinger
4ae252f80f Unhide @SystemApi Constructor
There are a few small classes that never got properly
exposed as @SystemApi. These classes were not caught
because vendors currently build against the source
directly and have access to hidden APIs. We can not
change the vendor code at this point (different vendor
code for each year for all supported devices), but
we can start pulling back the API for new devices.

1) Keep all public mutable fields @hide and put
todo (and file bug b/74402619) to make fields
private or final.

2) Add public constructor that populates all fields
so that @hide public mutable fields can be set to
private/final in the future.

3) Provide getters for fields that will not be
public in the future.

In this way, we can make minimal API changes for P,
support new vendor/3rd party ImsServices, and phase
out old ImsService implementations that still build
against the source instead of using the correct
@SystemApi.

Bug: 77278031
Bug: 74402619
Test: Manual
Merged-In: Idbf2a71018f1bd06f8445b07fc52bc65cb6776f6
Change-Id: Ifa3b6d0cbdb12e92efc699b760ca874768a89a7c
2018-06-06 15:55:04 -07:00
Brad Ebinger
2388c0cb4c Add GTS test APIs for testing ImsService
Bug: 77141737
Test: Manual
Merged-In: Id60cf07121cf98ab3f0a10af10cf70beb25feb54
Change-Id: Ia41a96b5013bc6a7f534c347db72a14348c1fc5d
2018-06-06 15:28:32 -07:00
Amit Mahajan
70dfbbce29 Update comments for TelephonyManager.getUiccSlotsInfo()
Test: treehugger
Bug: 109757298
Change-Id: I737c8349bb27c4bbbdb1a37bb147249fe30ffa7f
2018-06-05 16:45:07 -07:00
Hall Liu
7236332a74 Merge "Move the "repeated calls" caveat" into pi-dev
am: 7897fa3b9a

Change-Id: Ifbc5e1ffb1093ae9e5abd398dbb3eb190d67142f
2018-05-31 20:33:01 -07:00
Hall Liu
7897fa3b9a Merge "Move the "repeated calls" caveat" into pi-dev 2018-06-01 01:14:37 +00:00
Hall Liu
bc9f7cdf91 Move the "repeated calls" caveat
Previous CL put the "repeated calls will replace the listener" comment
on the wrong method. Fixing.

Bug: 80493663
Test: None, doc change
Change-Id: I2736a582d79b3b2f204519c649d82d9ba912e1e5
2018-05-31 16:26:01 -07:00
Hall Liu
b7e5cd58ac Merge "Fix MbmsDownloadSession documentation" into pi-dev
am: 73942715f3

Change-Id: I9217bcd5d4d70683e788b9afc77686ac2736d429
2018-05-31 14:51:26 -07:00
Hall Liu
bb2ce1010e Merge "Fix MbmsDownloadSession documentation" 2018-05-31 21:16:05 +00:00
Brad Ebinger
f122c22c50 Merge "IMS: Support for Implicit Call Rejection" am: 19d032b695
am: 982ceb81a9

Change-Id: Icc22c412ab47c5a4ca895dfc6c3389a3a6202200
2018-05-31 14:02:10 -07:00
Hall Liu
73942715f3 Merge "Fix MbmsDownloadSession documentation" into pi-dev 2018-05-31 20:34:42 +00:00
Hall Liu
7cdacd3c30 Fix MbmsDownloadSession documentation
Fix the TODO from forever ago and update the docs for the listener
registration methods.

Change-Id: I1276d0afe430e1b50c0af1fdfacb12a89ea5aa38
Fixes: 80493663
Test: None, comments only
2018-05-31 11:40:11 -07:00
Omkar Kolangade
275b1358eb IMS: Support for Implicit Call Rejection
Adding an API in MmTelFeature to allow IMS
Service to report the reasons for implicit
call rejections by lower layers. Corresponding
ImsReasonInfo codes are also being added.

The call rejections are not related to any
call session or a call that Framework is aware
of.

Change-Id: Ie47a239856db21e84d199a7620edf7b6ceeb81bc
2018-05-31 01:37:47 +00:00
Hall Liu
c1ae0a7656 Fix MbmsDownloadSession documentation
Fix the TODO from forever ago and update the docs for the listener
registration methods.

Change-Id: I1276d0afe430e1b50c0af1fdfacb12a89ea5aa38
Fixes: 80493663
Test: None, comments only
2018-05-30 16:11:11 -07:00
Tyler Gunn
5823043e0c Merge "Update onDeregistered docs to make capability change expectations clear." into pi-dev
am: 5025812860

Change-Id: Id84d7761db866905a8c6850beca302f17674ba5f
2018-05-30 07:37:35 -07:00
Tyler Gunn
e08a4fe325 Update onDeregistered docs to make capability change expectations clear.
Updating the onDeregistered docs to make it clear that the ImsService
must report any feature capability changes to the framework prior to
de-registration.

Bug: 73076695
Test: Docs only change.
Change-Id: Ib9bc88bfb43670f04c8afde36d0947255399397a
2018-05-25 15:06:31 +00:00
Tyler Gunn
b1b864cee2 Merge "Require READ_CALL_LOG permission to see phone numbers in phone state." 2018-05-19 00:13:15 +00:00
Tyler Gunn
84dad9565f Require READ_CALL_LOG permission to see phone numbers in phone state.
Incoming and outgoing call phone numbers are visible in the phone state
broadcast and via the PhoneStateListener.  To enhance user privacy, change
to require the READ_CALL_LOG permission in order to receive the call
phone numbers.

This means to see phone numbers:
1. android.intent.action.PHONE_STATE - requires READ_PHONE_STATE and
READ_CALL_LOG permission.
2. PhoneStateListener#onCallStateChanged - now required READ_CALL_LOG
permission.

To support this new behavior, added sendBroadcastAsUserMultiplePermissions
method to context to allow sending the broadcast to all users while
requiring the two permissions.

Bug: 78650469
Test: Created PHONE_STATE broadcast receiver in test app and verified that
when no permissions are granted, the phone number is empty for incoming
and outgoing calls.
Test: Granted Phone state permission to test app and verified that phone
number is not populated.
Test: Granted test app read call log permission and verified that phone
number is populated.
Test: Created PhoneStateListener in test app and verified that when no
permissions are granted, phone number is empty for incoming and outgoing.
calls.
Test: Granted read call log permission to test app and verified that both
the incoming and outgoing numbers are populated.

Change-Id: I857ea00cc58a0abbb77960643f361dd6dd9c8b56
2018-05-18 14:37:43 -07:00
Xiangyu/Malcolm Chen
54bd56d6c5 Merge "Add carrier config for partial sms raw message expiration." 2018-05-18 21:05:55 +00:00
Xiangyu/Malcolm Chen
147dc32b0b Merge "Fix UiccSlotInfo equals method." 2018-05-18 21:05:43 +00:00
Malcolm Chen
b668535a69 Add carrier config for partial sms raw message expiration.
Everytime at boot-up, we check Sms raw table, and delete the rows
with any partial message that is too old. By default the expiration
age is 30 days, but we want to make it configurable.

Bug: 77910620
Test: sanity-test
Change-Id: Ibd2374324be5513cbd09c04889e7b96051c26fb4
Merged-In: Ibd2374324be5513cbd09c04889e7b96051c26fb4
2018-05-17 16:49:12 -07:00
Malcolm Chen
9fd71f8ec5 Fix UiccSlotInfo equals method.
In UiccSlotInfo#equals method, it's comparing Strings incorrectly.

Bug: 78033760
Test: GTS test
Change-Id: I4fed0a70ee0ef06bcf7a1af544e6aebced31d9c2
Merged-In: I4fed0a70ee0ef06bcf7a1af544e6aebced31d9c2
2018-05-17 16:30:32 -07:00
Nathan Harold
c50d40aa9f Add toString() method to PhysicalChannelConfig
We need to be able to print the PhysicalChannelConfig
for debugging/dumping, so adding a toString() method
to print in a format that we can easily digest and
is consistent with other Telephony log formatting.

Bug: 78791811
Test: manual / TelephonyDebugMenu
Merged-In: Ieb12f78a821369072ca9f03d28b28759836f84b4
Change-Id: Ieb12f78a821369072ca9f03d28b28759836f84b4
(cherry picked from commit 2636dd435a)
2018-05-17 11:48:53 -07:00
Nathan Harold
23d103bc00 Merge "Add toString() method to PhysicalChannelConfig" into pi-dev
am: 89a48a509e

Change-Id: I04a47606699837e0b6c2c2079d0cafdb1f22dc77
2018-05-16 22:00:17 -07:00
TreeHugger Robot
89a48a509e Merge "Add toString() method to PhysicalChannelConfig" into pi-dev 2018-05-17 04:45:41 +00:00
Nathan Harold
2636dd435a Add toString() method to PhysicalChannelConfig
We need to be able to print the PhysicalChannelConfig
for debugging/dumping, so adding a toString() method
to print in a format that we can easily digest and
is consistent with other Telephony log formatting.

Bug: 78791811
Test: manual / TelephonyDebugMenu
Change-Id: Ieb12f78a821369072ca9f03d28b28759836f84b4
2018-05-16 12:00:34 -07:00
Xiangyu/Malcolm Chen
272769c41a Merge "Unhide constructors of DataService and NetworkService." 2018-05-15 18:54:50 +00:00
Ta-wei Yen
e1f739d4bd Merge "Update javadoc for setVisualVoicemailSmsFilterSettings" into pi-dev
am: 1f520a64d7

Change-Id: I200ac97a1bdc7efaca638628abff90f3853bf688
2018-05-14 16:59:17 -07:00
Ta-wei Yen
1f520a64d7 Merge "Update javadoc for setVisualVoicemailSmsFilterSettings" into pi-dev 2018-05-14 23:48:55 +00:00
Malcolm Chen
1d7e446f6e Unhide constructors of DataService and NetworkService.
DataService and NetworkService are System level classes. We shouldn't
hide their constructors otherwise their System level sub-class
can't be instantiated properly.

Test: gts
Bug: 77531655
Change-Id: I1a58b4857dbcf939ac124e20eb0a801ad5a9b597
Merged-In: I1a58b4857dbcf939ac124e20eb0a801ad5a9b597
2018-05-14 23:27:42 +00:00
Ta-wei Yen
25d29d7315 Update javadoc for setVisualVoicemailSmsFilterSettings
Test: N/A
Change-Id: I024fa5c2947b562e61e693ecb4d8421fe2507c9e
Fixes: 73829091
2018-05-14 15:32:22 -07:00
Jordan Liu
cdb29f97db Merge "Add Carriers.APN_SET_ID and NO_SET_SET" 2018-05-11 15:57:16 +00:00
Jordan Liu
b11cbb9e2e Merge "Update getIccAuthentication documentation" 2018-05-10 22:56:27 +00:00