Commit Graph

717 Commits

Author SHA1 Message Date
Patrick Scott
08e1f21dd4 Merge "Do not send the not-modified response when validating the cache." 2010-03-11 11:47:22 -08:00
Grace Kloba
c6f95fe523 Implement smart-zoom per Adobe request.
When double tap on plugin object, we toggle between
centering plugin object and overview mode.

Fix http://b/issue?id=2501726
2010-03-11 11:40:46 -08:00
Patrick Scott
5ac85ccabb Do not send the not-modified response when validating the cache.
Bug: 2450517
Change-Id: Ibdff4c4b573bb63ac5de94ec7277241bb0242203
2010-03-11 12:41:20 -05:00
Cary Clark
2809631e59 use the correct LayoutParams to fix going to fullscreen view
Change-Id: Id4d1841d720011c6fda6c43fe7ffb55762cef259
http://2467842
2010-03-11 08:25:33 -05:00
Mike Reed
180403ac10 pin our visible content bounds to the bounds of the doc itself, to account for overscroll
Change-Id: I3c8165338e31da45a70b3f65ba8389a7a50d6e07
http://b/issue?id=2496502
2010-03-10 13:11:48 -05:00
Leon Scroggins
62459c0fa5 If the new text and old text are "", return from onTextChanged.
Fixes http://b/issue?id=2496329

Change-Id: I239f143c0e539710342e46783157344a4d7ccc08
2010-03-10 09:08:47 -05:00
Kristian Monsen
a401d559ec Don't cut the url on a redirect
This is a fix for issue 2485033. It is not a final fix, but just starting with this so it can be discussed on code review. The line in question
was added to fix issue 1690652.

Updated fix. Stores the url before it is cut during a redirect. Forwards this to the reponse instead of the cut url.

Update 2: Using the old originalUrl

Change-Id: I286084451aa45e51d5d07811f9d119cf83849592
2010-03-10 12:40:04 +00:00
Grace Kloba
2d17e1d212 Add an api to set WebView over scroll background.
If the WebView doesn't support zoom, or WebView does
not use wide viewport and horizontal is just fit,
don't do over scroll.

Fix http://b/issue?id=2498403
Fix http://b/issue?id=2497901
2010-03-09 13:14:04 -08:00
Leon Scroggins
7a37587664 Set mShiftIsPressed properly when the focus is a plugin.
Fix for http://b/issue?id=2484986

Change-Id: I3140c3c3a0bd44af85939aceb0bbd07c0861cde4
2010-03-09 14:52:40 -05:00
Grace Kloba
c2242f2b5f Rewrite the WebView touch to support Flash.
When a page is loaded, Flash won't be the touch target.
This is ensured by another CL in external/webkit. When
user taps or uses nav key to make the Flash to be the
document focused node, it will take all the touch
events without time out. If Flash didn't call prevent
default, these touch events will be reprocessed by
the Browser. For double tap and long press, Browser
needs to detect and generate them for Flash.

While Flash is in full screen mode, it will take all
the touch events. If Flash doesn't consume them, they
won't be reprocessed by the Browser. Browser does need
to detect and generate the special events like double
tap and long press for full screen Flash.

Here are changes made for JavaScript touch events.

1. preventDefault on touchMove works now. If the author
calls preventDefault on touchStart, UI will not handle
this touch sequence. If the author didn't call preventDefault
on touchStart, it can call preventDefault on the first
touchMove to prevent UI from panning the page. We
currently do not support alternating preventDefault
during touchMove.

2. The first touchMove is only sent when the movement
is more than the system slop. There was a bug introduced by
https://android-git.corp.google.com/g/#change,42848
where the touch events are not sent to WebCore if 
preventDefault is called. This is fixed now.

3. Move sending TOUCH_EVENT to WebCore into each state.
So if user stops a fling and continue drag, it won't
send the touch_down as we are in drag mode.

4. Remove event time as Adobe doesn't need it any more

Fix http://b/issue?id=2438503
Fix http://b/issue?id=2478701
Fix http://b/issue?id=2390587
2010-03-09 11:33:51 -08:00
Andrei Popescu
0409857f8f Make sure access to WebView::mWebViewCore is synchronized.
Fix bug: 2498784
2010-03-09 18:04:35 +00:00
Leon Scroggins
3dc02fecbe For flash trackball, send several downs followed by a single up.
Change-Id: I2ca892bc409372ab1389f2da8254f13b2d84351c
2010-03-09 11:27:34 -05:00
Cary Clark
31b8367570 requestChildRectangleOnScreen takes layers into account
Call native LayerAndroid::subtractLayers so
the layers can be removed from the visible portion of the screen
when computing how much to scroll.

companion fix in external/webkit

Change-Id: Ib441b826ab5b2baaba20f41f392848a28a9e09ee
http://b/2453841
2010-03-09 10:00:30 -05:00
Leon Scroggins
198e40dcbe Merge "Pass keys to plugin while shift is held down." 2010-03-08 10:42:42 -08:00
Patrick Scott
2807dbd594 If both cookies have null values, use the name difference.
Change-Id: Idee9763a14dd559f136ee8b1eea9abaf265d15a1
2010-03-08 12:12:13 -05:00
Leon Scroggins
b127c8ff0e Pass keys to plugin while shift is held down.
Fix for http://b/issue?id=2484986

Change-Id: Ie252527957958d977cec044a1d383c229d3a3268
2010-03-08 12:04:48 -05:00
Patrick Scott
8da530c9b8 Merge "Cookies like "a=b" were broken due to my previous change." 2010-03-08 08:22:59 -08:00
Steve Block
271f7ae4e3 Merge "For synchronous loads, load file URLs in the WebCore thread, rather than in the new WebViewWorker thread" 2010-03-08 08:16:41 -08:00
Cary Clark
ad7dd48361 scroll into view considers layers
Remove view metrics data, which is a duplicate of
an existing interface (calcOurContentVisibleRect)

companion fix in external/webkit

http://b/2485168
2010-03-08 09:20:16 -05:00
Patrick Scott
d2b49d931a Cookies like "a=b" were broken due to my previous change.
Update the cookie parser to correctly detect "a=b" cookies and add comments.
Also change the comparator to compare null values before the name so that all
cookies with null values come after cookies with values.

Also added a cts test in cts project.

Bug: 2487245
2010-03-08 08:04:21 -05:00
Raphael
30df237f19 ADT: Mark WebView as a Widget. Eclipse/ADT will display it in the GUI creator.
SDK Bug 1588698

Change-Id: I47321a0e21a0761d20ed5e61a1a1db1024a141c5
2010-03-06 10:09:54 -08:00
Grace Kloba
d7625dd281 Adding over scroll to webview. We will always apply
over scroll vertically. In horizontal direction, if
the page can't be zoomed and the current content just
fit, we will not do over scroll.

Per UI request, only draw the shadow when title bar
is not visible.
2010-03-05 11:51:02 -08:00
Steve Block
76619af64c For synchronous loads, load file URLs in the WebCore thread, rather than in the new WebViewWorker thread
This fixes the layout test failure in fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html

Bug: 2218794
Change-Id: If86c5dbb72b21400bd0fb6981de1a6fdf9b40fe7
2010-03-05 18:39:30 +00:00
Ben Murdoch
9a823c4d81 Merge "It is possible that we may get a call from WebCore that the first layout has completed before we've successfully syncd the webview dimensions from Java to native and in this case, we end up syncing a height of 0 to WebKit. This causes hit detection to fail, as WebKit thinks we have a 0-height visible area. This patch fixes this scenario by syncing the height of the webview back to WebKit in the case that the first layout comes back before we've sent our dimensions." 2010-03-05 09:42:06 -08:00
Ben Murdoch
d1bee05d64 It is possible that we may get a call from WebCore that the first layout has
completed before we've successfully syncd the webview dimensions from Java to
native and in this case, we end up syncing a height of 0 to WebKit. This causes
hit detection to fail, as WebKit thinks we have a 0-height visible area. This
patch fixes this scenario by syncing the height of the webview back to WebKit
in the case that the first layout comes back before we've sent our dimensions.

Fix for b/2449863

Change-Id: Id72c37b17411f3409edc7104d83ca5ffd17ab09b
2010-03-05 17:25:44 +00:00
Shimeng (Simon) Wang
1c02c6a7d8 Squashed commit of the following:
commit 35ade1c72b5fe34c177712108ccbc070eab11a87
Author: Shimeng (Simon) Wang <swang@google.com>
Date:   Thu Mar 4 16:29:01 2010 -0800

    Alternative way to fix the history picture drawing issue.

    Disable zoom part for history picture mode.

    Bug: 2462039

commit 1a27acaa36c60546e5e6b2e1caf4ce5488dad14b
Author: Shimeng (Simon) Wang <swang@google.com>
Date:   Thu Mar 4 16:06:41 2010 -0800

    Use the screen width to derive the desired scale.

    This is to fix the history picture draw issue.  Since the mActualScale
    will be changed in some other places.

    Bug: 2462039
2010-03-05 09:22:41 -08:00
Mike Reed
189e7355e6 return false if any exception is thrown from savePicture 2010-03-05 10:12:29 -05:00
Cary Clark
966641a8da add comment for public function
http://b/242036
2010-03-04 08:58:33 -05:00
Leon Scroggins
75a36c2bc7 Remove an overzealous call to setDefaultSelection.
This was added to try and fix an earlier bug,
http://b/issue?id=2431351  However, it results in all
touches setting to the default selection, which
is incorrect.

Fix for http://b/issue?id=2486721
2010-03-04 08:44:56 -05:00
Grace Kloba
f6bd0ba630 Don't send ACTION_MOVE to webkit until the distance
is confirmed to be a drag.

Always send touch events to webkit if a subview, plugin,
is in full screen mode.

Fix http://b/issue?id=2478701
2010-03-03 10:28:55 -08:00
Leon Scroggins
c833119c14 Merge "Remove the TAB key from <textarea>s." 2010-03-03 09:21:14 -08:00
Leon Scroggins
7af1b837ff Remove the TAB key from <textarea>s.
Do not use flag for web edit, so that the IME does not have the
TAB key.

Fix for http://b/issue?id=2484101
2010-03-03 12:09:45 -05:00
Cary Clark
3403eb3156 refactor find state and scrolling
Separate out state when find is up and is empty.
Request a scroll when setting a match, rather than when drawing.
Don't draw if there's no match.

Companion fix in external/webkit and packages/apps/Browser

http://b/2370069
2010-03-03 11:12:33 -05:00
Cary Clark
de023c1ddd refactor find state and scrolling
Separate out state when find is up and is empty.
Request a scroll when setting a match, rather than when drawing.
Don't draw if there's no match.

Companion fix in external/webkit and packages/apps/Browser

http://b/2370069
2010-03-03 10:42:45 -05:00
Patrick Scott
0b2e84b32a Add a client for WebBackForwardList operations.
Provide a custom data slot in WebHistoryItem to store application data in the
history item. A client of WebBackForwardList can insert their custom data into
the item when created. In onIndexChanged, the custom data can be read by the
client.
2010-03-02 14:28:07 -05:00
Grace Kloba
4addf9b5d8 When titlebar's visible height changed, it means the
WebKit viewsize need to be updated.

Fix http://b/issue?id=2470621
2010-03-02 10:28:13 -08:00
Leon Clarke
43242d02e9 am ba74d7cc: am e861b8f9: Merge " Fix issue with authentication with flash" into eclair-mr2
Merge commit 'ba74d7ccadc34d09d57886120e9d412d9edbc4d7'

* commit 'ba74d7ccadc34d09d57886120e9d412d9edbc4d7':
  Fix issue with authentication with flash
2010-03-02 08:44:48 -08:00
Cary Clark
f79a819f24 Merge "account for find dialog height when positioning layers" 2010-03-02 08:37:18 -08:00
Leon Clarke
e861b8f95d Merge " Fix issue with authentication with flash" into eclair-mr2 2010-03-02 08:33:10 -08:00
Grace Kloba
c2ca936700 Merge "Start the synchronous load in the WebCore thread." 2010-03-02 08:21:22 -08:00
Cary Clark
72ab9980cb account for find dialog height when positioning layers
The Find dialog draws on top of the WebView, including any
layers attached to the bottom of the screen. Adjust the view
dimenions returned to the layer code by the height of the Find
dialog if visible.

http://b/2453769
2010-03-02 10:59:44 -05:00
Leon Clarke
cb01dba348 Fix issue with authentication with flash 2010-03-02 14:43:03 +00:00
Derek Sollenberger
2705c8f099 Merge "DO NOT MERGE. force plugins to render on top of browser content." into eclair-mr2 2010-03-02 06:33:32 -08:00
Patrick Scott
0245e09fa7 Merge "Store the LoadListener in the SslErrorHandler passed to the client." 2010-03-02 05:40:09 -08:00
Grace Kloba
5f38e1aaa1 Start the synchronous load in the WebCore thread.
Fix http://b/issue?id=2480606
2010-03-01 23:10:10 -08:00
Grace Kloba
3ff7cecd3d Merge "DO NOT MERGE" into eclair-mr2 2010-03-01 16:02:12 -08:00
Grace Kloba
12f807091d am 3ca122df: am cfb50c66: Merge "If we get TOUCH_UP before getting the WebCore\'s response for TOUCH_DOWN, remove the pending TOUCH_EVENT before proceeding to fling." into eclair-mr2
Merge commit '3ca122df9e9a25f7ed1c39ef18c5c4ba2e316fe8'

* commit '3ca122df9e9a25f7ed1c39ef18c5c4ba2e316fe8':
  If we get TOUCH_UP before getting the WebCore's
2010-03-01 13:16:46 -08:00
Grace Kloba
a752a949af If we get TOUCH_UP before getting the WebCore's
response for TOUCH_DOWN, remove the pending TOUCH_EVENT
before proceeding to fling.

This is partial fix for 
http://b/issue?id=2450534
2010-03-01 12:29:11 -08:00
Derek Sollenberger
6078399d29 DO NOT MERGE. force plugins to render on top of browser content. 2010-03-01 15:26:43 -05:00
Grace Kloba
b3d0cc5ca9 If zoom scale is set to minimum, treat it as in overview
mode.

When view size changed, we will adjust scale factor,
which should update the zoom button states afterwards.
 
http://b/issue?id=2477282
2010-03-01 12:25:29 -08:00