Commit Graph

793 Commits

Author SHA1 Message Date
Youngjun Kwak
8ddd24d39d DO NOT MERGE Set focus to PasswordTextView by default.
This ensures that password will be entered reliably programmatically in
CTS.

Bug:183644428
Test: atest CtsWindowManagerDeviceTestCases:KeyguardLockedTests &&
atest CtsWindowManagerDeviceTestCases:MultiDisplayLockedKeyguardTests

Change-Id: I35fa005e4571b150995efe8b0cc07a4556e06619
2021-04-02 00:15:43 +00:00
Youngjun Kwak
3c8e090455 Merge "Revert "DO NOT MERGE Remove focus on PasswordTextView"" into rvc-qpr-dev 2021-04-01 17:11:33 +00:00
Youngjun Kwak
44c4a7496e Revert "DO NOT MERGE Remove focus on PasswordTextView"
This reverts commit 1a96556be5.

Reason for revert: Although it makes sense in terms of UX that the PasswordView need not be highlightable, 
this change caused CTS failures, so we decided to revert this change.

Bug:183644428
Test: atest CtsWindowManagerDeviceTestCases:KeyguardLockedTests && 
atest CtsWindowManagerDeviceTestCases:MultiDisplayLockedKeyguardTests

Change-Id: I57f3d671a7c8430dd02cd7ddb9badbaab242f150
2021-03-31 21:46:23 +00:00
Alex Stetson
87e65f6442 Merge "DO NOT MERGE Inflate NotificationPanel on instantiation" into rvc-qpr-dev 2021-03-25 23:44:16 +00:00
Youngjun Kwak
7dc8ba8c37 Merge "DO NOT MERGE Remove superfluous resetting of Keyguard on unocclusion." into rvc-qpr-dev 2021-03-20 01:41:25 +00:00
Alex Stetson
04cdf3a7d4 DO NOT MERGE Inflate NotificationPanel on instantiation
If the NotificationPanel is not inflated, the proper listeners are not
setup and certain behavior will be broken until the panel is opened for
the first time.

Bug: 182531816
Test: manual
Change-Id: If55156b963c0a83ff644524dea0106708f1635cc
2021-03-17 09:26:13 -07:00
kwaky
92d80a9626 DO NOT MERGE Remove superfluous resetting of Keyguard on unocclusion.
Bug: 182245575
Test: Manual
Change-Id: I6fc7aa47a7880f321a50e687dd0882bd530a586b
Merged-In: I23eed3a1edbcbe946d14500d92d139b941a53ca4
2021-03-16 22:36:26 +00:00
kwaky
1f2cb484f9 DO NOT MERGE Delete superfluous call of mInsetsController.onControlsChanged.
This is already called by systemui and the redundant call causes
leash access after invalidation.

Bug: 179307474
Bug: 171031234
Bug: 177940325
Test: Manual
Change-Id: Ie2d12fc857a8b6dd5d8ee8b57ad693c822b896a4
2021-03-12 10:37:24 -08:00
TreeHugger Robot
b69e261eb2 Merge "DO NOT MERGE Remove focus on PasswordTextView" into rvc-qpr-dev 2021-03-11 01:50:50 +00:00
Heemin Seog
1a96556be5 DO NOT MERGE Remove focus on PasswordTextView
Because we provide a PIN pad, the passwordTextView does not need to be
focusable.

Bug: 182211814
Test: manual
Change-Id: Ib0ed8c0bf6c0fd70f750e093b1fb64134866d442
2021-03-11 00:03:39 +00:00
Youngjun Kwak
ed260d837f Merge "DO NOT MERGE Do not reinflate the layout if it has not been already inflated." into rvc-qpr-dev 2021-03-09 18:19:26 +00:00
kwaky
b700beab66 DO NOT MERGE Do not reinflate the layout if it has not been already inflated.
This fixes the NPE caused when reinflate method is called before the
layout is inflated.

Bug: 180534861
Test: Manual
Change-Id: Ia3fb6867e55c63a5fe7c17df1c3f86d048b4d1a8
2021-03-08 10:48:05 -08:00
Youngjun Kwak
b20f69a4cc Merge "Move posting logic from PerDisplay to DisplayWIndowInsetsControllerImpl." into rvc-qpr-dev 2021-03-05 22:39:32 +00:00
kwaky
3cc2f503bf Move posting logic from PerDisplay to DisplayWIndowInsetsControllerImpl.
Partial backport of I9a354f742167b907c32537eb022e22c0d5bfb97a.

Bug: 178071393
Test: Manual & Existing Unit Tests
Merged-In: I9a354f742167b907c32537eb022e22c0d5bfb97a

Change-Id: Ie8210170776d1a5a3b736b6d43989cc59ba30f48
2021-03-05 12:44:46 -08:00
Heemin Seog
e076c2344e DO NOT MERGE Add generic rotary support for sysui overlay window
Bug: 181138897
Test: manual
Change-Id: I353d9587fce09c5dff7328b5dec7e973230f2a9c
2021-03-04 11:53:18 -08:00
Heemin Seog
a287650f94 DO NOT MERGE Intercept back button on user switcher screen
The back button on the user switcher screen should go back to the
lockscreen of the current user.

Bug: 178505273
Test: manual (press back button from user switcher screen while it has
rotary focus)

Change-Id: I30b8619a26e8b0c1ca9632b3bb656d187dad91b9
2021-02-26 17:38:37 +00:00
Heemin Seog
9d3b7aacd9 DO NOT MERGE Dont restore focus on new HUN window
When a HUN window shows for the first time, Android framework can try to
find a default focus. As such, the FPV may try to focus the topmost HUN
by default, without having nudged to the HUN window.

Bug: 175897692
Test: manual (reboot and trigger HUN via kitchen sink)
Change-Id: Id4008c587aea353dc0c441593fe32e6e9fea5463
2021-02-01 22:18:03 +00:00
Heemin Seog
2f5e1b4004 DO NOT MERGE Handle back button for notification panel
Bug: 178504029
Test: manual
Change-Id: If44048ab1772b85d13aa1f96a23eded896c53883
2021-01-27 12:56:36 -08:00
Danny Epstein
ab6fd7362d DO NOT MERGE Focus clock by default
When nudging up to the status bar, focus the clock by default.

Test: Nudge up to status bar, switch from Launcher to Home
Bug: 169250454
Change-Id: Id55c236a447b86d502d46e799814b51c984916e4
2021-01-05 13:47:04 -08:00
Bill Yi
7bd07b24b3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I189241262a8cd88d60bbb9008bb1366a1aebeedd
2020-12-16 22:24:42 +00:00
Danny Epstein
9242e6ee6a DO NOT MERGE Use round highlight for navigation buttons
Make the focus highlight and touch ripple for buttons in the navigation
bar be round rather than square.

Also fix a bug in the dimming logic. The alpha was applied to the icon
initially, but when the state changed, the alpha was applied to the
entire button.

Launcher in master is quite different so it this change is limited to
rvc-qpr-dev for now.

Test: manual
Bug: 174614908
Bug: 168317872
Change-Id: I9b80946887ad85a73ddd281f7afcc9fcc8280a64
2020-12-03 16:35:13 -08:00
Bill Yi
5e75c33b11 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5d560633be89394ac8656192ae8e03367f7fdd67
2020-11-23 06:42:05 +00:00
Heemin Seog
20549dfe49 DO NOT MERGE Update bottom huns container to use HeadsUpContainerView
Necessary to nudge to the topmost notifications in rotary mode

Bug: 172267951
Test: manual
Change-Id: I3ac9a467589bfbe090e1b0c743dad6ca6332f56e
2020-11-17 20:52:58 -08:00
kwaky
c83cc01b62 DO NOT MERGE Update current user for passwordEntry and restart input on user switch.
This prevents IME not working due to the passwordEntry input field
drawn for a wrong user or due to having an invalid token.

Test: Manual
Bug: 168825956
Change-Id: I28e38a523e67011df680c9dfb21907047c0e3278
2020-09-24 15:57:47 -07:00
Youngjun Kwak
4d714cb8e9 Merge "Map bar type to new ITYPE_{SIDE}_MANDATORY_GESTURES_INSETs" into rvc-qpr-dev 2020-09-24 15:19:11 +00:00
Heemin Seog
fbec38f2ae Ensure the notif panel is inflated
Bug: 168823233
Test: manual
Change-Id: I1ed35a0c240acb2fa06241f34aa9c7a549dc360b
2020-09-23 14:19:25 -07:00
kwaky
9b2063caaf Map bar type to new ITYPE_{SIDE}_MANDATORY_GESTURES_INSETs
Bug: 167565741
Bug: 167288724
Test: atest WindowInsetsPolicy and atest SystemBarConfigs all passing

Change-Id: I767a423bc2437021af02c01a84fa3e1834413c1e
2020-09-22 11:05:56 -07:00
Heemin Seog
5079993610 Ensure notif panel behavior in immersive mode
Bug: 168823233
Test: manual, atest :carsysui-presubmit
Change-Id: I38241142a05c25cef5a5f3955ca7de49feb5c393
2020-09-18 16:35:39 -07:00
TreeHugger Robot
119e662303 Merge "Increase keyguard password maxlength to 500" into rvc-qpr-dev 2020-09-17 02:34:09 +00:00
Youngjun Kwak
2d1d3d0897 Merge "DO NOT MERGE Enable hiding system bars by side when IME appears." into rvc-qpr-dev 2020-09-16 15:11:35 +00:00
Agatha Man
d5b74ca264 Increase keyguard password maxlength to 500
Bug: 166867759
Bug: 165784344
Test: manual
Change-Id: Ic39223652fc7afe627259c4317ae90e0bcbc65b9
2020-09-15 20:41:23 -07:00
kwaky
cc3dfbeeba DO NOT MERGE Fix subclass/superclass check for NotificationPanelViewMediator.
Bug: 165806308
Test: Manual + Unit Tests Passing
Change-Id: I8f443762f1b487ab9d3fe4f6f84b0aa86e3d0c8a
2020-09-15 15:51:26 -07:00
kwaky
a0e8b666e4 DO NOT MERGE Enable hiding system bars by side when IME appears.
Bug: 167593045
Test: Manual + Unit Tests
Change-Id: Ib0c2c70e2df361f5cce156315c7fd4ae489ae279
2020-09-15 15:12:13 -07:00
Heemin Seog
b6f4a0c672 DO NOT MERGE Adjust window focusable by view controller
Some adjustments to note:
1. remove previous focusability changes per view controller
2. disallow calling insetsController.show/hide without window focus
3. update tests to depend on window focus
4. update DisplaySystemBarsController to refer to parent class for ime
insets

Bug: 163135884
Test: manual, atest :carsysui-presubmit
Change-Id: If5adf599bc2c676ad296f89566534c1fdc9f2492
2020-09-08 21:27:17 +00:00
Youngjun Kwak
339c9812f2 Merge "Fix AAOS SystemUI Presubmit tests that are breaking." into rvc-qpr-dev 2020-09-01 22:20:45 +00:00
Youngjun Kwak
4ee23daf7d Merge "Make SystemUI crash with warning if SystemBarConfigs is incompatible with NotificationPanelViewMediator." into rvc-qpr-dev 2020-09-01 22:20:45 +00:00
kwaky
56c3b76fc4 Make SystemUI crash with warning if SystemBarConfigs is incompatible with NotificationPanelViewMediator.
Bug: 162599873
Bug: 165806308
Test: Manual
Change-Id: I855c03d11e31cf722609f2bb0b0cb6c01624b0c0
Merged-In: I855c03d11e31cf722609f2bb0b0cb6c01624b0c0
2020-08-31 23:39:04 +00:00
kwaky
4a6f9b9721 Fix AAOS SystemUI Presubmit tests that are breaking.
Due to the newly added check in SystemBarConfig, tests can fail
erroneously when testing behavior of when either top or bottom system
bar is not enabled.

Bug: 162599873
Bug: 165808744
Test: atest carsysui-presubmit --include-subdir passing. (5/5)
Change-Id: Ife2ac4e746006c39eaf46cd0328c1639149891b2
Merged-In: Ife2ac4e746006c39eaf46cd0328c1639149891b2
2020-08-31 23:38:15 +00:00
Youngjun Kwak
e7c2611944 Merge "Fix NotificationPanel animation jank." into rvc-qpr-dev 2020-08-28 17:07:43 +00:00
Heemin Seog
2d4e0b75e2 Merge "Fix some notifications animation issues" into rvc-qpr-dev 2020-08-27 04:19:31 +00:00
Heemin Seog
d6f2f7fc11 Fix some notifications animation issues
Fix notif animation to not repeat when the panel is fully open
Fix notif animation when swiping the panel to close and it gets stuck

Bug: 158306816
Test: manual
Change-Id: Ia5ed0d9dca4e8366bd3f1526a3295464e3d06be4
2020-08-26 15:51:40 -07:00
kwaky
efc2cf9c4b Fix NotificationPanel animation jank.
Bug: 162599873
Bug: 161172460
Test: Manual -- To repro the bug, swipe on the Notification cards in the
closing direction. This should not in fact close the Notification Panel
since the user's intent is to scroll the Notification cards, not to
close the Notification panel. This also results in the animation jank.
This behavior is no longer observed after this fix.

Change-Id: I6144c064faf151a091ec66df4616036bf765e9fb
2020-08-26 14:59:13 -07:00
Heemin Seog
298ab92a0e DO NOT MERGE Add unused StatusBar to prevent crashes
Bug: 165390412
Test: manual (ensure UnusedStatusBar is used instead of StatusBar)
Change-Id: I3c9f48f86a599f950fb4e1268dd4a15468aa5839
2020-08-24 17:58:19 -07:00
Youngjun Kwak
96540963a8 Merge "Fix flaky test in ConnectedDeviceVoiceRecognitionNotifierTest." into rvc-qpr-dev 2020-08-05 16:10:53 +00:00
kwaky
2bc72aa87f Fix flaky test in ConnectedDeviceVoiceRecognitionNotifierTest.
Bug: 161892451
Test: atest ConnectedDeviceVoiceRecognitionNotifierTest now passes
without flakiness (10/10)

Change-Id: I95acf0fdbfa7ff1bf6bf02f7c3defbed27510250
2020-08-04 13:49:26 -07:00
TreeHugger Robot
82abf1c4cd Merge "Fix SideLoadedAppListenerTest" into rvc-qpr-dev 2020-08-01 01:48:45 +00:00
kwaky
01e7567c22 Fix SideLoadedAppListenerTest
Display2 is expected to return stack info that is not safe, and so it is
expected that onUnSafeTaskDisplayedOnDisplay is called for it.

Bug: 161892451
Test: Unit Test
Change-Id: I3e3afbadff4cb2fc252c5b0d4fe32bd9ce19097a
2020-07-31 17:04:26 -07:00
kwaky
ff69d4bf4c Fix UserSwitchTransitionViewMediatorTest
First, it has to extend SystemUiTestCase to pass AAAPlusPlusVerify Test.
Second, CarDeviceProvisionedController is injected into the Mediator and
mocked in its test to correctly test case where the user life cycle
event is being applied to the current user and a case when it is not.

Bug: 161892451
Test: Unit Test (the corresponding tests passing now.)
Change-Id: I8be7dacaa1bf0abb87dcb357c37e58ce511132d2
2020-07-31 16:49:24 -07:00
kwaky
4030db5f0d Allow SystemBar configuration via XML.
Bug: 160028073
Bug: 161825538
Test: Unit Tests + Manual -- CarNavigationBar reads configs from
SystemBarConfigs and applies them as intended. It throws an error when
the config validation fails.

Change-Id: If1575bdc2549058600fb80fa0d6c340fd3e1dbc5
2020-07-29 09:18:31 -07:00
TreeHugger Robot
c8e7ceeb71 Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-qpr-dev 2020-07-25 14:42:37 +00:00