Commit Graph

13910 Commits

Author SHA1 Message Date
Matt Pietal
f13dbe1a64 Merge "Sharesheet - Fix logic for a-z count" into rvc-dev am: c3e572fc74
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11820081

Change-Id: I5e8007be4e570a84d5cba6f2a694bee8893089d2
2020-06-10 20:24:42 +00:00
Matt Pietal
c3e572fc74 Merge "Sharesheet - Fix logic for a-z count" into rvc-dev 2020-06-10 20:10:15 +00:00
TreeHugger Robot
fe7e3019d2 Merge "Conversations UX polish pass" into rvc-dev am: 62a1b9d17e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11821053

Change-Id: I862dcd0507e86caa1329b46eb8eb602fb32cf39b
2020-06-10 19:52:16 +00:00
TreeHugger Robot
62a1b9d17e Merge "Conversations UX polish pass" into rvc-dev 2020-06-10 19:48:56 +00:00
TreeHugger Robot
f380ccaf3d Merge "Sharesheet - Disable expansion" into rvc-dev am: dc9a555126
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11820086

Change-Id: I900d125379a91c1b3a7640d10c1c79e75c78ce9f
2020-06-10 19:22:39 +00:00
TreeHugger Robot
dc9a555126 Merge "Sharesheet - Disable expansion" into rvc-dev 2020-06-10 19:07:05 +00:00
Steve Elliott
282498aaa5 Conversations UX polish pass
- adjust position of expanded group avatar to remain vertically
    centered with title

  - adjust top padding of guts to match that of conversation layout

  - vertically align app name and time in the conversation header

  - clean up some of our XML styles

Fixes: 157757386
Test: manual, visual
Change-Id: I5eb774b44ce641a97c5deb706711f3b252e6554e
2020-06-10 14:02:09 -04:00
Matt Pietal
185f715e77 Sharesheet - Disable expansion
Leave disabled until more apps are using sharing shortcuts

Fixes: 157065816
Test: atest ChooserActivityTest
Change-Id: I7f8811617fe2f3a77f86b8459c7f06b0929a40c9
2020-06-10 11:40:55 -04:00
Matt Pietal
1245b38b60 Sharesheet - Fix logic for a-z count
Prior logic only counted the number of grouped items. This could
result in the a-z list not being shown even though there were
additional targets. For instance, if 1 group had 9 targets, a-z
would've been hidden even though only 4 targets were present in the
ranked app row, resulting in 5 targets being inaccessible.

Fixes: 158017940
Test: atest ChooserActivityTest#fourOptionsStackedIntoOneTarget
Change-Id: I58e262e40f3064ce8a091e44d6b00163c8f4e4f3
2020-06-10 11:16:55 -04:00
TreeHugger Robot
4512999c22 Merge "Tweak Sharesheet DS icon rendering to ignore system shapes" into rvc-dev am: f6793af032
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11814420

Change-Id: Id11801611054f88a91c81107497e0d0434f82a8f
2020-06-10 13:13:12 +00:00
TreeHugger Robot
f6793af032 Merge "Tweak Sharesheet DS icon rendering to ignore system shapes" into rvc-dev 2020-06-10 13:04:23 +00:00
Matt Pietal
2a76a6928b Merge "Sharesheet - Disable delegate" into rvc-dev am: a4614b0f1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11814085

Change-Id: I15493708dd65c138ab449bbb81cb27cb87e20df7
2020-06-10 12:21:58 +00:00
Matt Pietal
a4614b0f1f Merge "Sharesheet - Disable delegate" into rvc-dev 2020-06-10 12:06:23 +00:00
TreeHugger Robot
7aa4e3e9df Merge "Adjust conversation layout paddings to match UX spec" into rvc-dev am: acea7d392c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11813182

Change-Id: Ife5ecf982f6be56e399ddf1feef3017b728d6b31
2020-06-09 22:19:37 +00:00
Mike Digman
4141daa946 Tweak Sharesheet DS icon rendering to ignore system shapes
Directly renders AdaptiveIconDrawables to avoid normal masking
by the user applied icon shape. Shifts insetting to DS circle
masking to avoid clipping issues.

Test: manual
Fixes: 158318613
Change-Id: I2abc6f866500f2d8045af46278e9bac6a53458fc
2020-06-09 14:42:21 -07:00
Matt Pietal
9a178365c4 Sharesheet - Disable delegate
The original plan was to move sharesheet into systemui. The first
step was to route through a delegate living in systemui, which 
would just launch the activity. However, the full migration has not
occurred. And more notably, there are intermittent race conditions
caused by token expiration. This comes from the framework activity token
being removed just before the target intent is launched, due to the
requirement to call finish() on resolver/chooser when complete.

Fixes: 157272342
Test: atest ChooserActivityTest ResolverActivityTest
Change-Id: I75ca19589ba78abc1d1a05a917457c151420c949
2020-06-09 21:33:46 +00:00
Steve Elliott
666124b0c5 Adjust conversation layout paddings to match UX spec
Fixes: 157757386
Fixes: 157144647
Test: manual, visual
Change-Id: Ibeccc0fe2269aea69b882895fbb1a280cd6bf126
2020-06-09 15:59:58 -04:00
TreeHugger Robot
f4db31bacb Merge "Add importance ring animation on convo priority change" into rvc-dev am: 80d5c61da5
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11739864

Change-Id: I8fa7a45a1e3d4f460fe95e1012722d180c4dc40f
2020-06-09 15:34:31 +00:00
TreeHugger Robot
80d5c61da5 Merge "Add importance ring animation on convo priority change" into rvc-dev 2020-06-09 15:33:55 +00:00
TreeHugger Robot
c1f9c5e221 Merge "Report WINDOW_FOCUS_GAIN_REPORT_ONLY when the served connection remains" into rvc-dev am: b121512580
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11686078

Change-Id: Ibb8d43ae4df099b3304284571365a3b55f0daa4c
2020-06-09 13:55:38 +00:00
TreeHugger Robot
b121512580 Merge "Report WINDOW_FOCUS_GAIN_REPORT_ONLY when the served connection remains" into rvc-dev 2020-06-09 13:41:30 +00:00
Ming-Shin Lu
6ecbf08772 Report WINDOW_FOCUS_GAIN_REPORT_ONLY when the served connection remains
When we tried CL[1] to fix Gboard Translation UI dialog dismissed that
keeping the served view when focused to the next window,
although we can skip starting new input when the window focused back as
the behavior of Q,

However, we overlooked in R, IME insets will rely on IMS#reportStartInput
to get the updated IME input target, which will out of sync for the above
case.

To fix this regression, we report the next window focus gain
to IMMS with WINDOW_FOCUS_GAIN_REPORT_ONLY when the next focused view is
same as current served view and the served input connection remains.

so that in IMMS side won't get StartInputFlags.INITIAL_CONNECTION flags
to set restarting as false when calling IInputMethod#startInput to IMS,
and in IMS side will still call reportStartInput to WMS for updating
IME input target without additional onFinishInputView callback to
client.

[1]: I8d4fff94ba9313b773bc27fcbd019cc88580d3e9

Fix: 152373385
Bug: 155781821
Test: atest CtsInputMethodTestCases
Test: manual, make sure Bug 155781821 comment #10 works:
    1) Launch video call in Hangouts.
    2) End call.
    3) Click on the text box.
    4) Expect Soft-Keyboard shown
Test: make sure not break Bug 148489857 and Bug 148788569, following
auto / manual test to verify:
 - Auto: atest FocusHandlingTest#testKeyboardStateAfterImeFocusableFlagChanged
 - Manual:
    1) Build / install EditTextVariations
    2) Select menu -> Direct-Reply, make sure Notification comes up.
    3) Tap EditText on Notification, verify soft-keyboard is visible.

Change-Id: I45a9814d812ad906f417c24200fd4219959e2423
2020-06-09 13:48:15 +08:00
Steve Elliott
8b4929dbbf Add importance ring animation on convo priority change
Bug: 157480039
Test: manual
Change-Id: I0c3b2a857c871fc344705f98aa8463e7de0c4b6b
2020-06-08 22:41:29 -04:00
Joanne Chung
158b81b6f0 Merge "Handle SyncResultReceiver.TimeoutException" into rvc-dev am: 9856804eb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11489902

Change-Id: I3be81b8ba85c2ed8809f2c798a543bd4ff5469fe
2020-06-09 00:35:13 +00:00
Joanne Chung
9856804eb2 Merge "Handle SyncResultReceiver.TimeoutException" into rvc-dev 2020-06-09 00:21:44 +00:00
Daniel Sandler
b5c8dcc91a Merge "Show the nearby chip for images and files too." into rvc-dev am: bb2d9a52c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11756600

Change-Id: I13b3ce771dca29068076294e2e5e340570943cb3
2020-06-08 20:12:25 +00:00
Daniel Sandler
bb2d9a52c1 Merge "Show the nearby chip for images and files too." into rvc-dev 2020-06-08 20:11:04 +00:00
Treehugger Robot
b736478a80 Merge "KernelCpuUidBpfMapReader: Verify presence of Uids before deleting" am: 907124607f am: 5f016c8deb
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1321018

Change-Id: I376684b31398743e5c873e8ccc874d0c6a1c8c89
2020-06-08 16:19:19 +00:00
Joanne Chung
c6adc68368 Handle SyncResultReceiver.TimeoutException
1.Change SyncResultReceiver.TimeoutException to checked exception
2.Handle the SyncResultReceiver.TimeoutException in AutofillManager,
ContentCaptureManager, ContentSuggestionsManager
3.Fix the bug we should throw e.rethrowFromSystemServer()

Bug: 156044027
Test: atest CtsAutoFillServiceTestCases
Test: atest ContentSuggestionsManagerTest
Test: atest CtsContentCaptureServiceTestCases
Change-Id: I959d2aca2b80866c076fae2520de66c123f5367d
2020-06-08 14:53:45 +08:00
Steve Elliott
eec7f12366 Merge "Fix missing icon for one-to-one convos" into rvc-dev am: 05e10b59af
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11727185

Change-Id: I43fc706e88d78547aed43737ffadcb93b54da0bf
2020-06-06 15:29:19 +00:00
Steve Elliott
05e10b59af Merge "Fix missing icon for one-to-one convos" into rvc-dev 2020-06-06 15:12:04 +00:00
Svetoslav Ganov
2d56a15699 Merge "Correctly offset app op history on reboot" into rvc-dev am: 0ce4fba38f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11747376

Change-Id: I3cd684c2f48b456efe4831a1bcb1dbffa9857c8c
2020-06-06 15:06:03 +00:00
Svetoslav Ganov
0ce4fba38f Merge "Correctly offset app op history on reboot" into rvc-dev 2020-06-06 14:50:03 +00:00
Jing Ji
d948fca5dd Merge "Use the UID as the package name in procstat assoc proto dump" into rvc-dev am: d29532e699
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11725049

Change-Id: I0b5ee05a425ae7904eb361e79664800271e52f6d
2020-06-05 23:18:54 +00:00
Jing Ji
d29532e699 Merge "Use the UID as the package name in procstat assoc proto dump" into rvc-dev 2020-06-05 23:16:36 +00:00
Mike Digman
2fd7f7c3a8 Merge "Make Sharesheet group and pin menu match material, redlines" into rvc-dev am: 5aa8394608
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11739866

Change-Id: I1e7c5bfc726f11e992df8fc37a5eb703d06e9572
2020-06-05 19:29:02 +00:00
Mike Digman
5aa8394608 Merge "Make Sharesheet group and pin menu match material, redlines" into rvc-dev 2020-06-05 19:19:41 +00:00
Miranda Kephart
762b9fb13d Merge "Only show error if screenshot process dies within timeout period" into rvc-dev am: 3a51a85aaf
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11739868

Change-Id: I72b2353a5bfe4961b74776e07f5db33dd3a777ef
2020-06-05 19:09:58 +00:00
Miranda Kephart
3a51a85aaf Merge "Only show error if screenshot process dies within timeout period" into rvc-dev 2020-06-05 18:55:08 +00:00
Mike Digman
ad2e9a0a57 Make Sharesheet group and pin menu match material, redlines
Requires wholesale creation of dialog layout. Using a fixed
width approach.

Test: manual
Bug: 152978014
Fixes: 158023059
Change-Id: Ifcff21b2f999839c3eba601a2ee96a08677e1267
2020-06-05 10:18:43 -07:00
Svet Ganov
185ddf644b Correctly offset app op history on reboot
The offset was computed based off the offset represented by
the most recent historical file while we have to use the time
this file was written.

Also now we persist the history on reboot and shutdown,
significantly minimizing the possibility of data loss.

Added test API to emulate reboot of the history to allow for
precise and tightly controlled test to prevent flakes due to
boot time deviations.

Test: atest android.app.appops.cts.HistoricalAppopsTest#testRebootHistory

Fixes:156853195

Change-Id: I4142371f8bc2b1d710cc8c300e7e79cb03764c04
2020-06-05 09:55:27 -07:00
Dan Sandler
b18b59fd58 Show the nearby chip for images and files too.
This revealed that we weren't initializing the nearby intent
from the original intent, so that's fixed too. This should
ensure that flags and extras from the original intent make
their way to the available and installed nearby component.

Test: Share (an image and a non-image) from DocumentsUI
Fixes: 155487375
Fixes: 155676993
Change-Id: If0c0b754a066b0ec439a866de3eae84caca7b793
2020-06-05 12:45:14 -04:00
TreeHugger Robot
0411d1d7e3 Merge "Cleanup outdated TODOs" into rvc-dev am: 6d410d8165
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11755478

Change-Id: Ieef9c07316a249d2336d2f9e3440e6e429022037
2020-06-05 16:10:29 +00:00
TreeHugger Robot
6d410d8165 Merge "Cleanup outdated TODOs" into rvc-dev 2020-06-05 15:53:50 +00:00
arangelov
a2a821336f Cleanup outdated TODOs
Fixes: 158292009
Test: compiled
Change-Id: I7889c7ee818c154194bbe66eabbe04aa7ddb65a4
2020-06-05 15:27:43 +01:00
PETER LIANG
37746ba287 Merge "Shouldn't turn on other accessibility features in SuW." into rvc-dev am: c9f8b52b26
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11716081

Change-Id: Iff43cb6194874cb2ee333bc460cbc13963ea8a06
2020-06-05 12:41:13 +00:00
PETER LIANG
c9f8b52b26 Merge "Shouldn't turn on other accessibility features in SuW." into rvc-dev 2020-06-05 12:36:06 +00:00
TreeHugger Robot
552252d2b9 Merge "Add test for tapping Work share tab when work profile is off" into rvc-dev am: 8f27cd8e55
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11734120

Change-Id: I8054bf473b2b229034391461e170f611252d01f1
2020-06-05 12:35:01 +00:00
TreeHugger Robot
8f27cd8e55 Merge "Add test for tapping Work share tab when work profile is off" into rvc-dev 2020-06-05 12:23:43 +00:00
Antoan Angelov
e42a9e3117 Merge "Setup button bar padding before empty state handling" into rvc-dev am: 16fce9c63b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11734105

Change-Id: I2134a003dce577b7c89c8bf10a57300b349adac4
2020-06-05 10:25:16 +00:00