Commit Graph

9539 Commits

Author SHA1 Message Date
TreeHugger Robot
60e0c19505 Merge "API refactor: context.startForegroundService()" into oc-dev 2017-03-30 20:54:24 +00:00
Rob Carr
2b33162e82 Merge "Remove code for seamlessly rotating SurfaceView's." into oc-dev 2017-03-30 20:10:26 +00:00
TreeHugger Robot
dada7c0e71 Merge "TextClassificationManager API updates." into oc-dev 2017-03-30 19:17:24 +00:00
TreeHugger Robot
7600925263 Merge "Hide TextClassifier.EntityType from the public API." into oc-dev 2017-03-30 19:15:17 +00:00
Christopher Tate
08992ac57e API refactor: context.startForegroundService()
Rather than require an a-priori Notification be supplied in order to
start a service directly into the foreground state, we adopt a two-stage
compound operation for undertaking ongoing service work even from a
background execution state.  Context#startForegroundService() is not
subject to background restrictions, with the requirement that the
service formally enter the foreground state via startForeground() within
5 seconds.  If the service does not do so, it is stopped by the OS and
the app is blamed with a service ANR.

We also introduce a new flavor of PendingIntent that starts a service
into this two-stage "promises to call startForeground()" sequence, so
that deferred and second-party launches can take advantage of it.

Bug 36130212
Test: CTS

Change-Id: I96d6b23fcfc27d8fa606827b7d48a093611b2345
(cherry picked from commit 79047c62b5)
2017-03-30 18:31:24 +00:00
Abodunrinwa Toki
45cb3e6c1f Hide TextClassifier.EntityType from the public API.
Test: current.txt and friends updated correctly.
Bug: 35959173
Change-Id: I74011020a4e509bad98b94738d2e929fc068d9ae
2017-03-30 16:56:18 +01:00
Abodunrinwa Toki
df61b0328e TextClassificationManager API updates.
- Changes getDefaultTextClassifier to getTextClassifier
- Adds a setTextClassifier API

Test: cts-tradefed run cts-dev -m CtsWidgetTestCases -t
android.widget.cts.TextViewTest
Bug: 35763797

Change-Id: I24e86272cf58bf6864505bee3b06978c1c0d46e5
2017-03-30 14:15:44 +01:00
Felipe Leme
955e252a95 Simplified autofill() methods by returning void instead of boolean.
Test: CtsAutoFillServiceTestCases pass

Change-Id: Ic94e6686e291fed60ef6715bd160f9b568bf0ea6
2017-03-29 18:16:40 -07:00
Evan Rosky
7ac3fb2282 Merge "Expose initial focus feature flag for testing" into oc-dev 2017-03-30 01:02:28 +00:00
Evan Rosky
18b886e8b2 Allow cluster navigation to jump into touchscreenBlocksFocus
Adds an exception to touchscreenBlocksFocus ViewGroups which
are also keyboardNavigationClusters. The behavior we want is
that cluster navigation can jump into touchscreenBlocksFocus
clusters but normal keyboard navigation can't. Once focus is
in a touchscreenBlocksFocus cluster; however, we allow focus
navigation to move freely within that cluster. It remains in
that cluster until a subsequent cluster navigation brings it
back out.

Adds back the touchscreenBlocksFocus attributes to Toolbar
and actionbar so that they behave like they did before.

Bug: 34363323
Test: Added CTS test. Verified desired behavior in a test app

Change-Id: I555bf5570b16a57f0d4c8a020ae509a1e1b33910
(cherry picked from commit aee802f3bc)
2017-03-29 22:18:56 +00:00
Evan Rosky
01f46a29ce Expose initial focus feature flag for testing
Bug: 34520588
Test: View_FocusHandlingTest
Change-Id: I7a20a6e9c57fc61bd2562307f4e7f8dee1979a40
(cherry picked from commit 9a0ea38671)
2017-03-29 22:11:34 +00:00
Robert Carr
897215d76a Remove code for seamlessly rotating SurfaceView's.
No longer required :D

Bug: 36230754
Bug: 36727915
Test: Rotate camera in different modes.
Change-Id: I7708d61646a36bc0c35cfa91d441296eb49eff9a
2017-03-29 12:29:29 -07:00
TreeHugger Robot
dd83c2006b Merge "TextClassifier: Switch model based on locale" into oc-dev 2017-03-29 19:17:36 +00:00
TreeHugger Robot
94696c5ac5 Merge "Fix bad Java docs in View.java" into oc-dev 2017-03-29 18:33:11 +00:00
Rob Carr
76d779374a Merge "SurfaceView: Make surfaceRedrawNeededAsync work with WM bypass." into oc-dev 2017-03-29 16:44:41 +00:00
Philip P. Moltmann
dc90922f78 Fix bad Java docs in View.java
Test: Used intelliJ to warn about bad docs
Change-Id: Idb119aff8ce0f2370f66707bd583e2d131fb0751
(cherry picked from commit f4946e7f15)
2017-03-29 16:29:22 +00:00
Abodunrinwa Toki
c39006a1cd TextClassifier: Switch model based on locale
Test: cts-tradefed run cts-dev -m CtsViewTestCases -t
android.view.textclassifier.cts.TextClassificationManagerTest

Change-Id: I91f814fc47bd75922c0e42a774dc7376daf65366
2017-03-29 17:12:56 +01:00
TreeHugger Robot
36e2483663 Merge "Add Configuration param to onMovedToDisplay" into oc-dev 2017-03-28 21:36:40 +00:00
Robert Carr
8508bb2f10 SurfaceView: Make surfaceRedrawNeededAsync work with WM bypass.
Prior to SurfaceView bypassing the WM, the WM would see that
the app had multiple windows and wait for them all
to finish drawing before beginning any animation, or similar operations.
Now that SurfaceView is invisible to the WM we have to replicate this
two-way latching in ViewRootImpl.

Bug: 36492285
Test: Launch Chrome over and over.
Change-Id: Ie72c2d394f1bb0eb8551e6f63bb1c19a5df43afd
2017-03-28 12:39:33 -07:00
Andrii Kulian
e5c58eefb1 Add Configuration param to onMovedToDisplay
To be consistent with other multi-window callbacks adding
Configuration param to the onMovedToDisplay, so that app
developer can handle configuration change at the same time
when it receives a notification about move.

Bug: 36649499
Test: android.server.ActivityManagerDisplayTests
Test: #testOnMovedToDisplayCallback
Change-Id: I80c765473bfc09ea1fb7aa4e2e77baf3b21606b8
(cherry picked from commit 2c32a11a71)
2017-03-28 17:28:17 +00:00
Tadashi G. Takaoka
da5790de78 Fix double-checked locking in InputMethodSubtype
No functional change.

Fixes: 35737935
Test: run cts test and confirmed all tests passed
  cts-tradefed run singleCommand cts-dev -m CtsInputMethodTestCases
Change-Id: I44e5e91b6462c3c7d023f50365b30da9cf98c509
2017-03-28 14:39:12 +00:00
Abodunrinwa Toki
b5ab25948b SmartSelection: Pass hintFlags to native library.
Test: cts-tradefed run cts-dev -m CtsViewTestCases -t android.view.textclassifier.cts.TextClassificationManagerTest
Tests have been written on the native side.
Bug: 35416389

Change-Id: If2de73391e1a343e0dc7698039ad1464cedfbf08
2017-03-28 10:02:07 +01:00
Abodunrinwa Toki
d2d1399a62 TextClassifier updates
- Increase the size of the text sent as context to the classifier
- Pass regex match hints to the classifer

Test: Build still works. Regex hints logged correctly. The hints won't
matter until we've actually passed in this values to native code. Native
library test will be written and I've got a tracker bug to write more robust Java tests.

Bug: 35416389
Bug: 36584397

Change-Id: I29e56189b388b36dc0cc7a8bb13ef237ff55be7b
2017-03-27 17:53:24 +01:00
TreeHugger Robot
2858ad3a4b Merge "TextClassifier cleanup." 2017-03-27 14:51:13 +00:00
TreeHugger Robot
1e8fd460fd Merge "Target selection for Accessibility button" 2017-03-25 04:04:16 +00:00
Casey Burkhardt
5e8b980c5d Target selection for Accessibility button
Allows for selecting a single accessibility service or feature
to be triggered by the accessibility button in the navigation bar

Bug: 34720082
Test: Manual
Change-Id: I320febede0398b1eff38a87d4db31fd7dfc53062
2017-03-24 19:17:12 -07:00
Felipe Leme
4753bb0c34 Make auto-fill UI robust
Now the autofill UI tracks the movement of the anchor view,
both real and virtual and while still preventing the filled
app from accessing the chooser UI. This was achieved by using
a popup window in the app process to determine the window
location and adding a window presenter interface to popup
window that controls the actual window addition, removal, and
update which is implemented by the system server.

Test: all autofill CTS tests pass

bug: 36392498
bug: 35708258
bug: 34943932
fixes: 36039182
fixes: 36493078

Change-Id: I0321913b2e2e759f4b17003bf85cb873e63a467c
2017-03-24 15:16:28 -07:00
Felipe Leme
b4ca70184c Added LocaleList on ViewStructure.
Fixes: 36219641
Test: CtsAssistTestCases pass

Change-Id: I4f208a3b979a524d631e9d2c642b9b5a3cdccb22
2017-03-22 18:51:00 -07:00
Andrii Kulian
38691e9d8f Merge "Revert "Update display contents when metrics change"" 2017-03-22 21:57:31 +00:00
Andrii Kulian
b6c5c0d902 Revert "Update display contents when metrics change"
This reverts commit eddb7c0985.

Reason for revert: b/36518752

Bug: 36518752
Change-Id: I39773db7b8d02aec360ca80d02b3c161ccf02786
2017-03-22 21:50:52 +00:00
Rob Carr
fcc79f5474 Merge "SurfaceView: Fix Surface leak when changing format." 2017-03-22 20:26:40 +00:00
Abodunrinwa Toki
9841ea07c0 TextClassifier cleanup.
- Remove "removed" methods.
- Temporarily log more information about the classification result.

Test: Successfully builds. Manually inspected logs.
Change-Id: I81312ac9992c08ce6137610bd16b339777f8f1fc
2017-03-22 20:13:21 +00:00
TreeHugger Robot
c8e2d5bad4 Merge "Don't call setAutofillId() when populating virtual structure for Assit." 2017-03-22 17:20:57 +00:00
Felipe Leme
4c7b841add Don't call setAutofillId() when populating virtual structure for Assit.
Change-Id: Ia96b5fd6ed7b8f7909b9df59cee57f606a0b37da
Fixes: 36503715
Test: manual verification
2017-03-22 08:26:29 -07:00
Kirill Grouchnikov
6eea0d2a4c Add support for tinting icon menus
Test: CTS tests in separate CL (same topic)
Bug: 31545315
Change-Id: I8877c77dab9b7b229b4246012b9380beadeb4790
2017-03-22 11:05:49 -04:00
TreeHugger Robot
e4e40af10b Merge "Update display contents when metrics change" 2017-03-22 00:02:32 +00:00
Felipe Leme
03ee781b97 Fixed bad link caused by race conditions on git merges.
Test: no time for that
Change-Id: Iffbba4ab2aa0751a406e031fe34e8e2c75e0abde
2017-03-21 16:28:26 -07:00
TreeHugger Robot
1f08e1369b Merge "Changes on Assist structure to handle virtual child for autofill:" 2017-03-21 22:52:09 +00:00
Andrii Kulian
eddb7c0985 Update display contents when metrics change
There are two separate overrides for display metrics in DisplayManager
and WindowManager:
- In DM - LogicalDisplay#mOverrideDisplayInfo, in most cases not null.
- In WM - DisplayContent#mBaseDisplayWidth/Height/Density, different
from #mInitialDisplayWidth/Height/Density values when some metrics are
forced.

When display was resized its windows weren't updated because of
two problems: old LogicaDisplay#mOverrideDisplayInfo was preventing
WM from detecting the change and override (base) display metrics were
never updated by resize.

When display size changes:
- Before this CL:
DM receives DISPLAY_CHANGED event, it updates internal values.
In most cases there is an override obtained from WM and WM doesn't
get new values from LogicalDisplay#getDisplayInfoLocked().

- With this CL:
DM receives DISPLAY_CHANGED event, it updates internal values and
resets the override received from WM. WM will receive updated values
and will decide whether to apply them or not: if there is no override
in WM - it will apply values from WM, otherwise it will keep the
override. In both cases WM will eventually update its own override
and will update the override in DM.

Bug: 35258051
Bug: 34164473
Test: android.server.cts.ActivityManagerDisplayTests
Test: #testDisplayResize
Test: #testForceDisplayMetrics
Change-Id: I80795434a6a35adb0577fbce334d76fabd2fa03d
2017-03-21 15:23:47 -07:00
TreeHugger Robot
e2436917d5 Merge "Allow draw hw bitmap on software canvas for hierarchyviewer" 2017-03-21 21:54:22 +00:00
TreeHugger Robot
709ff779e6 Merge "Improved WebView -> ViewStructure mapping for Autofill." 2017-03-21 19:49:43 +00:00
sergeyv
b94f89094a Allow draw hw bitmap on software canvas for hierarchyviewer
Test: runs hierarchyviewer on app with hw bitmaps
bug:34745484
Change-Id: I35f70f7927be23edebac171f3bc96405b14ca794
2017-03-21 17:26:22 +00:00
Robert Carr
3bc95b5b71 SurfaceView: Fix Surface leak when changing format.
We simply weren't destroying the old Surface (though the finalizer
would have eventually caught it). As we destroy it we need to use
a Window preservation scheme similar to what the WindowManager
provided.

Bug: 36447956
Test: Manual
Change-Id: I8b4210eb76cec364522cc0a40014517e42ebbe68
2017-03-20 21:57:23 -07:00
Robert Carr
44ab575092 SurfaceView: Fix some log spam.
We were throwing relatively harmless NPEs here
and catching them below. The log message when
catching exceptions also needed some updating.
Not assosciated with a particular bug just
noticed in logcat.

Test: Manual
Change-Id: I5f07e6fc8ff3a34318682bf7b6c309fbba4097e4
2017-03-20 21:48:53 -07:00
Adam Lesinski
60b4af5d65 Merge "AssetManager: Guard against null in array retrieval" 2017-03-21 01:03:18 +00:00
Felipe Leme
1a1e4687e4 Improved WebView -> ViewStructure mapping for Autofill.
Added setIdEntry() on ViewStructure and documented how WebView can map HTML
tags and attributes into ViewStructure.

Test: VirtualContainerActivityTest pass
Test: m update-api
Bug: 36056207

Change-Id: Idaee9612d2c1b1adac99f354c8f87137ee9ef877
2017-03-20 17:54:33 -07:00
Felipe Leme
f8a8174cd5 Changes on Assist structure to handle virtual child for autofill:
- Removed overloaded newChild() methods.
- Added a setAutofillId(parent, virtualId).
- Changed view so AutofillId is set on all relevant methods.

Test: VirtualContainerActivityTest (with new tests) pass
Bug: 36056207

Change-Id: Ia11344f95c2756e83307c54052878e9dbe471873
2017-03-20 16:21:41 -07:00
TreeHugger Robot
3f1fb26bbc Merge "Batch autofill() calls to views with virtual children." 2017-03-20 22:03:25 +00:00
Felipe Leme
28afe0e1d8 Batch autofill() calls to views with virtual children.
This is useful in the cases where the virtual children hierarchy is rendered
by a different process.

Test: VirtualContainerActivityTest pass
Bug: 36056207
Change-Id: Id9bf3a9e9366b616dc2a6e0a204e238a2bee3a20
2017-03-18 11:25:23 -07:00
Alan Viverette
42b0676d61 Merge "Revert "Changing initial and default focus behavior"" 2017-03-17 19:47:13 +00:00