Commit Graph

3264 Commits

Author SHA1 Message Date
Svetoslav Ganov
4210a6f08b am 8114f439: am ddbcce81: Merge "Cannot interact with dialogs when IME is up and on not touch explored popups." into jb-dev
* commit '8114f439fe8b409a00ac704b37128922690e2186':
  Cannot interact with dialogs when IME is up and on not touch explored popups.
2012-06-07 14:00:29 -07:00
Svetoslav Ganov
8114f439fe am ddbcce81: Merge "Cannot interact with dialogs when IME is up and on not touch explored popups." into jb-dev
* commit 'ddbcce81acaa744d35c727d9a530b04255fab5af':
  Cannot interact with dialogs when IME is up and on not touch explored popups.
2012-06-07 13:53:39 -07:00
Svetoslav Ganov
ddbcce81ac Merge "Cannot interact with dialogs when IME is up and on not touch explored popups." into jb-dev 2012-06-07 13:50:58 -07:00
Svetoslav Ganov
86783474fd Cannot interact with dialogs when IME is up and on not touch explored popups.
1. If the last touch explored location is within the active window we
   used to click on exact location if it is within the accessibility
   focus otherwise in the accessibility focus center. If the last touch
   explored location is not within the active window we used to just
   click there. This breaks in the case were one has touch explored
   at a given place in the current window and now a dialog opens *not*
   covering the touch explored location. If one uses swipes to move
   accessibility focus i.e. to traverse the dialog without touching
   it one cannot activate anything because the touch explorer is using
   the last touch explored location that is outside of the active
   window e.g the dialog.

   The solution is to clear the last touch explored location when a
   window opens or accessibility focus moves. If the last touch
   explored location is null we are clicking in the accessibility
   focus location.

bug:6620911

2. There is a bug in the window manager that does not notify a
   window that its location has changed (bug:6623031). This breaks
   accessibility interaction with dialogs that have input because
   when the IME is up the dialog is moved but not notified. Now
   the accessibility layer gets incorrect location for the
   accessibility focus and the window bounds.

   The soluion is when the accessibility manager service calls
   into the remove thress to obtain some accessibility node infos
   it passes the window left and top which it gets from the
   window manager. These values are used to update the attach info
   window left and top so all accessibility node infos emitted
   from that window had correct bounds in screen coordinates.

bug:6620796

Change-Id: I18914f2095c55cfc826acf5277bd94b776bda0c8
2012-06-07 12:02:16 -07:00
Chet Haase
9dc7d19309 am b4b0a7fe: am a1723d18: Merge "Revert "Remove ViewTreeObserver allocations"" into jb-dev
* commit 'b4b0a7fea8735dc7de4bdcfe5e7f065a39ee8e2d':
  Revert "Remove ViewTreeObserver allocations"
2012-06-07 11:34:52 -07:00
Chet Haase
b4b0a7fea8 am a1723d18: Merge "Revert "Remove ViewTreeObserver allocations"" into jb-dev
* commit 'a1723d18662d1316f931a6b4b3ee6ddc42743ee4':
  Revert "Remove ViewTreeObserver allocations"
2012-06-07 11:30:00 -07:00
Chet Haase
a1723d1866 Merge "Revert "Remove ViewTreeObserver allocations"" into jb-dev 2012-06-07 11:27:26 -07:00
Chet Haase
89b8838496 am ca43c961: am 44b2fe3f: Track canvas clearing for swap buffers logic.
* commit 'ca43c96127e9f7cdab8ee70638a2445347eebd08':
  Track canvas clearing for swap buffers logic.
2012-06-07 09:51:07 -07:00
Chet Haase
ca43c96127 am 44b2fe3f: Track canvas clearing for swap buffers logic.
* commit '44b2fe3fc114ee5f7273c6b0fee2cc999bf244a2':
  Track canvas clearing for swap buffers logic.
2012-06-07 09:45:16 -07:00
Chet Haase
0f8ffd8374 Revert "Remove ViewTreeObserver allocations"
This reverts commit b999cc118f.

There was an assumption in this earlier change that observer dispatching could not be
recursive - we could only ever have one iteration on the observer listener list. This
assumption broke down in a specific app, and maybe in more, so reverting the change for now.
We should probably find a way to accomplish the same allocation-minimizing goal without
causing exceptions when violating our assumptions.

Issue #6620795 [Application compatibility] Lufthansa app crashes

Change-Id: I1c1f9ad329c14398feb0e74ce77e1a07111f7d1f
2012-06-07 08:00:49 -07:00
Chet Haase
44b2fe3fc1 Track canvas clearing for swap buffers logic.
A previous fix made it necessary for a frame to render something to GL
in order to cause a call to eglSwapBuffers(). Besides the calls being
tracked as part of issuing a DisplayList, there is also a potential call
to clear the canvas (via glClear()) on non-opaque surfaces. This call is also
good to track, since a surface that gets cleared without any other drawing operations
is worth flipping to the screen (to erase old contents on that surface).

This fix tracks the status of the pre-draw operations to find out whether
glClear() was called and then sets the drawing status appropriately.

Issue #6606422 QuickContact dismissal is janky again (Tracking)

Change-Id: I5fcaccfdc9293dd46b83f2fc279730a5d2740ebf
2012-06-07 06:25:04 -07:00
Chris Craik
4e772cb938 am 6d99a024: am 8f1f714f: Merge "Revert "Add more temporary logging for investigating detachFunctor"" into jb-dev
* commit '6d99a024647ff845179311d611dcf031965ba96d':
  Revert "Add more temporary logging for investigating detachFunctor"
2012-06-06 16:52:16 -07:00
Chris Craik
6d99a02464 am 8f1f714f: Merge "Revert "Add more temporary logging for investigating detachFunctor"" into jb-dev
* commit '8f1f714f831bf8bf10f94211c42e36ef2851810d':
  Revert "Add more temporary logging for investigating detachFunctor"
2012-06-06 16:47:57 -07:00
Chris Craik
8f1f714f83 Merge "Revert "Add more temporary logging for investigating detachFunctor"" into jb-dev 2012-06-06 16:45:04 -07:00
Chris Craik
932b7f6765 Revert "Add more temporary logging for investigating detachFunctor"
bug:6608646

This reverts commit 8857b2f76a

Change-Id: I1563b5974c52b84201ae448298f804eb0dcc235d
2012-06-06 14:02:55 -07:00
Svetoslav Ganov
5fccbbebdf am cf27a374: am 538252cd: Merge "Removing leftover code to sync accessibility and input focus." into jb-dev
* commit 'cf27a3743941d9ccb1d20a294085819049fac028':
  Removing leftover code to sync accessibility and input focus.
2012-06-06 11:02:13 -07:00
Svetoslav Ganov
cf27a37439 am 538252cd: Merge "Removing leftover code to sync accessibility and input focus." into jb-dev
* commit '538252cd37945612a4761ff03d87022d56e33b96':
  Removing leftover code to sync accessibility and input focus.
2012-06-06 10:57:50 -07:00
Svetoslav Ganov
538252cd37 Merge "Removing leftover code to sync accessibility and input focus." into jb-dev 2012-06-06 10:55:12 -07:00
Svetoslav Ganov
462a7284b5 Removing leftover code to sync accessibility and input focus.
1. We have decided to let the accessibility services take care
   for syncing accessibility and input focus. Some apps may
   move input focus when a given view takes input focus which
   dragging accessibility focus can lead to a loop in the
   focus traversal. This change removes some leftover sync
   code.

bug:6616861

Change-Id: I57cb44e315a386d13596794d3767b559e9ee3d99
2012-06-05 21:10:04 -07:00
Adam Powell
b85afc25d5 resolved conflicts for merge of 1178569b to master
Change-Id: If2bb6ccaee99bcf199cd93f24eba217fe6ff485e
2012-06-05 20:08:41 -07:00
Adam Powell
1178569b26 am f6452d0c: Merge "More fun with MediaRouter" into jb-dev
* commit 'f6452d0cac64b72005af330411b5a895f0038312':
  More fun with MediaRouter
2012-06-05 19:29:57 -07:00
Adam Powell
f6452d0cac Merge "More fun with MediaRouter" into jb-dev 2012-06-05 19:27:49 -07:00
Adam Powell
690ffb4e1f More fun with MediaRouter
Add action provider, button, and styles. Extend ActionProvider to
allow for getting references to MenuItem instances.

Implement toggle mode for the MediaRouteButton/ActionProvider. Dialog
selection yet to come.

Change-Id: Ibe3188570f503bbf8dd00cf154663435656a7171
2012-06-05 19:15:57 -07:00
Svetoslav Ganov
7510230583 am f1abc425: am cab5b8a9: Merge "Nodes with contentDescription should always be important for accessibility." into jb-dev
* commit 'f1abc4253111907ffb8e5ba19dffa8d00d92fc45':
  Nodes with contentDescription should always be important for accessibility.
2012-06-05 16:02:17 -07:00
Svetoslav Ganov
f1abc42531 am cab5b8a9: Merge "Nodes with contentDescription should always be important for accessibility." into jb-dev
* commit 'cab5b8a91d6fbcbb694284038f5529ff02f10f78':
  Nodes with contentDescription should always be important for accessibility.
2012-06-05 15:57:25 -07:00
Svetoslav Ganov
cab5b8a91d Merge "Nodes with contentDescription should always be important for accessibility." into jb-dev 2012-06-05 15:55:42 -07:00
Svetoslav Ganov
e47957a0bb Nodes with contentDescription should always be important for accessibility.
1. Now after setting the content description on a view we mark is as
   important for accessibility of the current important for accessibility
   mode of that view is auto.

2. Minor tweak to a touch explorer coefficient to make performing double
   tapping easier.

bug:6615353

Change-Id: I3b477f533a3ebde85d425caf32ace5e851240f88
2012-06-05 14:48:58 -07:00
Chris Craik
3683fe8328 am 34e5f5a5: am 3676b137: Merge "Add more temporary logging for investigating detachFunctor" into jb-dev
* commit '34e5f5a534d915f253ae51cbcfe15c12e25a78a4':
  Add more temporary logging for investigating detachFunctor
2012-06-05 12:35:24 -07:00
Chris Craik
34e5f5a534 am 3676b137: Merge "Add more temporary logging for investigating detachFunctor" into jb-dev
* commit '3676b137ecf2f24e88e8a3567c11234e7d4416d2':
  Add more temporary logging for investigating detachFunctor
2012-06-05 12:31:31 -07:00
Chris Craik
3676b137ec Merge "Add more temporary logging for investigating detachFunctor" into jb-dev 2012-06-05 12:28:49 -07:00
Chet Haase
0fc37e46b4 am 7c54ef9a: am 14f73a02: Merge "Restore opaque alpha value when AlphaAnimation finishes" into jb-dev
* commit '7c54ef9a0e27b5146a51ebeb267a0a6a1fd9174f':
  Restore opaque alpha value when AlphaAnimation finishes
2012-06-05 12:25:43 -07:00
Chris Craik
8857b2f76a Add more temporary logging for investigating detachFunctor
bug:6596807
Change-Id: Ic9e34e323b12a887f2e8df0773a6155627b6a64f
2012-06-05 11:24:46 -07:00
Chet Haase
7c54ef9a0e am 14f73a02: Merge "Restore opaque alpha value when AlphaAnimation finishes" into jb-dev
* commit '14f73a02a42b5e4c700fe70e8c2d38dc518480b4':
  Restore opaque alpha value when AlphaAnimation finishes
2012-06-05 10:26:22 -07:00
Svetoslav Ganov
bce6f97202 am b25605cd: am 72d6835c: Merge "Accessibility focus should not clear selection when taken away." into jb-dev
* commit 'b25605cd7111bcab41ec10547f015bd2d6215c91':
  Accessibility focus should not clear selection when taken away.
2012-06-05 09:54:54 -07:00
Chet Haase
2143337d50 Restore opaque alpha value when AlphaAnimation finishes
Alpha values were being set correctly on native Display Lists during an
AlphaAnimation, but not when the animation finished. Only non-1 values
were being propagated to the Display List properties.

The fix is to track when we've set a non-1 alpha value from an AlphaAnimation
and to notice that flag when the value is 1 (because the animation ended), so that
we propagate that value correctly. Using the flag avoids sending a value of 1
(by far the most common case) unless we really need to restore it after animating
it with non-1 values.

Issue #6600592 Sometimes album art blends with list asset on queue

Change-Id: I51047d756a4ac42a2d907a4d77963cc23dfb1db3
2012-06-05 08:59:32 -07:00
Svetoslav Ganov
b25605cd71 am 72d6835c: Merge "Accessibility focus should not clear selection when taken away." into jb-dev
* commit '72d6835c7cea35d0faf5f1584bf2c475fcbf93c8':
  Accessibility focus should not clear selection when taken away.
2012-06-04 23:13:35 -07:00
Svetoslav Ganov
0a047bdcdd Accessibility focus should not clear selection when taken away.
1. Currently accessibility focus removal was clearing the selection
   in the view - in particular the accessibility cursor position
   which in the TextView case is the selection. This leads to a
   scenario where the selection may be cleared when the app does
   not explect. Further, the selection should not be cleared
   since the user can be say several pages in the content and
   removing and putting back accessibility focus would cause a
   tedious traversal to get to the previous position.

bug:6469840

Change-Id: Iba3c01600fa2c9c39f99085a5fbc4328aa539ea8
2012-06-04 19:32:45 -07:00
Fabrice Di Meglio
0cd655ad2d Merge "Revert "Revert "Clean up layout direction APIs for Drawable""" 2012-06-04 16:29:05 -07:00
Fabrice Di Meglio
b03b434089 Revert "Revert "Clean up layout direction APIs for Drawable""
This reverts commit c96132ff53
2012-06-04 12:55:30 -07:00
Christopher Tate
193fc075a2 Docs tweak
Cross-reference the flag manipulation methods in Window to make
it easier to discover them.

Change-Id: I81ef38fd69b43683e4ec8d48c058496470533b53
2012-06-04 11:42:10 -07:00
Dianne Hackborn
92bc9393e6 am 5a70063f: am 6593be0c: Merge "Work on issue #6579997: Mariner entrance animation" into jb-dev
* commit '5a70063f7ea8c910eefb025018ef02e84ff319f0':
  Work on issue #6579997: Mariner entrance animation
2012-06-04 10:38:48 -07:00
Dianne Hackborn
5a70063f7e am 6593be0c: Merge "Work on issue #6579997: Mariner entrance animation" into jb-dev
* commit '6593be0c200f69d932e40e05e9df54b89c157c48':
  Work on issue #6579997: Mariner entrance animation
2012-06-04 10:34:24 -07:00
Dianne Hackborn
6593be0c20 Merge "Work on issue #6579997: Mariner entrance animation" into jb-dev 2012-06-04 10:29:32 -07:00
Svetoslav Ganov
5a71617014 am cdb2a216: am 7b4799ca: Merge "Client app crashes if accessibility service uses invalid focus type." into jb-dev
* commit 'cdb2a2167d0f0676cc613a358073267d86d2851c':
  Client app crashes if accessibility service uses invalid focus type.
2012-06-04 10:27:42 -07:00
Svetoslav Ganov
cdb2a2167d am 7b4799ca: Merge "Client app crashes if accessibility service uses invalid focus type." into jb-dev
* commit '7b4799cafa6624862a172aaf2ececf661850b03c':
  Client app crashes if accessibility service uses invalid focus type.
2012-06-04 10:23:46 -07:00
Svetoslav Ganov
7b4799cafa Merge "Client app crashes if accessibility service uses invalid focus type." into jb-dev 2012-06-04 10:20:33 -07:00
Svetoslav Ganov
2ef6905003 Client app crashes if accessibility service uses invalid focus type.
1. If an accessibility service uses an invalid focus type argument
   when trying to find where focus is the queried application crashes.
   The same happens if the serivce calls focus search with an invalid
   derection. While we need the argument check in the controller that
   runs in the app process the accessibility service has to be the
   palace where an exception is thown for the invalid argument so
   the developer can fix his code.:

bug:6508797

Change-Id: Ib0d74f374fa60ee8fd6117f11c23af34f6c26ad3
2012-06-04 09:33:05 -07:00
Jeff Brown
94456bb32c am 7d3fa093: am f47e76e2: Merge "Make velocity tracker strategy configurable." into jb-dev
* commit '7d3fa093bbd34e19f6b580b6258c8ea4e138c777':
  Make velocity tracker strategy configurable.
2012-06-03 21:23:29 -07:00
Jeff Brown
7d3fa093bb am f47e76e2: Merge "Make velocity tracker strategy configurable." into jb-dev
* commit 'f47e76e2c78e78e26110786e99548d718d177c32':
  Make velocity tracker strategy configurable.
2012-06-03 21:19:13 -07:00
Jeff Brown
f47e76e2c7 Merge "Make velocity tracker strategy configurable." into jb-dev 2012-06-03 21:16:18 -07:00