This reverts commit 1f0b27532f.
Reason for revert: Crashes android.anim on a wembley
Bug: 149121559
Test: Local build of wembley with this reverted doesn't crash android.anim.
Change-Id: Ie2b9ce95114082d07fa6fddd1ec6d0cb345bd860
This is a follow up CL to our previous CL [1], where we forgot to
remove an obsolete comment, which was dded in our previous attempt to
tackle IME focus handling in InputMethodManager [2]. As the line
mentioned in that CL is now gone, there is no reason to keep that
stale comment.
There should be no behavior change in this CL.
[1]: Ib455704fe1e9d243f93190a84f230210dbceac2a
970d9d2e0c
[2]: I219394178e4172bc47864297f1418e677dba25e5
5f05965f54
Bug: 141738570
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Change-Id: Iee92a7eb4dfcfb059b0e1fc105f78dd9bdecbbfc
Also add a way to query for child containers of a container.
Combined, these provide enough flexibility to re-arrange
containers to system-ui. For now, it is locked-down a bit so
it only provides children of TaskTiles and can only reparent
ActivityStacks. Eventually, this can be expanded for nested
tasks or display areas.
Bug: 133381284
Test: Added TaskTileTest#testHierarchyTransaction
Change-Id: Id0e89a4e4b9352d9392349c4e1fe7d69b4f9f212
Removed this constant variable, TextView.ACCESSIBILITY_ACTION_IME_ENTER,
and added more description for new accessibility action,
ACTION_IME_ENTER.
Bug: 139380257
Test: a11y CTS tests & unit tests
Change-Id: I929262aa0046640aafe36a2dc2a8896ee7cab9ff
Root cause:
TCM caches SystemTC. TCM.createTCSession returns a wrapper of
the same SystemTC and it just updates the sessionID
(and some other session related stuff) of the shared system TC.
That means, if clients call createTCSession multiple times for multiple
active sessions, all of these session TCs have the same session ID
(the latest one) because they all point to the same SystemTC.
It has been an issue since P. But we don't really have code that creates
multiple active sessions before R. In R, we create a session per each
notification, and thus hit the bug.
Solution:
Don't cache SystemTC. SystemTC is just a thin wrapper that forwards calls
to TCMS anyway.
BUG: 149012454
Test: atest CtsTextClassifierService (Added a new test in ag/10260978.)
Test: Sanity tests: smart selection and smart replies are still working.
Change-Id: I71fe558b2f3d2c5d9eb0b6fc7f258fb4d8ad48d6
Remove comment due to test is ready.
Bug: 146453105
Test: atest CtsInputMethodTestCases:android.view.inputmethod.cts.InlineSuggestionInfoTest
Test: atest CtsInputMethodTestCases:android.view.inputmethod.cts.InlineSuggestionsRequestTest
Change-Id: I968ab360cae93c895e6cfeae76e15c2205f5a7e6
Fixes and issue where the initial frame of an app-driven transition would flicker
because onProgress would only be called after the first frame had been rendered.
Bug: 111084606
Test: atest WmTests
Change-Id: I312ba27d95aaeb69c94bbdba39ee423ed38ffdac
Since we aren't exposing the SurfaceControl in the public API
we need to show it for the user.
Bug: 134365580
Bug: 147303389
Test: SurfaceControlViewHostTests
Change-Id: Icec1384aeb50eef0261f3591a250f02f47737f66
of getDefaultTextClassifierImplementation()
Once the system health experiment is done, revert this change and
remove the local TC.
Test: Manual
1. Set use_default_system_text_classifier_as_default_impl to be false
by using device_config command. Select a phone number.
Verify the phone action is shown. Verify dumpsys textclassification
shows that default TC is bound.
2. Set use_default_system_text_classifier_as_default_impl to be true.
Reboot the device.
Select a phone number and verify the phone action is shown.
Verify dumpsys textclassification shows that the default TC
is not bound.
BUG: 148049185
Change-Id: I602c3cb6d7bef468cba50be6ed8d799d79af8240
Previously we passed back a SurfaceControl to the keyguard, updated to pass a SurfacePackage instead. The updated SurfaceControlViewHost logic addresses underlying accessibility bugs.
Bug: 136085151
Test: atest AdminSecondaryLockScreenControllerTest
Test: atest FrameworksServicesTests:DevicePolicyManagerTest
Change-Id: I4881d5766f118b99f497ee306cd71d3c5a65a2f3
SystemTextClassifier that is backed by ExtServices
1. The default textclassifier is always provided by
config_servicesExtensionPackage (i.e. ExtServices)
2. OEM can specify a system text classifier by specifying
config_defaultTextClassifierPackage.
3. System text classifiers can get an instance of the default textclassifier
by calling TCS.getDefaultTextClassifierImplementation(), so that
they can add their customization on top of the default TCS.
4. If config_systemTextClassifierPackage is set, the specified package
is used to process requests from apps and the platform. Otherwise,
the default textclassifier is used.
5. For testing and droidfooding purpose, text classifier service package
can be overridden. If the overridden package is neither
the default one nor the system one, the package is considered as a
untrusted text classifier, which can only see requests from itself.
Test: m mts && mts-tradefed run mts-extservices
Test: Not setting config_defaultTextClassifierPackage. Select some text and
make sure smart selection works. Run dumpsys textclassification
to make sure the default TCS is bound.
Test: Setting config_defaultTextClassifierPackage and repeat the above.
Make sure the specified OEM text classifier is used.
Test: Set the service override config to be ExtServices.
Run dumpsys textclassification to make sure everything is unbound.
Select some text and make sure ExtServices is bound.
Test: Set the service override to be AiAi and repeat the above.
Test: Set the service to be something invalid and repeat the above.
Observe that no TC is bound and fallback to NO_OP.
BUG: 148049185
Change-Id: Ia2fb549fda49363e0d0ebc4b7e0d31cb76e11ee0
Make TCS.getDefaultTextClassifierImplementation returns a ...
SystemTextClassifier that is backed by ExtServices
1. The default textclassifier is always provided by
config_servicesExtensionPackage (i.e. ExtServices)
2. OEM can specify a system text classifier by specifying
config_defaultTextClassifierPackage.
3. System text classifiers can get an instance of the default textclassifier
by calling TCS.getDefaultTextClassifierImplementation(), so that
they can add their customization on top of the default TCS.
4. If config_systemTextClassifierPackage is set, the specified package
is used to process requests from apps and the platform. Otherwise,
the default textclassifier is used.
5. For testing and droidfooding purpose, text classifier service package
can be overridden. If the overridden package is neither
the default one nor the system one, the package is considered as a
untrusted text classifier, which can only see requests from itself.
Test: m mts && mts-tradefed run mts-extservices
Test: Not setting config_defaultTextClassifierPackage. Select some text and
make sure smart selection works. Run dumpsys textclassification
to make sure the default TCS is bound.
Test: Setting config_defaultTextClassifierPackage and repeat the above.
Make sure the specified OEM text classifier is used.
Test: Set the service override config to be ExtServices.
Run dumpsys textclassification to make sure everything is unbound.
Select some text and make sure ExtServices is bound.
Test: Set the service override to be AiAi and repeat the above.
Test: Set the service to be something invalid and repeat the above.
Observe that no TC is bound and fallback to NO_OP.
BUG: 148049185
Change-Id: Ia2fb549fda49363e0d0ebc4b7e0d31cb76e11ee0
The call to relayout may release the SurfaceControl for us by
reading back a null parcel. In this case remove will throw an exception.
We could check is valid, but actually we don't need to call remove
just release, which doesn't throw an exception if already released.
Bug: 146598493
Bug: 148692069
Test: Flip USE_BLAST_ADAPTER device boots.
Change-Id: I38ee8df702dc2645ca5da980bebdc5ac32a7a065
Commit 970d9d2 introduced IME focus controller which
added a new method View#hasImeFocus to restrict IME focus
only when the focused window won't have either FLAG_NOT_FOCUSABLE
or FLAG_ALT_FOCUSABLE_IM flags.
Since NotificationShadeWindowController will unset both flags when
RemoteInput active (or when PasswordEntry focused on lockscreen).
But, in ImeFocusControler#onTraversal won't keep update View#hasImeFocus
state, it will affect IME focus handle correctness.
Hence, it needs to fix View#hasImeFocus state update issue.
Fix: 148489857
Fix: 148788569
Bug: 141738570
Test: manual as following steps:
Case 1:
0) make EditTextVariations
1) adb install -r EditTextVariations.apk
2) adb shell am start -n com.android.inputmethod.tools.edittextvariations/.EditTextVariations
3) Tap the 3-dot menu on the EditTextVariations
4) Tap `Direct Reply` on the menu
5) Open notification drawers
6) Try to direct-reply on the notification, expect soft-keyboard should come up after step 6)
Case 2:
1) Device set up with Pwd lockscreen security. Finish setting up the device.
2) Once the device goes into sleep mode > Wake up the device > Swipe up locksreen.
3) Observing that the keyboard should come up consistently.
Change-Id: I8d4fff94ba9313b773bc27fcbd019cc88580d3e9
Add a new API to update a previously-granted input channel. This
currently only supports changing layout param flags, and, for
those: only supports NON_TOUCHABLE and SLIPPERY
Bug: 133381284
Test: Added WindowlessWmTests#testDisableTouchInput
Change-Id: I29f70cde0eb646663c0a0ad058979845e732cee7
Recent deferTransaction change created
bootloop when BLAST is turned on
Bug: 146345307
Test: build, boot, manual
Change-Id: Ib5e484c39d11260026694fc2a32015d8a7f04baf
As part of statsd becoming a Mainline module in R, autogenerated
StatsLog.write() calls are going away and replaced by
*StatsLog.java
that is autogenerated for each module.
This CL replaces some usages of StatsLog with
FrameworkStatsLog.
Bug: 145952197
Test: m
Change-Id: Iaa2db34a7be4c3215f62cc36661ba8ac81656baa
This implements the transient insets animation. To have InsetsPolicy run
the animation, this patch:
1. Let InsetsPolicy implements InsetsAnimationControlCallbacks;
2. Make several properties, methods and subclasses in InsetsController
public, to let InsetsPolicy re-use them when possible.
3. Do everything necessary in InsetsPolicy to let the animation run
correctly.
Other misc changes in this CL includes:
1. Removed some un-necessary imports;
2. Implemented two toString method, for debug purpose.
Bug: 118118435
Test: Manual test with the new Insets API test app, everything works as
expected;
Test: go/wm-smoke
Test: atest InsetsPolicyTest
Change-Id: I6c45bd557573fcabb1a3f5aea3dcd58229280613
When control is unavailable, but the client still wants to hide or
show something, we keep track of it and execute the animation as
soon as we get control.
Also fix an issue with a crash where control was lost before
animation was started.
Test: InsetsControllerTest, InsetsSourceConsumerTest
Change-Id: I31c5177d9281161b8a607b24ddf094dbba640da3
The concept will move into the support library (androidx), so in
the framework we only need a simple boolean to toggle the default
behavior.
Also remove redundant methods on WIC to control IME.
Bug: 143556682
Bug: 118118435
Test: WindowTest CTS
Change-Id: I30fbffdfbe79a57b0f4166f0657c78370c7bcf02
b/147829061 used View id to search for the next backward view. The
problem was that there might be several Views with the same ID in View
hierarchy, so it may return the wrong View with the same ID. To fix
that, ag/10111732 compared the View itself. The idea was right but there
was a bug in that CL. This CL fixed the original bug and the following
bugs.
Fixes: 148545035
Fixes: 148166620
Bug: 147829061
Test: atest TimePickerTest
Test: atest BackwardNavigationTest
Test: atest SpinnerTest
Change-Id: I4ec44f91bbaa86b0f52e10611b91fcceb2588d12
