Commit Graph

632 Commits

Author SHA1 Message Date
TreeHugger Robot
028348d871 Merge "Update badge visibility on expand and collapse" into sc-dev 2021-02-05 20:30:51 +00:00
TreeHugger Robot
e2215fc083 Merge "Enable kotlin tests in shell & fix some bubbles ones" into sc-dev 2021-02-05 17:53:09 +00:00
Lyn Han
fddf14356a Merge "Skip reorder animation while collapsing" into sc-dev 2021-02-05 15:01:03 +00:00
Andrii Kulian
90f1b95ccf Merge "Add sample WM Jetpack Extensions impl" into sc-dev 2021-02-05 04:55:02 +00:00
Ben Lin
563727df26 Merge "PiP: Pinch-resize auto to max size if it's pretty close to it." into sc-dev 2021-02-05 02:19:38 +00:00
TreeHugger Robot
7ff13b5213 Merge "Disable split screen tests at 90 degrees" into sc-dev 2021-02-05 00:53:37 +00:00
TreeHugger Robot
80f96120be Merge "Log bubble package when available" into sc-dev 2021-02-05 00:08:45 +00:00
Evan Rosky
8277f84911 Merge "Add some more Protologs to Shell-side Transitions" into sc-dev 2021-02-04 23:33:08 +00:00
TreeHugger Robot
70b6c098ab Merge "Save the notification group key on the bubble" into sc-dev 2021-02-04 23:08:50 +00:00
Ben Lin
f3e2661602 Merge "Add basic PiP Transition foundation." into sc-dev 2021-02-04 22:40:43 +00:00
Lyn Han
5c87a1940c Merge "Log overflow bubble restoration after phone reboot" into sc-dev 2021-02-04 20:17:40 +00:00
Chris Li
cab4131e77 Merge "Allow non-resizable apps in split-screen (9/n)" into sc-dev 2021-02-04 19:40:51 +00:00
Mady Mellor
e108720aa0 Save the notification group key on the bubble
We don't need to persist this because any bubble created
from persisted bubbles in the overflow wouldn't have a
notification to match with it anyways.

Test: atest BubblesTest
Bug: 178620678
Change-Id: I005704cce0e7205e254e71578d40f931c496e8f5
2021-02-04 11:36:32 -08:00
Mady Mellor
4b4036cfad Enable kotlin tests in shell & fix some bubbles ones
Test: these
Bug: 173408780
Change-Id: Iadbc436748e6421f7b1f9544d06f574a7cf1602e
2021-02-04 17:49:37 +00:00
Lyn Han
11512218fd Merge "Land bubbles softly" into sc-dev 2021-02-04 17:45:40 +00:00
Nataniel Borges
c21bbe248c Disable split screen tests at 90 degrees
Those tests are right now flaky on flame and cannot be used in presubmit

Bug: 175687842
Bug: 179116910
Test: atest WMShellFlickerTests
Change-Id: I5e1b3075a63695fed006b2fb134b826447cb8d0c
2021-02-04 09:46:23 +01:00
Andrii Kulian
336f9fdf86 Add sample WM Jetpack Extensions impl
Moving some of the common bits of Sidecar and Extensions
into helper classes and adding both to the reference repo.

Bug: 154172225
Test: m androidx.window.extensions
Test: Manual, by including extensions in the emulator image
Test: gradlew window:window:cAT
Change-Id: I44ff06b06b2202a5d687216e017528098dc14d1d
2021-02-03 22:18:11 -08:00
Tiger Huang
cf1138d479 Merge "Remove outFrame from the parameters of addWindow" into sc-dev 2021-02-04 05:46:17 +00:00
Wale Ogunwale
7ae91f9d0e Merge "Prep work for exposing split-screen APIs to Launcher" into sc-dev 2021-02-03 20:33:35 +00:00
Ben Lin
5426e2ae47 Add basic PiP Transition foundation.
This adds the proper hook for framework to request PiP transition from
Shell and run the animation as needed. Currently only Enter using
3-finger navigation is supported, along with a KI that the PiP bounds
are not finalized at the end of the animation.

Bug: 165793917
Test: Enter PiP with ENABLE_SHELL_TRANSITIONS flag on

Change-Id: I0b992840ddcf8ddfcec9759a5cb06b630f1899a8
2021-02-03 10:34:17 -08:00
Evan Rosky
4146eb6af4 Add some more Protologs to Shell-side Transitions
Some more details about how local and remote transitions
are dispatched.

Bug: 172695387
Test: enable shell transitions and look at logs
Change-Id: I9edff6e43287514557b10b558a94c3300d835157
2021-02-03 17:38:11 +00:00
Jorge Gil
f2abb387f5 Merge "Only show Pip actions when menu is FULL (i.e. shown)" into sc-dev 2021-02-03 17:02:58 +00:00
Wale Ogunwale
e3956ba87a Prep work for exposing split-screen APIs to Launcher
Bug: 179176511
Test: DragAndDropPolicyTest
Change-Id: Iff8e5df9df87779cf8a33430245fc5584928b33c
2021-02-03 08:27:33 -08:00
Tiger Huang
46252a4134 Remove outFrame from the parameters of addWindow
This CL moves computeWindowBounds to the client side. The client can use
it to compute the frame hint on its own.

This can be a step to make client compute its window frame locally.

Bug: 161810301
BUg: 175858823
Test: atest WindowAddRemovePerfTest ActivityRecordTests
            DisplayPolicyLayoutTests TaskSnapshotSurfaceTest
Change-Id: Ia5af1919b8e0e973646a63d1a4c3bf7ea7e2d1f6
2021-02-03 22:50:41 +08:00
Bill Lin
3beefa9198 Disable flaky tests
These tests are flaky on both crosshatch and flame

Bug: 178447631
Test: atest WMShellFlickerTests
Change-Id: I084b91b3d7ab8ea28b7c70ad9bbeb69b873fbaa0
2021-02-03 10:54:11 +01:00
Nataniel Borges
7004ef2675 Merge "Provides assertion blocks on Flicker" into sc-dev 2021-02-03 07:21:25 +00:00
Nataniel Borges
04c8c54b15 Merge "Disable flaky tests" into sc-dev 2021-02-03 07:21:10 +00:00
Chris Li
7dfa7106a9 Allow non-resizable apps in split-screen (9/n)
Cleanup SizeCompatModeActivityController

Bug: 176061101
Bug: 178327644
Test: pass existing
Change-Id: If4bb5e082976725b80bda5a95880a24201b6c595
2021-02-02 18:00:35 -08:00
jorgegil@google.com
bf7df8a8a3 Only show Pip actions when menu is FULL (i.e. shown)
- The actions container viewgroup should only be visible
when the menu state is FULL
- Update the PipMenuView mMenuState before updating the
action views so that the views reflect the actual new
state of the pip menu.

Bug: 179046413
Test: Enter PiP from Youtube, tap on where the pause
icon would be if the menu was visible, verify it doesn't
pause the video.

Change-Id: I97c55fc12b8eca21a4aa2a94d7890330ca543fc1
2021-02-02 17:30:12 -08:00
Hongwei Wang
58b9a4e48e Merge "Add an invisible layer to trap focus" into sc-dev 2021-02-03 01:22:03 +00:00
Chris Li
5c3ad3a5a1 Merge "Allow non-resizable apps in split-screen (8/n)" into sc-dev 2021-02-03 00:38:22 +00:00
Chris Li
ee21983ae0 Merge "Allow non-resizable apps in split-screen (7/n)" into sc-dev 2021-02-03 00:24:54 +00:00
Chris Li
27d983a098 Allow non-resizable apps in split-screen (8/n)
Refactor SizeCompatModeActivityController to WM Shell. The old one will
be removed in separate cl as there are some dependencies in other
packages.

This cl is mainly for refactor. Major change will come after.
Besides refactor, also changed the mActiveButtons key to TaskId, because
launcher Task will also trigger onTaskInfoChanged, but should not remove
the restart button on the same display.

Bug: 176061101
Bug: 178327644
Test: manually verify that the size compat restart button works as usual
Test: atest WMShellUnitTests:SizeCompatUIControllerTest
Test: atest WmTests:SizeCompatTests
Change-Id: I9143e079a1a945b76c3c56596976dd6ad2802897
2021-02-02 12:54:40 -08:00
Chris Li
98d2d06106 Allow non-resizable apps in split-screen (7/n)
Add interface for SizeCompatUIController in WM shell to use
when refactoring SizeCompatModeActivityController from system UI.

Bug: 176061101
Bug: 178327644
Test: atest WMShellUnitTests:ShellTaskOrganizerTests
Change-Id: I37f72396e1769b7773722be6575506fc430b2739
2021-02-02 12:50:28 -08:00
TreeHugger Robot
08b0b82df9 Merge "Reset windows bounds when stop one handed mode" into sc-dev 2021-02-02 20:46:41 +00:00
Ben Lin
6292565f13 Merge changes If42d4470,Ia0b701b7 into sc-dev
* changes:
  PiP: Add tap-to-unstash function.
  PiP: Allow stashing via dropping on the edge.
2021-02-02 19:27:55 +00:00
Hongwei Wang
b7361f8dda Merge "Adjust the estimated minimum size of PiP menu" into sc-dev 2021-02-02 17:30:24 +00:00
Nataniel Borges
da5136ea43 Provides assertion blocks on Flicker
Enable tests ot be in presubmit, postsubmit or marked as flaky

Do not require flicker DSL changes

Bug: 162923992
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I74fdadaf5f6f08d96973683682297200eec6658d
2021-02-02 18:16:12 +01:00
Nataniel Borges
500d6db17b Disable flaky tests
These tests are flaky on both crosshatch and flame

Disable them from presubmit

Bug: 175687842
Bug: 179108356
Test: atest WMShellFlickerTests
Change-Id: I51e85238064e806106e68b47460836fd278cab3d
2021-02-02 18:00:24 +01:00
Hongwei Wang
cb98114abd Add an invisible layer to trap focus
This is a work around for b/169372603 where PiP menu defaults the focus
on expand button when being attached to system window.

There is another inconsistency observed regarding of touch feedback
which may not be related to b/169372603 but worth mentioning
- when entering PiP and close button is shown, tap on PiP window shows
  visual touch feedback
- when PiP menu in closed state, eg. nothing is shown in menu, tap on
  PiP window shows no visual touch feedback

Video: http://rcll/aaaaaabFQoRHlzixHdtY/cLwTz7ad7P9nrrqk1uPiRP
Bug: 169372603
Test: Enter PiP from YT, see video
Change-Id: Ief8976fac28a65ac35724adcad7f25e11f1876a5
2021-02-01 21:12:49 -08:00
Hongwei Wang
0dc09244e5 Adjust the estimated minimum size of PiP menu
Use the similar measurement from PipMenuView#updateActionViews

Video: http://rcll/aaaaaabFQoRHlzixHdtY/g1YgomInywOHbZcKdsegcf
Bug: 175055101
Test: See video
Change-Id: I2a52f46c2208b9e164f0898fff0e43cbb3eb8b96
2021-02-01 20:57:39 -08:00
Bill Lin
6ea20e07d8 1/ Integrate legacySplitScreen Flicker tests into individual assertions
1) Integrate companion object inheritance and the default test runner
2) Move launch activity to setup: avoid noise of splash screen
3) Move setRotate() to setup: avoid noise of system windows
   (LetterBox, NavBar, StatusBar...) visibility changes
4) Reducing test time of each test case: remove redundant transition
5) Remve redundant val for readibility
6) Remove navBarLayerIsAlwaysVisible assertion from split test
   the rotation flow of enter split screen :
   Overview(land) -> enter split(portrait) -> split mode(land)
7) Partially enable ROTATION_90 tests
8) Bypass visibleLayersShownMoreThanOneConsecutiveEntry assertion
   for flaky reasons(Splash Screen, LetterBox, BackGestureSurface)

Test: atest WMShellFlickerTests
Bug: 176134495
Bug: 178685668
Bug: 178447631
Change-Id: I1d6153b987e5913a5d9a1fa5b72b9341b40db6fc
2021-02-02 10:41:45 +08:00
Ben Lin
6d00ea7a4a Merge "PiP: Double-tap to maximum, again to go back to last resized size." into sc-dev 2021-02-01 22:35:13 +00:00
Ben Lin
eded2ac40d PiP: Add tap-to-unstash function.
Bug: 178752503
Test: Tap on PIP while stashed
Change-Id: If42d4470f21744a29302879cd490fbb5c3110703
2021-02-01 12:43:22 -08:00
Ben Lin
6930fd5cbc PiP: Allow stashing via dropping on the edge.
Changes so that:
1) PiP now can be stashed when the user releases/let go of input when
PiP is currently floating on top of the left/right edge of the device.
Currently, 1/3 of the PiP needs to be off-screen in order for stash to
happen.
2) Stashing is now allowed from one edge to the other (e.g. user flings
from left to right, right to left), with VERY high velocity (>=
18000.f).

Bug: 178752503
Test: Let go of PiP when off screen, stashes
Test: fling from left to right with extremely high velocity, stashes
Change-Id: Ia0b701b75f598965d79b07b10f09118f80562f09
2021-02-01 12:41:14 -08:00
Lyn Han
0b2db04cf8 Land bubbles softly
Fixes: 168647014
Test: visual
Change-Id: I33f2e1384dcef44887538b1c936cc3a25a6405f0
2021-02-01 11:15:10 -06:00
Nataniel Borges
283866d88d Merge "Reduce flicker memory consumption (Pt 4)" into sc-dev 2021-02-01 12:22:01 +00:00
Nataniel Borges
1ee38b1c18 Reduce flicker memory consumption (Pt 4)
Improve flicker memory consumption with the following:
- Use a static factory for better compatibility with JUnit4 ParameterizedRunner
- Ensure `cleanUp` is always called, even when an exception occurs

Bug: 178572522
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Id9e539c0e8bce350f94811cab58a726e47aac525
2021-02-01 09:38:12 +01:00
Bill Lin
9e963584b5 Reset windows bounds when stop one handed mode
So far OHM reset windows bounds when
1) Rotate
2) Unregister(Settings disabled)
We want to add 1 more policy:
3) Reset windows when stop one handed mode(animation end/cancel)

Test: manual trigger OHM, stop OHM and check visual
Test: atest WMShellUnitTests
Bug: 178553230
Change-Id: Iba95fa11107fd0fa910685112ca962bca4adde80
2021-02-01 15:13:38 +08:00
Lyn Han
648208dfd6 Log overflow bubble restoration after phone reboot
Fixes: 178533138
Test: restart phone, examine logs
Change-Id: Ibffa5e4061a07b0f9327f6e99b138c354b96bee2
2021-01-31 17:16:46 -06:00