Commit Graph

9899 Commits

Author SHA1 Message Date
Philip P. Moltmann
15a028c929 Merge "Not specify return val of View#onSaveInstanceState" into oc-dev am: 1454afce82
am: 89d98d34cb

Change-Id: I93d3cbb6e0b6e7bbc7a535c0ebf437c16319075f
2017-05-12 20:27:57 +00:00
TreeHugger Robot
1454afce82 Merge "Not specify return val of View#onSaveInstanceState" into oc-dev 2017-05-12 19:14:53 +00:00
Abodunrinwa Toki
d7e4ef1ffb Merge "TRON: Count smart selection events." into oc-dev am: 6bf9b9a5f3
am: 1609833a2d

Change-Id: Ie7ccac9d9f93b69944d868be738bd37bfe37931d
2017-05-12 12:07:13 +00:00
TreeHugger Robot
6bf9b9a5f3 Merge "TRON: Count smart selection events." into oc-dev 2017-05-12 11:54:37 +00:00
Evan Rosky
5f607f135a Merge "Merge "Only save focus in keyboard navigation clusters when appropriate" into oc-dev am: f14aea9f8b" into oc-dev-plus-aosp
am: 4b5e7163ac

Change-Id: Iabddf8006df6b06eaa6349d8299259f5f3496146
2017-05-12 05:05:11 +00:00
Svet Ganov
45bd1bbd33 Merge "Detect isVisibleToUser post layout" into oc-dev am: a7af385208
am: 73d5b089b9

Change-Id: I1369c5ccb51f7b147144a4cd3576729f920e5bbd
2017-05-12 02:06:50 +00:00
Philip P. Moltmann
517bafa59d Not specify return val of View#onSaveInstanceState
.. as the comment was incorrect since a long time.

Bug: 37802299
Test: compiled
Change-Id: I10fe0b1c0f7f4ccaade38c87136a3785f2685798
2017-05-11 15:32:15 -07:00
Evan Rosky
f14aea9f8b Merge "Only save focus in keyboard navigation clusters when appropriate" into oc-dev 2017-05-11 22:26:18 +00:00
Abodunrinwa Toki
1d77557517 TRON: Count smart selection events.
Logs:
 - Smart selection occured
 - TextView menu item activated on smart selection
 - Smart selection reset
 - Smart selection modified

Test: Manually checked logging happens as per go/tron-howto and verified
nothing is broken in related classes by running:
bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
bit FrameworksCoreTests:android.widget.TextViewActivityTest

Bug: 32572232
Change-Id: Ia9081d92ae9aea50d863455be770eecd0c73be1a
2017-05-11 23:04:29 +01:00
TreeHugger Robot
a7af385208 Merge "Detect isVisibleToUser post layout" into oc-dev 2017-05-11 20:38:28 +00:00
Albert Chaulk
bcee3cc3fa Merge "Propagate UIDs for all SurfaceControl instances" into oc-dev am: 6c34dd58f6
am: eccbbe4ca2

Change-Id: I350bb7899eaa1e9919d6fdf8079afd11be4e9918
2017-05-11 15:52:48 +00:00
Albert Chaulk
6c34dd58f6 Merge "Propagate UIDs for all SurfaceControl instances" into oc-dev 2017-05-11 15:19:28 +00:00
Derek Sollenberger
ef16269e41 Merge "Add an O-release targetAPI check for Canvas.setBitmap. am: d70695ee34" into oc-dev-plus-aosp
am: 172bd07308

Change-Id: Iddc0babe08b2e1a9abe1bebe117fa66832417cff
2017-05-11 14:56:32 +00:00
Derek Sollenberger
d70695ee34 Add an O-release targetAPI check for Canvas.setBitmap.
For apps targeting releases earlier than O setBitmap will attempt
to preserve the matrix from the previous bitmap.  It does not however
attempt to reconstruct the save/restore stack or the clip.

Test: manual test of messenger app referenced in the bug
Bug: 37589964
Change-Id: I67f0928a3f84a8be41da38ef1868e79bdeb03e46
2017-05-11 09:28:02 -04:00
Phil Weaver
c3a67fca97 Merge "Remove outdated security note from A11yEvent" into oc-dev am: ea60efa8ef
am: 052bf032cb

Change-Id: I0ef433251e0e53af6ed00a34433cdea0edaf18eb
2017-05-11 09:20:31 +00:00
Phil Weaver
066fdf5d3f Merge "Clarify documentation for notification a11y events" into oc-dev am: 69a0f3f020
am: ce67e46e9a

Change-Id: I4ce14090b8a203f838dbb3d9fb18b2225ac053ce
2017-05-11 07:15:45 +00:00
Svet Ganov
84390348ea Merge "Properly position dataset picker UI" into oc-dev am: d915aecfaa
am: d0bfa95b4c

Change-Id: I8387cbce6e288c02a5e469dc80245528ae2381e1
2017-05-11 07:08:00 +00:00
Svet Ganov
68f583879f Detect isVisibleToUser post layout
Test: MiltipleFragmentsLogin test no longer fails.
      All auto fill CTS tests pass.

bug:38173625

Change-Id: I6e36229bc9517c7339c77cbc5f236e8399ef4283
2017-05-10 20:11:45 -07:00
TreeHugger Robot
ea60efa8ef Merge "Remove outdated security note from A11yEvent" into oc-dev 2017-05-11 02:27:19 +00:00
TreeHugger Robot
69a0f3f020 Merge "Clarify documentation for notification a11y events" into oc-dev 2017-05-11 01:57:08 +00:00
Albert Chaulk
e4338f843b Propagate UIDs for all SurfaceControl instances
Previously, a default value was being propagated for surfaces constructed
though paths other than WindowManagerService.createSurfaceControl. This
allows us to handle all surfaces in VR in a better way

Bug: 36589137
Test: Launch chrome (uses SurfaceView)
Change-Id: I8434c356ebe51173cae161ec1405e3d5f9a17723
2017-05-10 20:13:09 -04:00
Svet Ganov
374cae1e61 Properly position dataset picker UI
Test: all autofill CTS tests pass

bug:37958210
bug:37986800

Change-Id: Ic2cb3b8c6762a922bdb7c632e451772b7a006739
2017-05-10 23:38:51 +00:00
Svetoslav Ganov
2b3385ab9d Merge "Allow null fill values to support authentication case" into oc-dev am: 90bcc1c8bc
am: 0e4f1bab09

Change-Id: I4f95cb012fd5d8b96c2beb097aa3b09c8c557b74
2017-05-10 06:43:26 +00:00
Svetoslav Ganov
a9379d0b44 Allow null fill values to support authentication case
If a dataset needs to be authenticated the fill service
may not have the values but needs to tell the system for
which fields to show the fill UI. We now allow passing
a null value to mean the view is a part of the dataset
semantically but its value should remain unchanged.

If a dataset has no values, i.e. the related autofill ids
are mapped to null, we cannot properly filter. In this case
we always match such items regardless what the user typed.

While at this improved accessibility support for filtering
to announce when the number of items being filtered changes.

Also while at this allowed a dataset authentication to return
a response which replaces the current response and refreshes
the UI. Matching datasets with null values to any text plus
allowing a response to be returned from a dataset auth enables
the use case where there is always "Import" item at the
end of the list which when clicked can show arbitrarily more
data entries associated to other apps.

Another change is that we now provide the client state
bundle on both request and dataset auth.

Finally, this change gets rid of dataset waiting auth and
response waiting auth concepts since the reference to the
response and the dataset is piped with the auth request.

Fixed a bug where the width of the autofill UI was not
properly measured by going over all items in the adapter.
Now we measure enough height to fit the first three and the
width id the width of the widest item in the adapter.

Test: Added LoginActivityTest#testDatasetAuthTwoFieldsReplaceResponse
      Added LoginActivityTest#testDatasetAuthTwoFieldsNoValues
      Added LiginActivityTest#filterTextNullValuesAlwaysMatched
      All autofill CTS tests pass

bug:37724701
bug:37424539

Change-Id: Ic19e5d7cbdbb7d110c9e7da0ad60b540cbf1aecf
2017-05-09 17:40:28 -07:00
Phil Weaver
33c7136dde Clarify documentation for notification a11y events
This javadoc was confusing the TalkBack team, so I've
clarified that these events can come from either a
notification or a toast. I also removed a note that I
found confusing and, as far as I could tell, was not
correct anyway.

Bug: 34851364
Test: Docs changes only. Relying on TreeHugger.
Change-Id: Ie5c6efd6e32ce1e33f8cc45c795cda7d7b2e6583
2017-05-09 16:17:02 -07:00
Rob Carr
bb8131b1d7 Merge "SurfaceView: Release Surface with SurfaceControl." into oc-dev am: 3630fd4e11
am: 9cbe611f4a

Change-Id: I1b18f556b4b42f81ddca69ae5ce420d7a612bf6b
2017-05-09 17:14:05 +00:00
Phil Weaver
2bd8bdc89f Merge "NumberPicker a11y (and a11y-inspired) fixes" into oc-dev am: 8d25b77e4c
am: bcc047ca4f

Change-Id: I7814872b4f530ed408587887225243a3fc1c59ce
2017-05-09 17:10:02 +00:00
Phil Weaver
2cb0972340 Merge "Fix crash in a11y cache" into oc-dev am: 64d6e3e11d
am: 2af1fda3ca

Change-Id: Ib2aaaf46de7a402e34288ea9dcad45b9b2ba55eb
2017-05-09 16:46:34 +00:00
Rob Carr
3630fd4e11 Merge "SurfaceView: Release Surface with SurfaceControl." into oc-dev 2017-05-09 15:49:29 +00:00
Phil Weaver
8d25b77e4c Merge "NumberPicker a11y (and a11y-inspired) fixes" into oc-dev 2017-05-09 15:36:00 +00:00
Phil Weaver
64d6e3e11d Merge "Fix crash in a11y cache" into oc-dev 2017-05-09 15:30:30 +00:00
Philip P. Moltmann
f227375052 Merge "Fix left/top in ViewNode for suppressed parents" into oc-dev am: 9f028643c2
am: b1e1d2bf0a

Change-Id: I9b96fdd581401389b2d1e494e3fab49683787518
2017-05-09 02:55:27 +00:00
Philip P. Moltmann
7e6ef30452 Merge changes I7c2c9411,Ibc72c84d,Ib3968644 into oc-dev am: f512575c68
am: 169989822e

Change-Id: I330cd6e1601584e3903a26b27047aae2e7b7c711
2017-05-09 02:18:52 +00:00
TreeHugger Robot
9f028643c2 Merge "Fix left/top in ViewNode for suppressed parents" into oc-dev 2017-05-09 02:15:43 +00:00
TreeHugger Robot
f512575c68 Merge changes I7c2c9411,Ibc72c84d,Ib3968644 into oc-dev
* changes:
  No need to deal with windowTokens
  Persistable accessibility ID from ContextWrappers
  Check callbacks when operting on UI
2017-05-09 01:49:58 +00:00
TreeHugger Robot
fa7392c901 Merge "SpellCheckerSession: Fix brittle finalizer pattern." 2017-05-09 01:45:43 +00:00
Philip P. Moltmann
2a8ff264b5 Merge "Read the autofill highlight from rootView context" into oc-dev am: f51b5f991c
am: cc5a7192e2

Change-Id: I2a4bf3bfb8edf9129f48eb3fb1f1cef8b1579e34
2017-05-08 23:22:32 +00:00
Philip P. Moltmann
f51b5f991c Merge "Read the autofill highlight from rootView context" into oc-dev 2017-05-08 23:06:31 +00:00
Svet Ganov
88d403034f Merge "Also check if view visible to user before engaging fill" into oc-dev am: f0de5cdd9a
am: d54f65521f

Change-Id: Ic946eaf470506021263173d529e5cd35702e93a3
2017-05-08 22:26:15 +00:00
TreeHugger Robot
f0de5cdd9a Merge "Also check if view visible to user before engaging fill" into oc-dev 2017-05-08 21:10:53 +00:00
Philip P. Moltmann
134cee27b8 No need to deal with windowTokens
we have a link to the client which is enough to find the views.

Also there was some cases where the windowToken was not updated
properly. This is moot now.

Also: Read a array of views from the client to speed up the
client<->AutofillManager communication.

Fixes: 38070352
Test: CtsAutoFillServiceTestCases
      1 Started autofill, saw fill UI
      2 Home button
      3 Kill activity in background
      4 Recents -> back to activity
      5 Saw fill UI restored
Change-Id: I7c2c9411204fa5d65867efae9b7296399121c3a2
2017-05-08 14:02:58 -07:00
Philip P. Moltmann
ff6d6d9492 Persistable accessibility ID from ContextWrappers
Only IDs beyond LAST_APP_ACCESSIBILITY_ID can be reliably used for
autofilling. Other ids might change occasionally.

All Views attached to activities get usable IDs. Hence if a
ContextWrapper wraps an activity forward the goodness.

Also make sure that we don't accidentially autofill an unsafe view.

Test: Before the messaging handed out unusable Ids because it uses a
      Contextwrapper. Now it hands out good ideas (accoring to dumpsys)
      CtsAutoFillServiceTestCases
Bug: 38070352
Change-Id: Ibc72c84d77197019939abd231e8960988af7a592
2017-05-08 13:29:17 -07:00
Robert Carr
de84443489 SurfaceView: Release Surface with SurfaceControl.
Not so drastic as we were releasing the Server side resources
anyway but the close guard is producing a strict mode warning.

Bug: 35955183
Test: cts-tradefed run cts -m CtsViewTestCases -t android.view.cts.SurfaceViewTest#surfaceInvalidatedWhileDetaching
Change-Id: Id250fff8d001d5d82458af1a732c0e123f925dad
2017-05-08 12:12:30 -07:00
Svet Ganov
01e1a62997 Also check if view visible to user before engaging fill
Test: autofill CTS tests pass 

bug:37753348

Change-Id: Ia16bff13f2cfdf1d315e3f45cc114ee13b145eb5
2017-05-08 19:11:05 +00:00
Philip P. Moltmann
e926aad53d Fix left/top in ViewNode for suppressed parents
If parents of a view got suppressed in the autofill structure the left
and top value are not relative to their direct parents anymore. They
need to be relative to the next non-suppressed parent.

This does not change any values for assist structures.

Fixes: 36060132, 37444334
Test: CtsAutoFillServiceTestCases + new ones that check for the left and
      top parameters of view nodes.
Change-Id: I914ad028c7ed2f93ce44210cbe1a2a710673cbbb
2017-05-06 12:29:10 -07:00
Phil Weaver
af00cb406c Merge "Properly translate text locations to screen coords" into oc-dev am: 2a86bad94c
am: c89c9dd3a9

Change-Id: I873787374ca65c0d18bf0c62416c4ffd4db69ef3
2017-05-06 15:46:00 +00:00
Phil Weaver
2a86bad94c Merge "Properly translate text locations to screen coords" into oc-dev 2017-05-06 15:29:24 +00:00
Philip P. Moltmann
c1e1810ca2 Merge "Report less data in structure to autofill provider" into oc-dev am: d19113b390
am: 889b15b4c2

Change-Id: Id60c55e06e94c3f639703beda9b249dcf0f8bd6c
2017-05-06 02:37:00 +00:00
Philip P. Moltmann
c368a240c9 Report less data in structure to autofill provider
Fixes: 35899963
Test: CtsAutoFillServiceTestCases, CtsAccessibilityTestCases,
      CtsAccessibilityServiceTestCases
Change-Id: Ia7dba3e252e7678c033d67bcf653e592f3134304
2017-05-05 14:20:11 -07:00
Phil Weaver
6c617f0a93 Properly translate text locations to screen coords
Using the same method as getBoundsInScreen.

Bug: 35095925
Test: Manually verified location with test app, ran a11y cts
Change-Id: I1eee2a4eb23912698be61c9030d92bbade1d743a
2017-05-05 14:19:58 -07:00