Commit Graph

423 Commits

Author SHA1 Message Date
Phil Weaver
e05fba4e94 Change API name for a11y keyboard flag
Bug: 113855740
Test: make
Change-Id: Ia41360cb5e2bf5d845027add13dec34bc246f403
2018-09-04 17:08:56 -07:00
Dieter Hsu
01f426fd5e Add TouchExplorerTest
- Add test cases to check sent action-change-to-non-move motion events
  is not contain history.
- Fix AccessilityGestureDetector TODO that will affect atest test fail

Bug: 74069091
Test: atest FrameworksServicesTests:TouchExplorerTest FrameworksServicesTests:AccessibilityGestureDetectorTest

Change-Id: Iae4321eaeea15021dfed4503da4665398d899c07
2018-08-24 15:38:59 +08:00
Jackal Guo
ea479da1e0 disableSelf doesn't recover the init state of value
It leaves empty string instead of null for the value of
secure.enabled_accessibility_services. It may cause other tests
fails.

Bug: 111317486
Test: atest CtsAccessibilityServiceTestCases
Test: manual check the value of settings providers after test
Change-Id: I3f882ba00145ffa555514117c4684aec9ce33947
2018-08-21 11:41:43 +08:00
Jackal Guo
7080e1a588 Avoid duplicated touch events
TouchExplorer doesn't check for double tap (and hold) so there may
be duplicated TYPE_TOUCH_INTERACTION_START/END events.

Bug: 66730372
Test: manual
Test: CtsAccessibilityServiceTestCases
Test: CtsAccessibilityTestCases
Change-Id: Iece13d3a401f13d8a7dcda2147b2865eee5e5f33
2018-08-09 10:01:28 +08:00
Dieter Hsu
1979bad271 Remove dupe events while 2-fingers scrolling
Move events may contain a history of other move events. When we split
the event, each of the resulting events has history. When the system
dispatches the events, it also dispatches the ones in the history.

We change these events with actions which are NOT ACTION_MOVE and
inject to input. But those histories are no longer consistent with what
happened and are causing InputDispatcher::injectInputEvent to enqueue
duplicated events of each historical pointer coord.

Bug: 74069091
Test: manual
Test: atest CtsAccessibilityTestCases
Test: atest CtsAccessibilityServiceTestCases

Change-Id: I2a9f5526cbeecfcc379f86624607190e16265405
2018-08-06 06:08:07 +00:00
Phil Weaver
a92586955a Merge "Eliminate race condition for a11y windows" 2018-08-03 22:58:42 +00:00
Jackal Guo
9e795d828a Merge "Magnification isn't reset when service is disabled" 2018-08-03 01:23:38 +00:00
TreeHugger Robot
637415892c Merge "Remove batchMotionEvent in AccessibilityInputFilter." 2018-08-02 07:10:42 +00:00
Phil Weaver
c72faad7ab Eliminate race condition for a11y windows
Update the window list when a new window is registered
with a11y.

Bug: 111766358
Test: A11y CTS.
Change-Id: Id5ec3db3da1849b5de91cce55a67d8241e489e1f
2018-07-31 16:02:07 -07:00
Jackal Guo
1418a6b07f Magnification isn't reset when service is disabled
If the disabled service is the last service to magnify, reset the
magnification.

Bug: 28623059
Test: manual
Test: atest CtsAccessibilityTestCases
Test: atest CtsAccessibilityServiceTestCases
Test: testResetIfNeeded_resetsOnlyIfLastMagnifyingServiceIsDisabled
Change-Id: I6b12a5251b5fede8d2c9eb06048bf9fa4bd70f8b
2018-07-31 11:24:29 +08:00
Phil Weaver
b5df055d34 Merge "Enhance a11y soft keyboard controller" 2018-07-27 23:43:32 +00:00
Phil Weaver
03a65b04d8 Enhance a11y soft keyboard controller
Allow a11y services to request that the soft keyboard be
shown even when the hard keyboard is attached.

Defer to users who override this behavior, and put things
back the way they were when a service requesting this
behavior stops.

Bug: 31012180
Test: Adding CTS tests in linked CL, ran a11y unit tests,
modified TestBack to use the new flag and verified behavior
with a hard keyboard and verfied that settings behave as
expected when overriding and rebooting.
Change-Id: I530481e102ac376a4506b662862ee1ee74815b40
2018-07-27 12:58:18 -07:00
Rhed Jao
fe39083a97 Remove batchMotionEvent in AccessibilityInputFilter.
Change-Id: I65da739528cb8ff329721015de0adf5b269c46c5
Fixes: b/77939003
Test: A11y CTS
2018-07-26 14:15:09 +08:00
Jackal Guo
1528c875e3 Correct return value of MagnificationController#reset
It only returns true if magnification changes from magnifying to
non-magnifying. This is inconsistent with the docs. Return true if
the magnification scale and center is reset.

Bug: 64616261
Test: atest CtsAccessibilityTestCases
Test: atest CtsAccessibilityServiceTestCases
Change-Id: I0c496c5c45c2e35025f1887842a2a9741c440af1
2018-07-24 17:49:16 +08:00
Jackal Guo
d447b5cfc6 Merge "Using transformed event for standard gesture detector" 2018-07-20 03:26:27 +00:00
Jackal Guo
79ea482641 Using transformed event for standard gesture detector
TouchExplorer uses raw event in both a11y and standard gestures
detection, but transformed event in following movement. This
inconsistency causes significant difference of distance between
their locations when screen is magnified and long press would fail.
Passing transformed events for standard gesture detector instead.

Bug: 67378068
Test: manually test if double tap and hold works while Talkback
and Magnification are both enabled.
Test: manually test if Talkback and Magnification work as expected.
Test: AccessibilityGestureDetectorTest

Change-Id: I0e1dc59e25bc36f1f99ba6ecdb05c9c488b6f47e
2018-07-19 11:33:54 +08:00
Rhed Jao
8a39cef7f8 Update AccessibilityManagerService to use SystemService
Bug: 70221242
Test: atest CtsAccessibilityServiceTestCases
Change-Id: Icdf0772d0be93168a954fdd746cada4d5d507eb4
2018-07-18 13:42:35 +08:00
TreeHugger Robot
24158ba81b Merge "Make sure keys get flushed when connection falls apart." 2018-07-02 17:58:20 +00:00
Qasid Sadiq
5bbc301350 Make sure keys get flushed when connection falls apart.
This is for the event that a key has been intercepted, sent to the app,
and the app hasn't handled it yet. If the connection dies, the key is
lost. So flush all pending keys.

Test: Unit test (this would have caught me introducing this bug in the
first place).

Bug:74593001
Change-Id: I5a94aafe5c58f18a3e9ca46f7cd5a9cb71d38aaa
2018-06-27 22:33:11 +00:00
Wale Ogunwale
9e4f3e077f Introduced WindowProcessController/Listener (10/n)
One heavy dependence between the current AMS service and activities
is process management which is heavy affected by activities and their
current state. We introduce WindowProcessController and WindowProcessListener
objects as a structured way for the process changes in AM package to
be communicated to the WM package and WindowProcessListner for activity
changes in the WM package to the communicated back to the AM package.
The ProcessRecord object in AM will own the WindowProcessController object
and also implement the WindowProcessListener.

Test: Existing tests pass
Test: go/wm-smoke-auto
Bug: 80414790
Change-Id: I9e96e841b0f95e99a597cb4629fa5d2fe45760b6
2018-06-22 14:26:24 -07:00
Wale Ogunwale
6767eaee94 Split internal interface activities from current AM interface (3/n)
3rd step in unifying the window hierarchy that is currently split
within AM and WM packages. We separate the the internal interface used
to communicate within system server dealing with activities and their
containers (tasks, stack, display) from the rest of AM internal
interface.

Test: Existing tests pass
Test: go/wm-smoke-auto
Bug: 80414790
Change-Id: Idad77721c1fe10621b9be5dced42a0a11f0183e5
2018-06-15 08:43:22 -07:00
Qasid Sadiq
fba2c8fb58 After an ax service permanently crashes, it won't eat keys
The volume keys will work again, the ax button will reset back to the
correct state, and a bunch of other things.
This is cause we are not tracking the state of the service correctly in
this "Service won't run, but is on" state. Previously we just assumed it
was on.

Bug: 74593001
Test: Verified on device. By getting testback to crash. Tested, turning
service on and off in settings. Crashing it once, and having it restart
automiatically. Continuesouly crashing it until the system decides this
is bad. And after that state rebooting to make sure the service starts
up again.

Change-Id: I00e9c978d6807d8508968286a7545e48f9ae5800
2018-06-07 15:51:37 -07:00
Yuki Awano
0b47dde976 Fix magnification offset min and max calculation
- Magnification offset is in screen coordinate. It needs to take care
  about left and top of magnification bounds when calculating min and
  max.

Bug: 77152978
Test: None
Change-Id: I5ee7835c88eed080d9b22901977b0b5f76737703
2018-05-25 16:47:11 +09:00
Phil Weaver
466b71e1a2 Add config value for fingerprint gesture support
Also correcting docs for using the fingerprint gesture
flag.

Bug: 76419487
Test: Verified with a test a11y service that gestures are
not available. Adding a unit test to verify this case.

Change-Id: I90233613777013e8b117a2d94f767be292c80019
2018-04-20 15:53:58 -07:00
Phil Weaver
985617969f Don't clear a11y focus with lock held
The bug I'm fixing is kind of weird, but in the trace it
showed lock contention with onWindowsForAccessibilityChanged
holding the lock for a long time. So I've cleaned up that
method a bit, looking for trouble. The only concrete thing
I see that's wrong is that I was clearing a11y focus, which
involves calling the app that last reported having focus.
That was done with the lock held. Now doing it through the
handler.

Bug: 77298850
Test: Ran a11y CTS and unit tests.
Change-Id: I667707412a0e3ba98639d0cb43858e8c6b52a5a7
2018-04-04 04:49:12 +00:00
Eugene Susla
bd573236f8 [DO NOT MERGE] Sort A11yService#getWindows by layer descending
This is what A11yService#getWindows promises in the javadoc.

Fixes: 71581072
Test: using testback ensure the order is correct
Change-Id: I5038c4de29c60e235b65751f7bd7771ef35eb339
(cherry picked from commit f40da1a884)
2018-04-03 21:36:01 +00:00
Tony Mak
6f2e97e235 Not allow shell to dump screen by using ui-automator if...
DISALLOW_DEBUGGING_FEATURES is set

(adb unroot first)
Test: Turn on DISALLOW_DEBUGGING_FEATURES in work profile.
      Can dump personal window + Cannot dump work window by using
      adb shell uiautomator dump
Test: Turn off DISALLOW_DEBUGGING_FEATURES in work profile.
      Can dump window in both profiles
Test: atest CtsAccessibilityServiceTestCases
Test: Enable talkback, try launching a few apps and interact with them.

Fixes: 73147467

Change-Id: I044a1546f9b568b0d19714154d6e7e5ab7232d26
2018-03-29 08:20:10 +00:00
TreeHugger Robot
c863d506cf Merge "Expose if running a11y service has crashed" into pi-dev 2018-03-20 20:16:08 +00:00
Phil Weaver
c09a021987 Expose if running a11y service has crashed
Using a hidden variable to communicate this for enabled
services. Used in Settings to report the current status.

Fixes: 35219990
Test: Adding unit test to verify that crashed value is
populated correctly. Run a11y unit and cts tests.

Change-Id: Ia47a8bd1d750186c504758df21e05a8a76c285cb
2018-03-13 09:54:28 -07:00
Phil Weaver
53454a1c84 Don't let non-touchable windows retain a11y focus
Accessibility services can't see non-touchable windows,
so those windows should not be allowed to have
accessibility focus.

Bug: 70986605
Test: Manually went through bug steps, verified that
double-tapping on the screen has no effect.

Change-Id: I7be72331c5704f7aa99714a01bbb2e336eea15e1
2018-03-09 16:00:24 -08:00
TreeHugger Robot
3a1b5d1867 Merge "Fix bug in clearing a11y focus" 2018-02-27 05:32:53 +00:00
Phil Weaver
7bb765e74d Fix bug in clearing a11y focus
Pooled lambda change dropped the argument.

Fixes: 73889458
Test: Turn on TalkBack, select things in different
windows, observe that focus clears in one window
when it is set in another.

Change-Id: I9755ffbce1b5305a24f5b9ac7b8f59069c917995
2018-02-26 12:54:40 -08:00
Phil Weaver
6343b32ae0 Make equality check more robust for a11y button
Fixes: 72734254
Test: "adb shell settings put secure
accessibility_button_target_component blah" no longer
crashes.

Change-Id: I1c8b56386c135f111a8f5ab3f5b76d2991a6c5a1
2018-02-26 11:28:03 -08:00
Phil Weaver
fde445631a Merge "Stop throwing exceptions in TouchExplorer" 2018-02-24 13:57:09 +00:00
Phil Weaver
9404bea49a Stop throwing exceptions in TouchExplorer
These crash the system. Resetting and trying to muddle
through seems like a better solution than restarting
the device.

Bug: 68269250
Test: make, try TalkBack a bit. The crashes were so rare that
the code I'm changing *almost* never executes.

Change-Id: I7931417832cb2ce39de5c8b00312c12354d76803
2018-02-23 11:26:25 -08:00
Eugene Susla
75fbfc7ec1 Use PooledLambda in A11yManagerService
This replaces the usage of handler messages with PooledLambda

Test: cts tests
Change-Id: I0c9db5deddef7c69444d1fbadc19d10e4071a4d0
2018-02-21 13:38:52 -08:00
TreeHugger Robot
a9e97b0d9e Merge "Couple fixes for M11nGestureHandler" 2018-02-15 06:06:52 +00:00
Eugene Susla
5210e9447c Couple fixes for M11nGestureHandler
1. Added missing defensive copy for a MotionEvent that is posted
asynchronously with delay, and thus might get recycled
2. Fixed transitioning to viewport dragging on 3tap/shortcut+swipe

Test: manually ensure the fix is working
Bug: 73359125
Change-Id: Iae8cd3a83512ee363abe9f0b5702287d7616c092
2018-02-14 17:44:28 -08:00
TreeHugger Robot
8d79feb801 Merge "Fix magnification viewport drifting when scaling" 2018-02-14 20:51:33 +00:00
Eugene Susla
10280a87df Fix magnification viewport drifting when scaling
Fixes: 32255388
Test: Ensure viewport no longer drifts when scaling
Change-Id: I1b12aeaa8e1d0282d6c35a27ee061f6cd7b0a667
2018-02-13 15:11:45 -08:00
TreeHugger Robot
421822ce0f Merge "Clean up usage of COWArrayList in a11y code" 2018-02-09 22:17:41 +00:00
Eugene Susla
b7c8f2dc06 Clean up usage of COWArrayList in a11y code
The single usage we had was already mostly guarded by lock -
replaced with a regular list to prevent confusion

Fixes: 71795155
Test: atest CtsAccessibilityServiceTestCases
Change-Id: I1c3235aadb0db4907cbe92a17cc58d2c8a8b5564
2018-02-09 11:15:18 -08:00
Andreas Gampe
bbab23ff97 Frameworks: Annotate trivial @GuardedBy in services/ misc
Add @GuardedBy for simple functions that require a single lock
and are named XYZLocked.

Derived by errorprone.

Bug: 73000847
Test: m
Test: m javac-check-framework RUN_ERROR_PRONE=true
Change-Id: Id1d9fbe5018250e3b9d1466fc5f670d5ad902fa3
2018-02-08 02:19:42 -08:00
TreeHugger Robot
6af87a9513 Merge "Fix inconsistent MagnificationGestureHandler state after delegation" 2018-01-24 22:09:24 +00:00
Eugene Susla
8f07ee15cb Fix magnification button toggle off
Fixes: b/69307379
Test: Ensure attached bug no longer reproduces.
Ensure magnification using a11y button otherwise works as expected
Change-Id: Ie4e966eb8cfcc9d3f37ae7252b951381ef1fb7c7
2018-01-23 15:03:09 -08:00
Eugene Susla
e6e55b5359 Fix inconsistent MagnificationGestureHandler state after delegation
Fixes: 71863482
Test: ensure attached bug no longer reproduces
Change-Id: I223484caefa01dd15066797e53a2f21607ee162d
2018-01-23 12:16:45 -08:00
Phil Weaver
d0429743fa Add a11y action to take screenshot
Bug: 70392997
Test: Adding unit test for functionality, cts test
for presence of api.

Change-Id: Ib5bc2217e1d29f527db0f0fadb69fd8249d6c279
2018-01-19 15:43:53 -08:00
TreeHugger Robot
dc8e52684b Merge "Treat ACTION_CANCEL as ACTION_UP for magnification" 2018-01-13 02:34:55 +00:00
TreeHugger Robot
34bc2ab967 Merge "Prevent race condition when iterating over bound services" 2018-01-13 02:32:04 +00:00
Eugene Susla
5b05f77a12 Prevent race condition when iterating over bound services
Fixes: 71770764
Test: cts
Change-Id: Ifb7457a6b9a88b466bf39a647b92531de6c3c70e
2018-01-10 15:18:11 -08:00