Commit Graph

55525 Commits

Author SHA1 Message Date
Jeff DeCew
025a668cf9 Merge "Do not show the notification footer until the user is set up." into qt-dev am: 3bc24e3826
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15877960

Change-Id: Id7097c9716292cb6edef1e06fe321b954fcff7ac
2021-10-05 17:32:35 +00:00
Jeff DeCew
3bc24e3826 Merge "Do not show the notification footer until the user is set up." into qt-dev 2021-10-05 17:21:10 +00:00
Quang Luong
72c56e2c88 Merge "Fix NPE on getTitle()" into qt-dev am: afee5a7219
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15888886

Change-Id: Ib57e720c6c28fe5d24406775ba8832650c8dbd12
2021-09-30 15:23:33 +00:00
cnchen
ced3af1e05 Fix NPE on getTitle()
Bug: 199922685
Test: make RunSettingsLibRoboTests -j40
Change-Id: I35bf6f5911dc0ee56e43af7faddaceb479362863
(cherry picked from commit f00f2203b5)
Merged-In: I35bf6f5911dc0ee56e43af7faddaceb479362863
2021-09-22 22:20:42 +00:00
Jeff DeCew
e7f992a133 Do not show the notification footer until the user is set up.
Bug: 193149550
Test: follow repro steps
Merged-In: I49e2b8bcec7b2ce0a9776ff30a64c07f24949da7
Change-Id: I49e2b8bcec7b2ce0a9776ff30a64c07f24949da7
2021-09-22 16:04:05 +00:00
TreeHugger Robot
bfc095df4f Merge "[DO NOT MERGE] Fixing unsafe pending intent in notification" into qt-dev 2021-09-06 21:20:01 +00:00
Evan Chen
37d7f20996 Merge "Backporting the change of ag/15629060 to qt-dev" into qt-dev am: 587162dfb8
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15744060

Change-Id: I3b0f3bdeff33c52b5b20f4b6db10f5069d9bfbb6
2021-09-06 05:03:16 +00:00
Evan Chen
55f71f96c3 Backporting the change of ag/15629060 to qt-dev
Bug: 172251622
Bug: 197035186
Change-Id: Ic3ffcb622af232473adf8a8c8307cce78227bac0
Merged-In: I7e2f95fd85e18127dc481f188ace8ad6effc4831
Test: Manual
2021-09-03 01:44:01 +00:00
Sunny Goyal
7ff5163b2d [DO NOT MERGE] Fixing unsafe pending intent in notification
Bug: 173025705
Test: Manual
Change-Id: I37e807fffe9ad67caa93a91d5e350350514989ab
2021-08-31 10:51:20 -07:00
Dave Mankoff
0122320cb2 Merge "Guard DISABLE_PLUGIN with PLUGIN permission." into qt-dev am: b279744b70
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15358519

Change-Id: Ic923b993f8bff5b5fa2c5f32f91e4787b8c21e18
2021-08-10 19:11:11 +00:00
Dave Mankoff
55cd8952c0 Guard DISABLE_PLUGIN with PLUGIN permission.
Fixes a p0 security bug. We already have the plugin permission
defined in our manifest. Ensure that senders of the DISABLE_PLUGIN
broadcast have that permission.

Bug: 193444889
Test: manual
Change-Id: Iebaba435c17c5644c5357c0683858447f5ffb897
Merged-In: Iebaba435c17c5644c5357c0683858447f5ffb897
2021-07-22 13:06:57 +00:00
Beth Thibodeau
fcd571f060 Increase maximum allowed size for status bar icons am: 92106a58df
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14053514

Change-Id: Ide2c48e4eedeb5d15a6a3199b7ad66cec1320338
2021-04-27 21:20:01 +00:00
Beth Thibodeau
c7731486df Merge "Limit maximum allowed size for a status bar icon" into pi-dev am: ed7118d8bf am: 04043de40c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13430565

Change-Id: I5d7be58c98debc681c655d8cda5745a449b91e58
2021-04-27 21:18:08 +00:00
Beth Thibodeau
92106a58df Increase maximum allowed size for status bar icons
The previous size was causing some apps to crash which otherwise worked
fine. This more closely matches the hard limit in RecordingCanvas
(which we need to stay below to prevent SystemUI from crashing).

Fixes: 182891864
Fixes: 182232777
Bug: 169255797
Test: atest StatusBarIconViewTest
Test: manual - posting notifications with different drawable sizes
Change-Id: I8deacc651e05a202ec980eeb8bcdf4f92daea8eb
(cherry picked from commit 5cd7976f7d)
2021-04-01 18:16:47 +00:00
Beth Thibodeau
04043de40c Merge "Limit maximum allowed size for a status bar icon" into pi-dev am: ed7118d8bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13430565

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I4dd07763f8c0c767c82a8e354f20e980e06a9373
2021-03-03 19:32:05 +00:00
Beth Thibodeau
ed7118d8bf Merge "Limit maximum allowed size for a status bar icon" into pi-dev 2021-03-03 19:13:46 +00:00
Eugene Susla
4d587c5aa9 RESTRICT AUTOMERGE am: 30e9d28c22
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13181018

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ia0ce89b57ab01e6316b5cad5854b26624b460043
2021-02-09 23:01:14 +00:00
TreeHugger Robot
a0f134bd11 Merge changes from topic "notif-backport" into qt-dev
* changes:
  DO NOT MERGE: Fix interaction tracking logic
  DO NOT MERGE: Associate notif cancels with notif posts
  DO NOT MERGE: Allow interrupting notifications to bypass lifetime extension
  DO NOT MERGE: Create a shim for StatusBarManager click methods
2021-02-03 23:23:40 +00:00
Evan Laird
0e2acaf0a5 DO NOT MERGE: Fix interaction tracking logic
Tried to put a clever kotlin-ism there, but then the interaction tracker
was returning `true` for every notification because it only checked if
the key existed

Test: manual
Bug: 144324894
Bug: 119041698
Change-Id: Ie2f489acca973c0aebbd8e7d8fc7fbef2bac793f
2021-02-01 18:19:22 -05:00
Evan Laird
98d6853f1a DO NOT MERGE: Allow interrupting notifications to bypass lifetime extension
Notifications which have interruped the UI (usually a HUN) can safely
bypass FGS lifetime extension because the system has done the best it
can to show the user this notification.

This valve is important in particular for things like a dialer which
might want to interrupt a user but need to do so again on the same
channel, for instance when getting multiple phone calls quickly in
succession.

Bug: 155594347
Bug: 119041698
Test: atest ForegroundServiceNotificationListenerTest
Change-Id: Id80fba3191cc133d1e73ca04015f9cbed62fc086
2021-01-29 10:47:58 -05:00
Evan Laird
cec677aca4 DO NOT MERGE: Create a shim for StatusBarManager click methods
`StatusBarManager#onNotificationClick` and
`StatusBarManager#onNotificationActionClick` are signals we send to
system server about notification clicks. This CL adds a shim so that we
can have an in-process callback about the exact same events.

This CL also adds NotificationInteractionTracker, which basically just
merges the NotificationClickNotifier callbacks with the notification
collection and will be able to answer the question "has the user
interacted with this notification"

Lastly, this modifies the logic in ForegroundServiceLifetimeExtender
which now checks the interaction flag for notifications. So if a user
tapped on a notification action (for instance) which _then_ triggers a
notification cancel, it will succeed. It _does not_ as of yet release
the notification from lifetime extension upon interaction. So if a
notification is canceled and then interacted with, it will still live
the full amount of time.

Test: atest SystemUITests
Bug: 144324894
Bug: 119041698
Change-Id: I42201d6e7b7ffe9ad4f19c774b638a36a51750ef
(cherry picked from commit 9b2a480ceb)
2021-01-29 10:47:13 -05:00
Beth Thibodeau
c508aed10f Limit maximum allowed size for a status bar icon
Bug: 169255797
Test: atest StatusBarIconViewTest
Test: verified that app crashes instead of SysUI following repro steps
Change-Id: I66e3bb873841b5babfd522c82cea7bed361fc14c
(cherry picked from commit 4394595deb)
2021-01-28 22:00:46 +00:00
Eugene Susla
486773ff45 RESTRICT AUTOMERGE
Allow CDM to hide overlays

Since CDM has sensitive user consent UIs, it should be able to hide
non-system overlays

Test: use a 3p overlay app with a visible overlay to ensure overlay disappears when CDM is shown
Bug: 171221090
Change-Id: I3274cb7f03f63e1fa99a9ca06759972ce2a51309
2020-12-07 15:22:25 -08:00
Eugene Susla
068221bbba RESTRICT AUTOMERGE
Prevent non-system overlays from showing over CDM UI

Since CDM grants privileges, it should have the same overlay
policy as permission UI

Test: use an app wit ha visible overlay to ensure
the overlay disappears when CDM is shown
Fixes: 171221090

Change-Id: I4daaee7d8b710a72f6166cbb2252ef8af84c2c60
2020-12-07 15:07:55 -08:00
Eugene Susla
30e9d28c22 RESTRICT AUTOMERGE
Allow CDM to hide overlays

Since CDM has sensitive user consent UIs, it should be able to hide
non-system overlays

Test: use a 3p overlay app with a visible overlay to ensure overlay disappears when CDM is shown
Bug: 171221090
Change-Id: I3274cb7f03f63e1fa99a9ca06759972ce2a51309
2020-12-07 14:41:06 -08:00
Eugene Susla
2d5a635fec RESTRICT AUTOMERGE
Prevent non-system overlays from showing over CDM UI

Since CDM grants privileges, it should have the same overlay
policy as permission UI

Test: use an app wit ha visible overlay to ensure
the overlay disappears when CDM is shown
Fixes: 171221090

Change-Id: I4daaee7d8b710a72f6166cbb2252ef8af84c2c60
2020-12-07 14:35:42 -08:00
TreeHugger Robot
78c8bbdfaf Merge "Revoke the uri permission when the file is deleted" into pi-dev am: 2b52397d56 am: 9095b67c84
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12455472

Change-Id: Ic42474e16756dbd77c3a343ba1f7cbf95b2c10c8
2020-12-03 06:11:17 +00:00
TreeHugger Robot
9095b67c84 Merge "Revoke the uri permission when the file is deleted" into pi-dev am: 2b52397d56
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12455472

Change-Id: I46865cbc3572d68f2ef738c95bcc05de8088f403
2020-12-03 05:48:51 +00:00
TreeHugger Robot
2b52397d56 Merge "Revoke the uri permission when the file is deleted" into pi-dev 2020-12-03 04:55:15 +00:00
Miranda Kephart
bb4bfcc575 [DO NOT MERGE] Make GlobalScreenshot PendingIntents immutable
Mutable pending intents are a security risk. This change adds the
IMMUTABLE flag to all PendingIntents created in GlobalScreenshot.

Bug: 162738636
Test: manual
Change-Id: I1044b6aaf2b1650ff91d9a72181684d2aaea9a62
2020-11-09 16:09:36 +00:00
Miranda Kephart
ed450d77ed [DO NOT MERGE] Make GlobalScreenshot PendingIntents immutable
Mutable pending intents are a security risk. This change adds the
IMMUTABLE flag to all PendingIntents created in GlobalScreenshot.

Bug: 162738636
Test: manual
Change-Id: I1044b6aaf2b1650ff91d9a72181684d2aaea9a62
2020-11-09 16:09:20 +00:00
Miranda Kephart
f4eefc55c4 [DO NOT MERGE] Make GlobalScreenshot PendingIntents immutable
Mutable pending intents are a security risk. This change adds the
IMMUTABLE flag to all PendingIntents created in GlobalScreenshot.

Bug: 162738636
Test: manual
Change-Id: I1044b6aaf2b1650ff91d9a72181684d2aaea9a62
2020-11-09 16:07:30 +00:00
TreeHugger Robot
0bfb8a8808 Merge "Hide overlays over uninstall confirm dialog" into qt-dev am: 75826a6664
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12950014

Change-Id: Id1b999a8d7b6803d4add52475abe5564d5ccb3d9
2020-11-06 04:12:08 +00:00
TreeHugger Robot
75826a6664 Merge "Hide overlays over uninstall confirm dialog" into qt-dev 2020-11-06 04:01:29 +00:00
Philip P. Moltmann
d75105e74b Hide overlays over uninstall confirm dialog
Test: atest CtsPackageUninstallTestCases
Fixes: 171221302
Merged-In: I38b6d85871064d76f2911e20acc74b4ab76406b3
Change-Id: I38b6d85871064d76f2911e20acc74b4ab76406b3
2020-10-29 19:27:33 +00:00
Pinyao Ting
6d9794aa9f remove sensitive pii from safetynet logging
Bug: 159145361
Test: manual
Change-Id: I8f1be55971672c7e8f5aa8848f65b1b9d9f40fb5
Merged-In: I8f1be55971672c7e8f5aa8848f65b1b9d9f40fb5
(cherry picked from commit 3b6905bf6a)
2020-10-14 19:27:21 +00:00
Pinyao Ting
391c143418 remove sensitive pii from safetynet logging
Bug: 159145361
Test: manual
Change-Id: I8f1be55971672c7e8f5aa8848f65b1b9d9f40fb5
Merged-In: I8f1be55971672c7e8f5aa8848f65b1b9d9f40fb5
(cherry picked from commit 3b6905bf6a)
2020-10-14 19:26:54 +00:00
Pinyao Ting
6d0599f07e remove sensitive pii from safetynet logging
Bug: 159145361
Test: manual
Change-Id: I8f1be55971672c7e8f5aa8848f65b1b9d9f40fb5
Merged-In: I8f1be55971672c7e8f5aa8848f65b1b9d9f40fb5
(cherry picked from commit 3b6905bf6a)
2020-10-14 19:26:15 +00:00
Pinyao Ting
4cab9c3876 Fix the issue provider can be wrong when requesting slice permission
SlicePermissionActivity reads provider_pkg from intent, which can be
modified at will. As a result user might see incorrect package name in
the dialog granting slice permission.

Bug: 159145361
Test: manual
Merged-In: I8b66c02786df4096dad74b7e76255d5ddd1d609d
Change-Id: I8b66c02786df4096dad74b7e76255d5ddd1d609d
(cherry picked from commit 0ad32a2d70)
2020-09-24 15:33:58 -07:00
Pinyao Ting
149bb7e038 Fix the issue provider can be wrong when requesting slice permission
SlicePermissionActivity reads provider_pkg from intent, which can be
modified at will. As a result user might see incorrect package name in
the dialog granting slice permission.

Bug: 159145361
Test: manual
Merged-In: I8b66c02786df4096dad74b7e76255d5ddd1d609d
Change-Id: I8b66c02786df4096dad74b7e76255d5ddd1d609d
(cherry picked from commit 0ad32a2d70)
2020-09-24 19:06:32 +00:00
Pinyao Ting
e3eba1322b Fix the issue provider can be wrong when requesting slice permission
SlicePermissionActivity reads provider_pkg from intent, which can be
modified at will. As a result user might see incorrect package name in
the dialog granting slice permission.

Bug: 159145361
Test: manual
Merged-In: I8b66c02786df4096dad74b7e76255d5ddd1d609d
Change-Id: I8b66c02786df4096dad74b7e76255d5ddd1d609d
(cherry picked from commit 0ad32a2d70)
2020-09-24 19:06:07 +00:00
Ivan Chiang
c5c373c258 Revoke the uri permission when the file is deleted
When the file is deleted, renamed or moved, revoke all uri
permissions with the file

Bug: 157474195
Test: manual test with DocumentsUI
Test: atest DocumentsTest#testAfterMoveDocumentInStorage_revokeUriPermission
Change-Id: I4ffb183630aadb2d87b0965e8cecf88af15f4534
Merged-In: I4ffb183630aadb2d87b0965e8cecf88af15f4534
(cherry picked from commit 9efd606f43)
2020-08-26 07:23:34 +00:00
Steve Elliott
db245b0310 Mark implicit PendingIntents as immutable
Bug: 156020795
Test: manual, atest
Change-Id: I72206c7a52b067b77d6542d170a6483713dfeee7
(cherry picked from commit 84e08280d3)
2020-08-04 20:24:45 +00:00
Steve Elliott
599c3e4b75 Mark implicit PendingIntents as immutable
Bug: 156020795
Test: manual, atest
Change-Id: I72206c7a52b067b77d6542d170a6483713dfeee7
(cherry picked from commit 84e08280d3)
2020-08-04 20:22:46 +00:00
Steve Elliott
7f0fd285c6 Mark implicit PendingIntents as immutable
Bug: 156020795
Test: manual, atest
Change-Id: I72206c7a52b067b77d6542d170a6483713dfeee7
(cherry picked from commit 84e08280d3)
2020-08-04 20:21:51 +00:00
Lucas Dupin
6dbda27f98 Require a more specific intent
Bug: 147606347
Fixes: 161150380
Test: run poc, device didn't reboot
Change-Id: I8f721ca659d58271880a7adbf386b270b331e55b
Merged-In: I8f721ca659d58271880a7adbf386b270b331e55b
(cherry picked from commit a9afc32ddc)
(cherry picked from commit d16e86f466)
2020-07-28 23:49:31 +00:00
TreeHugger Robot
c83b93b3f1 Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev 2020-07-06 16:32:23 +00:00
Bill Yi
2ccfb6dc4d Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: Ib0a31852a6b6d623ee06130fdb80d402afa2f4b4
2020-07-06 07:15:02 -07:00
TreeHugger Robot
cc4a65b365 Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev 2020-07-06 13:54:29 +00:00
TreeHugger Robot
1cdb57b79a Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev 2020-07-06 13:53:09 +00:00