When notifications were blocked due to proximity, the heads
up would never show until unlocked. We're now showing it
when the screen turns on.
This also avoids the header to be shown while the
notifications are fully collapsed, since that was the
only element that changed before.
Fixes: 137711785
Test: get hun in pocket, pull out, observe notification visible
Change-Id: I9c3d0cdc341eb2d95bcb76099e59b0d561f81210
This change stops the animation because there isn't a
transition from the no-header state to the music header
state when turning the screen off (to AOD). Since there
isn't a transition, there isn't an animation.
This assumes that there isn't a transition from unlocked to
lock screen. If there is, then there would be an animation
of the music going away while arriving at the lock screen.
Fixes: 137383007
Test: Checked repro steps in bug, clock doesn't animate.
Test: Also checked repro steps when audio is paused, clock doesn't
animate.
Test: atest KeyguardSliceProviderTest.java
Change-Id: If39777340b72bc623d6690bc4f784c7f5c26ea8d
Because we were listening to the tuning value but not
actually handling the null default value, the visibility
of the silent icons would be wrong by default.
Additionally, the whole settings check isn't actually
needed since we are already limited to the visible
notifications in the notification list and therefore
the setting is already automatically applied.
Fixes: 137977737
Test: atest SystemUItests
Change-Id: I93e23b08525c6bb8d2219a4bdaa0bbc64ce55d8d
The position of the background could be 0 and therefore the
background could fly over the whole screen.
We're now positioning the top section at the start
of the first visible section.
Fixes: 137885070
Test: atest SystemUiTests
Change-Id: I6720b570f5cd209249b90681cdf6c6a56cf0194e
We were getting an NPE because the superclass was
calling an overridden method on its constructor,
before the variable could be initialized.
Test: atest ScrimControllerTest
Fixes: 137665467
Fixes: 137878476
Change-Id: I8914eac86cac19d92a68a2d55d97dfcee4066ed3
(cherry picked from commit 1c72bc2151)
Prox can be noisy and should only be used as a fallback when a more
robust sensor implementation is not available.
Test: manually cover prox sensor
Test: breakpoint
Test: dumpsys
Fixes: 137451005
Change-Id: If0fca42aca36546942930ce76be1353129fc91fc
Since the headsUpManager is calling out in various places to
its listeners, the callbacks may query the headsupmanager
in an internally inconsistent state, such that the pinned mode is
true but there is no topEntry. Let's add a null-check for
safety here.
Bug: 137804505
Test: atest SystemUITests
Change-Id: Ibae76b555ca51ccf676228b034a614d59a8b4e8e
Sensors might disable the screen, setting the machine state to
DOZE. We need to update the clock when the screen turns on.
Fixes: 137943236
Test: turn off screen with sensor, wait for a few minutes, come back
Change-Id: I633568294aa24bfea6765accc08ccf23f9c6bec1
KeyguardUpdateMonitor#isUnlockWithFacePossible was returning true
when the user had disabled face unlock.
This was causing bypass to still be enabled (hiding all notifications)
and bouncer was also being delayed, even though we were not scanning.
Fixes: 134977472
Test: auth with bypass (toggling face auth setting on/off)
Test: auth without bypass (toggling face auth setting on/off)
Change-Id: I234eb303db87fe0dafa2073a9bdf819c665018d6
This also ensures that the FalsingManagerProxy cleans up its internal instance
whenever a Phenotype flag changes.
Bug: 71762354
Test: atest SystemUITests
Change-Id: I9fa4d1344bb184dea00f92f8d265667f0be11466
We recently fixed the logic where notifications are being displayed
if multiple huns are showing, however we were not clipping to them.
We're now clipping heads up notifications as well by the clipTopAmount
Fixes: 136914021
Test: add two different sized HUNS, so weird overlap.
Change-Id: I68a4c373eff3952b1a4711858c9ce61684f6ff17
Let's not play the lock icon animation if the keyguard had just
become visible. Otherwise it will look like we're locking the phone,
and it was already locked earlier.
Test: manual
Fixes: 137691015
Change-Id: I2486cfff3efbbb30d23ce4b68962dd352a2e60b7
The lock icon and the scrim now fade with the same quick unlock animation
like the rest of the bypass, which completes the experience
Fixes: 134952761
Change-Id: Id164914e0e8d780e626acb28922c2084257620f9
Use slower animation when turning on the display, and request
a black frame when going to sleep.
Fixes: 137398766
Test: Wake up with presence sensor
Test: Wake up by uncovering prox sensor
Test: Wake up by pressing power (with AOD on or off)
Test: Receive notification from AOD
Change-Id: Ic3201e4c6b9de3d1322c9473897bca21fe63f773
Fixes the issue where only one SIM's PIN is checked when unlocking.
This undoes behavior changes introduced in aosp/769050
Test: manually verify with single and dual SIM that SIM PIN functions
correctly with different lockscreen settings
Bug: 135496265
Change-Id: I8db4565c4e5d5bcfb166b5962e878531a84dbafb
Test: atest BiometricsUnlockControllerTest
Test: dismiss bouncer after hitting reply button
Test: hit back on bouncer on shade_locked
Test: tap on padlock on camera app, swipe up to retry
Bug: 134096479
Fixes: 137517676
Change-Id: I12e5bbd2c5ceac642a281fc16c5398e09e65ca9d
When the FalsingManager gets reloaded (due to plugins) it can
leak its listeners and callbacks. This change fixes that.
Bug: 136351609
Test: manual
Change-Id: I2b52d018d478dbcad4ecb7d8a5b361638d5c5877
Merged-In: I2b52d018d478dbcad4ecb7d8a5b361638d5c5877
