Commit Graph

1049 Commits

Author SHA1 Message Date
TreeHugger Robot
924367f6ed Merge "Implement QS spec." 2018-02-28 14:14:16 +00:00
TreeHugger Robot
a65d4f8587 Merge "Add AOD to BatterySaverPolicy" 2018-02-28 00:41:32 +00:00
TreeHugger Robot
daa44c28d6 Merge "Show next alarm on ambient display" 2018-02-28 00:19:29 +00:00
TreeHugger Robot
9e9fc28b73 Merge "Remove leftover alarm code (Due diligence)" 2018-02-27 23:53:54 +00:00
Amin Shaikh
d620def5f4 Implement QS spec.
- Update padding between QS tiles
- Add margins in the QS header for larger width devices
- Update carrier text length in QS footer and fix animation overlap
- Fix TouchAnimator to linearly interpolate more than 2 keyframe values

Bug: 73312177
Test: visual
Change-Id: I8da031437fc78ef1fb86797237711ac92a860616
2018-02-27 23:47:30 +00:00
Lucas Dupin
1f7374a276 Show next alarm on ambient display
Next alarm will be visible 12h before triggering.

Test: Set alarm that will ring in 8h
Test: Set alarm that will ring in 14h
Test: Set alarm that will ring in 11:59, wait one minute
Test: atest packages/SystemUI/tests/src/com/android/systemui/keyguard/KeyguardSliceProviderTest.java
Change-Id: Icd4253771efcdf5afb4e9e52329fa410d7fd1cc1
2018-02-27 14:35:44 -08:00
Rohan Shah
738bc0c8f1 Remove leftover alarm code (Due diligence)
ag/3659178 was merged without removing extra alarm tile code. Cleaned up
the unnecessary bits in this CL.

Test: Visually and ran AutoTileManagerTest as confirmation
Bug: 73764084
Change-Id: I55fa39775ba9f4092034bd1273dfa1c2848c3953
2018-02-27 12:25:38 -08:00
Lucas Dupin
92a62e5533 Add AOD to BatterySaverPolicy
Test: activate/deactivate battery saver, look at AOD
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/BatteryControllerTest.java
Fixes: 62797110
Change-Id: I9fc5f4fc5aa9cfd45e90e602251e4c2c863dfbcc
2018-02-27 09:05:09 -08:00
Lucas Dupin
32febef04d Merge "Ignore rebroadcasts of ACTION_SIM_STATE_CHANGED" 2018-02-27 02:40:36 +00:00
Lucas Dupin
b380c882a2 Fix scrim busyness regression
Scrim opacity on the keyguard should vary according to how many
notifications are visible.
A busy lock screen has a more opaque scrim, and an empty lock screen
has a more transparent scrim.

Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Test: swipe away or receive notifications on the keyguard
Change-Id: I672b5e1a82d65dd326b40069d61223c3c0161493
2018-02-27 00:19:24 +00:00
Lucas Dupin
5e0f0d27ca Ignore rebroadcasts of ACTION_SIM_STATE_CHANGED
Telephony will rebroadcast ACTION_SIM_STATE_CHANGED with
EXTRA_REBROADCAST_ON_UNLOCK set to true to indicated
that an old message is being reposted for backwards
compatibility purposes.

System UI is direct-boot-aware and can should these
broadcasts.

Test: atest packages/SystemUI/tests/src/com/android/keyguard/KeyguardUpdateMonitorTest.java
Change-Id: Ie1c092f06f32f124cca68d2561b50038af6dc38f
Fixes: 68546898
2018-02-26 13:32:16 -08:00
Petr Cermak
7ef7812c7b Tear down broadcast receiver in RemoteInputView and SmartReplyView tests
Bug: 73803843
Test: atest RemoteInputViewTest SmartReplyViewTest
Change-Id: Iea933874fd76d445971864c743dd02b20ff1e1e9
2018-02-26 12:45:09 +00:00
TreeHugger Robot
e2cf16bfb0 Merge "Revert "Disabled presubmit for flakey test"" 2018-02-23 20:18:23 +00:00
Lucas Dupin
bfb36c3f20 Merge "Ensure keyguard slice use correct colors" 2018-02-23 17:21:27 +00:00
Selim Cinek
d87fdecc9f Revert "Disabled presubmit for flakey test"
This reverts commit 5bdfb4c1bd.

Reason for revert: fixed the flakyness in ag/3650459

Change-Id: I4a73a0f82a087fb59da79f286e98f0e1f88693b5
2018-02-23 03:37:31 +00:00
Selim Cinek
6fb936f814 Merge "Fixed an issue with a test that didn't work properly" 2018-02-23 03:35:40 +00:00
Selim Cinek
9a236f780d Fixed an issue with a test that didn't work properly
This was causing tool failures.

Change-Id: Ia29b2b22dc1e0bf53dfd664280fd69dc110e020b
Fixes: 73791701
Test: runtest systemui
2018-02-22 19:26:53 -08:00
Lucas Dupin
f8e274c422 Ensure keyguard slice use correct colors
Change-Id: I0406f8092583174e60ee5c89a71047288cbe480a
Fixes: 73538050
Test: atest packages/SystemUI/tests/src/com/android/keyguard/KeyguardSliceViewTest.java
2018-02-22 17:03:20 -08:00
Selim Cinek
5bdfb4c1bd Disabled presubmit for flakey test
Test: runtest systemui
Change-Id: If772052b2c172e62a22958f9996436914d8e8e1b
2018-02-22 16:13:22 -08:00
Selim Cinek
bdbf458844 Fixed a NP when replying to a message
The visbilityChanged listener is only set up later,
so we'll have to add a nullcheck for it.

Change-Id: I1f5843f02fd9c8fc20e26f1de47911e5eb533471
Fixes: 73758799
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/RemoteInputViewTest.java
2018-02-22 09:50:24 -08:00
Julia Reynolds
ee57193bb6 New small volume dialog
- Remove labels
- Remove output chooser dialog
- Reorder icons
- Add settings affordance
- Add instructive toast

Test: manual
Change-Id: I6640fb8147707936fe22e3c756ab29116973fbe3
Fixes: 73719758
Fixes: 73333233
Fixes: 71663761
2018-02-22 10:10:42 -05:00
TreeHugger Robot
f45f121a76 Merge "Fix opacity of expanded shade during transitions" 2018-02-21 21:54:33 +00:00
Lucas Dupin
80a3fcc3f5 Fix opacity of expanded shade during transitions
Change-Id: I480e558113cd9f31b7548002265e9b4b78b0ddad
Fixes: 70351996
Fixes: 71443237
Fixes: 73311721
Fixes: 72757727
Test: packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Test: unlock with fp. pattern
Test: pull down shade adjust brightness on bouncer and launcher
Test: unlock with fingerprint from pulsing notification
2018-02-21 19:43:38 +00:00
Rohan Shah
db2cfa3609 [QS] Add header tooltip for long press
Added some hooks in animator to pass along expanded/animating/collapsed
state in a more clear manner. Added tooltip view with the teaser text to
animate in at the top of the view (and fade out either when we start
animating or automatically after 5 seconds).

Added prefs for tracking how often tooltip is shown/hiding it based on
that number.

Updated dimensions for correct spacing (based on redlines).

Test: Visually
Bug: 72528203

Change-Id: I70e4654ed95057fac6d8dbb890d575c2a5d9f215
2018-02-21 10:12:33 -08:00
TreeHugger Robot
f084a7a40f Merge "Switch to inline mockito for a bunch of tests" 2018-02-18 19:43:54 +00:00
Jason Monk
1fc931a38a Switch to inline mockito for a bunch of tests
So we can mock final stuff

Test: The tests
Change-Id: Ia3a47c6655c4b0b9af0aea0ee6f8f6cb9ebaab09
2018-02-18 13:02:25 -05:00
TreeHugger Robot
8434214c17 Merge "Custom SmartReplyView layout" 2018-02-16 21:43:37 +00:00
Petr Cermak
102431d5eb Custom SmartReplyView layout
Implement SmartReplyView#onMeasure and SmartReplyView#onLayout according
to the redlines in go/p-notifications:

  * Smart reply buttons can have at most 2 lines of text.
  * Squeeze buttons to 2 lines of text when necessary to fit more
    buttons.
  * Don't show buttons which have more than 2 lines of text or don't fit
    within the notification width.
  * Update button background and text color.

Screenshot: https://screenshot.googleplex.com/cSM6Ve7qjb3.png

Bug: 67765414
Test: atest SmartReplyViewTest
Change-Id: Ia161c7f5669e7aef1b8c3480a8836784f0bde055
2018-02-16 17:30:45 +00:00
Evan Laird
2144158a26 Merge "Revert "[QS] Add header tooltip for long press"" 2018-02-16 15:37:22 +00:00
Evan Laird
92fbcb2f91 Revert "[QS] Add header tooltip for long press"
This reverts commit 22caf078e4.

Reason for revert: Quick settings is no longer expanding properly. Reverting this fixes it

Change-Id: I63b82e948316726067214b088016661785982e3a
2018-02-16 15:25:53 +00:00
Rohan Shah
100d494bae Merge "[QS] Add header tooltip for long press" 2018-02-15 17:50:27 +00:00
TreeHugger Robot
9ec308d29b Merge "Revert "Fix opacity of expanded shade during transitions"" 2018-02-15 04:32:29 +00:00
Lucas Dupin
f4fcd5e094 Revert "Fix opacity of expanded shade during transitions"
This reverts commit ee98ccb0a3.

Reason for revert: Causing b/73349375

Change-Id: Ie2cd15ed0522f7768035beb04853a6432be111a9
Fixes: 73349375
2018-02-15 01:15:53 +00:00
TreeHugger Robot
d91f35fb96 Merge "Fix opacity of expanded shade during transitions" 2018-02-13 23:09:52 +00:00
TreeHugger Robot
e047522ece Merge "Do not show blocking helper if user likes channel" 2018-02-12 22:30:26 +00:00
Rohan Shah
22caf078e4 [QS] Add header tooltip for long press
Added some hooks in animator to pass along expanded/animating/collapsed
state in a more clear manner. Added tooltip view with the teaser text to
animate in at the top of the view (and fade out either when we start
animating or automatically after 5 seconds).

Added prefs for tracking how often tooltip is shown/hiding it based on
that number.

Updated dimensions for correct spacing (based on redlines).

Test: Visually
Bug: 72528203
Change-Id: Ided991da43fbede43c84c53ef22688d21aabe291
2018-02-12 11:50:03 -08:00
TreeHugger Robot
6b83824afa Merge "Move SignalDrawable to SettingsLib so every can enjoy it" 2018-02-12 19:49:29 +00:00
Julia Reynolds
c65656ae7d Do not show blocking helper if user likes channel
If a user has previously explicitly set the importance of
a notification, assume the user sentiment is postive regardless of what
the assistant suggests.

Test: runtest systemui,  runtest systemui-notification
Change-Id: I646f0878fb5bb2a28ba17fd0ec11c8cdb64b611d
Fixes: 73231297
2018-02-12 13:18:38 -05:00
Petr Cermak
10011fa917 Replace smart reply boolean setting with key-value list
This patch replaces the recently introduced
Settings.Global.ENABLE_SMART_REPLIES_IN_NOTIFICATIONS boolean setting
with a new Settings.Global.SMART_REPLIES_IN_NOTIFICATIONS_FLAGS
key-value list.

Rationale: This will allow us to add and tweak smart reply parameters
without polluting the global settings namespace.

Bug: 67765414
Test: atest SmartReplyConstantsTest
Change-Id: I284bb6b31618a234c4772d16ad6190a713035f1b
2018-02-12 09:40:37 +00:00
Lucas Dupin
ee98ccb0a3 Fix opacity of expanded shade during transitions
Change-Id: I2dba88ea52b58d12fc2a858639d270b41403a22c
Fixes: 70351996
Fixes: 71443237
Test: packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Test: unlock wit fp. pattern
Test: pull down shade adjust brightness on bouncer and launcher
Test: unlock with fingerprint from pulsin notification
2018-02-11 10:24:41 -08:00
Evan Laird
06e9fd822b Move SignalDrawable to SettingsLib so every can enjoy it
Anyone with a dependecy on SettingsLib should be able to create and use
a platform SignalDrawable.

Test: runtest systemui; visual
Change-Id: I65caa2ac69cae52b6ad798937df3f3399ab406af
Fixes: 72511183
2018-02-10 09:36:55 -08:00
Lucas Dupin
67f77a34e6 Merge "Remove black frame when pulsing" 2018-02-09 17:50:37 +00:00
Salvador Martinez
3630796861 Update time based triggering logic to guard against spam
Since the time based estimate takes recent usage into account we
could get a situation where the notification could trigger many
times. This CL makes it so the notification can only trigger at most
twice per charge cycle. The percentage based triggering remains
unaffected.

Test: SysUI Tests
Bug: 27567513
Change-Id: I81e29f96ac97b0d1a177e923c16d5f2800da404a
2018-02-08 19:17:06 -08:00
Lucas Dupin
12663d30ba Remove black frame when pulsing
Fixes: 73121392
Test: Receive notification on AOD
Change-Id: I04802b3b456e2c484fc5aaab8460a08b82f952e4
2018-02-08 16:10:09 -08:00
Narayan Kamath
945356ac0f Merge "SystemUI: Remove obsolete dependency on android.car." 2018-02-08 12:40:53 +00:00
TreeHugger Robot
853f4c244b Merge "Split HeadsUpManager implementation to HeadsUpManagerPhone (2nd try)" 2018-02-08 05:30:35 +00:00
TreeHugger Robot
9555c952da Merge "Add shared strings to settingsLib" 2018-02-07 22:15:29 +00:00
Alison Cichowlas
0ab4ea3ef2 Merge "Ignore flaky test. See discussion on bug." 2018-02-07 19:24:27 +00:00
Salvador Martinez
eb9ab29ec6 Add shared strings to settingsLib
Now that hybrid notifications exist in SysUI these strings should
be moved into settingsLib so we don't duplicate them. Additionally
several utility methods were moved so that they could be shared to
help keep behavior and strings consistent between different system
components that show battery time remaining.

Test: robotests
Bug: 65656091
Bug: 66909350
Bug: 67469159
Change-Id: Ifdaf02cf39354ed0088560490eabf8b101788a83
2018-02-07 10:55:42 -08:00
Lucas Dupin
d1fac203ad Merge "Display blanking logic improvements" 2018-02-07 00:34:28 +00:00