Commit Graph

9346 Commits

Author SHA1 Message Date
Steven Moreland
df7675f1cb Merge "Don't use cutils/Atomic.h" am: 07735797a2 am: a272d540d8
am: 0f4ca4a5c0

Change-Id: I4b9798b39d890537f888415b5ac283227970e4de
2018-02-28 14:13:52 +00:00
Steven Moreland
0f4ca4a5c0 Merge "Don't use cutils/Atomic.h" am: 07735797a2
am: a272d540d8

Change-Id: Ie442c255e43f2ebe80ef5423aa4508930d72c44c
2018-02-28 14:01:17 +00:00
TreeHugger Robot
ec98448f15 Merge "Implement a new section to attach LAST_KMSG to incident report This section simply gzip a large file and stores result in GZippedFileProto" 2018-02-28 03:02:16 +00:00
TreeHugger Robot
f3537c2054 Merge "Updates jank metrics in statsd to include uid." 2018-02-27 20:47:33 +00:00
Yi Jin
1a11fa1097 Implement a new section to attach LAST_KMSG to incident report
This section simply gzip a large file and stores result in GZippedFileProto

This greatly improves the size, before gzip, the last kmsg size ~500KB,
after gzip the proto size is ~60KB.

Bug: 73354384
Test: atest incidentd_test and manual on device test
Change-Id: I9bfc2cf07384487671edbffb5f0bd8495608fea6
2018-02-27 11:36:29 -08:00
TreeHugger Robot
255ed5cbdc Merge "[Magnifier-26] Wire up frame callback for realsies" 2018-02-27 02:13:46 +00:00
David Chen
77ef671c41 Updates jank metrics in statsd to include uid.
We need the uid to easily know which app to blame for producing the
frame with excessively long render time. Also updates the errors so
it's more obvious if the error is in parsing versus the other checks.

Test: Test that statsd builds and verified CTS test still passes.
Change-Id: Ib6518f2d9fe6f9c78d548b6dcbdb67a0f211ff5c
2018-02-26 17:18:20 -08:00
Mihai Popa
9568800d90 [Magnifier-26] Wire up frame callback for realsies
Test: none yet
Bug: 73810478
Bug: 72041926
Change-Id: I7154ed4b3d2cd820dc8c8ff55eed130be87d1606
2018-02-26 11:23:27 -08:00
TreeHugger Robot
be01248470 Merge "Remove obsolete pragma statements" 2018-02-26 15:38:58 +00:00
Siarhei Vishniakou
bfd4914b60 Remove obsolete pragma statements
These pragma statements used to guard against compiler warnings in Sk..
code. They are no longer necessary.

Test: make
Change-Id: I9f7f88276edb546ba08c7344c142eb487a04f978
2018-02-23 15:48:10 -08:00
Steven Moreland
fb7952f57e Don't use cutils/Atomic.h
Test: builds
Change-Id: I74485a5cbecb8710714f7bf3e54da61dd787838f
2018-02-23 15:02:42 -08:00
Leon Scroggins
08ddee7303 Merge "Add AnimatedImageDrawable.getLoopCount" 2018-02-23 20:39:21 +00:00
Greg Daniel
c9a8945477 Update call to null out GrVkAlloc in VulkanManager
Test: manual testing

Change-Id: Ia0af7526cad2dc4614afc73c31bf07e25890c677
2018-02-23 13:16:59 -05:00
Leon Scroggins III
1474b78888 Add AnimatedImageDrawable.getLoopCount
Bug: 73791004
Test: Id0335f15fdf0ebdc16d1edcabca547b9399c506f
Change-Id: I1c048196e45b91a1039c1f89e2176592765d2967
2018-02-23 09:43:00 -05:00
TreeHugger Robot
a64f88700b Merge "Need to add report id and sequence number to uniquely mark a incident report data." 2018-02-20 20:09:51 +00:00
Yi Jin
41d6192401 Need to add report id and sequence number to uniquely mark a incident
report data.

Bug: b/65451198
Test: N/A
Change-Id: I12f2c80c57e00e92888a295d432f2ec7e0d95ffd
2018-02-20 10:32:27 -08:00
TreeHugger Robot
8b3a832cdd Merge "Remove Skia RenderPipeline saveLayer logic for software layers." 2018-02-20 18:09:04 +00:00
Derek Sollenberger
52230bc215 Remove Skia RenderPipeline saveLayer logic for software layers.
Test: CtsUiRenderingTestCases:LayerTests
Bug: 72052698
Change-Id: Ief845c409755e6bc61849a6ab3506ef60161f231
2018-02-20 10:59:44 -05:00
Yi Jin
329130b7e4 Put metadata or stats into each dropbox incident report.
Bug: 65451198
Test: atest incidentd_test
Change-Id: Ib406b177ad7f1b4bda7fef2e606fc66a9836e060
2018-02-14 16:12:57 -08:00
TreeHugger Robot
b1c36318f7 Merge "Fix AnimatedImageDrawable drawn in software" 2018-02-12 20:38:17 +00:00
TreeHugger Robot
d6d5e0cc77 Merge changes from topic "revert-assetmanager2-02-09-2018"
* changes:
  Revert "Replace AssetManager with AssetManager2 implementation"
  Revert "libandroidfw: Make sure to set the 'app as lib' flag"
  Revert "Make idiomatic use of ApkAssets and AssetManager"
  Revert "libandroidfw: Add ApplyStyle and SetConfiguration benchmark"
  Revert "libandroidfw: Improve performance of AssetManager2"
  Revert "AssetManager2: Allow out of order type/type spec"
  Revert "AssetManager2: Fix list function"
  Revert "AssetManager2: Fix issue with native cast"
2018-02-10 03:42:41 +00:00
TreeHugger Robot
a27ae0fdd1 Merge "Add clear method to ProtoOutputStream so it is reusable by just rewinding its internal pointer." 2018-02-10 02:20:30 +00:00
Yi Jin
7f9e63b632 Add clear method to ProtoOutputStream so it is reusable by just
rewinding its internal pointer.

Bug: 72319159
Test: atest incidentd_test and atest statsd_test
Change-Id: Id046b987a7460d68300e5d4d46ae56aec1eba2d0
2018-02-09 14:20:48 -08:00
Leon Scroggins III
d935157f48 Fix AnimatedImageDrawable drawn in software
Test: Manual, existing CTS, I4e884636801c0a2e920ca9d99f3c38fb034b3774

- Fix a bug where the animation never advanced.
- Rename mFinished to mStarting. It was already being used to indicate
that we were restarting anyway. Now only set it to true in calls to
start().
- Prevent skipping ahead the same way we do in hardware.
- Return kFinished when reaching the last frame of the animation.

This also includes a fix for hardware drawing. The first time start() is
called, there is no need to create a snapshot of the first frame. Just
draw the first frame directly and kick off a decode of the second frame.

Change-Id: I0a6fb909a361dd4c233cfa2d79bc2210d2dcddc8
2018-02-09 16:31:25 -05:00
Adam Lesinski
bde1df21ad Revert "Replace AssetManager with AssetManager2 implementation"
This reverts commit 1187590da3.

Bug: 73134570
Change-Id: I59b4d714e447478ea124f086356f127f42251fb7
2018-02-09 12:43:24 -08:00
Adam Lesinski
2a447172a5 Revert "libandroidfw: Make sure to set the 'app as lib' flag"
This reverts commit 9ad287c828.

Bug: 73134570
Change-Id: If930d3a7c17fc2f7ffaebd31281ad5a5d120144f
2018-02-09 12:43:17 -08:00
Adam Lesinski
c9a9c1c1c3 Revert "libandroidfw: Add ApplyStyle and SetConfiguration benchmark"
This reverts commit 59f63bd801.

Bug: 73134570
Change-Id: I6ace34b0d6545ff001664792b0bb1bbff5b5cbbe
2018-02-09 12:43:13 -08:00
Adam Lesinski
b8b3a26194 Revert "libandroidfw: Improve performance of AssetManager2"
This reverts commit 88c9959e5b.

Bug: 73134570
Change-Id: I012643d2b4212cef5aef68feb4146add34f9ecfc
2018-02-09 12:43:10 -08:00
Adam Lesinski
dfeb7ceb2a Revert "AssetManager2: Allow out of order type/type spec"
This reverts commit 78695c3543.

Bug: 73134570
Change-Id: I6acc35372d9071d067d2fb7caa775ee9ba689811
2018-02-09 12:43:07 -08:00
Adam Lesinski
ec7f06cc37 Revert "AssetManager2: Fix list function"
This reverts commit adc0b87ec2.

Bug:73134570
Change-Id: I9e652245e7661eb7a34dadb5f363a08bc8c9e57e
2018-02-09 12:43:04 -08:00
Mike Reed
6b6e66d521 use writepixels on surface, the canvas version is deprecated
Test: make

Change-Id: I6af16bf4a8c9952d2e493cbd34b6db58d581a694
2018-02-09 12:06:01 -05:00
TreeHugger Robot
7b575e528d Merge "SkColorTypeShiftPerPixel is deprecated" 2018-02-09 15:55:34 +00:00
TreeHugger Robot
a9bf9d166a Merge "AssetManager2: Fix list function" 2018-02-09 08:18:16 +00:00
Adam Lesinski
adc0b87ec2 AssetManager2: Fix list function
List was skipping directories. Include them, and add tests to ensure
the order and precedence is correct.

Bug: 72511641
Test: make libandroidfw_tests
Test: atest CtsContentTestCases:AssetManagerTest
Change-Id: Iadf45883283d3e4aae93bd7c3343745912e34fa0
2018-02-08 22:37:48 -08:00
TreeHugger Robot
e5ffb6aabe Merge "Fix the Skia roll - implement onWritePixels" 2018-02-09 04:55:27 +00:00
Adam Lesinski
05bbd43b93 Merge "AssetManager2: Allow out of order type/type spec" 2018-02-09 04:18:59 +00:00
Leon Scroggins III
71195ab5c8 Fix the Skia roll - implement onWritePixels
Test: None

https://skia-review.googlesource.com/c/skia/+/105623 added a new
abstract method to SkSurface_Base, so these subclasses needs to
implement it. Implementation is empty just to get the roll fixed.

Change-Id: Ib6029acf40feb47a572cd6e18678b08a6f38fe4b
2018-02-08 22:09:59 -05:00
Adam Lesinski
78695c3543 AssetManager2: Allow out of order type/type spec
AssetManager2 assumes that RES_TABLE_TYPE_SPEC_TYPEs must immediately
precede their associated RES_TABLE_TYPE_TYPEs. This is not correct.
RES_TABLE_TYPE_SPEC_TYPEs must precede their associated
RES_TABLE_TYPE_TYPEs, but they do not need to immediately precede them.

For example, this is what we currently expect:

  RES_TABLE_TYPE_SPEC_TYPE id=1
  RES_TABLE_TYPE_TYPE id=1
  RES_TABLE_TYPE_SPEC_TYPE id=2
  RES_TABLE_TYPE_TYPE id=2

but this is also valid:

  RES_TABLE_TYPE_SPEC_TYPE id=1
  RES_TABLE_TYPE_SPEC_TYPE id=2
  RES_TABLE_TYPE_TYPE id=1
  RES_TABLE_TYPE_TYPE id=2

Bug: 73052092
Test: make libandroidfw_tests
Change-Id: I1f3c43760f8108eee24c2c6ed7bc16f70e951c2b
2018-02-08 15:16:32 -08:00
Stan Iliev
7717e22c85 Draw text with a hairline stroke as if it is fill style
Dew to a side effect of HWUI opengl pipeline, the hairline stroke
is not respected, but it is drawn as a fill style. Implement the
same behaviour for skiagl pipeline with SDK API 27 and older.
On SDK released with Android P, the hairline stroke is respected.

Bug: 72494357
Test: Ran duolingo app
Change-Id: I48bdcf3ddec4bf65b5e93e01c5002177c4e3da90
2018-02-08 23:04:47 +00:00
TreeHugger Robot
5b5e00aca1 Merge "Cache VectorDrawable bounds at record time" 2018-02-08 20:43:20 +00:00
Stan Iliev
65e678fdb1 Cache VectorDrawable bounds at record time
Cache VectorDrawable bounds at record time, because the same
drawable object may be used several times with different bounds.

Bug: 71737362
Test: Wrote a new unit test, tried sample app attached to the bug
Change-Id: If7be934acf0c16b328cb0f95d849e463dcd3b88b
2018-02-08 19:01:08 +00:00
Mike Reed
937c694080 SkColorTypeShiftPerPixel is deprecated
Test: make

Change-Id: Ib55e1d8d0bd173be0d5afa70b40fa0d867e20fd1
2018-02-08 11:36:56 -05:00
Seigo Nonaka
0606a8874d Use new minikin::Font constructor
This is 2nd attempt of I4d7af881ed1a6c

Bug: 37567215
Test: minikin_tests
Test: hwui_unit_tests
Test: atest CtsTextTestCases \
      CtsWidgetTestCases:EditTextTest \
      CtsWidgetTestCases:TextViewFadingEdgeTest \
      FrameworksCoreTests:TextViewFallbackLineSpacingTest \
      FrameworksCoreTests:TextViewTest FrameworksCoreTests:TypefaceTest \
      CtsGraphicsTestCases:TypefaceTest CtsWidgetTestCases:TextViewTest
Test: bit  FrameworksCoreTests:android.text.

Change-Id: I596c67b9453688f998a88031b9724425e2305b20
2018-02-07 13:10:35 -08:00
Seigo Nonaka
ecc00786d0 Merge "Revert "Use new minikin::Font constructor"" 2018-02-07 19:06:26 +00:00
Seigo Nonaka
36dadcfc7e Revert "Use new minikin::Font constructor"
This causes a regression for some characters

This reverts commit ab40df9e69.

Bug: 73054061
Change-Id: Icf1f9d2b89b75031aabb47507135e45a21bc5363
2018-02-07 18:38:58 +00:00
TreeHugger Robot
dd3afdb483 Merge "remove unused/deprecated flags from savelayer" 2018-02-06 23:43:42 +00:00
TreeHugger Robot
451832a5ed Merge "Use new minikin::Font constructor" 2018-02-06 22:47:46 +00:00
Mike Reed
58978e182f remove unused/deprecated flags from savelayer
Test: make

Change-Id: I39e41a80430dca7878e6983b098c1c4541904fd1
2018-02-06 16:18:47 -05:00
Adam Lesinski
88c9959e5b libandroidfw: Improve performance of AssetManager2
AssetManager2 relied on creating a list of configurations
present in the resource table so as to avoid copying and
converting ResTable_config's from the APK on every
resource retrieval.

ResTable, however, had a better optimization that pruned
the configurations that didn't match the currently set
configuration. This vastly reduced the number of ResTable_configs
to test.

In this CL, AssetManager2 follows suite with this optimization
and only maintains the filtered ResTable_configs, falling back
to the slow path when the configuration is overridden.

Test: mma frameworks/base/libs/androidfw
Test: adb sync system data
Test: adb shell /data/benchmarktest64/libandroidfw_benchmarks/libandroidfw_benchmarks
Change-Id: Ib57b75fbb32e1d310eec146e5a12dfc6de4385f9
2018-02-05 18:38:57 -08:00
Adam Lesinski
59f63bd801 libandroidfw: Add ApplyStyle and SetConfiguration benchmark
Test: mma frameworks/base/libs/androidfw
Test: adb sync system data
Test: adb shell /data/benchmarktest64/libandroidfw_benchmarks/libandroidfw_benchmarks
Change-Id: Ia0e868008a3b32dc8d1c69ed1f2c39f152bb7815
2018-02-05 18:38:57 -08:00