Commit Graph

500 Commits

Author SHA1 Message Date
Hawkwood Glazier
a4649ba3bf Skip dynamic load of known clock plugins
Bug: 279933902
Test: Checked load/unload cycles on device
Change-Id: I80b403ba8544c6aded5c766fb7dba6322a12a37a
2023-06-06 18:26:22 +00:00
Hawkwood Glazier
24ec252394 Remove default impls from clock plugins
This appears to prevent crashes from dynamic loading failures when
building and deploying sysui & wpp from sysui studio instead of building
through soong.

Bug: 279049213
Test: Deployed wpp & sysui from sysui studio
Change-Id: I6225f9529898ef8c6f4953957fb83cf0cd2abda0
2023-05-28 16:22:23 +00:00
Hawkwood Glazier
5c0ab458fc Merge "Log weather information parsing" into udc-dev 2023-05-18 22:16:34 +00:00
Sherry Zhou
7a973036ec Merge "Fix clock scale in picker" into udc-dev 2023-05-17 17:36:46 +00:00
Sherry Zhou
49db8bd20f Fix clock scale in picker
Test: manual
Bug: 278023961
Change-Id: Iec777704376369dd358f29b8aa9376fbe5671b50
2023-05-16 03:28:33 +00:00
Aaron Liu
73af217e13 Remove legacy activity starter code
Fixes: 278273334
Fixes: 278761837
Test: Open settings from lockscreen, 7 days of team food testing and 7
days of released flag.

Change-Id: I73af77466f4a199dd743e62e48f7040c36e8cd8f
Merged-In: I73af77466f4a199dd743e62e48f7040c36e8cd8f
2023-05-15 13:31:11 -07:00
Hawkwood Glazier
1da9fa24c2 Log weather information parsing
Bug: 281993323
Test: Checked logs
Change-Id: I512365a43ecb054cf83842632700b21d310fb322
2023-05-12 23:09:58 +00:00
Darrell Shi
59ea47e0ab Log Monitor condition updates to TableLogBuffer.
This change introduces a plugin interface for TableLogBuffer so Monitor,
which is under the shared/ target, can communicate through it and log
condition updates in a table format.

Bug: 280816949
Fix: 280816949
Test: atest ConditionMonitorTest
Test: adb bugreport and verify conditions logged as table in ABT

Change-Id: Ib5d69bba61a190ed0426ab548d2129572ced376c
2023-05-11 16:43:04 +00:00
Hawkwood Glazier
a3ebc6b013 Do not proguard com.android.systemui.log
Defensively also add com.android.systemui.common

Bug: 280569676
Test: Manually checked crashlooping device
Change-Id: I4959d2853f7bedc3f699999085b8a32c19a23ece
2023-05-03 20:00:59 +00:00
Darrell Shi
46805d766a Merge "Revert^2 "Move LogBuffer and related to SystemUILogLib."" into udc-dev 2023-05-01 22:47:58 +00:00
Darrell Shi
1a21b366f9 Revert^2 "Move LogBuffer and related to SystemUILogLib."
d738e282ed

Change-Id: I93a842bdd9eca25a3bdca941232068a96bcf788d
2023-05-01 16:08:02 +00:00
Hawkwood Glazier
1c8c7247c6 Add a minor note about SystemUIPluginLib dependencies
Bug: 279941949
Test: N/A
Change-Id: Id624b67267ac8c7fd8c49ec558028c7d4f178589
2023-04-28 19:20:03 +00:00
Shawn Lee
8687d9736c Merge "Fixed QS tiles incorrectly clipping in landscape shade" into udc-dev 2023-04-28 00:13:47 +00:00
Priyanka Advani
293025ea05 Merge "Revert "Move LogBuffer and related to SystemUILogLib."" into udc-dev 2023-04-27 22:18:57 +00:00
Priyanka Advani
d738e282ed Revert "Move LogBuffer and related to SystemUILogLib."
Revert submission 22512633-sysui-log-lib

Reason for revert: b/279941949

Reverted changes: /q/submissionid:22512633-sysui-log-lib

Change-Id: I2af5254d848a12b533ca84bfdbb71c0f82637144
2023-04-27 18:59:56 +00:00
Darrell Shi
60e53b7a62 Merge "Move LogBuffer and related to SystemUILogLib." into udc-dev 2023-04-27 16:36:04 +00:00
Darrell Shi
17bdd50dde Move LogBuffer and related to SystemUILogLib.
This change
- creates a new logging library under /SystemUI/log/
- moves all classes under
  SystemUI/plugin/src/com/android/systemui/plugins/log/ into the new
  library

Test: verify LogBuffer works correctly on device
Test: atest LogBufferTest
Bug: 276475093
Change-Id: I0a963c660a288177be0f881312abffc84f95d5bf
2023-04-26 16:28:09 +00:00
Treehugger Robot
48fb7c5d5e Merge "Step clock animation: fix RTL issues and clean-up a little" into udc-dev 2023-04-26 15:05:54 +00:00
Christian Göllner
f5bc9b73cc Step clock animation: fix RTL issues and clean-up a little
- Leaves the bounds change animation be taken care of, by a
  `ChangeBounds` transition. This takes care of the clock moving
  correctly in RTL, and works well together with the burn-in animation
  (offset + scale) that happens when going from/to AOD.
- Changes the step clock animation logic to only update glyph offsets,
  instead of bounds + offsets.
- Removes the cancellation logic as it wasn't being used now, and was
  making the code more complicated to read.
- Renames a few methods, adds documentation, and tries to simplify the
  code a little bit.

Fixes: 274892412
Test: Manually - Going from/to AOD and posting/clearing notifications
      on lockscreen.
      Also took before/after videos and compared side by side.
Change-Id: I92f5c822a6b45ef5e4c5db680f9c795b3d8a5042
2023-04-25 10:55:19 +02:00
Shawn Lee
7b449d9101 Fixed QS tiles incorrectly clipping in landscape shade
When shade is in full width mode in landscape (i.e. on phones),
the QS tile clipping was incorrect due to the QS container view
having an inset to avoid the camera cutout. This inset needed to be
accounted for so the clipping would accurately mimic the shape of
the notifications scrim, which does not have an inset.

This only fixes the visible mismatch in QS tile clipping in landscape
mode; it does not fix the very subtle ~1-2 pixels mismatch in
QS tile clipping that is consistently visible in any orientation and
is most likely an anti-aliasing issue(?)

Bug: 267303661
Test: Manually verified QS tile clipping appears correct
Change-Id: I78421482b1c3f5e8eca355182aef0cdac2e4edfe
2023-04-24 15:15:25 -07:00
Aaron Liu
f3fc361a54 Add ActivityStarterImpl
This is a new class that will replace
ActivityStarterDelegate/CentralSurfaces/CentralSurfacesImpl for
ActivityStarter delegation.

Bug: 278273334
Test: Open notifications from lockscreen
Test: Open settings from quick settings

Change-Id: Ie4513c0850e9a79ede133aba52d7dc6ac0dfa04d
2023-04-20 15:47:19 -07:00
Aaron Liu
15e968754b Remove centralsurfaces activitystarter invocations
We want to ensure that ActivityStarterDelegate handles all activitystarter
invocations so that we can route these method to a separate class.

There should be no change in behavior as activitystarter delegate just
asks central surfaces to do these same invocations.

Bug: 278273334
Test: Unit tests
Test: Make sure it builds

Change-Id: I4af5b793ba9b8ab9091782cb17997039c8df2e4d
2023-04-20 09:15:52 -07:00
Xiaowen Lei
e0dfbbbe11 Merge "Update startPendingIntent to have a View v function parameter." into udc-dev 2023-04-19 16:21:30 +00:00
Hawkwood Glazier
6f3eb327f7 Change clock animations to be per-clock face
Also add a small Start Delay to StatusArea translation

Bug: 276733633
Bug: 276236565
Test: Manually looked at timing of animation
Change-Id: I6d77e53a4f80c8b860596797b3f982e116601167
2023-04-17 16:49:30 +00:00
Xiaowen Lei
fa365ee4be Update startPendingIntent to have a View v function parameter.
The `View v` parameter can be used to construct a custom
ActivityOptions for launching animations.

No behavior change.

Bug: 274104981
Test: N/A; passing existing tests.
Change-Id: I26f1f4c967a153697d4a6e38ea3a14b441c47bb5
2023-04-14 18:22:29 -07:00
Aaron Liu
358c7f6ddf Merge changes I85e60cfc,I82a5aea6 into udc-dev
* changes:
  Make getCurrentController async friendly.
  Add custom message to bouncer
2023-04-13 18:38:01 +00:00
Aaron Liu
8dd1644170 Add custom message to bouncer
Add a message to bouncer when we are showing to show the reason we are
authing bouncer. This is set in dismiss with action as we intend to
authenticate to perform some action.

Fixes: 277278610
Test: longpress lockscreen and open lockscreen settings. Open bouncer
with udfps enabled and not enabled.

Change-Id: I82a5aea6779a60e200921f0743882cd03305185c
2023-04-13 08:54:47 -07:00
Ned Burns
1acffcbe5e Merge "Correctly log buffer unfreeze events" into udc-dev 2023-04-13 14:55:47 +00:00
Ned Burns
a85afccbf1 Correctly log buffer unfreeze events
Previously the events were dropped on the floor since we were still
frozen.

Bug: 277974555
Test: atest
Change-Id: Ia6e26e8bc5226919d7b9797905bbd19f8503e7b2
2023-04-12 21:00:35 -04:00
Peter Kalauskas
a6eedbc470 New comment for WeatherStateIcon
Test: n/a
Bug: 276387860
Change-Id: Ic0735117b6e2363c937881a79132e38dbd7925fb
2023-04-11 18:06:55 +00:00
Hawkwood Glazier
2de7f45344 Move entire status view in AOD for some clocks
Bug: 275727037
Test: Manually checked new scaling
Change-Id: Ib635f7c6ccd76b6ffdcd451f5b900200e39ffeda
2023-04-10 23:51:41 +00:00
Sherry Zhou
6a92c172aa Merge "Revert "Revert "Polish Weather Clock""" into udc-dev 2023-04-09 00:43:15 +00:00
Sherry Zhou
459e7d6329 Revert "Revert "Polish Weather Clock""
This reverts commit e5c34615ea.

Reason for revert: Try to submit the change separately

Change-Id: I3bf6e641983866effb8d54044dea4a94b10ba93c
2023-04-07 22:39:24 +00:00
Sherry Zhou
756ee44b44 Merge "Revert "Polish Weather Clock"" into udc-dev 2023-04-07 22:15:14 +00:00
Sherry Zhou
e5c34615ea Revert "Polish Weather Clock"
Revert submission 22391223-polish_weather_clock

Reason for revert: This CL causes a build breakage.  

Reverted changes: /q/submissionid:22391223-polish_weather_clock

Change-Id: I4f294818f5ee620382b22dec6d82eae285da11d2
2023-04-07 21:54:58 +00:00
Treehugger Robot
857b09eb82 Merge "Polish Weather Clock" into udc-dev 2023-04-07 20:36:51 +00:00
Darrell Shi
6000632d38 Move RingBuffer to SystemUICommon.
This change adds a new module SystemUICommon and moves RingBuffer to
it. This is to prepare introducing a new logging library which would
depend on it.

Bug: 276475093
Test: RingBuffer does not have existing tests, so just verified
LogBuffer works correctly on device

Change-Id: Ib71fcf8526021be1ac3fe279210c54cb7d4cd0e6
2023-04-06 17:58:40 +00:00
Sherry Zhou
225d1777a2 Polish Weather Clock
Test: atest SimpleClockScreenshotTest
Bug: 275893959, 269227336
Change-Id: I0519416d20d6208836372d5e00258a8ecdd2ec03
2023-04-04 17:59:06 +00:00
Hawkwood Glazier
a2cc47dd51 Refactor various rendering parameters into config structure
Bug: 276770058
Test: Validated clock behavior functioned the same
Change-Id: I2cc02ca0d43155eabff614cf883c1d751fb3c974
2023-04-04 00:30:51 +00:00
Hawkwood Glazier
57405bd0a5 Additional Color Palettes
Bug: 274647325
Test: Checked new tonal specs
Change-Id: Iae852a80567e2f0420009eaac7022d3e8c194f48
2023-03-29 15:38:06 +00:00
Sherry Zhou
e851fbcae2 Add animations during swiping picker carousel
Test: atest SimpleClockScreenshotTest
Bug: 271159401
Change-Id: I0fac27de3bd6ef503192f4bbd0917d0f707b7a21
2023-03-28 23:05:26 +00:00
András Kurucz
2e2ddc0cea Remove unused code from SwipeHelper
SwipeHelper was always configured with the X direction and furthermore
the Y scrolling was broken with the ExpandableNotificationRow

Bug: 247866457
Test: atest NotificationSwipeHelperTest
Change-Id: Ib45df3f84f0851b99d9460f578ff154dc8e4a5f8
2023-03-27 15:32:37 +00:00
Hawkwood Glazier
f22fbb7e83 Optionally hide default keygaurd weather view
Bug: 274631066
Test: Manually checked relevant views on device
Change-Id: I8bbcd1f15d3c01a2f02d93dc96c4cd6d7afaaf60
2023-03-24 19:15:05 +00:00
Lucas Silva
236b845e2b Update notification FSI logic for when device is considered dreaming
This change uses StatusBarStateController to check if the device is
dreaming, since that state is based on the dreaming broadcasts which are
only sent after the dream has finished waking up. This means that
StatusBarContoller.isDreaming will remain true during the wake-up phase
of the dream, therefore allowing full-screen intents in notifications.

This change also removes the RPC to DreamManagerService, since the dream
state is locally cached in StatusBarController

Fixes: 265977861
Test: atest StatusBarStateControllerImplTest
Test: atest NotificationInterruptStateProviderImplTest
Test: atest CentralSurfacesImplTest
Change-Id: I8e97fdb064c4b23517d69498638769aac26f419f
2023-03-15 14:09:13 +00:00
Holly Jiuyu Sun
ccd9936912 Merge "Solve NPE." into tm-qpr-dev am: 9748eedae0 am: 1eca45e58d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/21752777

Change-Id: Ie5b148d3c999dc3dead64fe0e858b40a316e6dc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-13 22:04:19 +00:00
Holly Jiuyu Sun
9748eedae0 Merge "Solve NPE." into tm-qpr-dev 2023-03-13 21:45:25 +00:00
Holly Sun
4c76f8db29 Solve NPE.
`secondaryLabel` is public and may be changed from other threads, therefore make a local reference and use the local reference.

Bug: 271270746
Test: build SystemUI and verify the secondary label works properly
Change-Id: I71c79bcf380ce46ad5f0be6b8e2a7647df55f5bf
2023-03-03 09:27:56 -08:00
Jordan Demeulenaere
1d870f1f55 Merge changes Ide7d63a7,I9e075f29 into udc-dev
* changes:
  Format files with the upcoming version of ktfmt
  Regenerate include file for ktfmt upgrade
2023-03-01 12:17:58 +00:00
Hawkwood Glazier
8d9375693e Merge "Expose Metadata Json Object for WPP settings" into tm-qpr-dev am: c3835e6b4c am: 4d4c8eb2fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/21535741

Change-Id: Ie365e323085a5e90dad25411c34e31174dd68bfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 12:17:09 +00:00
Hawkwood Glazier
20e19793f3 Merge "Add alternative color updating path for seed colors" into tm-qpr-dev am: 765485f7c2 am: cc1bc3ee10
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/21495251

Change-Id: I56bb8a03c7ea6246b70897d64a693250449f8cce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 11:20:37 +00:00