Commit Graph

14438 Commits

Author SHA1 Message Date
Jorim Jaggi
387991e2aa Merge "Revert "Revert "Defer updating InsetsSource.mFrame while animating""" into rvc-dev am: a775f45d85 am: 911ce402a4 am: 67658867a1 am: 46756d0fa2
Change-Id: Ida5cd0ca35bed637a2bc3e5cacc20168efa1d990
2020-04-06 15:48:46 +00:00
Jorim Jaggi
a775f45d85 Merge "Revert "Revert "Defer updating InsetsSource.mFrame while animating""" into rvc-dev 2020-04-06 14:27:16 +00:00
Jorim Jaggi
33a2183d4b Revert "Revert "Defer updating InsetsSource.mFrame while animating""
This reverts commit 8c56ac6b94.

Underlying issue has been fixed:

Test: InsetsControllerTest
Bug: 152071027
Change-Id: I2b80de7067bf688a6b36233b9a1e92e2cf31c148
2020-04-06 14:28:59 +02:00
Tony Huang
3b3d8ea61d Merge "Fix split divider janky" into rvc-dev am: a171ec4203 am: e6abf0b719 am: c030cdafad am: d1db0d4023
Change-Id: Ie2fedd5893590745c62d85819693f71a38c46f27
2020-04-06 08:52:20 +00:00
Tony Huang
a171ec4203 Merge "Fix split divider janky" into rvc-dev 2020-04-06 07:24:15 +00:00
Rob Carr
9d02abec80 Merge "BLASTBufferQueue: Fix unnecessary copying of Surface" into rvc-dev am: 73e4cc48c7 am: 1827f745ae am: 95cdc5fc5c am: ade8075965
Change-Id: I17cab3aeffaec66bf7264e5aaa7d94c6dfc971d4
2020-04-03 22:58:14 +00:00
Rob Carr
73e4cc48c7 Merge "BLASTBufferQueue: Fix unnecessary copying of Surface" into rvc-dev 2020-04-03 21:48:08 +00:00
TreeHugger Robot
53700f16e7 Merge "Revert "Fix DecorView error about non-visual context"" into rvc-dev am: 59a65bdc0f am: fca4a6e057 am: 3dc933b9b1 am: 518d408967
Change-Id: I4f320ff2ce2df427d4c032639f97d7db1150be55
2020-04-03 20:42:04 +00:00
Rob Carr
c2dc32f00c Merge "BLASTBufferQueue: Avoid unnecessary transactions" into rvc-dev am: 0bed41a993 am: 5192d2be9b am: e8ea7c64cf am: d4fda59476
Change-Id: I20b5d3554de88cc7991d8851d58284587f54f0a7
2020-04-03 20:22:53 +00:00
TreeHugger Robot
59a65bdc0f Merge "Revert "Fix DecorView error about non-visual context"" into rvc-dev 2020-04-03 19:53:56 +00:00
Rob Carr
0bed41a993 Merge "BLASTBufferQueue: Avoid unnecessary transactions" into rvc-dev 2020-04-03 19:04:42 +00:00
Vadim Tryshev
5420fffe19 Revert "Fix DecorView error about non-visual context"
This reverts commit 828c498904.

Reason for revert: b/152806048
Bug: 152806048

Change-Id: I0ba53944a7fddf42cccf79c6495945c8afa3ab31
2020-04-03 18:06:05 +00:00
TreeHugger Robot
846ab2095b Merge "Only track focused next served view in onViewFocusChanged" into rvc-dev am: 37b8baa3a8 am: 00dde964ce am: 8adeade86f am: 75b7024ba2
Change-Id: Ice0e1e1d1529cd980178204ac5278a64dc41e33b
2020-04-03 16:57:04 +00:00
TreeHugger Robot
37b8baa3a8 Merge "Only track focused next served view in onViewFocusChanged" into rvc-dev 2020-04-03 15:51:28 +00:00
Robert Carr
1dd148d9ac BLASTBufferQueue: Fix unnecessary copying of Surface
When we call mSurface.transferFrom(getOrCreateBLASTSurface()) we
always end up incrementing mSurface.generationId, because
BLASTBufferQueue.java::getSurface will always return a new native
wrapper object. We had a similar situation with
mSurface.copyFrom(mSurfaceControl), and had to build IGBP
comparison in to the native method. Here though, it's easier
to just rely on the stability of the Surface (never changes
for the lifetime of the BLASTBufferQueueAdapter) to avoid
duplicate calls to transferFrom.

Bug: 152501005
Test: Existing tests pass.
Change-Id: I64b9a6ae3cabfa75974e040460638417bfac6845
2020-04-02 15:29:34 -07:00
Adrian Roos
56e213bb9d Merge "WindowInsetsAnimation: Fix app driven closing of IME" into rvc-dev am: 56f4b1b9d3 am: 2b8d80b8cb am: c5bd862378 am: cd8f9672ae
Change-Id: Ic90c4d54265240fd9e95d54dfe81c1c1d110f703
2020-04-02 19:31:06 +00:00
Adrian Roos
b2544c811c Merge "WindowInsetsAnimation: Synchronously dispatch window insets animation callbacks" into rvc-dev am: f5a0f80fe2 am: bbec0bba6d am: 685b92c8fc am: 621318aacb
Change-Id: I1f2966143a915b3c7725eca02680be20c915d55b
2020-04-02 19:30:55 +00:00
Robert Carr
cb250de686 BLASTBufferQueue: Avoid unnecessary transactions
Currently every call to getOrCreateBLASTSurface produces a transaction.
This transaction has two parts, both of which can be eliminated:
	1. The first is the reparent. This was written when the
	client allocated the BLAST SurfaceControl, but now the WM
	allocates it and it has the correct parent to start, so
	we can just eliminate this.
	2. Showing the surface. We can eliminate this by just showing
	the surface by default.

Bug: 152501055
Test: Flip BLAST flag. Play.
Change-Id: If6e28e9153a09909fb3bb061980deb82c132dd5a
2020-04-02 12:28:36 -07:00
Jorim Jaggi
0046722d6c Merge "WindowInsets: Ignore consumeStableInsets()" into rvc-dev am: d80aee2ed8 am: 104cd6c756 am: d386951afb am: 2686524ef7
Change-Id: Id5381eae7fdc36c4d261f0f9715293f67c847376
2020-04-02 19:25:38 +00:00
Automerger Merge Worker
bf8ab402e9 Merge "Merge "Request fit system windows if soft input mode updates" into rvc-dev am: ea4fe825b7 am: 16fb21c354" into rvc-d1-dev-plus-aosp am: 1e9b641945 am: 0e21be56c5
Change-Id: Ieef7ec4c46c427c3a9cd2a5acb8024c08cc260a1
2020-04-02 19:20:16 +00:00
Jorim Jaggi
2601b17b2b Merge "Initialize sourceless insets with Insets.NONE" into rvc-dev am: fe2228aa89 am: ce24761577 am: d4485fe330 am: b954419290
Change-Id: Ica3c28957e8fa51cba071cc29c48cac55a286e5d
2020-04-02 19:17:01 +00:00
Feng Cao
f8347366d2 Merge "Define custom equals method for bundles in the inline APIs" into rvc-dev am: 257aa916ac am: 8ab445a7a9 am: 3f185c6881 am: 6c8b4417cc
Change-Id: Iff11cae258441c0adbccc16bf28b2ccc2f61d252
2020-04-02 18:34:58 +00:00
Rob Carr
b0469c1ec8 Merge changes I98b51b43,I03cb69e1 into rvc-dev am: f2f056ef71 am: a77f60313d am: 698a536015 am: 3174ed17d3
Change-Id: Ia96143157d57b95c79405abe66924fb024fe2883
2020-04-02 17:38:07 +00:00
Automerger Merge Worker
17390b4a33 Merge "Merge changes Ia152bc41,Iae8026e7 into rvc-dev am: 71a6d0bf2b am: 9716d62b4d" into rvc-d1-dev-plus-aosp am: aa5088485c am: aef5228d68
Change-Id: I84c387f3c2f7c774c236a5786f5602dc997c3cbe
2020-04-02 17:06:10 +00:00
Adrian Roos
56f4b1b9d3 Merge "WindowInsetsAnimation: Fix app driven closing of IME" into rvc-dev 2020-04-02 13:41:46 +00:00
Adrian Roos
f5a0f80fe2 Merge "WindowInsetsAnimation: Synchronously dispatch window insets animation callbacks" into rvc-dev 2020-04-02 13:41:46 +00:00
Jorim Jaggi
d80aee2ed8 Merge "WindowInsets: Ignore consumeStableInsets()" into rvc-dev 2020-04-02 11:21:22 +00:00
Jorim Jaggi
ea4fe825b7 Merge "Request fit system windows if soft input mode updates" into rvc-dev 2020-04-02 10:56:27 +00:00
Jorim Jaggi
fe2228aa89 Merge "Initialize sourceless insets with Insets.NONE" into rvc-dev 2020-04-02 10:55:38 +00:00
Feng Cao
257aa916ac Merge "Define custom equals method for bundles in the inline APIs" into rvc-dev 2020-04-02 02:47:01 +00:00
Rob Carr
f2f056ef71 Merge changes I98b51b43,I03cb69e1 into rvc-dev
* changes:
  InsetAnimationThreadControlRunner: Don't copy controls
  InsetsSourceConsumer: Release directly
2020-04-01 22:43:59 +00:00
Priyank Singh
43b604f9c5 Merge "Add attr allowClickWhenDisabled for the new API View#setAllowClickWhenDisabled" 2020-04-01 22:43:25 +00:00
Adrian Roos
6a4448f0f8 WindowInsetsAnimation: Synchronously dispatch window insets animation callbacks
Test: atest WindowInsetsAnimationControllerTests
Bug: 152617481
Change-Id: Ie002f2e605f841563d8c2669f949be3ddd666146
2020-04-01 21:30:17 +00:00
Jorim Jaggi
6f2ccea9f9 Initialize sourceless insets with Insets.NONE
...in order to make WindowInsets.equals consider source missing
and source not providing insets the same.

Fixes: 152822955
Test: InsetsAnimationTest
Change-Id: I31cb0278f45c38fb788d4f2bdefb1a13b6870216
2020-04-01 22:00:39 +02:00
Feng Cao
59b682f5cd Define custom equals method for bundles in the inline APIs
Test: atest android.view.inputmethod.cts
Bug: 152811052

Change-Id: I15051493bb37f05b579b16d6e7fee36b05ab10cc
2020-04-01 12:46:15 -07:00
Selim Cinek
a2b1d3753b Added back the recently alerted indicator to conversations
Previously this was dropped, it's now reintroduced.

Fixes: 150905003
Test: atest SystemUITests
Change-Id: Ia152bc4117fa9c656b3d477ef8e50708e1056148
2020-04-01 11:40:57 -07:00
Selim Cinek
4237e8277a Reintroduced app ops for conversation notifications
Previously app ops weren't showing in conversation notifications
Also made sure that they show in case the app name is long.
Additionally this fixes the coloring of the sender name.

Fixes: 150905003
Test: atest SystemUITests
Change-Id: Iae8026e7efdec8c207d1984dac4ee089abe116b9
2020-04-01 11:40:54 -07:00
Adrian Roos
3b19ff1e0f WindowInsetsAnimation: Fix app driven closing of IME
When using controlWindowInsetsAnimation to close the IME,
delay reporting this to the IME until the animation is actually
finished. Otherwise, the IME will self-hide and start a transition
that breaks the just-begun app-driven transition.

(Regression from I7f6098a61a5942795ffd33a60329e4dd5fb5d6cb which
changed InputMethodService to hide itself in reponse to notifyHidden)

Bug: 151980214
Test: make WindowInsetsTests, ensure that dragging the IME closed doesnt get cancelled
Change-Id: If4e64cc78742a4e1e8c98137bd97d65dd567f674
2020-04-01 18:28:13 +00:00
Jorim Jaggi
38448827f4 Merge "Fix missing finish callback to fix running animation leak" into rvc-dev am: 526632d15f am: d49d6f502c am: 2dfb499d57 am: 159b76cd08
Change-Id: Icbeea792b5645981cf32b839fd87a4176676f044
2020-04-01 17:07:57 +00:00
Jorim Jaggi
526632d15f Merge "Fix missing finish callback to fix running animation leak" into rvc-dev 2020-04-01 16:13:54 +00:00
Jorim Jaggi
c5c829f675 Request fit system windows if soft input mode updates
To make sure legacy insets are correct always.

Test: Open Message, go to attachments, reopen IME
Bug: 152851108
Change-Id: I9ae0930645ca4331d362af7db9ab77bf49d74edc
2020-04-01 15:48:17 +02:00
Jorim Jaggi
f103588cc1 Fix missing finish callback to fix running animation leak
Make sure finish callback gets called when
applyChangeInsets gets called synchronously from
scheduleApplyChangeInsets

Bug: 152071027
Test: InsetsAnimationControlImplTest
Change-Id: I6808b3527f1d2e15de681c5260208d238dcf53e2
2020-04-01 14:50:59 +02:00
Adrian Roos
9ab688d487 WindowInsets: Ignore consumeStableInsets()
With the introduction of insets types we no longer support consuming
individual insets.

Instead we consumed all insets, regardless of whether you consumed
stable or system insets - but that led to compat issues.

On Q, consumeStableInsets was almost always a no-op anyways, because
stable insets already came pre-consumed during dispatch.

This change makes consumeStableInsets() a no-op to more closely match
that behavior.

Bug: 152033222
Test: atest WindowInsetsTest
Change-Id: Ic48ee7386320fc16449ac79435b69305a8132bf8
2020-04-01 14:26:24 +02:00
Tony Huang
89d580c056 Fix split divider janky
The janky caused by SurfaceFlingerVsyncChoreographer does not work
reliably. Sometimes it didn't update but sometimes update twice per
frame so cause janky.

Fix this by removed using SurfaceFlingerVsyncChoreographer and use
real surface flinger sync signal to update screen.

Bug: 150874701
Test: enter split mode and drag divider to observer janky
Change-Id: I5a8bce36738a97b0ddaf4c4e77949eb5295b4894
2020-04-01 19:07:49 +08:00
Feng Cao
9c6842e884 Merge "Replace Nullable bundle with NonNull and use Bundle.EMPTY" into rvc-dev am: f1771c0d33 am: 12a7be983b am: b6ad7232ad am: 85ff58a80a
Change-Id: I053719f33f9319312087b1f4ef0ae1589952e46a
2020-04-01 03:16:24 +00:00
Nikita Dubrovsky
4ec7f29691 Merge "Add unified API for inserting rich content (e.g. pasting an image)" 2020-04-01 02:59:15 +00:00
Priyank Singh
911dd88ca6 Add attr allowClickWhenDisabled for the new API View#setAllowClickWhenDisabled
Fix: 152628656
Test: Manual
Change-Id: I10d149b618dfc0f06d5e395e8d053dce2f5df452
2020-03-31 22:37:35 +00:00
Nikita Dubrovsky
832edc3cc9 Add unified API for inserting rich content (e.g. pasting an image)
The new callback provides a single API that apps can implement to
support the different ways in which rich content may be inserted.

The API is added to TextView and unifies the following code paths:
* paste from the clipboard (TextView.paste)
* content insertion from the IME (InputConnection.commitContent)
* drag and drop (Editor.onDrop)
* autofill (TextView.autofill)

Corresponding API in support lib: aosp/1200800

Bug: 152068298
Test: Manual and unit tests
  atest FrameworksCoreTests:TextViewRichContentReceiverTest
  atest FrameworksCoreTests:AutofillValueTest
  atest FrameworksCoreTests:TextViewActivityTest
Change-Id: I6e03a398ccb6fa5526d0a282fc114f4e80285099
2020-03-31 15:15:36 -07:00
TreeHugger Robot
5b0dcabe4d Merge "Add @UnsupportedAppUsage to the old inline APIs for compatibility" into rvc-dev am: c068acb6ae am: 739dc57124 am: 783b19b47a am: b391e5df1a
Change-Id: I1faff4a663df8c110af47ab0974c27ebc7a327b6
2020-03-31 22:08:42 +00:00
Automerger Merge Worker
ccc43f021b Merge "Merge changes I0d79642d,If8756ac8,I29e73897,Ia8c5121a,I533b8f06 into rvc-dev am: 9bad85af2b am: 3bd1a83e56" into rvc-d1-dev-plus-aosp am: 36bf20dfa6 am: 32d792b771
Change-Id: I78dbadac45e51606800c7d65a4dada58c134af8d
2020-03-31 21:51:40 +00:00