Commit Graph

17739 Commits

Author SHA1 Message Date
Mady Mellor
cf8ab8447e Merge "Fix CTS" into rvc-dev 2020-04-29 14:33:36 +00:00
TreeHugger Robot
447914fcfe Merge "Add RoleControllerManagerTest." into rvc-dev 2020-04-29 05:56:34 +00:00
Mady Mellor
a114b79392 Fix CTS
* fix BubbleExtractor tests to work with this & better
  test things now that the channel is a tristate

Test: atest NotificationManagerTest BubbleExtractorTest
Bug: 155025024
Change-Id: I8b75c1b0087ca79cea29741e32c7c524cb056d04
2020-04-28 20:06:03 -07:00
TreeHugger Robot
007a73c551 Merge "Don't remove OnAlarmListener mappings in the client" into rvc-dev 2020-04-29 01:09:32 +00:00
Suprabh Shukla
7d40780e39 Don't remove OnAlarmListener mappings in the client
Removing the mapping is prone to races in keeping the state consistent
with the server. An inconsistent state can lead to multiple alarms on
the server for the same listener.

Test: atest CtsJobSchedulerTestCases doesn't fill the alarm queue with
more than one alarm.
atest CtsAlarmManagerTestCases

Bug: 154444435
Change-Id: Iaf11d5decb17fbf2366b49d9865231bf65dbdc41
2020-04-28 15:37:21 -07:00
TreeHugger Robot
48f0527199 Merge "Close heap dump ParcelFileDescriptor." into rvc-dev 2020-04-28 20:52:29 +00:00
Hai Zhang
a39cf78c63 Add RoleControllerManagerTest.
Fixes: 155119713
Test: atest RoleControllerManagerTest
Change-Id: If90ba60cccbe1589365142a06d917a87b7a092ef
2020-04-28 12:14:01 -07:00
Julia Reynolds
49467eebac Update logging
Priority isn't used; shortcut is

Test: manual
Bug: 149651274
Change-Id: If6577c5588afe5e48787ae7e6bc528442fdb3423
2020-04-28 14:50:01 +00:00
Alex Johnston
a077a8a0cc Merge "Update setOrganizationColor javadoc" into rvc-dev 2020-04-28 08:36:57 +00:00
Chris Li
9859a326c1 Merge "Cache isSystemOrSystemUI on ContextImpl creation" into rvc-dev 2020-04-28 04:02:05 +00:00
Kweku Adams
f1ddecc60e Close heap dump ParcelFileDescriptor.
The file descriptor is only closed in certain situations. Explicitly
closing it to ensure we don't have any leaks.

Bug: 154277871
Test: take a system heap dump via developer options & and watch for StrictMode violation
Test: adb shell am dumpheap <system|another app> & and watch for StrictMode violation
Change-Id: I3ae3e270bcec18ba531055becfff32924c8f2a2d
2020-04-27 18:43:09 +00:00
Chris Li
e7f4f30698 Cache isSystemOrSystemUI on ContextImpl creation
When creating Context without a container Context, cache the value of #isSystemOrSystemUI().

Fix: 154161051
Test: atest FrameworksCoreTests:ContextTest
Change-Id: I1d16173c7da06a73d1338e3d6e75f5b56fcdbe23
2020-04-27 11:35:31 -07:00
TreeHugger Robot
756662fb2f Merge "Inform receivers of restart attempt previous visibility" into rvc-dev 2020-04-27 18:29:46 +00:00
Diego Vela
7c59c63943 Merge "Update Documentation for onActivityResult." into rvc-dev 2020-04-27 17:58:29 +00:00
Evan Rosky
8d1c24e0a5 Inform receivers of restart attempt previous visibility
This way receivers like recents know whether the activity
was already visible before a restart attempt.

Bug: 154575664
Test: added test. Can also launch a running activity into
      split-primary and it won't expand it.
Change-Id: If59ee1615fa36bbe3af9412194a7f96b9377528a
2020-04-27 09:13:31 -07:00
Diego Vela
6e99bfcd6c Update Documentation for onActivityResult.
Update doc to be more accurate about when onActivityResult is called

Bug: 140608415
Test: n/a
Change-Id: If44b02719e18b3107b064d749396d896bed08f86
2020-04-27 15:10:18 +00:00
Alex Johnston
6be8cda180 Update setOrganizationColor javadoc
Background
* In Android R, the UI of the work challenge was
  updated to latest material spec which no longer
  uses the organization color.

Changes
* Update javadoc of setOrganizationColor mentioning
  the organization color will no longer affect the
  work challenge starting from R.

Bug: 153607870
Bug: 153607569
Test: verify no build breakages
Change-Id: I071f544e4fba1915d810fa741dbc79966f9e72f4
2020-04-27 15:20:14 +01:00
Alex Johnston
c5e9a48db8 Merge "Add factory reset protection policy Test API to DPM" into rvc-dev 2020-04-27 11:04:46 +00:00
TreeHugger Robot
525fab26a1 Merge "Add back ActivityManagerService.onUserRemoved" into rvc-dev 2020-04-25 01:16:49 +00:00
Darryl Johnson
637fd24378 Merge "Revert "Try to reland Ib3ee007bc"" into rvc-dev 2020-04-25 00:37:46 +00:00
Darryl Johnson
87f93a5585 Revert "Try to reland Ib3ee007bc"
This reverts commit b6415618f1.

Reason for revert: Caused regression of b/149213586

Bug: 148639826
Bug: 149213586

Change-Id: I5248e03b42e3f24a6e2abb134d0bf339e77f484b
2020-04-24 23:50:53 +00:00
Adam Bookatz
aa59419bbd Add back ActivityManagerService.onUserRemoved
ActivityManagerService.onUserRemoved was accidentally removed in
ag/4246926. This cl adds it back.

The part of onUserRemoved that told ActivityTaskManagerService that
the user had stopped (and thereby cleaned up ATMS) was retained, but
the additional actions of AMS.onUserRemoved - namely, telling
BatteryStatsService and UserController - were accidentally removed.
Consequently, those services were never told when a user was removed.

Bug: 140645064
Test: manual verification that profile is removed in  adb shell dumpsys activity users
Change-Id: I903b06ae68d583bdb326ad3b764a63d18b5555d8
2020-04-24 22:24:05 +00:00
Charles Chen
56dfd7c643 Merge "Revert "Fix false positive of activity leak in NexusLauncherTests"" into rvc-dev 2020-04-24 02:55:31 +00:00
Julia Reynolds
a7dac439a3 Record whether apps have sent msg notifications
Test: atest
Bug: 154814754
Change-Id: I6b633c5e309deb11feda94d4e67858a376dd3d88
2020-04-23 20:19:15 +00:00
Darryl Johnson
700c2062a0 Revert "Fix false positive of activity leak in NexusLauncherTests"
This reverts commit b3230a3594.

Reason for revert: Possibly the cause of b/154581087
Bug: 154581087
Change-Id: I4a7ebeb33f68b8918d24b1e59638bbc5fa38bf72
2020-04-23 20:07:58 +00:00
Charles Chen
1e52a093ae Merge "Limit number of window context without any window" into rvc-dev 2020-04-23 03:34:37 +00:00
Winson Chiu
c023f4474b Merge "Calculate oldPaths for out of date LoadedApks" into rvc-dev 2020-04-23 00:44:57 +00:00
Charles Chen
2622d3ef7e Limit number of window context without any window
This change is to prevent misuse of window context from app
and leads to performance drop on system by limit the numer of window
context an app can use. Code snippet below is a sample to cause
this issue:
```
Rect getBounds() {
    Context windowContext = context.createWindowContext(...);
    return windowContext.getSystemService(WindowManager.class)
            .getCuttentWindowMetrics().getBounds()
}
```
This method could be invoked dozens of times and produce dozens of window
tokens. It would slow down the speed of window traversalling. These
token won't be removed until system server has been GC'd.

Test: atest WindowContextTests WindowContextPolicyTests
fixes: 152934797
Bug: 153369119

Change-Id: I927e85a45c05c4d90b51a624ea408ff3a3ffce93
2020-04-22 18:16:56 +08:00
Alex Johnston
e62d8d1117 Add factory reset protection policy Test API to DPM
* Add @TestApi isFactoryResetProtectionPolicySupported()
  to DevicePolicyManager which returns whether factory
  reset protection policy is supported on the device.

Bug: 153696811
Test: atest com.android.cts.devicepolicy.OrgOwnedProfileOwnerTest#testFactoryResetProtectionPolicy
Change-Id: Id0bd6cdacf33f0fb2f795e1ead5127b79f42960e
2020-04-22 10:23:15 +01:00
TreeHugger Robot
5ff2b3ce04 Merge "Avoid reporting unhandled config changes to activity" into rvc-dev 2020-04-22 03:40:26 +00:00
Jeff Sharkey
b67e70aa40 Merge changes from topic "apr19" into rvc-dev
* changes:
  Update some Parcelables to send Strings UTF-8.
  Offer to write Strings through Parcels as UTF-8.
2020-04-21 22:59:40 +00:00
Jeff Sharkey
0223df096c Update some Parcelables to send Strings UTF-8.
An earlier CL with benchmarks has shown that sending strings as UTF-8
is 50% faster for US-ASCII strings, and still 68% faster for complex
strings referencing higher Unicode planes.  (So an improvement in
both cases!)

Since code across the OS still makes heavy assumptions about Parcel
strings typically being UTF-16, we need to carefully migrate
Parcelables by hand, which is what this CLs begins doing.

This is a purely mechanical refactoring with no functional changes.

Bug: 154436100
Test: manual
Exempt-From-Owner-Approval: trivial refactoring
Change-Id: Ia9e581efd7c40269342b7528ca07363deb843c0f
2020-04-21 22:59:26 +00:00
Mady Mellor
582784757d Merge "Make bubble channel setting 3 state with unset / on / off" into rvc-dev 2020-04-21 22:30:28 +00:00
Wale Ogunwale
201af5078f Merge "Allow CTS test to control organized tasks" into rvc-dev 2020-04-21 22:01:40 +00:00
Winson
f8be8e51e1 Calculate oldPaths for out of date LoadedApks
This was originally omitted because the only known case this
branch was hit was after a package update, which would inherently
change the code paths for the package.

Thus, spending the time to calculate these oldPaths was worthless
because they would never be applicable.

Seemingly this case where the paths are not changed has been
found, causing duplicate paths to be added to the same ClassLoader.
This warrants further investigation to determine why, but for now,
this should be safe to commit to fix the issue.

Bug: 149410951

Test: manual used steps at b/149410951#comment57, verified that
    paths were not added multiple times; device functions as normal
    otherwise

Change-Id: I632994dd19cae2b0101d7386826c8f8c7251051a
2020-04-21 12:01:33 -07:00
TreeHugger Robot
6b74050d48 Merge "Add currentUiModeSupportsErrorDialogs() into ActivityTaskManager." into rvc-dev 2020-04-21 18:35:44 +00:00
Yuncheol Heo
5d9b2710da Add currentUiModeSupportsErrorDialogs() into ActivityTaskManager.
The method will be used in AnrTests to check if the system can support ANR Dialog or not.

Bug: 149510025
Test: atest AnrTests
Change-Id: I7a78be06fcf3c4882931aaea1d330b2cebdc2d84
2020-04-21 16:24:22 +00:00
Mady Mellor
ee8d5b59e2 Make bubble channel setting 3 state with unset / on / off
Test: atest NotificationManagerTest (with CTS cl)
Test: manual - have test app on "all" setting
             - get a bubble
             - hit "unbubble" from notification
             => no longer bubble
             - get update to that notif, it shouldn't bubble
Bug: 154232758
Change-Id: I1611002418cad18ec2426e7d8b4cd4dc93e6df24
2020-04-21 16:10:26 +00:00
Stanislav Zholnin
ae4605eee8 Merge "Allow listening for noted Ops if app is sampled for Stack trace collection." into rvc-dev 2020-04-20 15:21:10 +00:00
Michael Wachenschwanz
dcc388ab44 Merge "Add permission check to UsageStatsManager#isAppInactive" into rvc-dev 2020-04-20 15:15:35 +00:00
Linus Tufvesson
3bfec32633 Merge "Make ActivityViews backing virtual display private" into rvc-dev 2020-04-20 14:00:28 +00:00
Wale Ogunwale
20ab6d4999 Allow CTS test to control organized tasks
Changes to allow CTS test to control organized task so we can have the
tests run the same way sys-ui is driving things now. Control is given
back to sys-ui once the test is done running.

Bug: 149338177
Test: atest CtsWindowManagerDeviceTestCases:SplitScreenTests
Change-Id: I74a03ee3411f5b10ea4e26c1cc3c663dc394dd97
2020-04-19 19:09:33 -07:00
TreeHugger Robot
7f801fe0d1 Merge "Try to reland Ib3ee007bc" into rvc-dev 2020-04-20 00:29:45 +00:00
Lee Shombert
9bca3a380d Merge "Disable binder caches in unit tests" into rvc-dev 2020-04-19 19:07:24 +00:00
Stanislav Zholnin
d4968a0221 Allow listening for noted Ops if app is sampled for Stack trace collection.
Bug: 136134050
Test: manual verification
Change-Id: I86a70e7b0bbcb114bd28bf5ab90bbf1c625f333a
2020-04-18 21:11:22 +01:00
TreeHugger Robot
872afaeaeb Merge "Fixed Task#getVisibility to take into account task hierarchy" into rvc-dev 2020-04-18 02:23:41 +00:00
Lee Shombert
6747eaa8e5 Disable binder caches in unit tests
Bug: 152451909

Unit tests often execute server code in the context if a test process.
Such a process does not have the same permissions as formal system
processes.  In particular, such a process does not have permission to
invalidate binder caches.

This change disables all binder cache code in the current process.
This means caching is disabled and invalidation never occurs.  There
are no permission violations and the test process is also unable to
affect (through cache invalidation) the actual system processes.

Test: Ran a list of atests.  Two had security violations before the
change but were okay after the change:
 * FrameworksServicesTests
 * UserSystemPackageInstallerTest
 Ran additional tests to verify no regressions:
 * PlatformScenarioTests
 * PtsChreTestCases
 * BluetoothInstrumentationTests
 * UserLifecycleTests

Change-Id: I011ee1eb39b2d52c69b6d5164b64f7418d2bbdd4
2020-04-17 16:37:50 -07:00
TreeHugger Robot
e185aca339 Merge changes If07d6938,I32f9b89a,Ife4f8c4e into rvc-dev
* changes:
  RESTRICT AUTOMERGE: Add a facility for time-based cache corking
  RESTRICT AUTOMERGE: Cork permission and package cache around bulk permission update
  RESTRICT AUTOMERGE: Cork package information cache invalidations during boot
2020-04-17 23:25:02 +00:00
Wale Ogunwale
0db64ac043 Fixed Task#getVisibility to take into account task hierarchy
Also, correct some uses of getRootHomeTask()

Fixes: 153086746
Bug: 154331729
Bug: 80414790
Test: atest WmTests:ActivityStackTests#testGetVisibility_MultiLevel
Change-Id: I8b9a38879a0b4e6c72686312b414319b8b086cd1
2020-04-17 15:05:34 -07:00
wilsonshih
b6415618f1 Try to reland Ib3ee007bc
Don't let process configuration change application configuration,
but allow to update non-default display configuration while
initialize since the context is focus on different display.

Bug: 148639826
Test: atest PresentationTest ActivityThreadTest AppConfigurationTests
Change-Id: I16ba4eee64406d097b7ff0b7ff5c45175623663a
2020-04-17 21:31:24 +08:00