Commit Graph

607 Commits

Author SHA1 Message Date
Selim Cinek
12a9c8eac6 Merge "Retrying the remoteview application on the ui thread" into oc-dev
am: 07b93779ba

Change-Id: I21c7d62b1cb775a2992d4abcf5c4cfdae91c09a3
2017-06-20 22:51:24 +00:00
Selim Cinek
d246bed148 Retrying the remoteview application on the ui thread
Because of various reasons, the async inflation could spuriously
fail, leading to dropped notifications.
We're now retrying them on the UI thread before we fail completely.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/NotificationInflaterTest.java
Bug: 38190555
Change-Id: I13feaeaad925b72798a22194add16528c9438412
2017-06-20 18:42:48 +00:00
Siarhei Vishniakou
305fe47d65 Merge "Revive DeadZone" into oc-dev
am: b278424fa6

Change-Id: I5a06302eaad1e955aaea6ae8d2785c0b12e53cc4
2017-06-19 23:59:46 +00:00
Siarhei Vishniakou
6ad0e39f33 Revive DeadZone
Override dispatchTouchEvent for the root FrameLayout
of NavigationBar to process ACTION_OUTSIDE MotionEvents
and dispatch directly to DeadZone to keep track of the
most recent outside tap.
Clarified documentation of ACTION_OUTSIDE behaviour.

Bug: 37552674
Test: open IME, tap any key, then quickly tap on top half
of the home button. The home button tap is ignored
and device does not go to homescreen.

Change-Id: Icb5cf6c76959f3514b8b94c09e38cc5434f31b23
2017-06-19 14:06:21 -07:00
Lucas Dupin
84b89d9d59 WallpaperColors refactor
Hiding color extraction into WallpaperColors.
This enables us to create WallpaperColors from a a Bitmap
or Drawable.

Fixes: 62197187
Fixes: 62490115
Test: runtest --path cts/tests/app/src/android/app/cts/WallpaperColorsTest.java
Change-Id: I614cfa205e02b551a141642eac6de21251c3bff6
2017-06-16 09:27:43 -07:00
Sundeep Ghuman
9d10a3cf30 Revert "Update Status Bar with Badged Wifi Icons."
This reverts commit d57f324776.

Reason for revert: Kill badging in ODR

Bug: b/35628911
Test: runtest --path
frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/NetworkControllerWifiTest.java
Change-Id: I153863dfc02aaa211e1d76f0d85a2779894f72ee
2017-06-15 20:11:44 -07:00
Chris Wren
4bf303695b Merge "add a log for peek to shade expansion" into oc-dev
am: 04298759fe

Change-Id: I4813fcd717b966e2ed2b1835d12d4183633f60ff
2017-06-15 16:28:32 +00:00
TreeHugger Robot
04298759fe Merge "add a log for peek to shade expansion" into oc-dev 2017-06-15 16:20:15 +00:00
Chris Wren
621933fd7b add a log for peek to shade expansion
Move the note_load counter into the manager, replacing
the redundant and useless notification_load counter.

Update the StatusBarTest to allow for hander side-effects.

Test: runtest systemui
Change-Id: I2551c51cc0f4627995abe4401eafc2e5adb3a8fa
Fixes: 27698560
2017-06-15 09:18:58 -04:00
Lucas Dupin
1cd133a4d0 Fixed flaky test
Change-Id: I88a39a8eb4fd6da6dc5b156aa475330299ffb9b9
Fixes: 62568528
Test: runtest systemui
2017-06-14 10:00:38 -07:00
Lucas Dupin
c02e6c396e Disabled test
Bug: 62568528
Change-Id: I1e3908e4d18c216132b0c4d7ae9b6e223e321799
2017-06-14 10:00:37 -07:00
Lucas Dupin
1ead7fc753 Scrims should be grey when in-app
Bug: 38164389
Test: runtest -x colorextraction/tests/src/com/google/android/colorextraction/ColorExtractorTest.java
Test: runtest -x tests/src/com/android/systemui/colorextraction/SysuiColorExtractorTests.java
Change-Id: Ifcc04a8562e46b4f65bce0470ccd6c02dffcf377
(cherry picked from commit e1571705e6)
2017-06-14 10:00:16 -07:00
Jason Monk
adfc1ad840 Merge "Fix footer not being hidden in detail panels" into oc-dev
am: 2a0b423cd4

Change-Id: I97266821c07fd307dbe04e5d715792e57bfa9c0d
2017-06-14 13:46:11 +00:00
Jason Monk
2a0b423cd4 Merge "Fix footer not being hidden in detail panels" into oc-dev 2017-06-14 13:37:34 +00:00
Jason Monk
304f3a74be Merge "Fix sysui depending on slow bt calls" into oc-dev
am: 02d5b79cf6

Change-Id: If250b772445628e26fd73d0c81f31ea89e74f7fa
2017-06-13 21:43:35 +00:00
TreeHugger Robot
70cb08326e Merge "Change SlashDrawable semantics to fix QS crash" into oc-dr1-dev 2017-06-13 21:19:20 +00:00
Jason Monk
b4ec0b90dc Fix footer not being hidden in detail panels
Was causing incorrect accessibility focus

Test: manual
Change-Id: Id487286eb9fa931b73349b0b0dfe772566c10e6d
Fixes: 62568126
2017-06-13 21:16:15 +00:00
Evan Laird
418ffe4a0f Change SlashDrawable semantics to fix QS crash
SlashDrawable wraps a reference to Drawable in order to store the
intended Drawable and optionally draw a slash over it. As such, it
should probably have similar semantics to Drawable, in that it either
exists or doesn't; if you set SlashImageView's drawable to `null`, you'd
expect that the drawable goes away, not that the SlashDrawable's
contained Drawable goes away but the slash stays.

Test: runtest systemui
Change-Id: I34b92716cc60ba5043ab68ae09954f5a5e97e562
Fixes: 62525439
2017-06-13 15:09:21 -04:00
Adrian Roos
25c7a58f33 AOD: Use double tap coordinates to trigger Ambient Indication
Bug: 38386446
Test: Double tap on AOD, verify that it still works. On device that supports double tap coordinates, verify that double tapping on ambient music opens ambient music.
Change-Id: Ic75ba731a980c9598c85927e83d2032f01da4822
(cherry picked from commit 44198f5124)
2017-06-13 16:59:54 +00:00
Jason Monk
9ef03b463c Fix sysui depending on slow bt calls
Move calls to a background thread and cache the results to avoid
slowing down sysui when there are too many bluetooth devices.

Test: runtest systemui
Change-Id: Ica10e86ca6b2783c30ed9de68f1a91dc5cfdf068
Fixes: 38118549
2017-06-13 12:49:55 -04:00
Mady Mellor
f3f6ddf7cb Merge "Updates to NotificationMenuRowPlugin so that long press may be captured" into oc-dr1-dev 2017-06-12 21:48:45 +00:00
Mady Mellor
4ab2820e6c Updates to NotificationMenuRowPlugin so that long press may be captured
This will allow the NotificationMenuRow plugin to do something else
rather than showing a menu when the view is long pressed.

- Allow menu to intercept touch events
- If the menu item provided to long press is null, don’t show it
- Also passes the status bar notification when the menu is created
  or updated

Bug: 62534409
Test: manual, have no plugin and long press -> see notification info
      have a plugin that returns null for long press -> nothing happens
Change-Id: I384c5217d5343e990f4c3506eb2477b015705e5c
2017-06-12 18:08:19 +00:00
Geoffrey Pitsch
eefa3be55d Change FlakyTest to Ignores
These are failing reliably, no need for FlakyTest

Bug: 62475085
Test: runtest systemui
Change-Id: Ib9abedda149976cffe07ea75c7034dd290d1f715
2017-06-12 10:55:28 -04:00
Lucas Dupin
ed268dc350 Merge "Removed test from presubmit." into oc-dev
am: 4f30aa2be8

Change-Id: I3f73f3581fad4575f774f2c5ba870cc3308443a4
2017-06-09 23:26:36 +00:00
TreeHugger Robot
4f30aa2be8 Merge "Removed test from presubmit." into oc-dev 2017-06-09 23:17:18 +00:00
Lucas Dupin
f26517d466 Removed test from presubmit.
testOnNotification_stillWorksAfterOneFailedProxCheck needs to
be ignored on presubmit runs. It fails on Tree Hugger but
runs locally.

Test: runtest systemui
Change-Id: Id4e1107528715c7e0b6ce7c69e2da7fa837e79a2
2017-06-09 14:10:33 -07:00
Selim Cinek
4ab7b364a5 Merge "Fixed an issue where the notification could stay userlocked" into oc-dev
am: dc66506f0a

Change-Id: Ia2ea2f1b69bdcab2d27a56e89fbfb87b8cc11eed
2017-06-09 04:36:31 +00:00
Selim Cinek
dc66506f0a Merge "Fixed an issue where the notification could stay userlocked" into oc-dev 2017-06-09 04:25:42 +00:00
Jason Monk
d7dab0f36f resolve merge conflicts of a5b457b3bf to oc-dr1-dev
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I2aa49bfdbd2c44684d0edb21b52520fea406e167
2017-06-08 13:00:40 -04:00
Selim Cinek
f8c4add851 Fixed an issue where the notification could stay userlocked
When collapsing the shade while draging down (using fingerprint)
notifications would stay userlocked and would appear in a small
height instead of their regular size.

Test:  runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarWindowViewTest.java
Change-Id: Ibd97a6ce063bc2fcd76f11e010e781a61bd76b5f
Fixes: 36469584
2017-06-08 09:56:42 -07:00
Jason Monk
a5b457b3bf Merge "Move QS cell indicator back into mobile data tile" into oc-dev 2017-06-08 16:35:26 +00:00
Selim Cinek
1c28e96bf0 Merge "Fixed a bug where the navigation notification would flicker" into oc-dev
am: b18f65a168

Change-Id: I385374ede44f09bb729ec7df7be13dc62c19bb2a
2017-06-08 14:15:29 +00:00
Selim Cinek
b18f65a168 Merge "Fixed a bug where the navigation notification would flicker" into oc-dev 2017-06-08 14:07:23 +00:00
Ian Pedowitz
a27856d443 resolve merge conflicts of 695f21a661 to oc-dr1-dev
Test: I solemnly swear I tested this conflict resolution.
Change-Id: Ifeffa55c7fb80b0f327ecc5b50cefeca9db6457b
Merged-In: I558447f282bb54f13be1622c3f2528a383fbc3b7
2017-06-07 19:52:10 -07:00
Selim Cinek
131f1a4bc4 Fixed a bug where the navigation notification would flicker
Change-Id: Id68ba339407287d67d8db888515389e79e09ece3
Fixes: 62339936
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/NotificationCustomViewWrapperTest.java
2017-06-07 18:04:57 -07:00
Selim Cinek
a7c69637f8 Fixed an issue where the icons had the wrong color
The color of the icons was taken from the ambient view
and wasn't updated when dark changed.

Change-Id: I472e76ff9d4d92500faae5517f10bdeb2658936d
Fixes: 62423352
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
2017-06-07 15:52:30 -07:00
Selim Cinek
5cf1d0589a Fixed an issue where the qs panel wasn't properly placed
The QS panel should only be placed below the notifications
if it has notifications above the shelf. This ensures that
all animations including icons are appearing in the right
place.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/AboveShelfObserverTest.java
Fixes: 35305470
Change-Id: I97fb0c76ed69b7638ce83a7c06856d87bf6bf65f
2017-06-07 19:08:39 +00:00
Jason Monk
01df36f37f Move QS cell indicator back into mobile data tile
Remove it from the header and drop it back in its old location.

This reverts commit 10b4c8a4ab.

Test: runtest systemui
Fixes: 62331189
Change-Id: I087589c256894e0972656619e665b6a16536ce6c
2017-06-07 15:00:23 -04:00
Jorim Jaggi
3e34579bb8 Merge "Fix crash in test" into oc-dev am: d5ece513ec
am: 3a981207ce

Change-Id: I0f564ed2cee6ad4e45968704a4c64029644bbc4c
2017-06-07 04:27:53 +00:00
TreeHugger Robot
d5ece513ec Merge "Fix crash in test" into oc-dev 2017-06-07 04:12:50 +00:00
Jorim Jaggi
fd3b1a1b76 Fix crash in test
Test: runtest systemui
Change-Id: I841b6ed21fb101e7873b218521c480c904f361f8
Fixes: 62389344
2017-06-06 17:04:19 -07:00
Dan Sandler
f5aafb9e18 Hide redundant foreground service notifications.
If an app with a foreground service has (at least one)
FLAG_FOREGROUND notification shown to the user, we allow
that to satisfy the requirement that the user be informed
about such things. But if the fg notification or its channel
is blocked by the user, we show the NOTE_FOREGROUND_SERVICES
notification (a/k/a Dianne's Dungeon) provided to us by the
activity manager.

Note that if even one of the foreground processes for the
current user is missing its disclosure notification, the
user will see the whole dungeon.

Bug: 36891897
Test: runtest -x frameworks/base/packages/SystemUI/tests/src/com/android/systemui/ForegroundServiceControllerTest.java
Change-Id: I435b7c01e60f99da162c9ea61656e2991d2cb87c
2017-06-06 17:36:33 -04:00
Lucas Dupin
6abac00870 Merge "Fix icon tint on notification shelf" into oc-dev am: 285ad4ce66
am: 6b5b7c4d31

Change-Id: I286f4e0881d225a859f465e37a60944fb4427828
2017-06-06 15:54:15 +00:00
TreeHugger Robot
285ad4ce66 Merge "Fix icon tint on notification shelf" into oc-dev 2017-06-05 23:29:49 +00:00
Dan Sandler
008cea772a Hide redundant foreground service notifications.
If an app with a foreground service has (at least one)
FLAG_FOREGROUND notification shown to the user, we allow
that to satisfy the requirement that the user be informed
about such things. But if the fg notification or its channel
is blocked by the user, we show the NOTE_FOREGROUND_SERVICES
notification (a/k/a Dianne's Dungeon) provided to us by the
activity manager.

Note that if even one of the foreground processes for the
current user is missing its disclosure notification, the
user will see the whole dungeon.

Bug: 36891897
Test: runtest -x frameworks/base/packages/SystemUI/tests/src/com/android/systemui/ForegroundServiceControllerTest.java
Change-Id: I4f5d96f80b7c1901faadb56661a42d26f746aa88
2017-06-05 11:18:59 -04:00
TreeHugger Robot
a92028966e Merge "Revisions to Inline Controls for unblockable apps" 2017-06-02 13:09:25 +00:00
Jason Monk
5070e5b4b3 Merge "Add checks against incorrect context use in sysui tests" into oc-dev am: 227e65d818
am: b629460f33

Change-Id: I5695d4b2361bdf4ec9abe054418780572e660d2a
2017-06-01 20:22:03 +00:00
Jason Monk
3c0db1e00e Merge "Fix crash from non-default sims in QS" into oc-dev am: d0ba2cd40b
am: a3c778f16c

Change-Id: I6f4434c18bf96f8541a19cfef3b5e5ae8ea2582e
2017-06-01 20:17:53 +00:00
TreeHugger Robot
227e65d818 Merge "Add checks against incorrect context use in sysui tests" into oc-dev 2017-06-01 19:43:49 +00:00
Geoffrey Pitsch
b43486a2ae Revisions to Inline Controls for unblockable apps
- Do not call out the channel name, just display "Notifications"
- Secondary text: "Notifications from this app can't be turned off"
- Button string is "More Settings" instead of "ALL CATEGORIES"

Fixes: 37539747
Test: runtest systemui
Change-Id: I75c80e0ef1ba320c9ff5cccf073116b70bb5a3bc
2017-06-01 13:47:56 -04:00