Commit Graph

978 Commits

Author SHA1 Message Date
Paul Stewart
700c72d01d Fix string equality comparison am: 1033c6fdbc am: fdd4fe53cf am: 3fbe9280a4
am: bf4f010a5b

Change-Id: I7e57c484be20197748c40c80acd987802b43a734
2016-07-20 00:37:50 +00:00
Paul Stewart
e2a03026c4 WifiEnterpriseConfiguration: Do not print credentials in toString am: cc00f4d646 am: fa4bbf4ad6 am: df93deccf9
am: 141477b103

Change-Id: Ie4c9d06d225a2b99ebb4411e4282ea792c67d26b
2016-07-20 00:37:44 +00:00
Paul Stewart
bf4f010a5b Fix string equality comparison am: 1033c6fdbc am: fdd4fe53cf
am: 3fbe9280a4

Change-Id: Ib3bea7489d319bb94a41f3c8cb0d8ec7e40b14b7
2016-07-20 00:31:22 +00:00
Paul Stewart
141477b103 WifiEnterpriseConfiguration: Do not print credentials in toString am: cc00f4d646 am: fa4bbf4ad6
am: df93deccf9

Change-Id: Iaeae846189a8f5fa38c5da988eec7879300f8ab5
2016-07-20 00:31:15 +00:00
Paul Stewart
3fbe9280a4 Fix string equality comparison am: 1033c6fdbc
am: fdd4fe53cf

Change-Id: Id179c734fc503abea1216e7c6057d4903a17f340
2016-07-20 00:25:17 +00:00
Paul Stewart
df93deccf9 WifiEnterpriseConfiguration: Do not print credentials in toString am: cc00f4d646
am: fa4bbf4ad6

Change-Id: I3ec1ff70fdfc2fd2aabf22ad1b7b3dad27ad4674
2016-07-20 00:25:14 +00:00
Paul Stewart
1033c6fdbc Fix string equality comparison
Don't use "==" to compare strings.

Bug: 25624963
Change-Id: Id25696e4fdcbcf4d48ec74e8ed65c1a33716b30c
2016-06-30 11:58:38 -07:00
Paul Stewart
cc00f4d646 WifiEnterpriseConfiguration: Do not print credentials in toString
BUG:25624963
Change-Id: I939a12a27d6b915d8a9cc8b142f645fba0ee42ec
2016-06-30 11:57:20 -07:00
vandwalle
8650c03560 aggressively blacklist WifiConfiguration for the purpose of switching network
In cases where networks are not properly configured, WiFi might tries to repeatdly switch from one network to a bad network, or might try to roam and renew DHCP which can fail. In KK, WiFi autojoin would try other networks (by cycling to network it sees) and end up associated to a "good" network. In L release even thought WiFi might pick a good network it will still repeatedly try to switch to what it thinks is a better network and fail, thus annoying the user whose connection becomes unstable. This CL tries to remember networks that have seen multiple DHCP or auth failure in the past and for those networks it disable roaming temporarily. That is, if wifi is not associated to any network, it will tries to join a network aggressively, however if wifi is currently associated to a network, it will not try to switch to a new network if that new network has seen multiple failure in the past. The maximum blacklist time is set to 2 days for now.
    An example of such situation is:
    - user has multiple SSID at home, one of which is incorrectly configured with a wrong password
    - broken DHCP situation (potentially: multiple servers on home network, broken implementation incorrecting NAK'ing DHCP requests but properly serving DHCP offer...)
Bug:18792931

Change-Id: I332a9cebdc19be2e00b455205d386fcffcb70b29
2015-01-23 18:35:27 -08:00
vandwalle
72e1d3f538 add debug logs to confirm network flapping issue is fixed
Bug:18706288

Change-Id: I59378faafbccfa58639d942c8b8e2e0e815261f4
2014-12-17 16:38:58 -08:00
vandwalle
53d1f07073 make sure wificonfiguration scan cache doesnt grow unbounded
Bug:18703749

Change-Id: I8e35d602a80b341668d9607db2da3ca6fdb970ae
2014-12-11 02:58:44 -08:00
vandwalle
93e4192c06 add disable Ephemeral Network API
Bug:18525241

Change-Id: I954c53c55c39f6c376b2bae3c7ac4d28246a7f5a
2014-12-05 14:56:43 -08:00
vandwalle
da123a6726 make startScan with worksource specific to location scans
Change-Id: Ia09dae3e334ef6fd11f2b468e78ad7c2c3cf55e9
2014-11-25 17:35:12 -08:00
Vinit Deshpande
c3eb155644 Fix WPS docs for LABEL method
Since we don't support LABEL method in startWps, document
it explicitly.

Bug: 18298388

Change-Id: I5d4c2475a68f1b41e5fc449c911b7b01b3b82fc4
2014-11-18 11:07:58 -08:00
vandwalle
ec3e9805dd dont blacklist wifi config that have had validated internet status in the past
Change-Id: Iadb4e0e1beeb9e582b944e003470815a5a865652
2014-11-10 14:27:20 -08:00
Jeff Davidson
f92fc1ca65 Fix incorrect doc for WifiInfo#getSSID().
This method will never return null. It may return "<unknown ssid>" if
no network is currently connected.

Change-Id: Iae09a6b2376e47c2d010f8d05750a16361510cca
2014-11-05 10:26:00 -08:00
Jeff Davidson
074c5b5b65 Merge "Don't drop WifiConfiguration's ephemeral bit on copy/parcel." into lmp-mr1-dev 2014-10-15 15:49:26 +00:00
vandwalle
63edd98d2e adding debug information to bug report for Bug:16751877
Change-Id: I9d417c20c6b6721933a4eb943c1305845005facf
2014-10-07 14:38:38 -07:00
Jeff Davidson
8faf2a2a15 Don't drop WifiConfiguration's ephemeral bit on copy/parcel.
Bug: 15892711
Change-Id: I4a027c99634a11d13bb3c8420ba959c201644689
2014-10-06 16:29:35 -07:00
vandwalle
c520aa89a3 add millisecond timestamp to locallog
Change-Id: I33d8672efd2747ed3f49dd8d5bcd5f47bf418053
2014-10-03 15:35:25 -07:00
Lorenzo Colitti
8e1e34a3f6 Revert the configKey generation algorithm to what it was in K.
Bug: 17670914
Change-Id: Ibb2ea26ea28a38518caab7d1b45ae535a0eaf661
2014-09-30 18:30:58 +09:00
vandwalle
176a27f3ab handle bssid blacklist in case of dhcp failures
Change-Id: Iba13db478ed69976c37bd4882f59bf0cae2212e6
2014-09-23 12:38:06 -07:00
Vinit Deshpande
02b115b2d8 Fix documentation for Wifi ScanResult.timestamp
Bug: 14997906
Change-Id: Idfcf9ade905c7565cc1d59d15aa4362c1b597b72
2014-09-19 14:23:25 -07:00
Prem Kumar
97a0c45cf8 Merge "Allow creating EAP_TLS network without specifying Phase2.None" into lmp-dev 2014-09-15 00:51:13 +00:00
vandwalle
2e93c38fa6 make wifi cellular params configurable
Change-Id: Ia2a4ac3e11f2b0c7412f33496a655c5d5297ea0c
2014-09-13 13:44:34 -07:00
Vinit Deshpande
26a98001ad Allow creating EAP_TLS network without specifying Phase2.None
Phase2 isn't required for EAP_TLS networks, and it is possible
for a developer to miss it. We are requiring it for internal
book keeping - so this change just sets Phase2 to 'None' when
EAP_TLS is set on the configuration.

Bug: 17043082
Change-Id: I5a8e0a3a236d0dfd1295584de55d5b9a1b76b483
2014-09-13 11:10:07 -07:00
vandwalle
94fe7e99d1 various fixes:
- allow for making use of more aggressive initial autojoin attempt rssi thresholds
- create a blacklist due to missing identiy reason
- make autojoin parameters configurable

Change-Id: I385db83aab1da7918ff6935eb59a209b253d42e6
2014-09-12 14:30:51 -07:00
vandwalle
e26bc8fda7 make autojoin configurable, clean up BSSID info that may be stake in WifiConfiguration
Change-Id: I5052f6a76bcd1f980ef558bff54ce1b172319743
2014-09-10 13:49:48 -07:00
Vinit Deshpande
a0000c6c3c Merge "Secure access to WifiScanner" into lmp-dev 2014-09-10 06:34:25 +00:00
Vinit Deshpande
592b95901e Merge "Implement getAvailableChannels" into lmp-dev 2014-09-09 01:28:45 +00:00
Vinit Deshpande
4b9975671f Secure access to WifiScanner
This change implements access control for WifiScanner. It is now
available to only those apps that have CONNECTIVITY_INTERNAL permissions.

Bug: 15088601
Change-Id: I6acc13079b6dac6f190644b6d1a270c271cc679f
2014-09-08 18:03:12 -07:00
vandwalle
448e208b0a add more info to WifiConfiguration.toString:
- add the noInternetAccess field
- add stats about user triggered wifi state disabling requests
- Wifi SSID can change even though we don't loose connection, hence it must be looked at with each Network State Change

Bug:17348200

Change-Id: Ic956e11e7d61faf472a7332f84a46a746922455a
2014-09-07 21:43:25 -07:00
Vinit Deshpande
15f8907878 Implement getAvailableChannels
This API allows finding channels by band, so scanning services
can find out which channels to use.

Bug: 16652660
Change-Id: I690825333988a336efa3fc8886297e5b8baf8e1d
2014-09-05 20:43:57 -07:00
David Christie
e7baf5afc0 Merge "Add @SystemApi annotations to methods used by GmsCore. -Currently these methods are called using reflection for location. Bug: 17371392 Change-Id: I6546f5b485415beff69164ba0d526757ee831f69" into lmp-dev 2014-09-04 20:53:39 +00:00
David Christie
c20b795cf0 Add @SystemApi annotations to methods used by GmsCore.
-Currently these methods are called using reflection for location.
Bug: 17371392
Change-Id: I6546f5b485415beff69164ba0d526757ee831f69
2014-09-04 20:53:21 +00:00
Vinit Deshpande
73f5d16ad5 Address API Council feedback for WifiAdapter/WPS APIs
This change addresses concerns from the API review. Things that
are fixed are -

1. WifiAdapter is removed, until we have 'real' support for it
2. All the methods from WifiAdapter are moved to WifiManager
3. Changed WPSListener API names to be onFailed/onSucceeded et al
4. Removed ActionListener from WPS APIs, they now take WpsListener

Bug: 16403303
Bug: 17115004

Change-Id: Ia721dd95041acb3e50d16690319e3320fe550ff5
2014-08-29 13:36:51 -07:00
vandwalle
b1dce0220b fix ScanResult read from parcel, this function was broken and causes wifi settings to crash
Bug: 17293156

Change-Id: I5f7a8141adb21103e98913c9802d8364164eaba7
2014-08-27 08:16:31 +00:00
vandwalle
7aea15a08e Merge "remove passpoint - DO NOT MERGE" into lmp-dev 2014-08-26 21:26:42 +00:00
vandwalle
808079bd27 remove passpoint - DO NOT MERGE
This CL is dependent on I3d2a230b0362520b9f1b2bc3792260116971e106

Change-Id: I1a0d655877d9368d833d62e231797af4b2560862
2014-08-26 14:56:04 +00:00
vandwalle
b928a3802b add radio stats to link layer
Bug:15563188

Change-Id: I3d2a230b0362520b9f1b2bc3792260116971e106
2014-08-26 00:28:42 +00:00
Wenchao Tong
ddd0986311 Merge "Revert "Annotate @SystemApi on some WifiManager methods."" into lmp-dev 2014-08-21 16:05:00 +00:00
vandwalle
beec21522d Merge "per bssid blacklist" into lmp-dev 2014-08-21 14:55:12 +00:00
Wenchao Tong
cd8e041668 Revert "Annotate @SystemApi on some WifiManager methods."
This reverts commit 041bcc22bd21f84358e5b2102e3a919bcdd99b81.

Bug: 17134034
Change-Id: I1ebcdd9b4c56e5c93fd5667699c8971e8c6e5452
2014-08-20 22:10:36 +00:00
vandwalle
612519db40 per bssid blacklist
Bug: 16823537

This CL is dependent on Iff32fae2cd67343e63046d58d75fa1e10d9775d0

Change-Id: Id9411c8097337b37ac1ce1a6ac8b28b4bda31ff3
2014-08-20 21:07:02 +00:00
Jeff Davidson
833dcd4bea Merge "Improve documentation of ScanResult and WifiInfo." into lmp-dev 2014-08-20 20:15:45 +00:00
vandwalle
da3475dba7 Merge "remove passpoint, except ANQP - DO NOT MERGE" into lmp-dev 2014-08-20 16:06:26 +00:00
Wenchao Tong
4d11492071 Annotate @SystemApi on some WifiManager methods.
Bug: 17112931
Change-Id: I5980bc46bc1f16316caecd7fcc6cd771b8ca6cdf
2014-08-19 09:42:41 -07:00
vandwalle
1575d90605 remove passpoint, except ANQP - DO NOT MERGE
This CL is dependend on Ic3ae7269f0ca11cec6b7aea5143499e88ecc7149

Change-Id: Ic533d1820c470bf2370a92452b37515ef7458f45
2014-08-19 01:54:41 +00:00
Wenchao Tong
36ecb30b87 Merge "Annotate @SystemApi on some WifiManager methods." into lmp-dev 2014-08-19 02:43:23 +00:00
Lorenzo Colitti
0a82e80073 Stop using LinkProperties for static configuration.
LinkProperties can represent way more complicated configurations
than what we can actually apply to interfaces. This makes it
error-prone to use it to represent static configuration, both
when trying to apply configuration coming from LinkProperties
and when trying to save configuration from current
LinkProperties.

Instead, move static configuration (IPv4 only, since we don't
support static IPv6 configuration) into a separate
StaticIpConfiguration class.

Bug: 16114392
Bug: 16893413
Change-Id: Ib33f35c004e30b6067bb20235ffa43c247d174df
2014-08-19 11:59:43 -07:00