Commit Graph

114959 Commits

Author SHA1 Message Date
TreeHugger Robot
13d7838088 Merge "Address leftover TODOs from inline suggestions." into rvc-dev 2020-04-29 01:46:47 +00:00
TreeHugger Robot
8ba4e7599a Merge "Resolve IndexOOBException in SigningDetails#hasAncestor" into rvc-dev 2020-04-29 01:21:27 +00:00
TreeHugger Robot
007a73c551 Merge "Don't remove OnAlarmListener mappings in the client" into rvc-dev 2020-04-29 01:09:32 +00:00
Adam He
045c020636 Address leftover TODOs from inline suggestions.
Fixes: 146524826
Test: atest android.autofillservice.cts.inline
Change-Id: I50666e9fa012b18f74c20982068a452fdc9592f8
2020-04-28 17:17:47 -07:00
Yifan Hong
325bbcf799 Merge "Update cleanupAppliedPayload comment." into rvc-dev 2020-04-29 00:08:37 +00:00
Jeffrey Huang
144788b5bb Merge "Update process_state_changed logging" into rvc-dev 2020-04-28 22:56:29 +00:00
Suprabh Shukla
7d40780e39 Don't remove OnAlarmListener mappings in the client
Removing the mapping is prone to races in keeping the state consistent
with the server. An inconsistent state can lead to multiple alarms on
the server for the same listener.

Test: atest CtsJobSchedulerTestCases doesn't fill the alarm queue with
more than one alarm.
atest CtsAlarmManagerTestCases

Bug: 154444435
Change-Id: Iaf11d5decb17fbf2366b49d9865231bf65dbdc41
2020-04-28 15:37:21 -07:00
Michael Groover
09c24c3c4f Resolve IndexOOBException in SigningDetails#hasAncestor
When a package that is part of a shareduid is installed / updated its
lineage is compared against the current signature / lineage for the
shareduid. If the new package has more than one signature in the lineage
an IndexOutOfBoundsException is thrown by SigningDetails#hasAncestor
crashing the system server. This commit ensures the ancestor check
is only performed against the current signer for the shareduid.

Fixes: 155134046
Test: atest SigningDetailsTest
Change-Id: Icef9f21c6901e255e5276085259d2f773f41e858
2020-04-28 15:08:20 -07:00
Yifan Hong
524d0f5c28 Update cleanupAppliedPayload comment.
ServiceSpecificException might be thrown, but it is not
actionable by the caller. Hence hide the comment.

Fixes: 151156841
Test: none
Change-Id: I07836fe2c5cc361fa81f6fc24851ad2b0721591b
(cherry picked from commit d3abb6d385)
Merged-In: I07836fe2c5cc361fa81f6fc24851ad2b0721591b
2020-04-28 14:41:50 -07:00
TreeHugger Robot
48f0527199 Merge "Close heap dump ParcelFileDescriptor." into rvc-dev 2020-04-28 20:52:29 +00:00
Jeffrey Huang
419197630e Update process_state_changed logging
Log only the parent state to avoid unnecessary process states from being
sent to statsd. This may not work for all cases, but the edge cases can
be revisited later.

Bug: 135965535
Bug: 135375287
Test: manually tested using chrome
Change-Id: I87b79f5d21f186f227a5a50bbe83b56a9105348c
2020-04-28 13:48:06 -07:00
TreeHugger Robot
bc000662c3 Merge "Fix a bug in InlinePresentationStyleUtils#bundleEquals" into rvc-dev 2020-04-28 20:17:02 +00:00
TreeHugger Robot
04ccfdfae7 Merge "Don't pass initial intents to the inactive profile." into rvc-dev 2020-04-28 19:19:17 +00:00
TreeHugger Robot
821b7f21b0 Merge "Move conversation app name into header" into rvc-dev 2020-04-28 18:51:35 +00:00
Feng Cao
ca8cf2776d Fix a bug in InlinePresentationStyleUtils#bundleEquals
* before the fix, the method would return false if the two bundles both
  contains a nested bundle for the same key, and the nested bundles are
  equal. i.e. the test case
  InlinePresentationStyleUtilsTest#testBundleEquals_nestedBundle_equal
  would fail.

Test: atest InlinePresentationStyleUtilsTest
Bug: 154957669

Change-Id: Ia2cf682619fa245d846972a8683d03333551df78
2020-04-28 11:27:59 -07:00
arangelov
acc8243564 Don't pass initial intents to the inactive profile.
Otherwise the initial intents will be shown in the other
profile as share targets. This would cause a crash when
the user selects the app, as the activity cannot
be resolved.

Fixes: 155088755
Test: manual
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: I0604c15c35ecddf163460286b84c27daf6ca9a5b
2020-04-28 18:52:54 +01:00
Julia Reynolds
49467eebac Update logging
Priority isn't used; shortcut is

Test: manual
Bug: 149651274
Change-Id: If6577c5588afe5e48787ae7e6bc528442fdb3423
2020-04-28 14:50:01 +00:00
TreeHugger Robot
8862ee3891 Merge "Only perform autolaunch if list has completely rebuilt" into rvc-dev 2020-04-28 13:59:33 +00:00
Julia Reynolds
8582df5cc7 Add experience for shortcut-less convos
- no conversation specific controls
- no 'bubble this' button
- turn off interim placeholder channels
- fix msg tracking - only shortcut-less notifs matter

Test: atest
Bug: 154814754
Change-Id: Ia04ce496d4e7b2f353c71865f338b5229192c395
2020-04-28 12:11:47 +00:00
arangelov
1b11cc1a17 Only perform autolaunch if list has completely rebuilt
Previously we would check for autolaunch the first time
onPostListReady is called, but that is too early in the case
when we start the async task for sorting the targets. In
that case onPostListReady is called twice - once before
task is launched, and once after task is finished.

We fix this by passing the rebuildListCompleted parameter to
the onPostListReady callback and use it to check for autolaunch.

Test: atest ChooserActivity
Test: atest ResolverActivity
Test: manual
Fixes: 154728817
Change-Id: Ib1b049af00d791898b908bdb65971c07c558f3ac
2020-04-28 12:59:18 +01:00
TreeHugger Robot
f6288ea881 Merge "Enforce permission check in getUidStats function" into rvc-dev 2020-04-28 09:13:32 +00:00
Alex Johnston
a077a8a0cc Merge "Update setOrganizationColor javadoc" into rvc-dev 2020-04-28 08:36:57 +00:00
Chris Li
9859a326c1 Merge "Cache isSystemOrSystemUI on ContextImpl creation" into rvc-dev 2020-04-28 04:02:05 +00:00
TreeHugger Robot
046df72d9a Merge "Revert "Q Upstream: Use ParcelFileDescriptor for storing large clip data."" into rvc-dev 2020-04-28 02:12:12 +00:00
TreeHugger Robot
5e9aed81d0 Merge "Support WRAP_CONTENT in InlineSuggestion#inflate" into rvc-dev 2020-04-27 23:52:59 +00:00
Diego Vela
7383ef7a6c Merge "Fix default constructor for DisplayAdjustments" into rvc-dev 2020-04-27 23:41:45 +00:00
Sally Yuen
f8331a8a91 Merge "Fix system action API issues in SystemActions" into rvc-dev 2020-04-27 23:06:10 +00:00
Feng Cao
bd26abbc5b Support WRAP_CONTENT in InlineSuggestion#inflate
Test: atest android.autofillservice.cts.inline
Bug: 154887895

Change-Id: Ie420bd40e8f0fb7d6e6b1e47ed0f41dc3f85b25e
2020-04-27 15:12:14 -07:00
Evan Rosky
db49a262de Merge "Connect systemwindow root with accessibility" into rvc-dev 2020-04-27 21:52:07 +00:00
Philip P. Moltmann
fa658e0206 Merge "Fix typos in permissions.md" into rvc-dev 2020-04-27 21:18:40 +00:00
sallyyuen
93edd11724 Fix system action API issues in SystemActions
1) Actions are only registered when the service starts. If the locale
changes, the labels need to be translated, so re-register the actions
when this happens.

2) When its shortcut isn't visible the a11y menu action is a no-op. The
list should be an accurate representation of what actions are available.
Pass SystemActions into NavigationBarFragment, which keeps track of the
shortcut availability,  to unregister/register the action.

To do this, SystemActions exposes register/unregister to the fragment
and makes SYSTEM_ACTION_ID_ACCESSIBILITY_MENU public.

3) Remove Toggle Split Screen from SystemActions. The trigger isn't
system-level but is rather buried in the Recents UI in a button for each
app, and the a11y user can access this like everyone else.
SystemActionPerformer will still handle the legacy action call in
performSystemAction.

4) Rename "Accessibility Menu" to "On-screen Accessibility Shortcut"

Bug: 152636060, 152635646, 154833492
Test: Manual TalkBack test
Change-Id: I9b037f91c8d3b6f193fc9aee95ef73b7f3fbf315
2020-04-27 13:05:57 -07:00
TreeHugger Robot
1ef9f259c4 Merge "Keep the intent resolver button bar stuck to the bottom." into rvc-dev 2020-04-27 19:53:32 +00:00
TreeHugger Robot
9153a323fd Merge "Update one-line layout for conversation notifs" into rvc-dev 2020-04-27 19:53:23 +00:00
Steve Elliott
f7ef4efeda Move conversation app name into header
Bug: 154511267
Test: visual, manual, atest
Change-Id: I929569a5e3f39df69258f1ec5ee58057c95d2387
2020-04-27 15:40:18 -04:00
Mehdi Alizadeh
082d0c47b7 Merge "Adds unit tests for ShortcutChangeCallback APIs" into rvc-dev 2020-04-27 19:34:25 +00:00
Chavi Weingarten
5d2781b772 Merge "Added takeScreenshot API to WindowOrganizer" into rvc-dev 2020-04-27 18:59:49 +00:00
Kweku Adams
f1ddecc60e Close heap dump ParcelFileDescriptor.
The file descriptor is only closed in certain situations. Explicitly
closing it to ensure we don't have any leaks.

Bug: 154277871
Test: take a system heap dump via developer options & and watch for StrictMode violation
Test: adb shell am dumpheap <system|another app> & and watch for StrictMode violation
Change-Id: I3ae3e270bcec18ba531055becfff32924c8f2a2d
2020-04-27 18:43:09 +00:00
Chris Li
e7f4f30698 Cache isSystemOrSystemUI on ContextImpl creation
When creating Context without a container Context, cache the value of #isSystemOrSystemUI().

Fix: 154161051
Test: atest FrameworksCoreTests:ContextTest
Change-Id: I1d16173c7da06a73d1338e3d6e75f5b56fcdbe23
2020-04-27 11:35:31 -07:00
TreeHugger Robot
756662fb2f Merge "Inform receivers of restart attempt previous visibility" into rvc-dev 2020-04-27 18:29:46 +00:00
Miranda Kephart
c8f22beefe Merge "Keep screenshot process bound" into rvc-dev 2020-04-27 18:00:43 +00:00
Diego Vela
7c59c63943 Merge "Update Documentation for onActivityResult." into rvc-dev 2020-04-27 17:58:29 +00:00
Aran Ink
82e9872732 Merge "Add dismissImmediate to ListPopupWindow to prevent window leaks in GlobalActionsDialog." into rvc-dev 2020-04-27 17:57:15 +00:00
Mehdi Alizadeh
666796b0fa Merge "Include cache-only and pinned-only shortcuts as Sharing shortcuts as well" into rvc-dev 2020-04-27 17:47:23 +00:00
arangelov
27b997491e Keep the intent resolver button bar stuck to the bottom.
Fixes: 154939990
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Test: manual
Change-Id: Ia450701650dfca55488ed7bf1f9bebcae5b72c2c
2020-04-27 18:40:47 +01:00
Rob Carr
9005cdcf01 Merge "BLAST: Two start-up optimizations" into rvc-dev 2020-04-27 17:20:42 +00:00
Taran Singh
88191952ec Merge "Add test for ImeInsetsSourceConsumer" into rvc-dev 2020-04-27 17:08:05 +00:00
chaviw
5ef1e93671 Added takeScreenshot API to WindowOrganizer
Added requests to take screenshot of a Window that's organized
by the client. The resulting screenshot will be attached to a
SurfaceControl and reparented to the requested window's parent. The
client will be responsible for showing, setting z order, etc. They can
also re-parent to another place in the hierarchy. The default is to
parent to the window's parent since that's usually where a screenshot is
placed.

Test: Builds
Bug: 152114574
Change-Id: I5c829e029f3528fdb382842e9f0474097e01cb2e
Merged-In: I5c829e029f3528fdb382842e9f0474097e01cb2e
2020-04-27 16:45:27 +00:00
TreeHugger Robot
2133dc6e73 Merge "Implement direct share targets quota based onto app share score in ChooserTarget ranking protorype." into rvc-dev 2020-04-27 16:17:27 +00:00
TreeHugger Robot
bac5755dad Merge "Allow tests for more PermissionControllerManager methods" into rvc-dev 2020-04-27 16:16:28 +00:00
Evan Rosky
8d1c24e0a5 Inform receivers of restart attempt previous visibility
This way receivers like recents know whether the activity
was already visible before a restart attempt.

Bug: 154575664
Test: added test. Can also launch a running activity into
      split-primary and it won't expand it.
Change-Id: If59ee1615fa36bbe3af9412194a7f96b9377528a
2020-04-27 09:13:31 -07:00