Commit Graph

8346 Commits

Author SHA1 Message Date
Joshua Baxter
e86542744b Merge "docs: remove old broken link" into qt-dev am: 2dc61fc4f4 am: 101f294b58 am: 2947a87032
am: b5ac0fcb80

Change-Id: Id141c82bb2fdc996aa9c45978ccf8542878721ad
2019-11-06 14:43:57 -08:00
Joshua Baxter
2cb2f20f5b Merge "docs: fix typo" into qt-dev am: 74ff8a0bbd am: 6b70c7893d am: ebfb71dcde
am: 83e9f58ddb

Change-Id: Id91dbc7d6dd317c70386bfa1bb37102830929477
2019-11-06 14:27:32 -08:00
Joshua Baxter
b5ac0fcb80 Merge "docs: remove old broken link" into qt-dev am: 2dc61fc4f4 am: 101f294b58
am: 2947a87032

Change-Id: I8dab46c3abe2702156eefd500b74b0ed66426c55
2019-11-06 14:25:37 -08:00
Joshua Baxter
83e9f58ddb Merge "docs: fix typo" into qt-dev am: 74ff8a0bbd am: 6b70c7893d
am: ebfb71dcde

Change-Id: I11c4688e4023c72ec8beafa16e4ac5195f79714f
2019-11-06 14:13:05 -08:00
Joshua Baxter
2947a87032 Merge "docs: remove old broken link" into qt-dev am: 2dc61fc4f4
am: 101f294b58

Change-Id: Id655af3e092e125cc80cdb0d792e56a4adb93100
2019-11-06 14:09:20 -08:00
Joshua Baxter
ebfb71dcde Merge "docs: fix typo" into qt-dev am: 74ff8a0bbd
am: 6b70c7893d

Change-Id: I930b4b473f697499857eac19cfa6eb4d6d290cef
2019-11-06 13:57:01 -08:00
Joshua Baxter
101f294b58 Merge "docs: remove old broken link" into qt-dev
am: 2dc61fc4f4

Change-Id: Ib025e4553835807c5c44496c992fb3a79827bf6b
2019-11-06 13:49:15 -08:00
Joshua Baxter
6b70c7893d Merge "docs: fix typo" into qt-dev
am: 74ff8a0bbd

Change-Id: If59dc047a0e4d8095b3a22f4609ce125af6acfe5
2019-11-06 13:38:58 -08:00
Joshua Baxter
2dc61fc4f4 Merge "docs: remove old broken link" into qt-dev 2019-11-06 21:22:59 +00:00
Joshua Baxter
a51a9b7e96 docs: fix typo
Change-Id: I2e8f28a917d0b09c0bf0a11f0db863ae7bf03ac8
test: make ds-docs
bug: 79156293
2019-11-06 21:14:54 +00:00
Joshua Baxter
5e3b85b46d docs: remove old broken link
Change-Id: If39d214fde055c412dd881c282e543975a7cbc49
test: make ds-docs
bug: 120135854
2019-11-06 21:09:08 +00:00
Nikita Dubrovsky
b6b8c731a4 Merge "Add debug logging for cursor logic in TextView and Editor" 2019-10-31 19:56:21 +00:00
TreeHugger Robot
20277b8309 Merge "Set "today" and "selected" for Datepicker when using Calender" 2019-10-31 18:34:03 +00:00
Nikita Dubrovsky
05cfcc8ac4 Add debug logging for cursor logic in TextView and Editor
Test: manual
Change-Id: If5ddb575af3518aba2c4fbed3d6a040898c0d003
2019-10-31 08:15:23 -07:00
Yinglei Wang
6adfce55c2 Merge "remove accessibility event throttling in Progressbar" 2019-10-30 18:57:29 +00:00
yingleiw
7eef9a1adf Set "today" and "selected" for Datepicker when using Calender
Set the stateDescription to "today" if the date is today. Set selected
if the date is selected. Note that we didn't remove any information, so
this change doesn't need to wait until talkback changes get in.

Bug: 142361188, 141454158
Test: tested with date picker in calender mode. When the focus goes to
today, it announces "today, Oct. 22". When the focus goes to selected
date, it announces "selected, Oct. 22". When it is both today and
selected, it announces "select, today, Oct. 22".

Change-Id: Id210e22ec5ae2bc070c260c9632a605cf2a6236f
2019-10-24 15:27:41 -07:00
yingleiw
3e7bf90634 remove accessibility event throttling in Progressbar
The current throttling is not good: when we update progress periodically
at an interval smaller than 200ms, no progress is announced except
for the last 100% in talkback. We will reply on the throttling when
sending out state change events after adopting the accessibility state
api: we only send out state change events when the state description
actually changes.

Bug: 143079143
Test: tested with talkback test when updating progress at different
frequencies.

Change-Id: I7480a3420130fc42645df17074b093cdced430ae
2019-10-21 17:03:03 -07:00
Yinglei Wang
818f433f50 Merge "Separator in AbsListView should not be clickable" 2019-10-08 18:51:48 +00:00
Phil Weaver
239720107c Merge "Add @CallSuper to TextView#onSelectionChanged" 2019-10-04 17:39:08 +00:00
Phil Weaver
7f0348298e Add @CallSuper to TextView#onSelectionChanged
Clarifying the need to call super to make sure the a11y event
gets dispatched.

Bug: 65416426
Test: No functional changes, so just doing make
Change-Id: I34eb295b7d4d56c5211fb7c249e07d676ee7f295
2019-10-03 15:43:46 -07:00
yingleiw
d5b8992727 Separator in AbsListView should not be clickable
In ListAdapter, isEnabled (int position) returns true if the
item at the specified position is not a separator. (A
separator is a non-selectable, non-clickable item). So we should
not set it to clickable in accessibility node info when the item
is disabled.

Bug: 140017328
Test: After the fix, talkback focus will skip the separator in
linear navigation.

Change-Id: Id0a76a2f93b8af730dab1a808dc24a0ae24bcee0
2019-10-01 12:25:16 -07:00
Yinglei Wang
577002d730 Merge "[SimpleMonthView] days should be set clickable even when disabled" 2019-09-27 16:08:04 +00:00
yingleiw
a26a37c8ff [SimpleMonthView] days should be set clickable even when disabled
Currently, ACTION_CLICK is removed when a day is disabled. This causes
the month to be the first non-title talkback focusable item and talkback
places the initial focus on the month and announces all the disabled
dates. According to discussion, disabling an item should not change
whether it is talkback focusable. We still set the days as clickable
even when they are disabled. After the fix, the disabled days are also focusable (and will be
announced as disabled when talkback focus goes there). The initial focus
will go the first non-title focusable item (previous or next month
button).

Bug: 122831096
Test: Tested that after the fix, the initial focus will go the first
non-title focusable item (previous or next month button depends on the
visibility). The month never gets accessibility focus.

Change-Id: I925539282729d5d8418233fc95d3761ea2d0108f
2019-09-23 17:58:09 -07:00
Kevin Hufnagle
7968676de7 Merge "docs: Fixed link to material design for ScrollView" into qt-dev am: 80b543b45a am: 71f8040c3b am: 379b87531b
am: fe98a0d3bf

Change-Id: I164a9eaaf8eb9b15689203addc1083b6bedaac58
2019-09-20 16:05:09 -07:00
Kevin Hufnagle
fe98a0d3bf Merge "docs: Fixed link to material design for ScrollView" into qt-dev am: 80b543b45a am: 71f8040c3b
am: 379b87531b

Change-Id: Ia2422002d2f4b654c75116003501a248b65bf07d
2019-09-20 15:54:00 -07:00
Kevin Hufnagle
379b87531b Merge "docs: Fixed link to material design for ScrollView" into qt-dev am: 80b543b45a
am: 71f8040c3b

Change-Id: I317e75554f4741551e8221bfacb447ad0e914f4e
2019-09-20 15:47:23 -07:00
Kevin Hufnagle
71f8040c3b Merge "docs: Fixed link to material design for ScrollView" into qt-dev
am: 80b543b45a

Change-Id: Ic7cc4494a88e6feaedf85626270ed1e8057189f5
2019-09-20 15:39:50 -07:00
Kevin Hufnagle
926edfeb0c docs: Fixed link to material design for ScrollView
Test: make ds-docs -j32

Bug: 141024886
Change-Id: I69d05cdf99d91f74143454c78c000128d1da42ce
2019-09-19 23:50:47 +00:00
Long Ling
6fef46e473 Editor: do not blink when invisible to user
Bug: 140945114
Change-Id: Ie9f3c872530d6c683782472fe019f2914de1abc1
2019-09-18 11:53:12 -07:00
Yinglei Wang
aee3a9f714 Merge "Use -1 for ListView CollectionInfo" 2019-09-17 23:00:25 +00:00
yingleiw
7aa2e1f194 Use -1 for ListView CollectionInfo
Talkback is supposed to announce the number of "accessibility" items,
and some views from the adapter may set importance for accessibility
to no. Or one view may contain several children views. This is
consistent with what the recyclerview is currently doing.

Bug: 140313418
Test: after the change, talkback doesn't announce the number of items in
a list. Everything else remains the same.

Change-Id: Id05d96562e523ebd746ac4dbb652b0b15bf366a6
2019-09-17 11:04:13 -07:00
Mady Mellor
a5813e0e3d qt-r1-bubbles-dev @ build 5835883
Test: presubmit setup on source branch

Bug: 126945401
Bug: 128932906
Bug: 129158983
Bug: 130237686
Bug: 130250809
Bug: 130442248
Bug: 131267438
Bug: 131609280
Bug: 131692350
Bug: 131849856
Bug: 133444037
Bug: 134064116
Bug: 134064858
Bug: 134070807
Bug: 134077101
Bug: 134090085
Bug: 134155107
Bug: 134423445
Bug: 134512898
Bug: 134514210
Bug: 134514227
Bug: 134734945
Bug: 134960381
Bug: 134989736
Bug: 135214687
Bug: 135280077
Bug: 135472021
Bug: 135475155
Bug: 135487618
Bug: 135488406
Bug: 135518045
Bug: 135633218
Bug: 136034310
Bug: 136150954
Bug: 136199542
Bug: 136538998
Bug: 137201711
Bug: 137213469
Bug: 137214359
Bug: 137214536
Bug: 137233453
Bug: 137876221
Bug: 138301618
Bug: 138445026
Bug: 138659213
Bug: 138749133
Bug: 138799651
Bug: 138801505
Bug: 138941969
Bug: 139002444
Bug: 139025304
Bug: 139816141
Change-Id: Ia7364529ea58070c8d45ecd726ab6ac7d34f2abe
Merged-In: Ic271a6a0f0803941dd5a84124dabf4d8c5fcc755
Merged-In: Ic3a4ba793db7f1361678ef51c411d9eab85d9b85
2019-09-11 22:42:54 +00:00
TreeHugger Robot
50afc5eb41 Merge "Avoid global transaction in magnifier" 2019-09-11 20:47:28 +00:00
Mady Mellor
8e10394ccc qt-r1-bubbles-dev @ build 5835883
Test: presubmit setup on source branch

Bug: 126945401
Bug: 128932906
Bug: 129158983
Bug: 130237686
Bug: 130250809
Bug: 130442248
Bug: 131267438
Bug: 131609280
Bug: 131692350
Bug: 131849856
Bug: 133444037
Bug: 134064116
Bug: 134064858
Bug: 134070807
Bug: 134077101
Bug: 134090085
Bug: 134155107
Bug: 134423445
Bug: 134512898
Bug: 134514210
Bug: 134514227
Bug: 134734945
Bug: 134960381
Bug: 134989736
Bug: 135214687
Bug: 135280077
Bug: 135472021
Bug: 135475155
Bug: 135487618
Bug: 135488406
Bug: 135518045
Bug: 135633218
Bug: 136034310
Bug: 136150954
Bug: 136199542
Bug: 136538998
Bug: 137201711
Bug: 137213469
Bug: 137214359
Bug: 137214536
Bug: 137233453
Bug: 137876221
Bug: 138301618
Bug: 138445026
Bug: 138659213
Bug: 138749133
Bug: 138799651
Bug: 138801505
Bug: 138941969
Bug: 139002444
Bug: 139025304
Bug: 139816141
Change-Id: Ic3a4ba793db7f1361678ef51c411d9eab85d9b85
Merged-In: Ic271a6a0f0803941dd5a84124dabf4d8c5fcc755
2019-09-09 21:48:30 +00:00
Robert Carr
64660bedad Avoid global transaction in magnifier
It's not good to use the global transaction from the render thread
like this as the UI thread could also be using it from SurfaceView. Transaction
objects require external synchronization so we could be corrupting them.

Bug: 140070297
Test: Builds
Change-Id: I17b4c1417d45cc825fca380350c326ed6b3edcf6
2019-08-27 13:25:51 -07:00
Kevin Hufnagle
db1bad4ab9 Merge "docs: Added content desc in ImageView example." into qt-dev am: eba5156095
am: 230a23e8d2

Change-Id: Ibf9c2193db824ffd49022d9139b520a6d0986c52
2019-08-27 02:13:09 -07:00
Kevin Hufnagle
f9cea382c9 Merge "docs: Added content desc in ImageView example." into qt-dev am: eba5156095 am: f1e24288bb am: 37f493ca26
am: 9c463f3133

Change-Id: I79398cc80d534de3c321a4dc55965716c7a0158d
2019-08-26 19:17:13 -07:00
Kevin Hufnagle
9c463f3133 Merge "docs: Added content desc in ImageView example." into qt-dev am: eba5156095 am: f1e24288bb
am: 37f493ca26

Change-Id: Iec84b01b73fc9eceed77aa885811070fcc1e7f29
2019-08-26 17:15:07 -07:00
Kevin Hufnagle
73ca522b5f Merge "docs: Added content desc in ImageView example." into qt-dev am: eba5156095
am: 230a23e8d2

Change-Id: I4b267e50e8553b1e7c0e0371ad0bf100a442ee1d
2019-08-26 16:07:03 -07:00
Kevin Hufnagle
37f493ca26 Merge "docs: Added content desc in ImageView example." into qt-dev am: eba5156095
am: f1e24288bb

Change-Id: I8f43342b0114655a9a4467d8247ae238261ef9e0
2019-08-26 16:06:10 -07:00
Kevin Hufnagle
f1e24288bb Merge "docs: Added content desc in ImageView example." into qt-dev
am: eba5156095

Change-Id: I440bf71cdf541a0048cf0655372553d391ab611c
2019-08-26 15:13:26 -07:00
Kevin Hufnagle
230a23e8d2 Merge "docs: Added content desc in ImageView example." into qt-dev
am: eba5156095

Change-Id: I08a66c2da26833978d2ed4b77de175b3bfe78931
2019-08-26 15:10:39 -07:00
TreeHugger Robot
2941abbc9b Merge "Revert "The source of subtree chagnes should be the viewParent"" 2019-08-24 10:41:25 +00:00
TreeHugger Robot
4b7b1af6b1 Merge "Make TextClock.refresh() a public API" 2019-08-24 06:06:55 +00:00
Qasid Sadiq
9a65d51435 Revert "The source of subtree chagnes should be the viewParent"
This reverts commit ed508280f9.

Reason for revert: Caused a performance regression: b/138853920

Change-Id: Ibc981ffca7aa0bf365eeea4d4e5e57259ce40f35
2019-08-23 19:52:41 +00:00
shawnlin
ec99810e5b Make TextClock.refresh() a public API
Starting from R, apps in /product are not allowed to use hidden API.
TextClock.refresh() is used in FloralClock which is in /product.

We need to make it a public API.

Bug: 132750099
Test: make
Change-Id: I20adbff79270ce9d13f3323386d3636c322012f1
2019-08-23 10:52:08 +08:00
Tony Mak
e9f236906d Merge "Hold a strong reference to the callback in TextClassifierService" into qt-qpr1-dev
am: 8247b5f5a6

Change-Id: I8591d0ac8025589679e9462e82c7bbcf4ea8ea63
2019-08-22 14:43:03 -07:00
Tony Mak
7ba3fd4546 Hold a strong reference to the callback in TextClassifierService
Issue:
TextClassifierService failed to invoke the callback to send the result back to client
occasionally because  the callback object may be GCed.
And thus smart selection failed occasionally, as the client doesn't get a response
back when it hits this issue. It won't fallback to local textclassifier due to the
timeout specified in TextView.

Cause:
We thought that ITextClassifierCallback is a "cross process" reference, and
so we only store a weak reference of it to avoid leak.
And it turns out that it is wrong. As soon as the weak ref gets GCed in
the service, that counts as dropping the callback. The service doesn't
know about any strong references the client has.

Bug: 138865849

Test: Try smart selection over 30 times, make sure smart action is shown
for every single time.

Merged-In: Ia9218cf67e8d67697a0fdff22c7918a55efc39ca

Change-Id: I4d89518dfff777ba5d999d9ba89d7f4cf7598e75
2019-08-22 14:19:23 +00:00
Tony Mak
cdc81e8aff Hold a strong reference to the callback in TextClassifierService
Issue:
TextClassifierService failed to invoke the callback to send the result back
to client occasionally because  the callback object may be GCed.
And thus smart selection failed occasionally, as the client doesn't get
a response back when it hits this issue. It won't fallback to local
textclassifier due to the timeout specified in TextView.

Cause:
We thought that ITextClassifierCallback is a "cross process" reference, and
so we only store a weak reference of it to avoid leak.
And it turns out that it is wrong. As soon as the weak ref gets GCed in
the service, that counts as dropping the callback. The service doesn't
know about any strong references the client has.

Bug: 138865849

Test: Try smart selection over 30 times, make sure smart action is shown
for every single time.

Change-Id: Ia9218cf67e8d67697a0fdff22c7918a55efc39ca
2019-08-22 15:17:09 +01:00
Kevin Hufnagle
b358694739 docs: Added content desc in ImageView example.
The example ImageView at the beginning of the class description now
includes a content description attribute. Also updated the links in
the first paragraph where code fonts aren't necessary.

Test: make ds-docs -j32

Bug: 138856073
Change-Id: I33a75dc31d68289d955979d2fe8afe2ae3d4770e
2019-08-14 18:29:55 -07:00