Commit Graph

13225 Commits

Author SHA1 Message Date
TreeHugger Robot
2941abbc9b Merge "Revert "The source of subtree chagnes should be the viewParent"" 2019-08-24 10:41:25 +00:00
Qasid Sadiq
9a65d51435 Revert "The source of subtree chagnes should be the viewParent"
This reverts commit ed508280f9.

Reason for revert: Caused a performance regression: b/138853920

Change-Id: Ibc981ffca7aa0bf365eeea4d4e5e57259ce40f35
2019-08-23 19:52:41 +00:00
Joanne Chung
d38b888249 Merge "Log the error of TCS, TCMS and SysTC." 2019-08-22 02:03:14 +00:00
Joanne Chung
0b7c2c4135 Log the error of TCS, TCMS and SysTC.
TextClassifierService passes the error message to onFailure() when it fails
to process the task. But the error message was dropped at TextClassifierService
right away which makes debugging hard. Log the error at the place where the
error happens to help debugging.

Bug: 139114128
Test: Manual. Use DefaultTCService to pass error message and make sure
the error log is printed.

Change-Id: I7c848a6e96db85d6e5b4f90ee9677dfe5b703149
2019-08-21 16:47:53 +08:00
Joanne Chung
14275a9388 Merge "Move disable autofill from AutofillManagerService to AutofillOptions." 2019-08-21 06:29:18 +00:00
Sally Yuen
b3d0111b46 Merge "Add more ScrollDeltaX/Y support to AccessibilityRecord." 2019-08-19 23:10:07 +00:00
Mihir Patel
7e2700d328 Merge "Fixing a bug where content capture sessions with child sessions could get stuck in a state where no event flushing other than forced flushes would occur" into qt-r1-dev am: 4aa0aeadff am: c1b765e744
am: 6b365322d4

Change-Id: Idcce863bc63e9fb38d5a54080dcd9b86e192941c
2019-08-19 14:38:34 -07:00
Mihir Patel
6b365322d4 Merge "Fixing a bug where content capture sessions with child sessions could get stuck in a state where no event flushing other than forced flushes would occur" into qt-r1-dev am: 4aa0aeadff
am: c1b765e744

Change-Id: Ie4ed8565ad223fb751dded6414288ae619cd8aaa
2019-08-19 13:58:27 -07:00
Mihir Patel
c1b765e744 Merge "Fixing a bug where content capture sessions with child sessions could get stuck in a state where no event flushing other than forced flushes would occur" into qt-r1-dev
am: 4aa0aeadff

Change-Id: I5fbd4bbc0d08b0a43c12d36b2b172e2df1edb64a
2019-08-19 13:37:01 -07:00
Joanne Chung
9e247b1564 Move disable autofill from AutofillManagerService to AutofillOptions.
Bug: 125007037
Test: atest CtsAutoFillServiceTestCases
Change-Id: Ib139cffaced15f5a458cb07e8b6cc1502492c9a5
2019-08-12 19:04:52 +08:00
Tracy Zhou
8089ffaced Pass the captured snapshot data to Launcher when recents animation is
cancelled.

In the current implementation, when recents animation is cancelled due
to stack order change, window manager replaces the surface with a
snapshot before cancellation. Launcher needs to acquire the snapshot in
order to switch the live tile into snapshot mode, and yet because the
recents animation is cancelled, that snapshot can no longer be acquired
anymore. This change takes care of this "relay" process.

Fixes: 138683199
Test: N/A
Change-Id: I1c11af38c2bdc442e3b45d0b5f0c7e7e37c2b0f0
2019-08-11 17:00:38 +00:00
Mihir Patel
52ed9ee038 Fixing a bug where content capture sessions with child sessions could get stuck in a state where no event flushing other than forced flushes would occur
Fixes: 139202268
Test: atest CtsContentCaptureServiceTestCases
Change-Id: I21e9d4db2402fe5210b7d938dac2f12e7557c146
2019-08-09 14:10:30 -07:00
sallyyuen
ae695bd641 Add more ScrollDeltaX/Y support to AccessibilityRecord.
Copy these values over and print them out.

Bug: 139195176
Test: builds and values shows up in logs
Change-Id: I7ce2861d78bbb97a4b39a0ca9773fb2188f15d45
2019-08-09 12:11:36 -07:00
lumark
290d6f3546 DO NOT MERGE: Fix ActivityView surface can't visible for ActivityViewTest
am: dc9b319039

Change-Id: Iedaebd2888f402e382a4eaf0d7385df2c17d0bdd
2019-08-09 07:48:32 -07:00
Issei Suzuki
94e8d116ab DO NOT MERGE: Support alpha value in SurfaceView.
For backward compatibility, SurfaceView ignores alpha value by
default. In order to reflect alpha value set on the SurfaceView
to its underlying surface, setUseAlpha() needs to be called.

Translucent alpha only works when the surface is placed z-above.
Otherwise only fully opaque and transparent status are supported.

Bug: 137937105
(Orignal bug from b/130442248)
Test: Manual, use BubblesTest app and checks if alpha is set.
Change-Id: I86847de59109b2adf12a2c7c50c988c2cbcf0450
2019-08-09 14:08:03 +00:00
Qasid Sadiq
0dd1be75c3 Merge "The source of subtree chagnes should be the viewParent" 2019-08-07 18:46:51 +00:00
TreeHugger Robot
d1845aa160 Merge "Add GPU draw stats to gfxinfo and GraphicsStatsService" 2019-08-06 21:45:20 +00:00
Adrian Roos
304f75603b GestureNav: Log exclusion rect heights am: 5f2c9a14f5 am: fde134f106
am: e4b2440287

Change-Id: If3f626a85dcf93482ad580e93c1c5b49299fd78f
2019-08-05 14:43:57 -07:00
Adrian Roos
fde134f106 GestureNav: Log exclusion rect heights
am: 5f2c9a14f5

Change-Id: I6b72f4b68773a21575296601f5545746d012524e
2019-08-05 14:17:15 -07:00
Adrian Roos
5f2c9a14f5 GestureNav: Log exclusion rect heights
Logs the rejected and requested exclusion rect heights.

Test: adb shell device_config put android:window_manager key_system_gesture_exclusion_log_debounce_millis 1000
Bug: 135152789
Change-Id: Ie12640f4bf0a8b40b666e604188a0bedd85e8981
Exempt-From-Owner-Approval: DeviceConfig.java: Adding constant to WindowManager namespace.
2019-08-05 21:19:40 +02:00
Jorim Jaggi
5534e159c1 Merge "Fix overlapping remote and recents animations" into qt-r1-dev am: b248a0343f am: dd40a0c75a
am: c7b3ff1c52

Change-Id: Iaba42814773ab7333aae3fbc90d3bbd2ea8bac87
2019-08-05 12:01:12 -07:00
Jorim Jaggi
dd40a0c75a Merge "Fix overlapping remote and recents animations" into qt-r1-dev
am: b248a0343f

Change-Id: I103ff225bbf69e6945cb90430130ae233dd6cb9f
2019-08-05 11:39:05 -07:00
Jorim Jaggi
b248a0343f Merge "Fix overlapping remote and recents animations" into qt-r1-dev 2019-08-05 18:12:56 +00:00
Jorim Jaggi
589c5ba0fa Fix overlapping remote and recents animations
Test: Open app and immediately swipe up while opening. Verify
Thread prioties in systrace

Test: WindowProcessControllerTests
Fixes: 137881181
Change-Id: Ic1d7403d2a648e6f1d1b6a3d55b56bf37bc57a2c
2019-08-05 17:10:18 +02:00
TreeHugger Robot
f80171ef5c Merge "Dispose InputChannel when dispose InputEventReceiver" 2019-08-05 05:28:21 +00:00
TreeHugger Robot
b4cbc8ad29 Merge "Prevent SurfaceView from drawing over parent surface insets" 2019-08-03 00:56:09 +00:00
Vishnu Nair
8cb00aee22 Prevent SurfaceView from drawing over parent surface insets
Parent SurfaceView to a bounds layer that enforces a crop preventing it
from drawing over the surface insets. The bounds layer crop is set to the
surface insets and updated when the parent surface size changes or the
parent surface insets change.

The SurfaceView has a z order relative to the ViewRootImpl surface so
that it can be behind or in front of the main content. If the ViewRootImpl
surface changes, then SurfaceView takes advantage of the
ViewRootImpl.SurfaceChangedCallback to update the relative z order.

Bug: 132205507
Test: go/wm-smoke
Test: test preserve surfaces code path with split screen and ensure relative z is preserved
Test: test SurfaceView apps, YouTube, maps & camera.
Test: try to repro maps pip issue described in bug
Change-Id: I0b2a3612b7e12ba66abb39b6bad4968442743cdd
2019-08-02 15:20:51 -07:00
Abodunrinwa Toki
d311e06c5b Merge "Ensure userId is set in TCEvent." 2019-08-02 15:41:04 +00:00
Adrian Roos
47dc37d983 Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev am: c9f4bcae57 am: dbab020f04 am: 6344ea3020
am: 7dd171b9af

Change-Id: I4bceb19da7534f649ee4ee4065b3a74058ebd05a
2019-08-02 06:16:09 -07:00
Adrian Roos
6344ea3020 Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev am: c9f4bcae57
am: dbab020f04

Change-Id: Ia21ae36cf8c244af8d56027e7a251daa303bc6f0
2019-08-02 05:52:49 -07:00
Adrian Roos
dbab020f04 Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev
am: c9f4bcae57

Change-Id: I3ae8a19bd59ede69caae781f47dd05865a07cd7a
2019-08-02 05:42:27 -07:00
Adrian Roos
91ce40fa1a Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev
am: c9f4bcae57

Change-Id: I0581305f01ebdaa121ce0e70ab9d44f142c9f99f
2019-08-02 05:42:10 -07:00
Adrian Roos
c9f4bcae57 Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev 2019-08-02 12:17:11 +00:00
Stan Iliev
7203e1f55a Add GPU draw stats to gfxinfo and GraphicsStatsService
Test: ran dumpsys with gfxinfo and graphicsstats
Change-Id: Id9950de87dc4343c6878baa6a6dd42fbc8aeddef
2019-08-01 18:53:21 +00:00
Artur Satayev
70507ed5a1 Add @UnsupportedAppUsage annotations for max-p.
See go/UnsupportedAppUsage for more details.

These have already been greylisted, however due to bugs/omissions in the tooling have been kept in go/greylist-txt instead of being annotated in the code.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 137350495
Test: m
Change-Id: I5aa29a49b193db47aaee4d3a756c17f48cc9f0b1
2019-08-01 19:46:29 +01:00
Abodunrinwa Toki
1480ed10ed Ensure userId is set in TCEvent.
Part of security fix in I2fdffd8eb4221782cb1f34d2ddbe41dd3d36595c

TCContexts that existed outside a TC session did not have userId
set by the SystemTC. This CL ensures SystemTC always sets the
userId for all TCEvents (and deprecated SelectionEvents).

Bug: 136483597
Test: atest android.view.textclassifier
      Manual test ensuring that ConvActions was logging TCEvent with
      userId.

Change-Id: Ie2a362f8f4758d5dc0390aeb2dbf23f9d78a378e
2019-08-01 15:26:19 +01:00
TreeHugger Robot
cf695aabfd Merge "Move InputMethodSytemProperty to server from client." 2019-08-01 00:41:25 +00:00
Adam He
2eaec69928 Merge "Implement AssistStructure.ViewNode.getHintIdEntry()." 2019-07-30 21:32:27 +00:00
TreeHugger Robot
2b551ea603 Merge "Add cursor position to synthesized events." 2019-07-30 16:38:09 +00:00
Garfield Tan
1da8628ae3 Add cursor position to synthesized events.
Synthesized events consist of injected, split and clamped events.
Instead of letting caller specify it, we fill cursor position fields by
deriving from pointers. Thus we can maintain the property between
pointer coodinates and cursor position. If there is need we can add a
new obtain method later as well anyway.

I decided to update the value for split events because it would be
unnatural to have a out of bound cursor position when a gesture crosses
view boundaries, but ultimately we probably shouldn't split mouse
events. Nevertheless that's out of the scope of this CL and I chose to
be on the safe side at this moment.

Bug: 134788085
Bug: 136607870
Test: atest TooltipTest#testMouseHoverTooltipWithHoverListener
Test: atest MotionEventTest (and select running all candidates)
Test: atest DragDropTest
Change-Id: I4f3dec0f3c4c1ab2ff5cb986b94b0e007d9fe41b
2019-07-30 09:22:27 -07:00
John Reck
aa712c5d4b Merge "Fix ReliableSurface to be more reliable" 2019-07-29 19:40:55 +00:00
John Reck
59dd2ea974 Fix ReliableSurface to be more reliable
Handle TIMED_OUT better by rescheduling (TODO: give up after N
attempts?)

Fix SYNC_SURFACE_LOST_REWARD_IF_FOUND path to actually go fetch
a new surface.

Bug: 137509524
Test: Injected errors randomly, verified nothing got permanently dead.
Change-Id: Id30f8ad1dd7196041ee84c16c8cf5c814002a6ce
2019-07-26 16:58:37 -07:00
Adrian Roos
e6feb7d198 GestureNav: Clarify javadoc in regards to exclusion limits
Bug: 124518180
Test: m checkapi
Change-Id: I43b0b890a763e339deb246cabf9adbf011eae088
2019-07-26 14:50:03 +02:00
Arthur Hung
12a06ce6ea Dispose InputChannel when dispose InputEventReceiver
There would be an error if an InputChannel didn't be disposed before
finalized. The client InputChannel created by ViewRootImpl or SystemUI
that would also create an InputEventReceiver to receive input events, and hold
the client InputChannel, so if the InputEventReceiver is going to be disposed,
the InputChannel should be disposed as well.

Test: manual
Bug: 128679213
Change-Id: I24c16f032403e8a982a84a5e0adbfabcdc016f0f
2019-07-26 19:14:17 +08:00
Vadim Caen
ef4e1cea9b Do not call drawableChanged pre Q
Some apps rely on not updating the window format when changing the
background of the DecorView. To keep the compatibilty with these app we
add only call DecoreView.drawableChanged() when the window background is
changed on app targetting Q and above.

Test: Manually test by lunching Instagram TV and pressing return twice.
The window should aninate with no flickering.
Bug: 136987724

Change-Id: I3593d30dc6f10519008151974e475f0dad86fc64
2019-07-25 15:25:19 +02:00
Vadim Caen
d6aa056512 DO NOT MERGE Do not call drawableChanged pre Q am: 843f9dee8b
am: 2106ef79ad

Change-Id: Ic5ceb704346deb38d1151f0e1fdc79fbb28ff82d
2019-07-24 16:38:48 -07:00
Vadim Caen
605e74c930 DO NOT MERGE Do not call drawableChanged pre Q
am: 843f9dee8b

Change-Id: I813f41905386da06e6eaebd6b7f85c17a6051456
2019-07-24 16:19:39 -07:00
Vadim Caen
2106ef79ad DO NOT MERGE Do not call drawableChanged pre Q
am: 843f9dee8b

Change-Id: Id54fa3b2327faec88c936228109643c8425eeb2a
2019-07-24 16:17:49 -07:00
Vadim Caen
843f9dee8b DO NOT MERGE Do not call drawableChanged pre Q
Some apps rely on not updating the window format when changing the
background of the DecorView. To keep the compatibilty with these app we
add only call DecoreView.drawableChanged() when the window background is
changed on app targetting Q and above.

Test: Manually test by lunching Instagram TV and pressing return twice.
The window should aninate with no flickering.
Bug: 136987724

Change-Id: I3593d30dc6f10519008151974e475f0dad86fc64
2019-07-24 21:29:12 +00:00
Winson Chung
df69ae467a Merge "Modify deferred recents animation cancel to work without screenshot" into qt-r1-dev am: 48e3cfc06a am: 932a656359
am: 71626be681

Change-Id: Ie5636139863163d42788314c0e8ca0c946a80ae1
2019-07-24 00:33:54 -07:00