Commit Graph

82193 Commits

Author SHA1 Message Date
Makoto Onuki
0f88f865bd Merge "Truncate(*1) it if WAL file is too big when opening DB" into pi-dev 2018-09-25 15:12:15 +00:00
Makoto Onuki
0939c5a2b3 Truncate(*1) it if WAL file is too big when opening DB
*1 -- not truncate(2) but "PRAGMA wal_checkpoint(TRUNCATE)"

Otherwise, depending on how an app operate on a DB, SQLite may not
have a chance to "shrink" the WAL file.

Fixes: 112777941
Bug: 111939259
Test: atest /android/master/frameworks/base/core/tests/coretests/src/android/database/sqlite/SQLiteCompatibilityWalFlagsTest.java
Test: Manual test with google dailer:
1. With normalized_spam.db-wal > 100MB and receive a phone call
-> WAL file gets truncated to 0 bytes.

2. Restart the dialer process and receive a phone call again
-> WAL file is already 0 bytes; won't be truncated.

3. Restart with the WAL file deleted
Same as #2. WAL file will be created before the added logic, but is 0 bytes,
so it won't be truncated.

4. Test with settings put global sqlite_compatibility_wal_flags truncate_size=1024
-> make sure the threshold is overridden

Merged-in: I2b193603e5dfa493ccccb8123db592f0e9c0e7ae
Change-Id: I2b193603e5dfa493ccccb8123db592f0e9c0e7ae
(cherry picked from commit 96e06002ed)
2018-09-24 22:47:02 +00:00
TreeHugger Robot
45fda27211 Merge "Fixed when the CompatibilityBridge is attached to an activity." into pi-dev 2018-09-24 22:04:27 +00:00
TreeHugger Robot
98d747e7f3 Merge "Fix the unresolved link/see tag error for framework docs" into pi-dev 2018-09-23 09:34:23 +00:00
Nan Zhang
99adf3cb76 Fix the unresolved link/see tag error for framework docs
Synced with alanv@ that doc weren't federated against AndroidX yet, use
this v7 reference until they migrate the docs to AndroidX.

Test: m -j offline-sdk-docs
Bug: b/116163454
Change-Id: Ib5167c4815708d159945ce6db239f8debdf8f865
2018-09-21 14:58:26 -07:00
TreeHugger Robot
02bc7c2228 Merge "docs: Removes reference to the clock displaying seconds" into pi-dev 2018-09-21 19:40:38 +00:00
TreeHugger Robot
82b0d17b39 Merge "docs: fixing several minor documentation bugs" into pi-dev 2018-09-20 22:42:48 +00:00
TreeHugger Robot
679e58a8d3 Merge "WebView: fix TracingController example usage" into pi-dev 2018-09-20 18:57:55 +00:00
kopriva
f07a46058c docs: fixing several minor documentation bugs
Test: make ds-docs

Bug: 36949243
Bug: 116169695
Bug: 37001248
Bug: 37044885
Bug: 37053166

Change-Id: I844a8978518cd7214bf9d068d602902dfa7e8246
Exempt-From-Owner-Approval: Docs-only change
2018-09-20 11:20:27 -07:00
Nate Fischer
9e39bf1067 WebView: fix TracingController example usage
This fixes a minor mistake in the TracingController class usage. The
example previously used a bare `CATEGORIES_WEB_DEVELOPER` instead of
`TracingConfig.CATEGORIES_WEB_DEVELOPER`.

Bug: 116227333
Test: make docs
Change-Id: I648dd0d5e61666e61adb27303c185013bd80b0ea
2018-09-20 18:17:05 +00:00
Lucas Dupin
562f5485d3 Merge "Clarify that UiModeManager sets global night mode" into pi-dev 2018-09-20 16:39:49 +00:00
TreeHugger Robot
971ad7aa5e Merge "Clarified FillCallback and SaveCallback behaviors." into pi-dev 2018-09-20 02:12:57 +00:00
Felipe Leme
5cd660d5e9 Fixed when the CompatibilityBridge is attached to an activity.
The AccessibilityManager is a singleton, so we need to update it everytime
an activity is resumed.

Test: manual verification with Chrome (CTS test is an overkill here)
Test: atest CtsAutoFillServiceTestCases # to make sure it didn't break anything

Fixes: 112690889
Change-Id: If011db203dee96ec511da80f4e49395c0340f482
(cherry picked from commit ce40498dc2)
2018-09-19 17:55:06 -07:00
Felipe Leme
deff81b12b Clarified FillCallback and SaveCallback behaviors.
Test: mmm -j frameworks/base/:doc-comment-check-docs

Bug: 116103297

Change-Id: Ib397556007d1f8bf6d5d08c6bf2edf69f88b7f07
2018-09-19 13:41:22 -07:00
Lucas Dupin
b01c390b54 Clarify that UiModeManager sets global night mode
Test: repo upload
Fixes: 116121230
Change-Id: I127c169eb9cb6f951943879bd4bdaca2a00ed222
2018-09-19 11:44:31 -07:00
TreeHugger Robot
82b413428e Merge "docs: fixed five typos" into pi-dev 2018-09-18 18:38:16 +00:00
TreeHugger Robot
9a32a1dc3e Merge "docs: bug 36997358, typo 'than an'" into pi-dev 2018-09-18 00:04:39 +00:00
kopriva
7ecfe31427 docs: fixed five typos
Test: make ds-docs

Bug: 37095452
Bug: 37001217
Bug: 37004068
Bug: 37015340
Bug: 37044652

Change-Id: Ib305df88b63286810d7722e73321ddb238b45e8e
Exempt-From-Owner-Approval: Docs-only change
2018-09-17 15:17:50 -07:00
kopriva
fc3949e099 docs: bug 36997358, typo 'than an'
Test: make ds-docs

Bug: 36997358

Change-Id: I11a5fcbd76638c7d6b060c0852268efa9e37a7fe
Exempt-From-Owner-Approval: Docs-only change
2018-09-17 11:35:13 -07:00
David Castro
3e10355b99 docs: Removes reference to the clock displaying seconds
Test: make ds-docs

Bug: 115691112

Change-Id: Ic87d6c2806b20ed682ad0ca7e8e52e8096c9ac07
Exempt-From-Owner-Approval: Docs-only change
2018-09-17 09:38:14 -04:00
Felipe Leme
df0cefab6b Clarified that some autofill interfaces can only be implemented by the system.
Test:  mmm -j frameworks/base/:doc-comment-check-docs

Fixes: 113323194

Change-Id: Ic0bea0e16fca0ce4c67d36f5611587843d7aad9f
(cherry picked from commit d5225e13d0)
2018-09-14 10:03:30 -07:00
TreeHugger Robot
3667b71225 Merge "Add note for FLAG_CANCEL_CURRENT when stopping scan" into pi-dev 2018-09-14 03:04:37 +00:00
TreeHugger Robot
206a50673d Merge "docs: fixed mistaken reference to NotificationManager" into pi-dev 2018-09-14 02:38:28 +00:00
TreeHugger Robot
26bdd62ce5 Merge "docs: fixed button value in reference" into pi-dev 2018-09-13 23:37:04 +00:00
TreeHugger Robot
62348dad3e Merge "WebView: fix SafeBrowsingResponse javadoc bug" into pi-dev 2018-09-13 22:19:59 +00:00
kopriva
5495dbbb80 docs: fixed mistaken reference to NotificationManager
Test: make ds-docs

Bug: 36952345

Change-Id: Icc74db9f8808e67c6eafacc0e40a35f47cba32ba
Exempt-From-Owner-Approval: Docs-only change
2018-09-13 14:18:34 -07:00
kopriva
8082168bb1 docs: fixed button value in reference
Test: make ds-docs

Bug: 36946449

Change-Id: I13d863e2cb0e94e51c3a274c8d27d58f7a7a78eb
Exempt-From-Owner-Approval: Docs-only change
2018-09-13 13:18:40 -07:00
kopriva
debd4ee72d docs: fixed instances of typo in 'overridden'
This affects several files beyond those mentioned in the bug.

I didn't fix some instances because the files had code
problems that blocked presubmit checks.

Test: make ds-docs

Bug: 37094741

Change-Id: I642f0384fef2b267ebc970bae1b4fb90bae667e7
Exempt-From-Owner-Approval: Docs-only change
2018-09-13 11:40:59 -07:00
Nate Fischer
211d6159b9 WebView: fix SafeBrowsingResponse javadoc bug
No change to logic, only minor javadoc change.

This fixes javadoc in SafeBrowsingResponse.java. Previously, the first
(and only) sentence did not end in a period (it ended with a quote
character). The Android javadoc parser doesn't handle this well--it
requires a period followed immediately by some whitespace character.

This wasn't a big issue because this was the only sentence. However, if
we ever add a second sentence, both sentences will appear as the
one-line "synopsis doc" for the methods.

See http://go/android-api-guidelines#heading=h.teqny5h9ohqc for details.

Bug: 115441402
Test: make docs
Change-Id: Ic363ed1ecf3d169d598ae85d55297d0a520a6604
2018-09-12 17:26:41 -07:00
Stanley Tng
009103c675 Add note for FLAG_CANCEL_CURRENT when stopping scan
Added a note in the Android API documentation for stopScan to make sure
that the flag FLAG_CANCEL_CURRENT is not used when creating the
PendingIntent parameter.

Bug: 77658091
Test: Just compile since not logic is changed
Change-Id: I55f33ae68679310ba4899708a2072a40fea0b3b4
(cherry picked from commit 20fc9a250e)
2018-09-12 10:55:54 -07:00
kopriva
9b5c03973e docs: fixed typo
Test: make ds-docs

Bug: 36942287

Change-Id: I6931817127a7b98a4b97e0e18cf4d654231c32f9
Exempt-From-Owner-Approval: Docs-only change
2018-09-10 14:02:58 -07:00
Michael Wachenschwanz
78a2caeb94 Merge changes from topic "am-bdb0270e-8295-4ee6-be36-2709e172d48f" into oc-dev am: d32c2a4189 am: 1f5050c054
am: 4fda414ed6

Change-Id: I7c7901f0147f7577240803cc2adc4e189f1994b4
2018-09-05 20:23:16 -07:00
Michael Wachenschwanz
4fda414ed6 Merge changes from topic "am-bdb0270e-8295-4ee6-be36-2709e172d48f" into oc-dev am: d32c2a4189
am: 1f5050c054

Change-Id: Ibae3dc08eabf5b12a8f1a03ea33bd54a28e0442e
2018-09-05 19:01:27 -07:00
Michael Wachenschwanz
1f5050c054 Merge changes from topic "am-bdb0270e-8295-4ee6-be36-2709e172d48f" into oc-dev
am: d32c2a4189

Change-Id: Ie2ad590368e9c10f6222d9ae65470ebb12dabac2
2018-09-05 18:46:57 -07:00
Android Build Merger (Role)
7cf42221c6 [automerger] Verify number of Map entries written to Parcel am: 057a01d1f3 am: d6947f1cbf am: 628cbe5c53 am: 433e4173ec am: 686897ddd9
Change-Id: I07c1d68a0c5d8da6ec81c717dff97d33dba86a16
2018-08-30 20:46:20 +00:00
Android Build Merger (Role)
686897ddd9 [automerger] Verify number of Map entries written to Parcel am: 057a01d1f3 am: d6947f1cbf am: 628cbe5c53 am: 433e4173ec
Change-Id: I8375f1c1a860f5021efc5873e94b452a44d6c145
2018-08-30 20:46:12 +00:00
Android Build Merger (Role)
433e4173ec [automerger] Verify number of Map entries written to Parcel am: 057a01d1f3 am: d6947f1cbf am: 628cbe5c53
Change-Id: Id32bd5aa02d5689873bb311eebc87f367af9a9d9
2018-08-30 20:46:05 +00:00
Android Build Merger (Role)
628cbe5c53 [automerger] Verify number of Map entries written to Parcel am: 057a01d1f3 am: d6947f1cbf
Change-Id: Idaab5395d9e0970fe57b017bcba10f8757ffe3c7
2018-08-30 20:45:59 +00:00
Android Build Merger (Role)
d6947f1cbf [automerger] Verify number of Map entries written to Parcel am: 057a01d1f3
Change-Id: Idb2572b46c48fe2f3e4b99c5cb4372dcfe6b20ce
2018-08-30 20:45:51 +00:00
Michael Wachenschwanz
057a01d1f3 Verify number of Map entries written to Parcel
Make sure the number of entries written by Parcel#writeMapInternal
matches the size written. If a mismatch were allowed, an exploitable
scenario could occur where the data read from the Parcel would not
match the data written.

Fixes: 112859604
Test: cts-tradefed run cts -m CtsOsTestCases -t android.os.cts.ParcelTest

Change-Id: I325d08a8b66b6e80fe76501359c41b6656848607
Merged-In: I325d08a8b66b6e80fe76501359c41b6656848607
2018-08-30 13:40:44 -07:00
TreeHugger Robot
7795e97f27 Merge "Docs: fixed formatting for setLaunchBounds()" into pi-dev 2018-08-30 01:45:55 +00:00
TreeHugger Robot
8bb6781e56 Merge "Docs: fixed a broken link in SystemUpdatePolicy" into pi-dev 2018-08-30 00:18:32 +00:00
TreeHugger Robot
53141c3984 Merge "docs: Added reminder that custom CAs aren't automatically trusted by apps." into pi-dev 2018-08-29 23:22:01 +00:00
TreeHugger Robot
f5411070a8 Merge "Fixes possible issue with no-op creator." into pi-dev 2018-08-29 22:07:27 +00:00
Benjamin Miller
8a12c12ad2 docs: Added reminder that custom CAs aren't automatically trusted by apps.
Compact reminder with CTA to read more in Security & Privacy best
practices document.

Test: make ds-docs and inspect generated HTML in the browser.
Bug: 29000858
Change-Id: If74bfd50f85f044214f6db1950351d2f2014e0ae
2018-08-29 17:43:24 +00:00
Benjamin Miller
557145676c Docs: fixed formatting for setLaunchBounds()
Some changes to phrasing and punctuation to meet API Council guidelines.
Bug: 111149822
Test: make ds-docs and visual inspection of HTML

Change-Id: I2f7586cee3c1d0b41286f98cd0598cb6c62eafd6
(cherry picked from commit fcefd69c5b)
2018-08-24 08:17:39 +00:00
Benjamin Miller
46734a060d Docs: fixed a broken link in SystemUpdatePolicy
{@docroot} is relative to the root dir, not the host.
Updated the destination and anchor text to reflect the new OTA guide.

Bug: 111521364
Test: make ds-docs and inspect generated HTML
Change-Id: I937f47338e8c18637947944467803c1764938754
(cherry picked from commit 625f91aa46)
2018-08-24 08:15:03 +00:00
dwchen
78622d57ad Fixes possible issue with no-op creator.
Leaving a no-op CREATOR can lead to issues. We throw a run-time
exception to prevent anyone from using this. The StatsLogEventWrapper is
meant to be write-only since it's only used to send data to statsd.

Bug: 112550251
Test: Tested with provided POC app by external researcher.
Change-Id: I001d84e2a61a1cd8a4f59aa156ca52f73ad0f6e1
2018-08-23 11:35:01 -07:00
Jorim Jaggi
e387ce18d8 Merge "BootAnimation: Fix boot animation with hidden cutout" into pi-dev 2018-08-22 23:06:35 +00:00
Adrian Roos
9ee5dff83c BootAnimation: Fix boot animation with hidden cutout
We do this by storing the masking inset in a persistent property.
The boot animation then animates itself to where it would be if that
masking inset were applied, then changes the viewport.

For this to work, we also need to make sure the DisplayManagerService
has the right overlay right at the start.

Bug: 112876936
Test: Hide cutout, then reboot. Verify boot animation is smooth.
Change-Id: I3e988b2340b2e0d2be3939bdc6878704c234ccc8
2018-08-22 21:37:39 +01:00