Commit Graph

7287 Commits

Author SHA1 Message Date
Sergey Vasilinets
3c9c422d33 Merge "Revert "Revert "Update overscroll and toast UI""" into oc-dr1-dev
am: 2cf8f91637

Change-Id: Ia0f4dc6193776e0b37eb7e2d2048918510cae535
2017-07-28 22:02:14 +00:00
Sergey Vasilinets
2cf8f91637 Merge "Revert "Revert "Update overscroll and toast UI""" into oc-dr1-dev 2017-07-28 21:46:43 +00:00
Sergey Vasilinets
ebfaca5246 Revert "Revert "Update overscroll and toast UI""
This reverts commit 45c493f2c2.

Change-Id: Idefc8e1b6f954def7ef4cdf08b687042a6091a0d
2017-07-27 23:29:34 +00:00
Aurimas Liutikas
0aadeed536 Merge "Revert "Update overscroll and toast UI"" into oc-dr1-dev 2017-07-26 22:36:59 +00:00
Aurimas Liutikas
45c493f2c2 Revert "Update overscroll and toast UI"
This change broke android.uirendering.cts.testclasses.EdgeEffectTests.

This reverts commit 6085f8a16b.

Bug: 64085792

Change-Id: I70ccebebb54dabf1ec0ee5002adca93e44104a1e
2017-07-26 22:24:21 +00:00
Chet Haase
1c31f9653f Merge "Update overscroll and toast UI" into oc-dr1-dev 2017-07-26 05:40:41 +00:00
Chet Haase
6085f8a16b Update overscroll and toast UI
Overscroll updates:
Same shape, but smaller radius (doesn't come as far into the view)
and more translucent (max 15% instead of 50%). Overall, more subtle.

Toast updates:
Light background, smaller, dark font, closer to the bottom of the
container.

Test: manual unit tests. Also:
cts test ToastTest for toast changes
cts test EdgeEffectTests for EdgeEffect changes (adding some tests to
known-failures for now, due to brittle golden-image failures - see
CL ag/2596621)
Bug: 30563264  Refresh toast visuals for Android ODR
Bug: 63010438  Tweaks to overscroll animation
Change-Id: I0fac6322b0b81d030c8d174852c134211290bbea
2017-07-26 05:40:02 +00:00
Felipe Leme
2e58b1672e Move cursor to end of text when autofilling.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testAutofillMovesCursorToTheEnd
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 62669787

Change-Id: I70a583c71057804334e86ed3f7dd2aca8da20922
2017-07-25 10:37:02 -07:00
Selim Cinek
8ffa981686 Merge "Reducing bitmap sizes in notifications" into oc-dr1-dev 2017-07-19 23:41:44 +00:00
Selim Cinek
15733d1f85 Reducing bitmap sizes in notifications
Bitmap sizes could be arbitrary large when they were sent
over to the system. We're now reducing them to reasonable
sizes.s

Also fixed that notification bitmaps were not put into
ashmem anymore since it got lost in a refactor.

Test: code inspection
Bug: 62319200
Merged-In: I87db7656e749666b9eab1f67fd497f155c407e18
Change-Id: I87db7656e749666b9eab1f67fd497f155c407e18
2017-07-19 18:06:09 +00:00
Selim Cinek
d0426628f6 Reducing bitmap sizes in notifications
Bitmap sizes could be arbitrary large when they were sent
over to the system. We're now reducing them to reasonable
sizes.s

Also fixed that notification bitmaps were not put into
ashmem anymore since it got lost in a refactor.

Test: code inspection
Bug: 62319200
Change-Id: I87db7656e749666b9eab1f67fd497f155c407e18
2017-07-19 11:05:26 -07:00
TreeHugger Robot
e38db1b9be Merge "Fix calculation of RelativeLayout width in RTL mode" 2017-07-14 21:10:57 +00:00
TreeHugger Robot
41db50cd25 Merge "Disable smart sharing for password fields." 2017-07-14 20:21:59 +00:00
Abodunrinwa Toki
76b51dc450 Disable smart sharing for password fields.
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Bug: 62340817
Change-Id: Ifbf2c39d9f304251adc8c4acdf1b4fd6914011d8
2017-07-14 18:31:04 +01:00
TreeHugger Robot
267c6b2a5b Merge "Avoid FloatingToolbar flickers" 2017-07-14 13:44:45 +00:00
Roozbeh Pournader
4d4596aae8 Fix calculation of RelativeLayout width in RTL mode
Fixes: 37035671
Test: Manual
Test: bit CtsWidgetTestCases:.RelativeLayoutTest
Change-Id: I82feecdba7d1ed1198580758ab1f68932bb50aa7
2017-07-13 19:11:05 -07:00
Roozbeh Pournader
bfe8b1cdd6 Merge "Merge "Make TextInputTimePickerView use localized input" into oc-dr1-dev am: dd74c1a8cd" into oc-dr1-dev-plus-aosp
am: d792c31806

Change-Id: I91e28ff9aa7b2bea64dcfe2371f8a734ea8cbb6e
2017-07-14 00:57:59 +00:00
Roozbeh Pournader
f3cda89def Make TextInputTimePickerView use localized input
Previously, TextInputTimePickerView used the default numeric IME, which
could result in cases where the digits displayed in the text fields were
native, but the IME showed ASCII digits resulting in a mix.

Now we use setImeHintLocales to hint that we need a localized IME.

Change-Id: Ic4041dcc65a31bd00741c6d96d8cbc5dac9d77c8
Fixes: 63650251
Test: Manual (tested under en-US and ar-BH locales)
2017-07-13 15:25:24 -07:00
Abodunrinwa Toki
4a7aeb3cb0 Avoid FloatingToolbar flickers
by:
 1. Restricting 'moving hide' -- where we hide the toolbar if the
    toolbar is moving.
 2. Hide the toolbar when transitioning to 'select all' -- where the
    toolbar is refreshed.

Bug: 32910217
Bug: 30418276
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit CtsWidgetTestCases:android.widget.cts.TextViewTest

Change-Id: I1f44ee765d74bbcf08e6e7cd635f76d1e8f6305b
2017-07-13 21:48:51 +01:00
Sumir Kataria
37b8567a87 clearChoices when setting AbsListView adapters.
This allows us to reset mCheckedItemCount to 0 to match the clearing
of check states.

Bug: 63559021
Fixes: 63559021
Test: Added test to AbsListViewTest.

Change-Id: I47a0fbc25448addf75a3f7e5a282bb98360200dd
2017-07-12 10:39:41 -07:00
Phil Weaver
9e90a7236a Merge "NumberPicker a11y (and a11y-inspired) fixes" 2017-07-11 23:12:20 +00:00
TreeHugger Robot
ed8c1eb56a Merge "Respect the locale in vertical location of AM/PM" 2017-07-06 22:08:25 +00:00
Anthony Chen
10fccb0473 Merge "Merge "Fix bug where RemoteViews addView is backwards." into oc-dr1-dev am: 25c84b3321" into oc-dr1-dev-plus-aosp
am: 7730f5ad86

Change-Id: Id53671bbdefa0683c19e84f245cf60ba9460278c
2017-07-06 21:46:50 +00:00
Roozbeh Pournader
6791c7bf67 Respect the locale in vertical location of AM/PM
If the locale puts the AM/PM before the hour and minute in time
formatting, make sure TimePicker respects that by putting the AM/PM
above the hour and minute in landscape mode, where the AM/PM used to
always appear below the hour and minute.

Two sets of locales are affected. All of them put the AM/PM before
the hour and minute, but the first set also defaults to 12-hour, so
the change is most visible in these: Ewe, Chinese (both Simplified
and Traditional, including Cantonese), Korean, and Tamil. The second
set, Hungarian, Japanese, Myanmar, Sinhala, and Turkish, would only
see the difference if the time picker is forced into 12-hour mode.

Test: manual (tested en-US, ar-EG, ta-IN, zh-Hans-CN, ko-KR)
Change-Id: Ic5840d46d81a004294bda4644df02c721152686b
Fixes: 63352170
2017-07-06 13:18:02 -07:00
Roozbeh Pournader
01bcf1ef5c Respect locale direction in TimePicker AM/PM location
Previously, the code that decided where the AM/PM indicator should
end up relative to the hours and minutes assumed that the locale was
LTR. Now it works correctly for RTL locales too.

Bug: 62846484
Test: manual (tested adding an alarm under ar-EG, en-US, and ta-IN, all of which are 12-hour)
Change-Id: I748baff01e2b3398747a2f8c074edbd16322bdf9
2017-07-05 18:32:47 -07:00
TreeHugger Robot
60b108d758 Merge "Fix RTL issue in RelativeLayout" 2017-07-05 23:45:24 +00:00
Chet Haase
bcd3520be6 Fix RTL issue in RelativeLayout
A long-standing bug in RelativeLayout meant that items inside a
RelativeLayout with layout centering (layout_centerHorizontal)
and WRAP_CONTENT would cause the surrounding RelativeLayout to be
sized incorrectly, resulting in bad layouts overall (the RelativeLayout
could end up much too large, pushing other layouts out of view). This
artifact was visible in TimePicker in landscape mode, but worked
around in the O release by forcing LTR on the parent layout of the
RelativeLayout.

The problem was that the case of center/wrap would end up positioning
the view on the left of the layout, instead of the RTL-friendly right
side. The fix is to do the correct thing in RTL mode (position relative
to the right side of the layout instead).

Bug: 63003526  TimePicker RTL issue
Bug: 62846484  TimePicker layout is broken in RTL landscape mode
Test: manual (run Clock app in RTL and non-RTL modes and observe layout behavior in
both portrait and landscape modes).

Change-Id: I9033857a39f422e3d6fb6e4d313d1739ae3f5c63
2017-07-05 21:45:50 +00:00
Anthony Chen
ea202f6646 Fix bug where RemoteViews addView is backwards.
The index on where to add a child view was not being saved when writing
to a Parcel. This causes the index to default to 0 and resulted in views
always being added as the first view.

Now, persist this value to the Parcel and restore it.

Test: booted up on Nexus 6P, created notification with RemoteView, added
two views and verified views added in correct order.
Bug: 63177271

Change-Id: I94384e348b8a5168efe0601f382cdd2db6791fdb
2017-07-05 21:12:41 +00:00
Abodunrinwa Toki
1d263b8a38 Merge "No smart text assist for unprovisioned device." into oc-dr1-dev am: bda6275cf6
am: 925eb60a2c

Change-Id: Ib08b1a455c69ec499488d89df6c2419c368ca27c
2017-06-30 22:49:45 +00:00
Abodunrinwa Toki
9796a1bd00 No smart text assist for unprovisioned device.
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit FrameworksCoreTests:android.widget.TextViewActivityMoutseTest
Bug: 62745625
Change-Id: I360250a5c2a92d09c8d8f559b51c74f490f70c2c
2017-06-30 00:50:39 +01:00
TreeHugger Robot
c1323664d4 Merge "Make the android.R.string.autofill public." 2017-06-28 01:55:57 +00:00
Phil Weaver
53a8e4370a Merge "Clean up popup window titles" 2017-06-27 00:39:30 +00:00
Phil Weaver
dd6978545f Clean up popup window titles
Removing the recently-added APIs to adjust the title for
the popup window, and moving setting the title to
preparePopup(), which is guaranteed to have a context.
(The bug is a crash because we didn't have a context.)

Apps wishing to specify their own title can still do so
in the LayoutParams without bothering with the get/set.

Bug: 62675086
Test: With TalkBack running, navigate to Settings->
Network & Internet. Select the more options button and
double-tap to select it. It now announces "Popup Window".

Change-Id: I9735ace42c24ef4977d3f4d5150f768d44aff351
2017-06-26 15:32:21 -07:00
Felipe Leme
555bcac6b2 Make the android.R.string.autofill public.
Fixes: 62444792
Test: manual verification with app that uses it the string
Test: CtsAutoFillServiceTestCases pass

Change-Id: Ic859a7a80ab25f6e240a308715b7c50708c497f3
2017-06-26 12:55:17 -07:00
Seigo Nonaka
b7773ce875 Stop loading other package's font by default.
Since CONTEXT_RESTRICTED is not a default flag of createPackageContext,
we can't rely on it for preventing unexpected font injections.
To protect developers and existing apps from a risk of font injection,
stop loading font from other package's resouce unless the developer
explicitly set CONTEXT_IGNORE_SECURITY.

Bug: 62813533
Bug: 62879353
Test: Manually done
Merged-In: I4442ddc48dadb5c968b444be86038b602074d301
Change-Id: I4442ddc48dadb5c968b444be86038b602074d301
(cherry picked from commit 6d6cd68660)
2017-06-23 10:02:59 +00:00
Rob Carr
e8a3b7a162 Merge "ListPopupWindow: Wrap new bounds checking in targetSdk check." into oc-dev am: 82b41e460c am: 874b6402af
am: 9a8971fabb

Change-Id: Ida4fd8f112a7164fb79512d09eadd10da718c269
2017-06-22 22:41:39 +00:00
Rob Carr
9a8971fabb Merge "ListPopupWindow: Wrap new bounds checking in targetSdk check." into oc-dev am: 82b41e460c
am: 874b6402af

Change-Id: I3db14694bc27e9fed16b5efec6aba99570b89675
2017-06-22 22:32:07 +00:00
TreeHugger Robot
abc6fd57de Merge "Stop loading other package's font by default." 2017-06-22 22:28:10 +00:00
Rob Carr
9e391f9f86 Merge "ListPopupWindow: Wrap new bounds checking in targetSdk check." into oc-dev
am: 82b41e460c

Change-Id: I47c8e096ccd513eb65fa9fd2a34fc75fa222a42c
2017-06-22 22:23:19 +00:00
Robert Carr
c1fdd2aa32 ListPopupWindow: Wrap new bounds checking in targetSdk check.
While a negative height is pretty silly, crashing apps on
the new version of android makes them sad.

Test: Existing CTS passes.
Bug: 62434804
Change-Id: I5fc3fc50fb6ccfa9e96f38ded4fb8e338f263f09
2017-06-22 11:54:45 -07:00
Seigo Nonaka
6d6cd68660 Stop loading other package's font by default.
Since CONTEXT_RESTRICTED is not a default flag of createPackageContext,
we can't rely on it for preventing unexpected font injections.
To protect developers and existing apps from a risk of font injection,
stop loading font from other package's resouce unless the developer
explicitly set CONTEXT_IGNORE_SECURITY.

Bug: 62813533
Bug: 62879353
Test: Manually done
Change-Id: I4442ddc48dadb5c968b444be86038b602074d301
2017-06-22 08:36:03 -07:00
Felipe Leme
49a38c6f1c Added BaseAdapter.setAutofillOptions()
Also changed ArrayAdapter to use it, when set.

Fixes: 37518906
Test: cts-tradefed run commandAndExit cts-dev -m CtsWidgetTestCases  -t android.widget.cts.BaseAdapterTest
Test: cts-tradefed run commandAndExit cts-dev -m CtsWidgetTestCases  -t android.widget.cts.ArrayAdapterTest
Test: m update-api

Change-Id: I5e883555b0fb9d084b57b9239595bf0632fc41af
2017-06-21 13:36:56 -06:00
Yohei Yukawa
c9cd9db4bb Use TEXT_HANDLE_MOVE in TextView behind the flag
This CL enables TextView to trigger
HapticFeedbackConstants.TEXT_HANDLE_MOVE on devices that explicitly
enable this feature with resource overlay.  This CL should have no
behavior change and no performance impact by default.

Since the use case of HapticFeedbackConstants.TEXT_HANDLE_MOVE is
when the user is manually moving the text insertion/selection handle
on the touch screen, it is intentional that text handle move
triggered by hardware keyboard, mouse, TextView APIs, IME APIs, and
any other internal API calls do not trigger the haptic feedback
even if the feature is enabled with resource overlay.

Bug: 62454887
Test: Manually done as follows.
  * Not triggered on cursor move by mouse
  * Not triggered on cursor move by hardware keyboard
  * Not triggered on cursor move by IME
  * Triggered on cursor move by touch screen
Change-Id: I5e78aafb065378ca88ba39ec507b121c8baa3631
2017-06-19 18:27:34 -07:00
TreeHugger Robot
1c75b9c99f Merge "Hide IME when switching to Radial Time Picker" 2017-06-19 17:40:05 +00:00
Siyamed Sinir
4558068f63 Merge "Fix crash during TextView.onCreateContextMenu" into oc-dev am: 58df6ab93f am: 92d86d59c0
am: 4c6d3ba183

Change-Id: I06ed6fea1fe414e7a33694047b0e6e903b7816bb
2017-06-19 17:24:27 +00:00
Siyamed Sinir
4c6d3ba183 Merge "Fix crash during TextView.onCreateContextMenu" into oc-dev am: 58df6ab93f
am: 92d86d59c0

Change-Id: I690ebf4df8e22a57c5f7b2b5e0267a550db15945
2017-06-19 17:13:23 +00:00
Siyamed Sinir
04171ecb31 Merge "Fix crash during TextView.onCreateContextMenu" into oc-dev
am: 58df6ab93f

Change-Id: Icd240aa9e5881067acd7521e4235692c5a538b29
2017-06-19 17:03:17 +00:00
Aurimas Liutikas
7334441d69 Hide IME when switching to Radial Time Picker
When switching back to the Radial Time Picker with an
IME visible, make sure to hide it.

Test: Set time from Settings. Switch to TextInputTimePicker.
      Enter text so IME appears.  Switch back to RadialTimePicker
      IME should be hidden again.

Change-Id: Ia0ed149d74333b2f643d50a324172b64aa5e223b
2017-06-17 00:14:11 +00:00
Siyamed Sinir
532f3c989e Fix crash during TextView.onCreateContextMenu
Test: bit CtsWidgetTestCases:TextViewTest

Bug:62450393
Change-Id: I162c28d253ca197eba9c4c148c76179c2880daa5
2017-06-16 19:32:41 +00:00
Alan Viverette
0a14ba56a7 Manually merge 23bb5bf262 to fix APIs
Also updates documentation for RemoteViews clone to reflect the ISE;
however, the implementation is still incorrect and the method should be
deprecated and replaced with a copy constructor.

Bug: 62576297
Test: make -j32
Change-Id: I72dea99fa45a838d22eb54190a0f26a15e8ba766
2017-06-14 17:33:49 -04:00