Commit Graph

2392 Commits

Author SHA1 Message Date
Andrew Solovay
369f2eeaf9 docs: Fixing broken Javadoc comments
Two recent checkins broke the Javadoc (in both cases, an <h3> wasn't
properly closed). Made the fix by hand to the HTML output in
cl/309818465 but we need to make the corresponding change to
the Java source or it'll get reverted next time we update the reference
docs.

Staged to:

go/dac-stage/reference/android/content/pm/LauncherApps.PinItemRequest
go/dac-stage/reference/android/service/autofill/AutofillService

go/dac-stage/reference/kotlin/android/content/pm/LauncherApps.PinItemRequest
go/dac-stage/reference/kotlin/android/service/autofill/AutofillService

BUG: 155669442
Exempt-from-owner-approval: Docs-only change
Test: make ds-docs
Change-Id: I97be9550689544304dff276cf3c9406f9cd98408
2020-05-04 16:03:17 -07:00
Feng Cao
98367aef11 Merge "Make autofill requested by augmented autofill service non-manual" into rvc-dev 2020-05-04 20:30:01 +00:00
Feng Cao
08abd46f61 Make autofill requested by augmented autofill service non-manual
* The use case of this API was for augmented autofill service to send
  updated suggestions
* Before this change, the dynamic autofill request by the augmented
  autofill service only triggers a manual request, but this has caused
  some regular autofill providers to always some suggestion due to
  their special handling for the manual request. Thus the augmented
  autofill service will not receive the request.
* With this cahnge, the request cancels the previous session to start a
  new session, and also it triggers a regular request (non-manual) so
  the autofill provider will not special handle the request.

Test: atest CtsAutoFillServiceTestCases
Bug: 154543563

Change-Id: I233125a6070394a102ad40b9a50b98a43d952b9f
2020-05-04 11:36:21 -07:00
Andrew Sapperstein
975ca816ec Merge changes from topic "cherrypick-ctor-refs-03y8i58ine" into rvc-dev
* changes:
  Update inner class constructor refs to use proper syntax.
  Fix broken @see tags in public documentation.
2020-05-02 00:21:33 +00:00
Feng Cao
4e20f2b97c Merge "Support receiving touch event in the inline suggestion view" into rvc-dev 2020-05-01 22:07:39 +00:00
Feng Cao
c23bfc7819 Support receiving touch event in the inline suggestion view
* Before this change, the suggestionRoot would intercept all touch
  events so that it can optionally forward them to the IME process
  to support scrolling, no touch event will be sent to the child
  view through the regular event dispatching process.
* With this change, we move the touch event transferring (to IME)
  logic from SuggestionRoot's onTouchEvent to dispatchTouchEvent.
  Now the touch events before a scroll is detected will be sent to
  the child chip view, and only the touch events after a scroll is
  detected will be sent to the IME.
* This patch also move the OnClickListener and OnLongClickListener
  from the root view to the chip view, since the touch events now
  either goes to the chip view or to the IME process.
* Note that in order to achieve this, given that we can't change
  the API, and there is existing OnLongClickListener registered
  to the chip view, we have to add a @hide API to the View to
  get the existing OnLongClickListener and attach a new one to the
  chip view, such that we can do the additional work of sending
  the long click event to IME, when the view is long clicked.
* This patch should also fix the a11y talkback mode bug where
  double-tapping on the view doesn't autofill the value.
  Double-tap and hold also works that it triggers the attribution
  dialog.

Test: atest CtsAutoFillServiceTestCases (sanity test)
Bug: 155245913
Bug: 154149807

Change-Id: I6f7be1ea5c0955969abb4ccae0cb421423095c4d
2020-05-01 12:36:51 -07:00
Andrew Sapperstein
88d565e7e7 Update inner class constructor refs to use proper syntax.
Previously, we generally required fully qualified names for referring
to inner class constructors (like #Notification.Builder()) despite that
not being valid javadoc. Now, we properly support #Builder() syntax and
the old syntax will error.

Bug: 6963924
Test: make doc-comment-check-docs
Exempt-From-Owner-Approval: cherry-picked from master
Change-Id: Ib2e4360493275b79c72487ee1cb173bb5e0fd35f
Merged-In: Ib2e4360493275b79c72487ee1cb173bb5e0fd35f
(cherry picked from commit 4c4aa41272)
2020-05-01 18:33:15 +00:00
Abodunrinwa Toki
1cf3ce8fde Merge "Rewrite Icons from the TCS." into rvc-dev 2020-05-01 10:52:43 +00:00
TreeHugger Robot
2b49f81e7e Merge "Use POWER_MENU_LOCKED_SHOW_CONTENT in wallet" into rvc-dev 2020-04-29 18:08:23 +00:00
TreeHugger Robot
13d7838088 Merge "Address leftover TODOs from inline suggestions." into rvc-dev 2020-04-29 01:46:47 +00:00
Sean Pont
d3cfe6204e Use POWER_MENU_LOCKED_SHOW_CONTENT in wallet
Use POWER_MENU_LOCKED_SHOW_CONTENT to control lock screen behavior for
the Quick Access Wallet.
Do not provide Intents that will fail to start an Activity.
Update comments.

Bug:155232731
Bug:155186709
Test: manual
Test: atest CtsQuickAccessWalletTestCases

Change-Id: I78e5355a69d666aee6dd122389edabed170f07b2
2020-04-28 17:40:09 -07:00
Adam He
045c020636 Address leftover TODOs from inline suggestions.
Fixes: 146524826
Test: atest android.autofillservice.cts.inline
Change-Id: I50666e9fa012b18f74c20982068a452fdc9592f8
2020-04-28 17:17:47 -07:00
Abodunrinwa Toki
8f2bf3cb53 Rewrite Icons from the TCS.
Because of the new app visibility constraints introduced in Android R,
apps may be unable to load icons from the TextClassifierService (TCS).
This is because the TCS returns "Icons" based on resources to the apps.
These resources were globally available until this new restriction.

In this CL, the TCMS rewrites responses with Icon(typ=RESOURCE) coming
from a TCS to responses with Icon(typ=URI). The new icons are backed
by a content provider that may be used to retrieve the necessary icons.

Bug: 151847511
Test: atest tests/tests/textclassifier/src/android/view/textclassifier/cts
Test: atest core/tests/coretests/src/android/view/textclassifier
Test: Select a phone number text, check that the "Call" icon shows
Change-Id: Ib63e54462508029cdf0e56c2c6a82ff4e81b02a8
2020-04-28 15:02:26 +01:00
Julia Reynolds
8582df5cc7 Add experience for shortcut-less convos
- no conversation specific controls
- no 'bubble this' button
- turn off interim placeholder channels
- fix msg tracking - only shortcut-less notifs matter

Test: atest
Bug: 154814754
Change-Id: Ia04ce496d4e7b2f353c71865f338b5229192c395
2020-04-28 12:11:47 +00:00
Feng Cao
bd26abbc5b Support WRAP_CONTENT in InlineSuggestion#inflate
Test: atest android.autofillservice.cts.inline
Bug: 154887895

Change-Id: Ie420bd40e8f0fb7d6e6b1e47ed0f41dc3f85b25e
2020-04-27 15:12:14 -07:00
TYM Tsai
850c8129e6 Filter the content of the Bundles used as extras and styling APIs
Adds filter to prevent passing binder objects in the extras and styling
APIs for inline suggestions. Avoids these to be used to send over remote
objects for Autofill provider and IME to communicate through private APIs
bypassing the OS.

Bug: 152316540
Test: atest CtsAutoFillServiceTestCases
Test: atest InlineSuggestionsRequestTest
Change-Id: I00940a845ed0e2546cbe09fa36e2439869c2f783
2020-04-22 14:41:07 +08:00
Julia Reynolds
96c9c4f967 Update default for conversations in DND
Including a one time reset of dogfooders/dev preview users

Test: manual - value is reset on first boot
Test: manual - change value, reboot, value is maintained
Fixes: 154234926
Change-Id: I5e4b338d6d7cc30dec1b12d31c3f1461c6f664cc
2020-04-20 13:52:53 -04:00
TreeHugger Robot
4e16915321 Merge "Cleaning up resources on mount destruction." into rvc-dev 2020-04-18 06:35:35 +00:00
Alex Buynytskyy
9a54579ac5 Cleaning up resources on mount destruction.
DataLoaderStub's lifetime is controlled externally, but we want to
release resources ASAP.

Bug: b/153874006
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: I34035f36d1fe4ed0e4916014d859feb7fe2c0a09
2020-04-17 22:07:10 -07:00
Nicholas Ambur
d3c1f27b0c add KeyphraseEnrollmentInfo to TestApi
KeyphraseEnrollmentInfo is used for testing the system enrollment
application support within GTS.

Bug: 153264697
Test: gts-tradefed run gts-dev -m GtsAssistIntentTestCases \
-t com.google.android.assist.gts.KeyphraseModelManagerTest# \
testAllSystemKeyphrasesAndLocales

Change-Id: I66558cf849f2815f2c917d128f9f9cc0673750ef
Merged-In: I66558cf849f2815f2c917d128f9f9cc0673750ef
2020-04-17 22:12:13 +00:00
Adam He
3f8cdb51b4 Remove android.view.inline deprecated API.
Bug: 152912563
Test: atest android.autofillservice.cts.inline
Change-Id: I95f3b1281e48c9319e96eabc53e81d524bf720ff
2020-04-15 16:31:21 -07:00
Galia Peycheva
652a8a65f3 Merge "Remove usage of low profile in DreamService" into rvc-dev 2020-04-15 20:35:00 +00:00
Galia Peycheva
4d3aaf6980 Remove usage of low profile in DreamService
The low profile in DreamService was used to hide the status bar and
navigation bar. Now this is done by
WindowInsetController.hide(systemBars()) in DreamActivity.

Bug: 151749301

Test: m && flash && verify that system bars don't show up
Change-Id: I8fc9ca67262e92422afb472ccd76ec561c90f66d
2020-04-15 20:01:28 +02:00
Julia Reynolds
b5535c6faa The notification archive should follow history setting
Test: atest
Fixes: 153677280
Change-Id: I9b2ae1ecd1cc8b42ab715ee033879f295949a9ba
2020-04-15 15:29:32 +00:00
Galia Peycheva
e7eee891b4 Merge "Fix DreamService not finishing correctly" into rvc-dev 2020-04-14 17:11:45 +00:00
Galia Peycheva
95b12348eb Fix DreamService not finishing correctly
CL assigns null to DreamService.mActivity when the DecorView of the
main window is detached (in onViewDetachedFromWindow()). This is also
when the Window is detached, so at that point the DreamService doesn't
care about the DreamActivity.

Fix: 152994058

Test: atest DreamManagerServiceTests

Change-Id: I716f443b2876a2db57df999a551eee31e98ab4f1
2020-04-14 16:42:10 +02:00
Joanne Chung
ba52b860f7 Merge "Pass augmented client state to the event history." into rvc-dev 2020-04-14 07:16:02 +00:00
Joanne Chung
5edb1aed08 Pass augmented client state to the event history.
Bug: 153030079
Test: manual
Test: atest android.autofillservice.cts.inline.\
InlineAugmentedLoginActivityTest

Change-Id: Ida14605296b9dcffe5ee55e0fb4612350d1629af
2020-04-10 23:08:21 +08:00
Yurii Zubrytskyi
4e21986e59 [incfs] Fix a leaked pending_reads FD
Bug: 153670585
Test: adb install/uninstall a dozen times
Change-Id: Iac05b5dc3792e55c2f103ac08bdd734b3b398882
2020-04-10 14:49:31 +00:00
TreeHugger Robot
c0404ff5e5 Merge "Pass inline suggestions renderer info Bundle to Frameworks and IME" into rvc-dev 2020-04-10 02:19:23 +00:00
Adam He
89afcd6f5d Pass inline suggestions renderer info Bundle to Frameworks and IME
Bug: 146454892
Test: manual verification
Change-Id: I5db6c3795a4a295486e497f2d27eaa561e1a3887
2020-04-09 13:30:33 -07:00
Sergey Volnov
6c74f7cc9a Fix Content Capture Data Share
Fixing a typo in the previous commit: s/remove/put/

Bug: 153013604
Test: ran CTS tests on sdk_gphone_x86
Change-Id: Iabe8ce51f38ac921aa5cc0e78b559e4a512b9273
2020-04-09 21:23:03 +01:00
Alex Buynytskyy
f415679228 Change the way how we call setStorageParams.
Now it's unified with callback FS connector - we are passing the
callback pointer directly to dataloader. This restricts access only
to methods we want and only by someone we want.

Bug: b/153468113
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: Ib557ebbe7c6c5ce92140eb20534a3626b3ac96d3
2020-04-07 14:42:50 -07:00
TreeHugger Robot
77d7bcc124 Merge "Update controls after addToDisplay/relayout before dispatching insets" into rvc-dev 2020-04-07 16:26:53 +00:00
Tiger Huang
0426a33650 Update controls after addToDisplay/relayout before dispatching insets
A window might request to control insets before it is added to WM and
expect the first dispatched WindowInsets as requested.

The first insets state returned from addToDisplay or relayout might be
not expected if the window just become thecontrol target in the
function.

With this CL, WM can return controls from addToDisplay and relayout, so
that the client can apply controls immediately, and update controlled
insets sources before dispatching the insets to the view hierarchy. This
enaures the insets dispatched are up-to-date.

Fix: 150756571
Test: atest WindowInsetsControllerTests RelayoutPerfTest
            WindowAddRemovePerfTest
Change-Id: Ib78c24beb7af5a54ad78935c3ddb260ef9645212
2020-04-07 16:05:40 +08:00
TreeHugger Robot
5eb9c8fada Merge "Store conversation requirement in a setting" into rvc-dev 2020-04-07 03:47:02 +00:00
Joanne Chung
62cd75f90d Merge "Made ExplicitHealthCheckService testable." into rvc-dev 2020-04-06 02:33:24 +00:00
Julia Reynolds
e24faa2c86 Store conversation requirement in a setting
So we can show it in developer options. Also fix a bug
where the setting wasn't being respected in systemui.

Test: atest
Bug: 152907434
Change-Id: I1eaed93a0c8a1ec4486c7072972e2f924402bb94
2020-04-02 16:28:40 -04:00
Alex Buynytskyy
50e0244012 Merge changes from topic "LOADER_USAGE_STATS" into rvc-dev
* changes:
  Checking LOADER_USAGE_STATS before enabling read logs.
  Revert "Update the current API dump"
2020-04-02 00:36:26 +00:00
Alex Buynytskyy
5e860ba105 Checking LOADER_USAGE_STATS before enabling read logs.
Bug: b/152633648
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: Ic747a51b97b785c627c95bddecc6834ef602ff30
2020-04-02 00:31:41 +00:00
Joanne Chung
ea12c719b6 Made ExplicitHealthCheckService testable.
Bug: 149077550
Test: atest CtsPackageWatchdogTestCases
Change-Id: I588052de62bce6cbfa8118d1be56257a1dde422f
2020-04-01 22:54:35 +08:00
Galia Peycheva
5a0549cd42 Merge changes Id6161f92,Ie0d8849a into rvc-dev
* changes:
  Introduce security checks to startDreamActivity
  Add verification for setting ACTIVITY_TYPE_DREAM
2020-04-01 10:18:19 +00:00
TreeHugger Robot
2240431010 Merge "Prevent dream service finishSelf before it was attached" into rvc-dev 2020-04-01 03:01:03 +00:00
Feng Cao
edb332c645 Replace Nullable bundle with NonNull and use Bundle.EMPTY
Test: atest InlineSuggestionsRequestTest
Bug: 152525467

Change-Id: Ie510e08ced8be4cc8df486f1acfa6eb330d194ef
2020-03-31 14:50:51 -07:00
TreeHugger Robot
c068acb6ae Merge "Add @UnsupportedAppUsage to the old inline APIs for compatibility" into rvc-dev 2020-03-31 21:23:09 +00:00
Sean Pont
4fca5e9d5b Merge "Add text attributes to Wallet manifest entry" into rvc-dev 2020-03-31 20:09:29 +00:00
Feng Cao
77636e89d0 Add @UnsupportedAppUsage to the old inline APIs for compatibility
Test: manually tested
Bug: 152799973

Change-Id: I6fed3fdbb9d3d872de8ed3bde8cbf45f5826975f
2020-03-30 23:08:21 -07:00
Sean Pont
b559e5689a Add text attributes to Wallet manifest entry
Bug: b/150331865
Test: atest CtsQuickAccessWalletTestCases
Test: manual - open quick access wallet

Change-Id: I76120c8d4d4f86eef37b312c61ae88934a53258f
2020-03-30 13:39:39 -07:00
Galia Peycheva
ed401cc16d Introduce security checks to startDreamActivity
This CL checks that the caller is the dream package and that the
device is dreaming when the activity is started.

isDream was instroduced in order to exempt the DreamActivity from
background start check. setAllowBackgroundActivityStart does that
more cleanly.

Bug: 152281628

Test: m && flashall && verify dream works

Change-Id: Id6161f923f3350d482b3452a78a792a541dcf1a1
2020-03-30 16:34:20 +00:00
Galia Peycheva
480275a197 Add verification for setting ACTIVITY_TYPE_DREAM
Bug: 152281628

Test: m && flash && check that dream starts normally
Change-Id: Ie0d8849aeb0c2de46a0e36bb0f9958091e0d28f4
2020-03-30 16:33:56 +00:00