Commit Graph

13144 Commits

Author SHA1 Message Date
Qasid Sadiq
aabd50e0a4 Merge "Populate scrollX and scrollY on AccessibilityEvents." 2019-07-03 23:17:52 +00:00
Issei Suzuki
60557b5bf5 Clean up SurfaceView.
Bug: 136538998
Test: no-op refactoring CL. Existing unit tests still pass.
Change-Id: Idd6c5871ed34880a053f3a43ab4f7aa3a466b548
2019-07-03 20:04:48 +02:00
TreeHugger Robot
08c51ea668 Merge "Removed unused variable from ThreadedRenderer" 2019-07-03 16:56:03 +00:00
TreeHugger Robot
4b235cb04a Merge "Clean up SurfaceView" 2019-07-03 09:21:41 +00:00
Issei Suzuki
f78b5e2e44 Removed unused variable from ThreadedRenderer
Bug: 136616503
Test: refactoring, check if existing tests pass
Change-Id: I627832b2e8f964dbabbf95788279e437c4347adf
2019-07-03 10:23:37 +02:00
Issei Suzuki
f0412592db Clean up SurfaceView
Bug: 136538998
Test: no-op refactoring CL. Existing unit tests still pass.
Change-Id: Ibd0310a87ed38aa48215be9cba54f1c7a2a8a9fa
2019-07-02 12:33:13 +02:00
John Reck
5e56d3f12b Merge "Switch to import for CtsUiRenderingTestCases" 2019-07-01 15:59:33 +00:00
Issei Suzuki
9e6679b040 Merge "Extend ViewRootImpl to support multiple FrameDrawingCallback" 2019-07-01 12:47:06 +00:00
Peiyong Lin
472eac2a3c Merge "Attach color space information when attach and queue buffer." into qt-r1-dev am: 964fcdbebd
am: 7537aeeb9f

Change-Id: I245e704a1d794ddb56892a97c74bf11effe0c3a1
2019-06-28 15:41:25 -07:00
Peiyong Lin
7537aeeb9f Merge "Attach color space information when attach and queue buffer." into qt-r1-dev
am: 964fcdbebd

Change-Id: I37376be3cdf0a8c72111c6de257eda4274f406c2
2019-06-28 14:35:34 -07:00
Mathew Inwood
b2f6f30c19 Merge "Restore some greylist entries." into qt-dev am: f4535c8d51 am: cd82f9adff
am: 7a4d871174

Change-Id: If3c3de3ec24226ec6ea10603ca246487ac40bfb4
2019-06-28 13:42:26 -07:00
Mathew Inwood
7a4d871174 Merge "Restore some greylist entries." into qt-dev am: f4535c8d51
am: cd82f9adff

Change-Id: Iff29bca8243e0c5e0e7ec30cd8b4a3f95c43ac82
2019-06-28 13:30:26 -07:00
Mathew Inwood
cd82f9adff Merge "Restore some greylist entries." into qt-dev
am: f4535c8d51

Change-Id: I3851fed60bedab9748f2d6d53f342f2605ecf78b
2019-06-28 13:18:30 -07:00
Issei Suzuki
935935660c Extend ViewRootImpl to support multiple FrameDrawingCallback
Bug: 136150954
Test: WIP
Change-Id: I690005fece924c38a5269cb35309061d0ccb6f1e
2019-06-28 15:48:17 +02:00
Mathew Inwood
a5531fa161 Restore some greylist entries.
In Q, these APIs were either:
- removed from the greylist entirely without good reason
- Moved to the restricted greylist without any public alternative
  information added

So they are being moved back to the greylist for Q.

Test: Treehugger
Bug: 136102585
Change-Id: Ie3dd15c8e17d530d853473a013717e6175383080
2019-06-28 09:23:06 +00:00
Rob Carr
1e32e5f4a1 Merge "Enable views to be placed in windowless surfaces." 2019-06-27 19:43:31 +00:00
Felix
2b1c378f0c Merge "PhoneWindowManager/KeyEvent: Camera key as WakeKey" am: dec76b8a40 am: 1841f6af1d am: de67a21c84
am: 727d193d5d

Change-Id: I418a5275d5ff6148eb5405589a1f89d3d2fa3f4e
2019-06-27 10:34:25 -07:00
John Reck
db7d1df4fc Switch to import for CtsUiRenderingTestCases
Centralizes option management

Test: this
Change-Id: I80bcaec765e1ed2bf0bdbe370548157690367ec6
2019-06-27 10:32:27 -07:00
Peiyong Lin
964fcdbebd Merge "Attach color space information when attach and queue buffer." into qt-r1-dev 2019-06-27 16:14:02 +00:00
Robert Carr
9d431e1cc8 Enable views to be placed in windowless surfaces.
For purposes of parcelling SurfaceControl to embed view hierarchies across
processes. We also want these Surfaces to receive input, but we can't
let the clients call setInputWindowInfo directly (or we could have issues
with clients stealing focus, etc...) and so we provide a method
blessInputSurface which has the WM configure a surface for input with
a minimal and safe set of parameters.

Test: WindowlessWmTests
Bug: 111373437
Bug: 134365580
Change-Id: I45fde62ba9b810e783d62c4dd5442abd038734d5
2019-06-27 15:14:45 +01:00
Winson Chung
6ff63bdf73 Merge "Catch all exceptions in onFrameDraw" into qt-dev am: cff24b878d am: abe1a94072
am: 056fd40726

Change-Id: Icd452fb2132ffd98fe65ee5951f727e41a37f40b
2019-06-26 18:35:14 -07:00
Peiyong Lin
ccc06b6f51 Attach color space information when attach and queue buffer.
Currently when calling attachAndQueueBuffer, the color space information is
lost. This results in color shift if the color space doesn't match the color
space of the surface.

BUG: b/135002842, b/131928312
Test: boot. Manually verified on P19
Change-Id: I95ec73c24942f79197d25ee85f139b2aaf805677
2019-06-26 11:40:08 -07:00
TreeHugger Robot
ee57765372 Merge changes from topic "sc_handles"
* changes:
  Remove SurfaceControl#getHandle from JAVA apis 2/2
  Remove SurfaceControl#getHandle from JAVA apis 1/2
2019-06-26 17:56:32 +00:00
Felix
727d193d5d Merge "PhoneWindowManager/KeyEvent: Camera key as WakeKey" am: dec76b8a40 am: 1841f6af1d
am: de67a21c84

Change-Id: I6c8450688f79394195e493877156e67330d022ff
2019-06-26 00:35:26 -07:00
Felix
de67a21c84 Merge "PhoneWindowManager/KeyEvent: Camera key as WakeKey" am: dec76b8a40
am: 1841f6af1d

Change-Id: I6771fdd3408461fb8343006a05d15c260d0fb256
2019-06-26 00:27:32 -07:00
Vishnu Nair
bc9beab8fe Remove SurfaceControl#getHandle from JAVA apis 2/2
Holding on to a reference of the handle in Java will keep the server-side surface alive until
the reference is removed by GC. This may cause surfaces to be kept alive longer than necessary.
Instead hold on the surface control and call SurfaceControl#release which will release the local
reference to the server-side surface.

Bug: 136004147
Test: go/wm-smoke

Change-Id: Iff7d48ae1593cea2e188aa07c417f4c5a98887d5
2019-06-25 17:33:44 -07:00
Vishnu Nair
4bcd152a3a Remove SurfaceControl#getHandle from JAVA apis 1/2
Holding on to a reference of the handle in Java will keep the server-side surface alive until
the reference is removed by GC. This may cause surfaces to be kept alive longer than necessary.
Instead hold on the surface control and call SurfaceControl#release which will release the local
reference to the server-side surface.

Bug: 136004147
Test: go/wm-smoke
Test: gesture nav sanity tests
Test: atest CompositionSamplingListenerTest

Change-Id: Iab33680746c8f48c28783e6a2a13c9ac7ae04980
2019-06-25 17:31:11 -07:00
chaviw
9f6171e7b2 Deleted SurfaceControl.remove method
Updated all callers of SC.remove to use Transaction.remove(sc) and apply
immediately since that's the equivalent. Eventually, the transactions
that contain remove could combine with other transactions if it makes
sense to avoid duplicate applies.

Test: SurfaceControlTest
Change-Id: I13c6ec86de6a6d60f142c2269337557510dd006d
2019-06-25 17:09:03 -07:00
Winson Chung
056fd40726 Merge "Catch all exceptions in onFrameDraw" into qt-dev am: cff24b878d
am: abe1a94072

Change-Id: I74089f0cf71ca2c3dc917001eb14dca8586396e0
2019-06-25 16:06:36 -07:00
Winson Chung
abe1a94072 Merge "Catch all exceptions in onFrameDraw" into qt-dev
am: cff24b878d

Change-Id: If3aef1ccbba89a4b0964749ee3184a83f88185be
2019-06-25 15:43:48 -07:00
Winson Chung
26ccc92307 Merge "Catch all exceptions in onFrameDraw" into qt-dev
am: cff24b878d

Change-Id: I485cc8af4e6180adebb31235b43191e467b393bc
2019-06-25 15:36:26 -07:00
Winson Chung
cff24b878d Merge "Catch all exceptions in onFrameDraw" into qt-dev 2019-06-25 22:07:44 +00:00
Jorim Jaggi
b0bb2f778f Catch all exceptions in onFrameDraw
... as throwing an exception in there somehow will mess up the
hwui task queue.

Test: Have a crashy app, swipe up while the app is crashing
Fixes: 134583193
Change-Id: Ie3ba5f991759f807b154f55f9fc816e7efe2fdfe
2019-06-25 15:37:53 +02:00
Issei Suzuki
a1a6067f2e Merge "Added subtle animation for unlocking screen." into qt-r1-dev am: 0ca1dbcb25
am: 79071973bf

Change-Id: I4612152ed11bab958d8d172e8620ab29dca5c883
2019-06-25 04:51:33 -07:00
Issei Suzuki
79071973bf Merge "Added subtle animation for unlocking screen." into qt-r1-dev
am: 0ca1dbcb25

Change-Id: I08834a57295530c15d19811cccc72174f9f428ad
2019-06-25 04:37:25 -07:00
Issei Suzuki
0ca1dbcb25 Merge "Added subtle animation for unlocking screen." into qt-r1-dev 2019-06-25 11:22:26 +00:00
Qasid Ahmad Sadiq
002e3cf73a Populate scrollX and scrollY on AccessibilityEvents.
This wasn't happening for RecyclerView, and that resulted in lost focus after scroll animations.
This is cause Talkback relies on changes in getScrollX/Y to determine if it should do anything about a TYPE_VIEW_SCROLLED AccessibilityEvent.
This squashes a big subset of "losted focus" bugs.
This is most painfully felt when you fling a RecyclerView and in ViewPager page transition, both resulting in slightly longer animations.
Also, change the default value of m[Max]Scroll[x/y] to reflect the above.

Change-Id: Ibe66260fbfc61c98ca88e1b2d9552ed116e44c15
Fix: 125385883
Test: CTSAccessibility*, Tried a few RecyclerViews on device, and ViewPager2 sample app.
2019-06-25 06:32:58 +00:00
Felix
2deb9b54d9 PhoneWindowManager/KeyEvent: Camera key as WakeKey
As discussed in https://r.android.com/973723

This makes any camera key event wake up the device.
Handling of the camera key apart from waking up the device might follow
in a later commit.

Signed-off-by: Felix <google@ix5.org>
Change-Id: I44dbc3f9ac465f664b6d740cb6a056b7f6e118fb
2019-06-25 06:41:12 +02:00
TreeHugger Robot
00c3a02ac7 Merge "Remove references of the previous surface control in ViewRootImpl" 2019-06-25 01:35:04 +00:00
Adam He
eec9ed5042 Merge "Fixed event flushing to handle when mDirectServiceInterface is not ready yet." into qt-r1-dev am: e6930c4aa1
am: accfaaa416

Change-Id: I37f6e60f3c28347e00bbfc3d4aeb09845ad00e63
2019-06-24 13:00:33 -07:00
Adam He
accfaaa416 Merge "Fixed event flushing to handle when mDirectServiceInterface is not ready yet." into qt-r1-dev
am: e6930c4aa1

Change-Id: I17671a59667ee8990e7f2ea62c7957d4ed90a966
2019-06-24 12:55:00 -07:00
TreeHugger Robot
e6930c4aa1 Merge "Fixed event flushing to handle when mDirectServiceInterface is not ready yet." into qt-r1-dev 2019-06-24 18:42:45 +00:00
Vishnu Nair
eaab0e5aad Remove references of the previous surface control in ViewRootImpl
Partial revert to fix regression from f7645aa9a9 which
kept a strong ref of the old SC used to detect when the SC changed. This meant that during the lifetime of an app it could keep an additional buffer alive.

Bug: 135762652, 132205507
Test: go/wm-smoke
Test: dumpsys meminfo

Change-Id: I93df8b4ef8ffdded6c46fb44ca4cd110038d75d0
2019-06-24 08:12:32 -07:00
Issei Suzuki
5609ccbf95 Added subtle animation for unlocking screen.
Change-Id: Id691fec4f2e492682a53d6855090524f000ddc6c
Bug: 134965724
Bug: 134952761
Test: N/A
2019-06-24 14:25:04 +00:00
Robert Carr
d2076adad2 Merge "ViewRootImpl: Ensure layout when configuration changes." into qt-dev am: 6397ab05f9 am: 641d4f27e3
am: 52277fd25e

Change-Id: I2eda57ef8935733732ed5adc5c9bb2baeeb4ed0c
2019-06-21 18:58:03 -07:00
Robert Carr
52277fd25e Merge "ViewRootImpl: Ensure layout when configuration changes." into qt-dev am: 6397ab05f9
am: 641d4f27e3

Change-Id: Ic3bfad9182f677251742ade7c430b8f1205a9e65
2019-06-21 17:42:23 -07:00
Robert Carr
641d4f27e3 Merge "ViewRootImpl: Ensure layout when configuration changes." into qt-dev
am: 6397ab05f9

Change-Id: I023b06dc785cbf22783a426060aef55714a457d8
2019-06-21 17:32:54 -07:00
Robert Carr
9e4b7a3f8d Merge "ViewRootImpl: Ensure layout when configuration changes." into qt-dev
am: 6397ab05f9

Change-Id: I17feac89670b328f88878ce57636cf4954e0c6f3
2019-06-21 17:30:57 -07:00
John Reck
14ff220613 Merge "Revert SurfaceView back to Q's version" into qt-r1-dev am: 2f8cae24b9
am: 2562753783

Change-Id: I3c95c3c080b76b9f9f33ddb9e27d84a167cdfcb6
2019-06-19 19:33:20 -07:00
John Reck
2562753783 Merge "Revert SurfaceView back to Q's version" into qt-r1-dev
am: 2f8cae24b9

Change-Id: Iedb5910e225fd2584b6b4342dc7aed9b93747eb0
2019-06-19 16:07:02 -07:00