Commit Graph

10280 Commits

Author SHA1 Message Date
Tony Mak
fe931c058b Merge "Optimize filterByLanguage by caching locale objects" into oc-mr1-dev am: cb5a109d17
am: 3c5890286b

Change-Id: Ie6f1892cb334433e1bc38f9bce1a42bf23456d80
2017-08-09 18:52:23 +00:00
TreeHugger Robot
cb5a109d17 Merge "Optimize filterByLanguage by caching locale objects" into oc-mr1-dev 2017-08-09 18:35:01 +00:00
Tony Mak
afcd19c71e Optimize filterByLanguage by caching locale objects
According to traceview, most of the time spent in filterByLanguage
is calling getLocaleObject to create java.util.Locale objects.
The solution is to cache the object to save the cost. Note that both
mSubtypeLangugageTag and mSubtypeLocale are final, so it is fine to
cache the locale object.

Test: bit FrameworksCoreTests:android.view.inputmethod.InputMethodSubtypeTest
Test: bit FrameworksCoreTests:com.android.internal.inputmethod.LocaleUtilsTest
Test: Try to switch user back and forth, and tap a textview to show IME.

Bug: 37647204
Fix: 37647213

Change-Id: Ib6ff7e97b17fc547c8109af8177f05fc3ea41b08
2017-08-09 15:50:57 +00:00
Felipe Leme
c58ef479e3 Clarifies autofill lifecycle. am: 744976e298 am: af40bb0dc4 am: 9457911997
am: 7bf5b6cb58

Change-Id: Id63a96d7c388c69066580163b092d9948c0c8364
2017-08-09 12:56:48 +00:00
Felipe Leme
9457911997 Clarifies autofill lifecycle. am: 744976e298
am: af40bb0dc4

Change-Id: I48f797f62c120b352045cb93e5067ee20c3154d3
2017-08-09 12:30:16 +00:00
TreeHugger Robot
891f481ef8 Merge "Refactoring: Deprecate Paint.mNativeTypeface." 2017-08-08 19:48:05 +00:00
Seigo Nonaka
318ca04079 Refactoring: Deprecate Paint.mNativeTypeface.
Bug: 64269689
Test: m checkbuild
Test: bit CtsGraphicsTestCases:*
Test: bit CtsViewTestCases:*
Test: bit CtsTextTestCases:*
Change-Id: Idc9f2b4612741be949204cd06efc41e1738d6587
2017-08-08 18:07:28 +00:00
Felipe Leme
af40bb0dc4 Clarifies autofill lifecycle.
am: 744976e298

Change-Id: Ia1c9652ded5c5ea6af9dc7872f89bd776a58e6d4
2017-08-08 17:34:14 +00:00
Felipe Leme
744976e298 Clarifies autofill lifecycle.
Test: m update-api

Bug: 64125551
Bug: 64114048
Change-Id: I17c5bc2e2e64fa27e877301dbcb983ac8497209e
2017-08-07 17:22:50 -07:00
Andrii Kulian
4e61506474 Merge "Merge "Add black frame behind app window" into oc-dr1-dev am: cbdaf04101 am: cdcc9dd0dd" into oc-mr1-dev-plus-aosp
am: 5c6f9676cb

Change-Id: Ifb0afb96bea83d9b05e0fd6db9e78bb8e0375de7
2017-08-07 22:44:41 +00:00
Andrii Kulian
cdea2b5ab8 Merge "Add black frame behind app window" into oc-dr1-dev am: cbdaf04101
am: cdcc9dd0dd

Change-Id: I1391ee22429cbc3cefe7f16fb9e2cc76d48ec870
2017-08-07 22:29:34 +00:00
Andrii Kulian
66994114e7 Merge "Add black frame behind app window" into oc-dr1-dev
am: cbdaf04101

Change-Id: I9ce5cf5aea7f0fd93fbe24664bbd583d5057d3e6
2017-08-07 22:21:08 +00:00
Jeff Sharkey
1fb3a312e7 Merge "Fix broken javadocs." into oc-mr1-dev am: b79eb54d36
am: 1ad38fe278

Change-Id: I21266d20be036196dbeddb9c4366d641ab1b68a8
2017-08-06 17:00:09 +00:00
Jeff Sharkey
67f9d5070a Fix broken javadocs.
Bug: 64337634
Test: make -j32 doc-comment-check-docs
Change-Id: I20fdd3dcddef09111d35946c41c596c7689effa6
2017-08-06 07:37:08 -06:00
Andrii Kulian
283acd20ca Add black frame behind app window
Add black background behind letterboxed apps on displays with tall
aspect ratio. This is needed to make sure that other windows won't
bleed through status/navigation bar area, because letterboxed
windows are not considered fullscreen.

Bug: 63156733
Bug: 62893418
Test: go/wm-smoke
Test: Trigger animations to/from recents with different rotations.
Change-Id: If0eac9a3801518185d560a87d9f88ee0aafa3a9c
2017-08-04 14:32:26 -07:00
Abodunrinwa Toki
213791f74d Merge "Remove LangId related code." into oc-mr1-dev am: 38bbbdfae6
am: 2566e91f9f

Change-Id: Ic481522e134d17bbaaa3741208a3fee5426ce688
2017-08-03 18:19:23 +00:00
TreeHugger Robot
38bbbdfae6 Merge "Remove LangId related code." into oc-mr1-dev 2017-08-03 17:54:29 +00:00
Robert Carr
e46a041f36 Merge "Merge "Inform SurfaceFlinger of which Surface is the RoundedCorners overlay." into oc-dr1-dev am: 48ed8aa4d0 am: e64d0028ae" into oc-mr1-dev-plus-aosp
am: eee9fe304c

Change-Id: Ibacf967f6dbf5a03752186e0a4c8750cabf15cae
2017-08-03 13:13:48 +00:00
Robert Carr
3f81745199 Merge "Inform SurfaceFlinger of which Surface is the RoundedCorners overlay." into oc-dr1-dev am: 48ed8aa4d0
am: e64d0028ae

Change-Id: Ib87b081ec02bfa030d0561cf12beac9d4b8ca692
2017-08-03 13:01:15 +00:00
Robert Carr
76136dcf45 Merge "Inform SurfaceFlinger of which Surface is the RoundedCorners overlay." into oc-dr1-dev
am: 48ed8aa4d0

Change-Id: I3030c64c30f6c16dc9c8a01e21a5dc6b58cbd273
2017-08-03 12:53:38 +00:00
TreeHugger Robot
48ed8aa4d0 Merge "Inform SurfaceFlinger of which Surface is the RoundedCorners overlay." into oc-dr1-dev 2017-08-03 12:45:07 +00:00
Tarandeep Singh
80f47e54f4 Merge "Merge "Fix keyboard focus in VR" into oc-dr1-dev am: 986995d481 am: 7def2eea97" into oc-mr1-dev-plus-aosp
am: 6f6cc83cf3

Change-Id: I9ceea32fa06bab6416a341998425e9d176c054e6
2017-08-02 23:44:16 +00:00
Tarandeep Singh
ab1a5ff749 Merge "Fix keyboard focus in VR" into oc-dr1-dev am: 986995d481
am: 7def2eea97

Change-Id: I538777a295628827fc3052c58641cbb659afad20
2017-08-02 23:04:58 +00:00
Evan Rosky
902a345f25 Merge "Gracefully handle focus loops created by app dev." into oc-dr1-dev am: ae938cee71 am: 756685b506
am: caab68931b

Change-Id: I22e1e9364d586579942f968d2f6e52687a8db276
2017-08-02 23:00:57 +00:00
Tarandeep Singh
9c4115a562 Merge "Fix keyboard focus in VR" into oc-dr1-dev
am: 986995d481

Change-Id: I693c1256583dc1081c6402668401c6aab2337d16
2017-08-02 22:59:51 +00:00
Evan Rosky
64dd913f68 Merge "Gracefully handle focus loops created by app dev." into oc-dr1-dev
am: ae938cee71

Change-Id: I0b0fe6f7cc07362e98f7a5a2b54aa66bbd5ffc7f
2017-08-02 22:42:21 +00:00
Evan Rosky
caab68931b Merge "Gracefully handle focus loops created by app dev." into oc-dr1-dev am: ae938cee71
am: 756685b506

Change-Id: I097489465c8bc066ddba04ea858c32f4af463a66
2017-08-02 22:40:48 +00:00
Tarandeep Singh
986995d481 Merge "Fix keyboard focus in VR" into oc-dr1-dev 2017-08-02 20:33:02 +00:00
Tarandeep Singh
e1cfcf4c4d Fix keyboard focus in VR
Consider this VirtualDisplay (VD) scenario:
HostActivity creates a VD which holds SettingsActivity. When EditText
on SettingsActivity is tapped, it gains focus.
On eventual taps, it loses focus i.e. the Window in VD loses focus and
the host activity in primary display gets the focus instead. This
happens because WM's TaskTapPointerEventListener.onPointerEvent()
is called on the default display only.

Root cause:
1. Tap detector isn't registered for non-default display.
2. Tap detector has no info on which displayId touch was received.
3. InputFlinger doesn't deliver InputMonitor events for
non-default displays (fixed in a separate CL)

Fixing above results in onPointerEvent(MotionEvent) to deliver the
Touch events successfully to VD. We restrict these changes to physical
multi-displays and VR VirtualDisplays (which uses virtual touch device).
[VrManagerService calls WMInternal.setVr2dDisplayId(int)]

In future, displayId should be part of InputEvent. Bug: 64258305

Bug: 62033391
Test: bit FrameworksServicesTests:com.android.server.wm.DisplayContentTests
Change-Id: I3626f4de5aa9bcf905da9abd39f3ab1baefc4c48
2017-08-02 10:46:22 -07:00
Dake Gu
06b1283394 Merge "View: fix setTransientState" into oc-mr1-dev am: 8eb3a3979f
am: 8701a3231b

Change-Id: Id7c933c23d472184ff7d8b91d1587bcb0853207e
2017-08-02 17:34:16 +00:00
Evan Rosky
9d93486ed6 Gracefully handle focus loops created by app dev.
Instead of ANR in an infinite loop, this will detect
a cycle and return null.

Bug: 62960867
Test: Added in CTS FocusFinderTest#testChainVisibility
Change-Id: Ifb4638e3350642f065c40b3bea112cc12efff447
2017-08-02 17:33:32 +00:00
Dake Gu
8eb3a3979f Merge "View: fix setTransientState" into oc-mr1-dev 2017-08-02 17:18:00 +00:00
Robert Carr
132c9f5140 Inform SurfaceFlinger of which Surface is the RoundedCorners overlay.
We need to omit it from screenshots, and screen mirroring, so SurfaceFlinger
will have to have some knowledge. Eventually we'd like to do this by
having everything else have a parent, and mirroring and screenshotting will
operate on that parent. Since we aren't comfortable doing that for DR though, here's
a quick and dirty hack to tide us over with low risk.

Bug: 63311708
Test: screencap, screenrecord, android.view.cts.SurfaceViewSyncTest
Change-Id: I2b43be00567ee19cf27aeef344e5415f4a69297f
2017-08-02 09:03:05 -07:00
Felipe Leme
27eb322ed2 Merge "Cherry-picked some Autofill Javadoc improvements from master." into oc-dev
am: 6829a1dace

Change-Id: I41dec3cb31e6b523927717950f827f45dadabd8b
2017-08-02 00:26:37 +00:00
Dake Gu
43ad57e548 View: fix setTransientState
Following four steps with RecyclerView - CardView - ImageView:
a. fade in imageview in onBind:
calling imageView.setTransientState(true)
b. RecyclerView animate the item: calling
cardView.setTransientState(true)
c. fade-in finishes, calling imageView.setTransientState(false)
d. RecyclerView animation finishes: calling
cardView.setTransientState(false)

After these four steps, RecyclerView unexpectedly has transient
state.

The problem is in step b, when calling cardView.setTransientState()
it incorrectly calls parent.childHasTransientStateChanged(this, true)
which causes RecyclerView's mChildCountWithTransientState increased
to 2. And it's decreased to 1 in step d and stay as 1 forever.

The child should only call childHasTransientStateChanged() when
actual hasTransientState() changed.

Bug: 64235615
Test: ViewTransientStateTest
Change-Id: I99ed35cc9c49e54d36590d8f1d206501fd3288f2
2017-08-01 14:17:39 -07:00
Abodunrinwa Toki
5820875975 Remove LangId related code.
FYI: We have plans to reintroduce this in some form in the near future.

Fixes: 62571798
Fixes: 64096360

Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Change-Id: I864d6c1143af6a2485cabdfe85116b5922a3e315
2017-08-01 21:22:46 +01:00
Felipe Leme
33681a94cf Cherry-picked some Autofill Javadoc improvements from master.
Test: m update-api

Bug: 64125551
Bug: 63669555
Bug: 63985284

Merged-in: Iba4817f682670e9fd6d891ae221e1fa415252e99
Change-Id: I82cbb54a522b2cf1dfb11aacc9735c932aa9af90
2017-07-31 10:18:03 -07:00
Yohei Yukawa
53a05ff72b Merge "Remove a compat hack SurfaceView#setWindowType()" into oc-mr1-dev am: f678eaad89
am: 5eca35d4a0

Change-Id: I29c7b3125d20ea44b3e9e0f1e1b0aec36fbbfeb2
2017-07-31 07:22:25 +00:00
Yohei Yukawa
7a1ad6d97c Remove a compat hack SurfaceView#setWindowType()
This CL logically reverts a compatibility hack I introduced [1] for
apps that had relied on @hide method SurfaceView#setWindowType(int).

 [1]: I5217f6417a73690ae8a978754218b7b089070fdd
      3b5011afc9

Fixes: 62054282
Test: Manually verified that Bug 36345857 is still not reproducible
Change-Id: Icee198c554de558cfa4ffe0b264064969839654e
2017-07-30 20:54:08 -07:00
Bryce Lee
62781c3190 Merge "Merge "Remove rotation and app bounds from Configuration diff." into oc-dr1-dev am: 5b76ce1b2b am: d6dfd4a8b4" into oc-mr1-dev-plus-aosp
am: 5cbba88608

Change-Id: Ib281ee072bfb0f2ce1fc88ffcf1bcdee742e7901
2017-07-28 22:18:52 +00:00
Bryce Lee
96d54d41f4 Merge "Remove rotation and app bounds from Configuration diff." into oc-dr1-dev am: 5b76ce1b2b
am: d6dfd4a8b4

Change-Id: I38aeed5d2ab2cf7932e98e97800fa1cd73c7a3ec
2017-07-28 21:47:21 +00:00
Bryce Lee
84fa183e7d Merge "Remove rotation and app bounds from Configuration diff." into oc-dr1-dev
am: 5b76ce1b2b

Change-Id: Ibf899e9a08cdab31ae38897add813fc4c8089474
2017-07-28 21:28:05 +00:00
Bryce Lee
0e4a6dfb3f Remove rotation and app bounds from Configuration diff.
The presence of these new flags leads to issues with application that
do not expect their presence. Since these flags can appear at
critical times, such as on orientation change, these issues are
brought to the surface often.

This CL remedies this problem by first removing the rotation
property. It is not used and the original issue of orientation and
Configuration alignment has been addressed. For app bounds, the CL
reverts the behavior back to identifying diffs as a screen size
change.

Fixes: 64004417
Test: bit FrameworksServicesTests:com.android.server.wm.AppBoundsTests
Test: go/wm-smoke

Change-Id: I1fabb564dfb5c13d897336708523cf7cd5099fa0
2017-07-28 07:49:01 -07:00
Felipe Leme
f4ec2869f2 Merge "Merge "Checks if mResponses is null before using it." into oc-mr1-dev am: db3c4ee787" into oc-mr1-dev-plus-aosp
am: 877e38f4d9

Change-Id: I3c9bac117c274da76cd62f8b1407836dd280ec6e
2017-07-27 02:51:53 +00:00
TreeHugger Robot
db3c4ee787 Merge "Checks if mResponses is null before using it." into oc-mr1-dev 2017-07-27 01:00:58 +00:00
Phil Weaver
6a65b75e47 Merge "Prohibit using recycled AccessibilityNodeInfos." 2017-07-25 18:35:34 +00:00
Andrei Stingaceanu
1244815e8f Remove @hide from ViewGroup debug methods
Allow developers to easily add their own debugging info
when developing custom ViewGroups.

Bug: 30117235
Test: tests still pass
Change-Id: Ia83005b4dc727c7b959a50e7b0130582f6e89762
2017-07-25 10:00:21 +00:00
Phil Weaver
11e5e3f875 Prohibit using recycled AccessibilityNodeInfos.
Bug: 37858096
Test: Adding a CTS test to verify an exception when using a
node after recycling it. Ran a11y CTS and unit tests.

Change-Id: I5486a7abec681cb6fbb315ff87f0915d5505b8f3
2017-07-24 13:37:03 -07:00
Felipe Leme
afdfe7665c Checks if mResponses is null before using it.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testFillResponseAuthWhenAppCallsCancel
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 63806922
Bug: 63985284

Change-Id: I8d7cfa34ba88a1d351967e17717b387c805dd00d
2017-07-24 12:38:47 -07:00
Michael Wright
d487520e4c Merge "Remove non-safe mode boot vibration." into oc-dr1-dev
am: 149ff697ff

Change-Id: Ie8964116ffb3dccd6b683f0fff764d128107ac4f
2017-07-24 12:52:43 +00:00