Commit Graph

1133 Commits

Author SHA1 Message Date
Felipe Leme
3ce370a98c Merge "Added missing quote (") on anchor tag." into oc-mr1-dev am: 7c112b733c
am: 33b907f6b0

Change-Id: I0e4382cdda9d5be28542d8cb8a4762b5b5513e0c
2017-09-26 23:51:48 +00:00
Felipe Leme
a821efeeb7 Added missing quote (") on anchor tag.
Test: 'm -j doc-comment-check-docs' then verify resulting HTML
Fixes: 66958057

Change-Id: Ie5914a5af191866404b6fbf244c78e145c59a8b1
2017-09-26 13:06:41 -07:00
TreeHugger Robot
8672d81355 Merge "Fixing method asymmetry in Parcel" 2017-09-23 04:18:46 +00:00
Felipe Leme
15b9eb5dac Merge "Add metrics (and moar logging) for when a service disables itself." into oc-mr1-dev am: 6f50d16338
am: cbbc364ec0

Change-Id: Iba0a0e66168a5716aa7cfc2f068fa922d19b02e9
2017-09-22 21:26:36 +00:00
Felipe Leme
9d41449ff4 Add metrics (and moar logging) for when a service disables itself.
Test: adb shell logcat -b events | grep sysui_
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Bug: 65376559
Bug: 65856399

Change-Id: Ieb54bb0a58ecd51da663170a12817d33188ac9f0
2017-09-22 09:23:04 -07:00
Sunny Goyal
0e60f22d2d Fixing method asymmetry in Parcel
Test: manually
Change-Id: I2a8321023b40cc74b7026eb0fb32a9cc5f5543a9
2017-09-21 21:41:14 -07:00
Jonathan Basseri
221c182ddc Merge "Convert ICarrierService to oneway." into oc-mr1-dev am: 806af68f5d
am: c323c9f4e9

Change-Id: Iaab75e584578be138d9e629bec59e32691771b67
2017-09-21 03:59:21 +00:00
Jonathan Basseri
49b54d64ca Convert ICarrierService to oneway.
Change the carrier config AIDL used by CarrierService to a oneway call.
This is the IPC used to fetch carrier config bundles from carrier apps.
Converting to oneway allows CarrierConfigLoader to be non-blocking while
it fetches config.

Bug: 63176442
Test: runtest carrierconfig-unit & manual
Change-Id: Iceaf0446321f719011f67897398da7d5998c5fc7
2017-09-19 12:47:51 -07:00
Fan Zhang
723bf37ab2 Initial API for providing suggestions.
This is a WIP system api that will be
 - Implemented by one unbundled app (SettingsIntelligence) using system-sdk,
 - and consumed by Settings app.

Note: The bundled app does not have permission to read/write any
      user settings. Nor does it have permission to call any private API
      to do anything unsafe.

Test: builds
Test: instrumentation test
Bug: 65065268
Change-Id: Ib190c0e4c167deb3c6197b8a5b39d442d804770b
2017-09-14 13:02:23 -07:00
TreeHugger Robot
627cc3c7ae Merge "Don't log TYPE_DATASET_SELECTED on dataset authentication." into oc-mr1-dev 2017-09-09 09:04:39 +00:00
TreeHugger Robot
09545e3fa7 Merge "Added more logging to diagnose a racy runtime restart." into oc-mr1-dev 2017-09-09 04:01:35 +00:00
Felipe Leme
2ad2e7c065 Merge "Javadoc: Added alternative to Package verification." into oc-dev am: 092349600d am: 33d476c170 am: 66e3c9aaf8
am: 210485221c

Change-Id: I6beec69db2fcdb2914859f7ff78974822dc40d8e
2017-09-08 22:15:44 +00:00
Felipe Leme
210485221c Merge "Javadoc: Added alternative to Package verification." into oc-dev am: 092349600d am: 33d476c170
am: 66e3c9aaf8

Change-Id: I07156ab1aec1415ed3c484da0fe3567896c073b7
2017-09-08 22:00:59 +00:00
Felipe Leme
bc1af42171 Merge "Javadoc: Added alternative to Package verification." into oc-dev am: 092349600d
am: 33d476c170

Change-Id: I59c6ddc48fad9178b03c7a1da7957238d4045ea7
2017-09-08 21:51:51 +00:00
Felipe Leme
33d476c170 Merge "Javadoc: Added alternative to Package verification." into oc-dev
am: 092349600d

Change-Id: Ic765df95fc660fb0df8a0f027d739ea999a36702
2017-09-08 21:41:36 +00:00
Felipe Leme
ada46b3fe7 Merge "Fixed CharSequenceTransformation to use find() instead of matches()." into oc-mr1-dev am: 48bf1ca5d4
am: 7f3510110c

Change-Id: Ib20cd412b29ab2a2d84ea9c28998c3c811140e05
2017-09-08 19:34:42 +00:00
TreeHugger Robot
c9982ce300 Merge "Don't log TYPE_DATASET_SELECTED on dataset authentication." 2017-09-08 19:15:45 +00:00
TreeHugger Robot
5664b30008 Merge "OemLockService: remove canUserAllowOemUnlock()" into oc-mr1-dev 2017-09-08 19:08:47 +00:00
TreeHugger Robot
48bf1ca5d4 Merge "Fixed CharSequenceTransformation to use find() instead of matches()." into oc-mr1-dev 2017-09-08 19:08:06 +00:00
Felipe Leme
63f7906c1d Don't log TYPE_DATASET_SELECTED on dataset authentication.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Bug: 65007529
Fixes: 65403592

Merged-In: I98f1198cbe1836c8154b73a1227be4f6947abc19
Change-Id: I98f1198cbe1836c8154b73a1227be4f6947abc19
2017-09-08 17:10:38 +00:00
Felipe Leme
8f0fad859c Don't log TYPE_DATASET_SELECTED on dataset authentication.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Bug: 65007529
Fixes: 65403592

Change-Id: I98f1198cbe1836c8154b73a1227be4f6947abc19
2017-09-08 10:05:31 -07:00
Andrew Scull
85be690734 OemLockService: remove canUserAllowOemUnlock()
No longer used by Settings as the logic was wrong.

Test: gts-tradefed run gts -m GtsOemLockServiceTestCases
Bug: 65124732
Change-Id: I44e5f697aabd2b5eefecf64060502b5c9ef5f911
(cherry picked from commit d37fe2d3e1)
2017-09-08 16:07:55 +00:00
Andrew Scull
96a9d0130a Merge "OemLockService: remove canUserAllowOemUnlock()" 2017-09-08 16:01:47 +00:00
TreeHugger Robot
1a7048f5d8 Merge "Added more logging to diagnose a racy runtime restart." 2017-09-08 05:15:57 +00:00
Felipe Leme
e102579e4c Merge "Finishes the session when the service returns a null response on authentication." into oc-mr1-dev am: a61839458f
am: 1c0d25fc56

Change-Id: Ie332a146dafde80058e6b30d54fffb8d5d4a7dc7
2017-09-07 22:47:07 +00:00
Felipe Leme
1540bfd21d Fixed CharSequenceTransformation to use find() instead of matches().
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.CharSequenceTransformationTest#testReplaceAllByOne
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 65459117

Change-Id: Ib5ff31b6b12e5583e736a0593e941e1556ae7384
2017-09-07 15:22:22 -07:00
Felipe Leme
8fa5f5e7df Added more logging to diagnose a racy runtime restart.
Also fixed a possible NPE on saveLocked() and improved locking.

Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases
Bug: 65374274

Merged-Id: I4b8368a9d19b4b4da76533dadb013ff2e2922955
Change-Id: I4b8368a9d19b4b4da76533dadb013ff2e2922955
2017-09-07 09:31:30 -07:00
Felipe Leme
a012d7e62b Added more logging to diagnose a racy runtime restart.
Also fixed a possible NPE on saveLocked() and improved locking.

Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases
Bug: 65374274

Change-Id: I4b8368a9d19b4b4da76533dadb013ff2e2922955
2017-09-07 09:05:55 -07:00
Andrew Scull
d37fe2d3e1 OemLockService: remove canUserAllowOemUnlock()
No longer used by Settings as the logic was wrong.

Test: gts-tradefed run gts -m GtsOemLockServiceTestCases
Bug: 65124732
Change-Id: I44e5f697aabd2b5eefecf64060502b5c9ef5f911
2017-09-07 14:03:21 +01:00
Felipe Leme
b0a4057d44 Finishes the session when the service returns a null response on authentication.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testFillResponseAuthServiceHasNoData
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 64985246

Change-Id: Id9a4b9f1752dcee6c67ac659b9dbd6dd1dd7b43c
2017-09-05 16:28:23 -07:00
Felipe Leme
87f03be771 Javadoc: Added alternative to Package verification.
Bug: 64125551
Test: ran 'm -j doc-comment-check-docs' and checked resulting HTML

Change-Id: I371cd1752ab92e19461fe3bf3d034c7bc83ca2dd
2017-09-05 10:56:07 -07:00
Felipe Leme
9852897bf6 New Autofill API: SaveRequest.getDatasetIds()
Test: modified some existing CTS tests to use it
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 64843801

Change-Id: I95fe7766f19e5a9eea9d7138636a15cc832c704c
2017-09-01 14:01:10 -07:00
TreeHugger Robot
9eb7a69e78 Merge "Removed deprecated BIND_AUTOFILL permission." 2017-09-01 15:11:56 +00:00
TreeHugger Robot
47f4cbdf04 Merge "Added getClientState() to FillEvent; deprecated it on FillEventHistory." 2017-08-31 22:59:02 +00:00
Felipe Leme
fff9f7ed61 Removed deprecated BIND_AUTOFILL permission.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 37563972

Change-Id: If751eb94336756da205908deae9e3b9b1c67c4e8
2017-08-31 14:31:39 -07:00
TreeHugger Robot
ac2a765a18 Merge "Fixed FillResponse.toString() to display list of datasets." into oc-mr1-dev 2017-08-31 19:43:01 +00:00
Felipe Leme
1c501ebfec Added getClientState() to FillEvent; deprecated it on FillEventHistory.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 62830277

Change-Id: Ib99a342c931f4fd44fc8aced1faef0b75588f63d
2017-08-29 17:48:00 -07:00
Felipe Leme
88cfa80901 Fixed FillResponse.toString() to display list of datasets.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Bug: 63392631

Change-Id: I893f468ee20d069b16f00d38f5fa18ed60826d03
2017-08-29 13:49:50 -07:00
Felipe Leme
c24a56ae06 Hides the Save UI while handling a pending intent from CustomDescription.
When the AutofillService sets a PendingIntent to launch an activity when
clicking a chield view (for example, to lauch a web page displayign the terms
and conditions of saving something), the system must hide the Save UI and
restore it after the new activity is dismissed.

That sounds simple in the surface, but it requires a huge refactoring behind
the scenes, such as injecting a token in the activity intent and using that
token to hide / cancel the UI during some activity lifecycle events.

Test: lotta of brand-new shinning tests on CtsAutoFillServiceTestCases
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Change-Id: Ie8ec7aeb2c63cab68467046c1a9dcf85dbcc24ec
Fixes: 64309238
2017-08-28 18:04:15 -07:00
TreeHugger Robot
0405d12a31 Merge "Allow VR State Listeners with RESTRICTED_VR_ACCESS permission." into oc-mr1-dev 2017-08-25 20:13:31 +00:00
Felipe Leme
017c0192d7 Merge "Minor Autofill javadoc fixes." into oc-dev am: 560221752e
am: 948e9ff4d3

Change-Id: I322ab59aa9600b7deb5a48f2e6fc6e012053b8f3
2017-08-25 19:48:51 +00:00
Felipe Leme
948e9ff4d3 Merge "Minor Autofill javadoc fixes." into oc-dev
am: 560221752e

Change-Id: Ib2924dae99bfe132a56a1583ecf4a88f833d3937
2017-08-25 19:36:56 +00:00
Santos Cordon
e6d7723307 Allow VR State Listeners with RESTRICTED_VR_ACCESS permission.
Extend the ability to use VrStateListeners to applications that
have RESTRICTED_VR_ACCESS permission.  Previously, it required
ACCESS_VR_MANAGER only.

Add VrStateCallback object and methods to VrManager to access the
functionality outside of frameworks.

Bug: 64360244
Test: Manual. Tested ability from VrCore.

Change-Id: I01f1c75b1ccd44a09364df84218168cf6caab322
2017-08-24 21:45:24 +00:00
Chris Thornton
08157c42ae The VIS should return an AOHD regardless of keyphrase availability.
Bug: 64932385
Test: Revert to previous behaviour
Change-Id: I10ae9ffe189a5d2dda5c74d0cff05f57e2f9bad7
2017-08-22 09:16:21 -07:00
Felipe Leme
94011333e8 Minor Autofill javadoc fixes.
Bug: 64125551

Test: no, thanks

Change-Id: Idea93d3a55705fbed6ede7eac0c0791300ff1c90
2017-08-17 09:14:39 -07:00
TreeHugger Robot
6ba128762f Merge "Calls CancellationSignal when onFillRequest() times out." into oc-mr1-dev 2017-08-15 22:23:57 +00:00
Felipe Leme
2220049d58 Merge "Additional documentation about Autofill / WebView security." into oc-dev am: 36cbdef880
am: a3c2cee055

Change-Id: Ie107dd462a47009a34ee3768183dfda2e36107c3
2017-08-15 21:48:32 +00:00
Charles He
77f3300f48 [automerger] Fix security hole in GateKeeperResponse. am: e74cae8f7c am: b1141b6ff0 am: 1cd9e8096f am: 6dfc8d8d4d am: a3c1de7e49 am: 4acf4fabf4 am: 40317127f4 am: 159cd14334 am: 24587d57cf am: 0fa9328b80
am: b0fa5855dc

Change-Id: Iaadf2350cd86ffc598e666e0d9dc735e5a7889f0
2017-08-15 21:35:05 +00:00
Felipe Leme
a3c2cee055 Merge "Additional documentation about Autofill / WebView security." into oc-dev
am: 36cbdef880

Change-Id: Ie198dbbdc7ab4ea1089c7363f1b1d2df333c1d8f
2017-08-15 21:33:01 +00:00
Charles He
b0fa5855dc [automerger] Fix security hole in GateKeeperResponse. am: e74cae8f7c am: b1141b6ff0 am: 1cd9e8096f am: 6dfc8d8d4d am: a3c1de7e49 am: 4acf4fabf4 am: 40317127f4 am: 159cd14334 am: 24587d57cf
am: 0fa9328b80

Change-Id: I4fc74296d3da5fef830e9ffe0eedc74bb4fb047b
2017-08-15 21:16:36 +00:00