Commit Graph

2595 Commits

Author SHA1 Message Date
John Reck
839fd4144e Merge "Eliminate gap between finalize() and destroy()" into jb-dev 2012-06-07 15:57:56 -07:00
John Reck
919c89e204 Stay in layer scroll if nothing to scroll
Bug: 6628376
 The issue here is that contentX & contentY can both be 0 if we are scrolling
 slowly enough as they are adjusted by the page's scale and can thus round down.
 However, this would result in us falling out of layer drag mode even though
 we haven't tried to scroll past the edge of the layer. Detect this case, and
 stay in layer scroll mode.

Change-Id: I3c655d0d03e8f89887abbe718bd24699c133ee1a
2012-06-07 14:45:34 -07:00
John Reck
d5e2937933 Eliminate gap between finalize() and destroy()
Bug: 6569073
 Only nativeDestroy and nativeStopGL need to be called on the UI thread,
 so split up destroyImpl into 3 functions, and only have the native
 destroy be pushed to the UI thread if necessary. Also make the work that
 is delayed be static without references to the finalizing WebView to allow
 it to be fully deleted immediately after finalization.

Change-Id: I4e424051e69df0bc409af95ca3f3d2b9e58a6b75
2012-06-07 13:14:57 -07:00
Chris Craik
37e0c3681e Merge "Revert "Add temporary functor detach logging"" into jb-dev 2012-06-06 16:59:01 -07:00
Chris Craik
aa3b7d88ef Revert "Add temporary functor detach logging"
bug:6608646

This reverts commit f98851ab37
2012-06-06 16:45:53 -07:00
Mangesh Ghiware
c7ad10201b Remove transient and unnecessary update density message.
On a page load, the (viewport) metadata settings for the main frame are
reset. Reloading a page with viewport meta tag specifying target density
dpi will result in 2 back to back update zoom density messages to be
sent from WebViewCore to UI thread.

In setupViewport(), remove update density messages in flight. If the new
density is indeed different from WebView's default scale, queue another
message.

Bug: 6509512
Change-Id: I195e40277bf1bcccb0e61d84ed84db1e34556243
2012-06-05 18:46:10 -07:00
John Reck
eba5e7ddfb Fix logspam
Bug: 6508832

Change-Id: I3061917ae7eba31723c006b1d30d20b7134890b8
2012-06-05 13:22:40 -07:00
Chris Craik
f98851ab37 Add temporary functor detach logging
bug:6596807
Change-Id: I22342079cdf238a933d62e9cbef58bc5af80522b
2012-06-04 13:42:33 -07:00
Ben Murdoch
078b591379 Get a WebViewDatabaseClassic instance lazily. Do not merge.
Rather than caching the WebViewDatabaseClassic instance in a member,
grab the instance when we need it.

In the case of WebSyncManager - neither it or it's subclass uses
the WebViewDatabaseClassic (and it's subclass is final) so remove
it's initialisation. We must leave the member declared however
to satisfy the published API.

Bug: 6482144
Change-Id: Ibf5186a2851d17f5ad62b35ad543aeadff5618d9
2012-06-01 14:07:20 +01:00
Chris Craik
41ee465734 Force webview invalidates on unsuccessful functor attach
Functor attach should always be successful, but adding a fallback just in
case. Also invalidates the WebView on initial content arriving.

bug:6511995
Change-Id: Ibca16505afec9f693ea4a7cc4966cd6d7353725c
2012-05-31 15:23:11 -07:00
George Mount
20c15a4271 Merge "Fix monkey NPE in AutoCompletePopup" into jb-dev 2012-05-30 07:36:11 -07:00
John Reck
2dc3ffd31a Don't long press if preventDefault is called
Bug: 6554060

Change-Id: Iad263c78a0e1504dd10e9ef5b92505bca6991cbc
2012-05-29 16:02:23 -07:00
George Mount
7a2cb35513 Fix monkey NPE in AutoCompletePopup
Bug 6554866

Change-Id: I2942e55d98bc768f5c5c563240c1841c7e869b3c
2012-05-29 15:39:50 -07:00
John Reck
7cbe645730 Merge "Copy over the scroll position for the scrolling layer" into jb-dev 2012-05-25 15:49:15 -07:00
John Reck
ec1b71adc6 Copy over the scroll position for the scrolling layer
Bug: 6557664

Change-Id: I9b1257ee0a4d75f5b445e9f72455d51e4add1c77
2012-05-25 14:02:26 -07:00
Teng-Hui Zhu
65e08329ee Merge "Better support for HTML5 audio loop." into jb-dev 2012-05-25 10:10:11 -07:00
John Reck
f738810247 Merge "Support skipping a touch stream due to lack of handlers" into jb-dev 2012-05-24 18:11:36 -07:00
John Reck
c1e80a360a Support skipping a touch stream due to lack of handlers
Bug: 6317798

Change-Id: Ia1652e9030e877e270326e9e8a8b040810b89f09
2012-05-24 15:31:13 -07:00
Teng-Hui Zhu
6f62ef32e2 Better support for HTML5 audio loop.
Loop is trigger by a seek to 0 when ended on native side but there is no play
call. So on java side, we detect this and call into native side to trigger a
play after completion.
This fixed the UI problem and keep in sync with the native mode.
Beyond that, we don't need to reload for looping and we don't have the seek
to play artifacts.

bug:5461143

webkit change:
https://android-git.corp.google.com/g/#/c/193750/

Change-Id: I779f3e1fbc789832a1a99d1f17823db6b57b35df
2012-05-24 15:24:29 -07:00
George Mount
222f561350 Merge "Use setCustomSelectActionModeCallback to disallow action bar." into jb-dev 2012-05-24 09:53:17 -07:00
George Mount
7e9f62ef48 Use setCustomSelectActionModeCallback to disallow action bar.
Bug 5993716
 Use setCustomSelectActionModeCallback rather than
 setLongClickListener to disallow custom action block so
 that long press can bring up the paste window.

Change-Id: I916e77dcea7914c02191f0ecda37cd126318807d
2012-05-24 07:43:27 -07:00
Ben Murdoch
2b5d66824b Make the WebCore thread watchdog opt in.
Add a setting on WebViewCore to control whether we monitor
the responsiveness of the WebCore thread. Default is not
to monitor.

Bug: 6447214
Change-Id: Ia95e5c769d458dcd24ae50660b2f22e93851956f
2012-05-24 13:01:57 +01:00
George Mount
c2813fa759 Show caret handle when clicking in the middle of text.
Bug 6545325

Change-Id: Ibea6daca1da12eec38b05f7f451561d31bb3c983
2012-05-23 14:04:54 -07:00
Chris Craik
3534e13486 Merge "Avoid crash if onDetachedFromWindow called after destroy" into jb-dev 2012-05-22 17:20:07 -07:00
Chris Craik
9e08012869 Avoid crash if onDetachedFromWindow called after destroy
This also removes the temporary logging from commit
f8dafa14e0.

bug:6535911
Change-Id: Icf1d0438b349a0e92e7d9cefed57a252eed2b9b0
2012-05-22 16:52:00 -07:00
Svetoslav Ganov
956f28edae Merge "Always reference injector using get method." into jb-dev 2012-05-22 15:32:19 -07:00
Chris Craik
7a9328a311 Merge "Add temporary functor lifetime logging" into jb-dev 2012-05-22 14:39:13 -07:00
Chris Craik
f8dafa14e0 Add temporary functor lifetime logging
bug:6535911

Change-Id: Ida5cc1def7fe1fc314317bbc5df50e1465753deb
2012-05-22 14:26:15 -07:00
alanv
500b91ebac Always reference injector using get method.
Bug: 6535301
Change-Id: If1d55c3229603d12c568213bd2f271c7cb6ab139
2012-05-22 14:22:48 -07:00
George Mount
12221d1540 DO NOT MERGE Consider current scroll position to move text field into view.
Bug 6530008

Change-Id: I6542dab70b64f809ec5dd4deb3511f8aa38278e1
2012-05-22 09:46:13 -07:00
George Mount
b999b22eca DO NOT MERGE Consider fixed layers when scrolling the edit box.
Bug 6147580
 Webkit Change: I810891decf0bad682e90f29f0f65c6b765b7d6d6

Change-Id: Idaa538824e611acd64eb5a4ccb7866d3c978a077
2012-05-22 09:40:23 -07:00
Michael Kolb
3fe0bca0c3 add flag to websearch intent
Bug: 6372537

Change-Id: Ia3f8577ffdde2df5234016dd8d9ca83265b53e5e
2012-05-21 09:40:17 -07:00
John Reck
88b756cd24 Merge "Don't show the touch highlight for double taps" into jb-dev 2012-05-17 20:03:17 -07:00
John Reck
aa5af8d004 Don't show the touch highlight for double taps
Bug: 6490959

Change-Id: I5a6cfa3d36f1df28d9c3b03e120f59581ee22c01
2012-05-17 19:57:08 -07:00
Charles Chen
c6015df128 Merge "Add actions to non-JavaScript accessibility handler." into jb-dev 2012-05-17 16:55:40 -07:00
Charles Chen
9a9a041cb7 Merge "Add movement actions to JS accessibility." into jb-dev 2012-05-17 16:55:20 -07:00
John Reck
3d6f7eadb2 Merge "Tweak show/hide of touch highlight" into jb-dev 2012-05-17 16:44:14 -07:00
George Mount
ea1603de2a Merge "Update the IME with selection and composing region changes." into jb-dev 2012-05-17 15:21:07 -07:00
George Mount
e41dfd9759 Sync the selection cursor when adjusting caret handle.
Bug 6512357

Change-Id: Ie8b0c6a17ea668b2c4ba9f3de404fdc0c2d319f8
2012-05-17 14:10:28 -07:00
John Reck
eb11f47353 Tweak show/hide of touch highlight
Bug: 6490959
 Fixes the issue where we will show the old tap highlight
 if webkit isn't quick enough to respond

Change-Id: Icd9864d276b6ad311e3f3dc4deaa7085e3769006
2012-05-17 13:47:39 -07:00
George Mount
cdd48a70df Update the IME with selection and composing region changes.
Bug 6507332
 The IME must be informed whenever the selection or composing
 region changes so that it can adjust its replacement regions
 and suggestions.

Change-Id: I484b112a2fede6528b0bc506711284b59bd886d1
2012-05-17 10:51:18 -07:00
Svetoslav Ganov
308904dcd0 Merge "Refactor WebView accessibility code into a separate class." into jb-dev 2012-05-17 10:32:27 -07:00
John Reck
76c0c612cd Merge "Don't send an ontouchmove until slop is exceeded" into jb-dev 2012-05-17 09:22:06 -07:00
George Mount
3c8140723f Merge "Only clear the caret when in caret selection mode." into jb-dev 2012-05-17 09:05:37 -07:00
George Mount
84c4b08bd4 Merge changes Ia5729aaf,I91584b7d into jb-dev
* changes:
  Remove selection highlight when replacing/deleting.
  Don't do character add/delete when there is a selection.
2012-05-17 09:05:30 -07:00
Ben Murdoch
74d37b9653 Fix up the WebCoreThreadWatchdog
Make the WebCoreWatchdog aware of the WebViews it is monitoring
(rather than the Activity context which may become stale) and
ensure that the code for the prompt dialog is run on the UI
thread.

Bug: 6420310
Change-Id: Ied003938edb04858c85bcc2491c4b2c4c0ede6eb
2012-05-17 12:38:07 +01:00
John Reck
94c478e9e5 Don't send an ontouchmove until slop is exceeded
Bug: 6490959

Change-Id: I0f447f65c84f9ce208ce52caba05e7dcb2f76bc5
2012-05-16 20:34:48 -07:00
alanv
6a62b77dfb Add actions to non-JavaScript accessibility handler.
Bug: 5932640
Change-Id: I302cfc6410d716ac46e1adb922de3079c4e4b4f3
2012-05-16 20:28:29 -07:00
alanv
448902d757 Add movement actions to JS accessibility.
Bug: 5932640
Change-Id: I80e210adbef266b1ec9bc1cad7eeacb70529bdba
2012-05-16 20:27:47 -07:00
alanv
525823a754 Refactor WebView accessibility code into a separate class.
Bug: 5932640
Change-Id: I52ab57f51c5904cbcf56307f17f406b2a30d6b91
2012-05-16 20:01:51 -07:00