Commit Graph

13161 Commits

Author SHA1 Message Date
Jackal Guo
73715ca6c3 Merge "Add new APIs to support RegionInScreen in A11yWindowInfo" 2019-07-17 06:43:45 +00:00
Jackal Guo
f382371d77 Add new APIs to support RegionInScreen in A11yWindowInfo
To support non-rectangular visible area for windows, add new APIs
about RegionInScreen in A11yWindowInfo to represent the actual
interact-able area of a window.

Bug: 132146558
Test: a11y CTS & unit tests
Change-Id: I86bb6bc8c567e09f01a3f853a3cffd896ce934c8
2019-07-17 10:57:09 +08:00
Adrian Roos
2dccd145d3 GestureNav: make reportSystemGestureExclusionChanged oneway
When the WindowManager lock is contended, reportSystemGestureExclusionChanged can cause
jank. Making it oneway avoids this.

Fixes: 137650591
Test: make droid
Change-Id: I5d96b7e2225745b146014ad11cafaf0ad9a1b734
2019-07-16 17:58:15 +00:00
Tarandeep Singh
eafd4dae94 Merge "Make MULTI_CLIEN_IME_ENABLED non-testable." 2019-07-16 17:48:51 +00:00
Issei Suzuki
6b5f5e97e8 Refined the logic to detect the location of DisplayCutout.
Bug: 117199965
Test: atest DisplayCutoutTest
Change-Id: I943922ff6e2866c783b88ce3b2c9bca494d688d7
2019-07-15 15:44:01 +02:00
Rhed Jao
882145e7e0 Improve A11yNodeInfo visibility for magnification
Returns visible if device enables magnification and node is visible
but outside of magnified area.

Bug: 79162853
Bug: 79531479
Test: atest AccessibilityMagnificationTest
Change-Id: I481bd5c3d73d01c0cd8b3e0ebd7a1584c9ae7064
2019-07-11 16:51:39 +08:00
Tarandeep Singh
db6c7815b7 Make MULTI_CLIEN_IME_ENABLED non-testable.
This mechanically reverts making MULTI_CLIEN_IME_ENABLED
testable originally introduced in [1].
CTS tests can check for FEATURE_INPUT_METHODS instead.
FEATURE_INPUT_METHODS is false for Android auto and true for
devices that support installable IMEs.

[1] Id7b4dceb2dbfaf3d7ed1084957dd14b04cad0cdf

Bug: 137203665
Test: Manually built and verified that it builds.
Change-Id: I6e430458dd05dec363f67b62416d424c395f2d5a
2019-07-10 13:28:38 -07:00
Tarandeep Singh
ff0d28905f Merge "Remove PER_PROFILE_IME_ENABLED property" 2019-07-10 18:06:39 +00:00
Tarandeep Singh
cf5ff82fca Remove PER_PROFILE_IME_ENABLED property
PER_PROFILE_IME_ENABLED is default enabled in Q. We no longer need this
property.

Bug: 135775619
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Change-Id: Ia957118fabc2dd794cb4f5018692b8548b85233a
2019-07-09 14:53:48 -07:00
TreeHugger Robot
dc8c71b1df Merge "TextClassifier cross-user vulnerability in direct-reply" 2019-07-09 17:55:04 +00:00
TreeHugger Robot
6a727cafa6 Merge "Fix missing version number in logs from webview" 2019-07-09 15:19:41 +00:00
Abodunrinwa Toki
e8492693c2 TextClassifier cross-user vulnerability in direct-reply
Sys UI runs on user 0. This can lead to the TextClassifier (TC)
running for the wrong user. Consequencies are user A can launch apps
in user B via the TC's predicted actions and selected text being
unintentionally shared from user A to an app running in user B.

This fix ensures that the correct user id is passed and verified for
every TC request going across process boundaries (i.e. via SystemTC).
- Sys UI sets the appropriate user id in the TextView
- TextClassificationManager (TCM) system service is constructed using
  a context generated from this user id
- SystemTC sets this user id before querying the TCMService
- TCMService validates the user id before forwarding the request to
  the TCService belonging to that user id.

Bug: 136483597
Test: atest android.view.textclassifier
      atest android.widget.TextViewActivityTest
      (manual) Verified according to steps in bug 123232892
Change-Id: I2fdffd8eb4221782cb1f34d2ddbe41dd3d36595c
2019-07-08 15:16:19 +01:00
Tony Mak
b393eeabde Fix missing version number in logs from webview
fromIndex is inclusive, so it should be startIndex +1.

This bug is fixed in our new logging APIs, but to those who
is still using the old pipeline, e.g: webview, will hit the issue.

Fixes: 136805228
Test: Enable verbose logging, try to select something in webview,
observe that the version number is logged.
Test: atest SmartSelectionEventTrackerTest

Change-Id: I7e8212d9be9684b9988634cf30043765dd8afe38
2019-07-05 17:06:14 +01:00
Issei Suzuki
4dd6a45d3c Merge "Support alpha value in SurfaceView." 2019-07-04 12:25:53 +00:00
TreeHugger Robot
693884a663 Merge "Add trackingBug to APIs used by chromium vebview." 2019-07-04 09:58:45 +00:00
Issei Suzuki
006b71f401 Support alpha value in SurfaceView.
For backward compatibility, SurfaceView ignores alpha value by
default. In order to reflect alpha value set on the SurfaceView
to its underlying surface, setUseAlpha() needs to be called.

Translucent alpha only works when the surface is placed z-above.
Otherwise only fully opaque and transparent status are supported.

Bug: 130442248
Test: Manual, use BubblesTest app and checks if alpha is set.
Change-Id: I86847de59109b2adf12a2c7c50c988c2cbcf0450
2019-07-04 09:49:23 +02:00
Qasid Sadiq
aabd50e0a4 Merge "Populate scrollX and scrollY on AccessibilityEvents." 2019-07-03 23:17:52 +00:00
Issei Suzuki
60557b5bf5 Clean up SurfaceView.
Bug: 136538998
Test: no-op refactoring CL. Existing unit tests still pass.
Change-Id: Idd6c5871ed34880a053f3a43ab4f7aa3a466b548
2019-07-03 20:04:48 +02:00
TreeHugger Robot
08c51ea668 Merge "Removed unused variable from ThreadedRenderer" 2019-07-03 16:56:03 +00:00
Mathew Inwood
5ca23f6a5a Add trackingBug to APIs used by chromium vebview.
Bug: 136637107
Test: m
Change-Id: I5b7612325d8b7e2578e71a75f60790039bc28eea
2019-07-03 12:20:45 +01:00
TreeHugger Robot
4b235cb04a Merge "Clean up SurfaceView" 2019-07-03 09:21:41 +00:00
Issei Suzuki
f78b5e2e44 Removed unused variable from ThreadedRenderer
Bug: 136616503
Test: refactoring, check if existing tests pass
Change-Id: I627832b2e8f964dbabbf95788279e437c4347adf
2019-07-03 10:23:37 +02:00
Issei Suzuki
f0412592db Clean up SurfaceView
Bug: 136538998
Test: no-op refactoring CL. Existing unit tests still pass.
Change-Id: Ibd0310a87ed38aa48215be9cba54f1c7a2a8a9fa
2019-07-02 12:33:13 +02:00
John Reck
5e56d3f12b Merge "Switch to import for CtsUiRenderingTestCases" 2019-07-01 15:59:33 +00:00
Issei Suzuki
9e6679b040 Merge "Extend ViewRootImpl to support multiple FrameDrawingCallback" 2019-07-01 12:47:06 +00:00
Peiyong Lin
472eac2a3c Merge "Attach color space information when attach and queue buffer." into qt-r1-dev am: 964fcdbebd
am: 7537aeeb9f

Change-Id: I245e704a1d794ddb56892a97c74bf11effe0c3a1
2019-06-28 15:41:25 -07:00
Peiyong Lin
7537aeeb9f Merge "Attach color space information when attach and queue buffer." into qt-r1-dev
am: 964fcdbebd

Change-Id: I37376be3cdf0a8c72111c6de257eda4274f406c2
2019-06-28 14:35:34 -07:00
Mathew Inwood
b2f6f30c19 Merge "Restore some greylist entries." into qt-dev am: f4535c8d51 am: cd82f9adff
am: 7a4d871174

Change-Id: If3c3de3ec24226ec6ea10603ca246487ac40bfb4
2019-06-28 13:42:26 -07:00
Mathew Inwood
7a4d871174 Merge "Restore some greylist entries." into qt-dev am: f4535c8d51
am: cd82f9adff

Change-Id: Iff29bca8243e0c5e0e7ec30cd8b4a3f95c43ac82
2019-06-28 13:30:26 -07:00
Mathew Inwood
cd82f9adff Merge "Restore some greylist entries." into qt-dev
am: f4535c8d51

Change-Id: I3851fed60bedab9748f2d6d53f342f2605ecf78b
2019-06-28 13:18:30 -07:00
Issei Suzuki
935935660c Extend ViewRootImpl to support multiple FrameDrawingCallback
Bug: 136150954
Test: WIP
Change-Id: I690005fece924c38a5269cb35309061d0ccb6f1e
2019-06-28 15:48:17 +02:00
Mathew Inwood
a5531fa161 Restore some greylist entries.
In Q, these APIs were either:
- removed from the greylist entirely without good reason
- Moved to the restricted greylist without any public alternative
  information added

So they are being moved back to the greylist for Q.

Test: Treehugger
Bug: 136102585
Change-Id: Ie3dd15c8e17d530d853473a013717e6175383080
2019-06-28 09:23:06 +00:00
Rob Carr
1e32e5f4a1 Merge "Enable views to be placed in windowless surfaces." 2019-06-27 19:43:31 +00:00
Felix
2b1c378f0c Merge "PhoneWindowManager/KeyEvent: Camera key as WakeKey" am: dec76b8a40 am: 1841f6af1d am: de67a21c84
am: 727d193d5d

Change-Id: I418a5275d5ff6148eb5405589a1f89d3d2fa3f4e
2019-06-27 10:34:25 -07:00
John Reck
db7d1df4fc Switch to import for CtsUiRenderingTestCases
Centralizes option management

Test: this
Change-Id: I80bcaec765e1ed2bf0bdbe370548157690367ec6
2019-06-27 10:32:27 -07:00
Peiyong Lin
964fcdbebd Merge "Attach color space information when attach and queue buffer." into qt-r1-dev 2019-06-27 16:14:02 +00:00
Robert Carr
9d431e1cc8 Enable views to be placed in windowless surfaces.
For purposes of parcelling SurfaceControl to embed view hierarchies across
processes. We also want these Surfaces to receive input, but we can't
let the clients call setInputWindowInfo directly (or we could have issues
with clients stealing focus, etc...) and so we provide a method
blessInputSurface which has the WM configure a surface for input with
a minimal and safe set of parameters.

Test: WindowlessWmTests
Bug: 111373437
Bug: 134365580
Change-Id: I45fde62ba9b810e783d62c4dd5442abd038734d5
2019-06-27 15:14:45 +01:00
Winson Chung
6ff63bdf73 Merge "Catch all exceptions in onFrameDraw" into qt-dev am: cff24b878d am: abe1a94072
am: 056fd40726

Change-Id: Icd452fb2132ffd98fe65ee5951f727e41a37f40b
2019-06-26 18:35:14 -07:00
Peiyong Lin
ccc06b6f51 Attach color space information when attach and queue buffer.
Currently when calling attachAndQueueBuffer, the color space information is
lost. This results in color shift if the color space doesn't match the color
space of the surface.

BUG: b/135002842, b/131928312
Test: boot. Manually verified on P19
Change-Id: I95ec73c24942f79197d25ee85f139b2aaf805677
2019-06-26 11:40:08 -07:00
TreeHugger Robot
ee57765372 Merge changes from topic "sc_handles"
* changes:
  Remove SurfaceControl#getHandle from JAVA apis 2/2
  Remove SurfaceControl#getHandle from JAVA apis 1/2
2019-06-26 17:56:32 +00:00
Felix
727d193d5d Merge "PhoneWindowManager/KeyEvent: Camera key as WakeKey" am: dec76b8a40 am: 1841f6af1d
am: de67a21c84

Change-Id: I6c8450688f79394195e493877156e67330d022ff
2019-06-26 00:35:26 -07:00
Felix
de67a21c84 Merge "PhoneWindowManager/KeyEvent: Camera key as WakeKey" am: dec76b8a40
am: 1841f6af1d

Change-Id: I6771fdd3408461fb8343006a05d15c260d0fb256
2019-06-26 00:27:32 -07:00
Vishnu Nair
bc9beab8fe Remove SurfaceControl#getHandle from JAVA apis 2/2
Holding on to a reference of the handle in Java will keep the server-side surface alive until
the reference is removed by GC. This may cause surfaces to be kept alive longer than necessary.
Instead hold on the surface control and call SurfaceControl#release which will release the local
reference to the server-side surface.

Bug: 136004147
Test: go/wm-smoke

Change-Id: Iff7d48ae1593cea2e188aa07c417f4c5a98887d5
2019-06-25 17:33:44 -07:00
Vishnu Nair
4bcd152a3a Remove SurfaceControl#getHandle from JAVA apis 1/2
Holding on to a reference of the handle in Java will keep the server-side surface alive until
the reference is removed by GC. This may cause surfaces to be kept alive longer than necessary.
Instead hold on the surface control and call SurfaceControl#release which will release the local
reference to the server-side surface.

Bug: 136004147
Test: go/wm-smoke
Test: gesture nav sanity tests
Test: atest CompositionSamplingListenerTest

Change-Id: Iab33680746c8f48c28783e6a2a13c9ac7ae04980
2019-06-25 17:31:11 -07:00
chaviw
9f6171e7b2 Deleted SurfaceControl.remove method
Updated all callers of SC.remove to use Transaction.remove(sc) and apply
immediately since that's the equivalent. Eventually, the transactions
that contain remove could combine with other transactions if it makes
sense to avoid duplicate applies.

Test: SurfaceControlTest
Change-Id: I13c6ec86de6a6d60f142c2269337557510dd006d
2019-06-25 17:09:03 -07:00
Winson Chung
056fd40726 Merge "Catch all exceptions in onFrameDraw" into qt-dev am: cff24b878d
am: abe1a94072

Change-Id: I74089f0cf71ca2c3dc917001eb14dca8586396e0
2019-06-25 16:06:36 -07:00
Winson Chung
abe1a94072 Merge "Catch all exceptions in onFrameDraw" into qt-dev
am: cff24b878d

Change-Id: If3aef1ccbba89a4b0964749ee3184a83f88185be
2019-06-25 15:43:48 -07:00
Winson Chung
26ccc92307 Merge "Catch all exceptions in onFrameDraw" into qt-dev
am: cff24b878d

Change-Id: I485cc8af4e6180adebb31235b43191e467b393bc
2019-06-25 15:36:26 -07:00
Winson Chung
cff24b878d Merge "Catch all exceptions in onFrameDraw" into qt-dev 2019-06-25 22:07:44 +00:00
Jorim Jaggi
b0bb2f778f Catch all exceptions in onFrameDraw
... as throwing an exception in there somehow will mess up the
hwui task queue.

Test: Have a crashy app, swipe up while the app is crashing
Fixes: 134583193
Change-Id: Ie3ba5f991759f807b154f55f9fc816e7efe2fdfe
2019-06-25 15:37:53 +02:00