Commit Graph

18541 Commits

Author SHA1 Message Date
Wu Ahan
009099e89d Merge "Instrument jank of CUJ take screen shot" into tm-dev 2022-05-11 06:35:13 +00:00
Tom Hsu
a3352d9664 Merge "[Panlingual][frameworks] Fix when tap search bar, will leave a big blank." into tm-dev 2022-05-11 05:51:00 +00:00
Song Hu
6c90bbe1cf Merge "ChooserActivity populates intentFilter mimeType with intent.getType() prior to intent.getDataString(). This fixes the issue in screenshot sharing that no or much less than usual direct share recommendations surface." into tm-dev 2022-05-10 15:23:31 +00:00
Shawn Lin
3ab2eccace Merge "Add multi-user support for kids mode" into tm-dev 2022-05-10 12:30:16 +00:00
tom hsu
75ed59fac9 [Panlingual][frameworks] Fix when tap search bar, will leave a big blank.
- Close blank layout after title disappear when search bar is expanded.

Bug: b/227287277
Test: local, see b/227287277#6
Change-Id: I6b5f6990cacf6da9e17b743519ae554af32f691d
2022-05-10 08:30:38 +00:00
Shawn Lin
2b9e4b6550 Add multi-user support for kids mode
Listener to ACTION_USER_SWITCH intent and update the settings key when
user switched.

Bug: 231575466
Test: 1. set different settings keys for different user.
      2. switch between users and see if the setting value is correct.
Change-Id: Ia1afcb6121b296b293bef0ba7d0a0be25b857554
2022-05-10 03:03:56 +00:00
Chaohui Wang
4f4e8dd340 Merge "Add validation TOO_SHORT_WHEN_ALL_NUMERIC" into tm-dev 2022-05-10 02:44:48 +00:00
Joanne Chung
070275dcae Merge "[DO NOT MERGE] Remove selection toolbar code from build time" into tm-dev 2022-05-10 00:59:33 +00:00
Alex Buynytskyy
4220511d7e Merge "Forcefully convert to basic Intent before calling PM API." into tm-dev 2022-05-09 21:44:00 +00:00
Dmitri Plotnikov
f19925afc9 Merge "Fix recording of battery history tags" into tm-dev 2022-05-09 17:56:17 +00:00
Raphael Kim
75577e9421 Merge "Remove package title from notification access confirmation intent" into tm-dev 2022-05-09 17:55:07 +00:00
Alex Buynytskyy
7e0ab65145 Forcefully convert to basic Intent before calling PM API.
AIDL can't accept subclasses, see more info in the bug

Bug: 223022163
Fixes: 223022163
Test: launch WSJ, click on share
Change-Id: I0015fda3a6fb741b109f7d3d00df1da6f7d64863
2022-05-09 09:17:23 -07:00
Tiger Huang
b8ab50b68b Merge "Don't clip background drawable if navigation color view is not opaque" into tm-dev 2022-05-09 12:47:17 +00:00
Rubin Xu
9c9916e4d9 Merge "Protect UnlaunchableAppActivity against overlay attack" into tm-dev 2022-05-09 11:41:02 +00:00
Song Hu
fbdcff39cd ChooserActivity populates intentFilter mimeType with intent.getType() prior to intent.getDataString(). This fixes the issue in screenshot sharing that no or much less than usual direct share recommendations surface.
Test: atest
Test: test on phone
Bug: 229607293
Change-Id: I8d610e4c7033b25eea8a98885339207a723716b6
2022-05-07 22:22:27 +00:00
Dmitri Plotnikov
44cb0c4e31 Fix recording of battery history tags
Bug: 230552845
Test: atest FrameworksCoreTests:BatteryStatsTests

Change-Id: I018cf3f85e8ef11167e780653863b234822be27a
2022-05-06 17:08:18 -07:00
Song Hu
42bf145179 Merge "ChooserActivity reports whether the selected target is pinned in Westworld logging" into tm-dev 2022-05-06 20:36:02 +00:00
Shan Huang
e3a61826eb Merge "Migrate IME to handle back with OnBackInvokedDispatcher." into tm-dev 2022-05-06 19:35:42 +00:00
TreeHugger Robot
ad237705da Merge "Fix logging crash in ResolverRankerService model" into tm-dev 2022-05-06 15:48:55 +00:00
Tiger Huang
64afcdaf53 Don't clip background drawable if navigation color view is not opaque
If the navigation bar color view is not opaque, we shouldn't clip the
background drawable. Otherwise, the view hierarchy cannot fill surface
buffer, and the un-filled area would display things previously drawn on
it, which is not expected.

Fix: 204834350
Test: Open a doc in Docs in split-screen, and scroll down to the end.
Change-Id: I050f3fa301412b71a7ae15d60fb49853c4be161e
2022-05-06 22:19:15 +08:00
Jacqueline Bronger
b6de832709 Merge "Add more information to the TV PiP notification" into tm-dev 2022-05-06 10:39:27 +00:00
Rubin Xu
61a660519e Protect UnlaunchableAppActivity against overlay attack
Bug: 181785557
Test: manual
Change-Id: If496bbb195b3f33cece6a93e683e9186d6175687
2022-05-06 10:57:57 +01:00
Song Hu
470f8434b1 ChooserActivity reports whether the selected target is pinned in Westworld logging
Test: atest
Bug: 210453009
Change-Id: Id67f5356f90e5ee1f10f782e2389582807b9be1e
2022-05-05 12:05:36 -07:00
Joshua Trask
9a43192cef Fix logging crash in ResolverRankerService model
This was a regression introduced in ag/17913997 because
I missed that the legacy code included the ternary
`? 0 : 1` to convert from boolean to int value in this
(not-type-safe, see b/231577676) API call.

Bug: 231491021
Bug: 231577676

Test: compile/presubmit. This doesn't prove that the fix
works (we must just not have coverage, or we would've
caught the regression the first time) but it does validate
the syntax and confirm that there are no other unintended
changes (stray keystrokes...). The fix is trivial; this CL
simply restores the exact behavior pre- ag/17913997.

Change-Id: I706dee50e074da3ca40cde5b83abfd076a271959
2022-05-05 15:12:38 +00:00
Joanne Chung
ade911b9c7 [DO NOT MERGE] Remove selection toolbar code from build time
The feature punts to QPR so disable or remove code from the build
time.

Bug: 222185402
Test: build pass and can boot to home
Test: make sure the toolbar using local implementation

Change-Id: Idad82c3c46ddce0731a26f4599de01eecb0e52c3
2022-05-05 18:09:42 +08:00
Raphael Kim
735bcf8cf7 Remove package title from notification access confirmation intent
Bug: 228178437
Test: Manually confirmed on an application
Change-Id: Idad6dc0c71d7b39de0bd9e4ad922b5e6020a6184
2022-05-04 19:41:25 +00:00
Mady Mellor
e8ee9cd8d4 Merge changes Ieb77b211,Iad01b8f3,Ib9653ed3 into tm-dev
* changes:
  If something is suppressed from the notification list don't bubble it
  Tell NoMan to update the auto-expand flag
  Allow SysUI to update BubbleMetadata#FLAG_AUTO_EXPAND_BUBBLE
2022-05-04 18:00:21 +00:00
Matt Casey
1ffed5d942 Merge "Halve listview update delay" into tm-dev 2022-05-04 17:47:53 +00:00
Galia Peycheva
f372925a29 Merge "Fix missing position updates to blur regions" into tm-dev 2022-05-04 16:09:27 +00:00
Chaohui Wang
fabf6dcd44 Add validation TOO_SHORT_WHEN_ALL_NUMERIC
To distinguish the requirement between all numeric and not all numeric
when COMPLEXITY_HIGH.

Note:
The second param of applyComplexity() changed back from
withNonNumericCharacters to isPin.
This was changed from isPin to withNonNumericCharacters in Change
I3227d4d8e6825b5c4ea525828d7e09f52702065b without changing the caller.
This currently not causing any issues because applyComplexity() only
used by KeyguardManager.getMinLockLength(), which currently never be
called with COMPLEXITY_HIGH.

Fix: 227149118
Fix: 173167839
Test: manual & robolectric
Change-Id: I7e0d4a1edf42327452b7d9a564258b26865c056e
2022-05-05 00:09:25 +08:00
Jacqueline Bronger
c096f52c55 Add more information to the TV PiP notification
Includes general information as well as the system and app actions (or
media actions if there are no app actions)

Bug: 204173025
Bug: 199490119
Test: manual - check notification content from aosp notification listener

Change-Id: I6a15e443ad8f1fa17bd76e52c002909faa1c44db
2022-05-04 15:08:51 +02:00
Galia Peycheva
38cf61f704 Fix missing position updates to blur regions
The PositionUpdateListener sometimes gets called after the
FrameDrawingCallback, because there is no ordering guarantee between
these two callbacks. This causes the BlurRegions sent to SF to
not have up-to-date positions. For example, an empty Rect gets sent
as the blur region bounds, because the position update hasn't arrived
when the surface transaction is sent. When the position update arrives
it set the correct bounds, but it requires another draw to happen so
that the correct position is picked up.

This CL fixes this issue by saving the blur regions that were last sent
to SF in FrameDrawingCallback and sending another transaction when the
position update arrives. That transaction is merged into the previous
one for the same frame, so the final transaction sent to SF has correct
values.

The CL also moves the FrameDrawingCallback registering logic entirely in
the BlurAggregator in the first onPreDraw. This cleans up VRI

Bug: 197239228
Test: atest --iterations 100 BlurTest#testBackgroundblurSimple
Test: atest BlurAggregatorTest
Change-Id: Ia122df40fdf2aa124299461c2e2597b61fa92699
2022-05-04 08:36:04 +00:00
Ahan Wu
9a083dde2c Instrument jank of CUJ take screen shot
Bug: 226526041
Test: see the reference trace in the bug
Change-Id: Ia25f0ebb965ada1006a00b68bfee90106f2a9573
2022-05-04 08:28:50 +00:00
Shan Huang
a6666f2221 Migrate IME to handle back with OnBackInvokedDispatcher.
We currently close the IME by having the target application forward KEYCODE_BACK to the IME process through InputMethodManager#dispatchInputEvent and having the IME handle the keycode in InputMethodService#onKeyDown. When apps opt in to OnBackInvokedDispatcher API, we will not dispatch KEYCODE_BACK to apps anymore. Thus we need to migrate IME to the new API for it to close on back invocation.

This implementation forwards OnBackInvokedCallbacks from the IME process
to the app process. This is necessary because all callbacks need to
exist in the app process for them to be considered by hardware back keys. While back gestures go through WM to resolve callbacks from the focused window, hw keys are directly sent to the focused window's ViewRootImpl, bypassing server side back nav logic.

Bug: 228358882
Test: atest CtsInputMethodTestCases:KeyboardVisibilityControlTest
Test: atest CtsInputMethodTestCases:InputMethodServiceTest
Test: atest CtsInputMethodTestCases
Change-Id: Ie207b63b11a56c9b2173f26b734a27b13ebccc60
2022-05-04 05:31:08 +00:00
Chaohui Wang
6474aed2f5 Merge "Add SETTINGS_SLIDER CUJ to InteractionJankMonitor" into tm-dev 2022-05-04 02:23:14 +00:00
Matt Casey
ea3e5046a7 Halve listview update delay
Will do further reductions later with a slower rollout.

Bug: 224816815
Test: atest ChooserActivityTest
Change-Id: I9c00137d73febca8f8576e579e55157aa1bd05fe
2022-05-03 20:54:27 +00:00
Dmitri Plotnikov
ae7b2277b9 Address proportional counting for out-of-order timestamps
Bug: 229906525
Test: atest FrameworksCoreTests:BatteryStatsTests

Change-Id: Id5fb963e256d56b42c9b5a0bc686af83ca3c7835
2022-05-03 19:04:44 +00:00
Matt Casey
5e35dcd369 Merge "Convert Personal/Work tabs to rounded bubbles" into tm-dev 2022-05-02 21:05:36 +00:00
Matt Casey
ec9b0f949e Merge "Empty state UI tweaks" into tm-dev 2022-04-30 18:32:43 +00:00
Chaohui Wang
68ed78c06a Add SETTINGS_SLIDER CUJ to InteractionJankMonitor
Also add a default onStopTrackingTouch() method in the
SeekBarVolumizer.Callback to let Settings inject the jank monitor.

Bug: 230285829
Test: make build
Change-Id: I9f5f511183f62caf809d7326766549b87d226b0b
2022-04-30 12:58:02 +08:00
Taran Singh
d5bb81348c Merge "Fix InputConnection creation callback" into tm-dev 2022-04-29 18:58:36 +00:00
Matt Casey
b82f35f21b Convert Personal/Work tabs to rounded bubbles
Modernize the tabs in Sharesheet/Resolver to match All Apps.

Much of this is copied from the tabs implementation in All Apps.

Remove divider line below tabs (no longer needed).

More XML, less code.

Bug: 188589041

Test: Manual in light and dark themes
Test: atest ResolverActivityTest
Test: atest ChooserActivityTest
Change-Id: Ib23a1927d416d32714dd8c890dd412c73f9e573c
2022-04-29 18:16:42 +00:00
Mady Mellor
40422db463 Allow SysUI to update BubbleMetadata#FLAG_AUTO_EXPAND_BUBBLE
This flag should only really be applied to a notification bubble
one time. Once the bubble has auto-expanded (or if it was posted and
unable to auto-expand at that time due to something like DND), the
flag should be removed so we don't auto-expand it again.

We have a method that allows us to modify some specific flags on
BubbleMetadata. This CL updates that method to be more general and
work with any of the BubbleMetadata flags.

Bug: 226316876
Test: atest NotificationManagerServiceTest
Change-Id: Ib9653ed304f13ac88f489146d503f4de4fa29421
2022-04-29 17:25:30 +00:00
Calvin Pan
f71832b46b Merge "Fix empty resource showing "Und"" into tm-dev 2022-04-29 03:55:52 +00:00
Taran Singh
fc6d5e91b7 Fix InputConnection creation callback
As noted in the linked bug, in certain scenarios IC established callback
is not always called. As a fix, we make sure we don't return early when
MSG_BIND callback is received from IME

Fix: 228105257
Bug: 217971553

Test: atest StylusHandwritingTest#testHandwritingEndToEnd

Change-Id: I780327003f7145c4f9b9df4dc5243227d7e67d92
2022-04-28 15:26:00 +00:00
Tom Hsu
12873579dc Merge "[Panlingual] Change Checkbox color and remove divider of listview" into tm-dev 2022-04-28 12:24:02 +00:00
Mark Renouf
82c77bb127 Merge "Restores a capture rate limit for long screenshots" into tm-dev 2022-04-28 11:46:50 +00:00
Calvin Pan
8d8d93bf6d Fix empty resource showing "Und"
Bug: 230689140
Test: manual
Change-Id: Ib732773758bb8344f04033be11f235456434bd29
2022-04-28 07:58:49 +00:00
TreeHugger Robot
6298c68c71 Merge "Make cuj be synchrous among atoms.proto and InteractionJankMonitor" into tm-dev 2022-04-28 05:47:54 +00:00
Calvin Pan
ba95ddf69d Merge "Adding state description for current locale item" into tm-dev 2022-04-28 02:42:29 +00:00