Commit Graph

1983 Commits

Author SHA1 Message Date
Romain Guy
04ee7956ea Merge "Add the ability to enable/disable marquee fading per device" 2011-08-02 17:03:22 -07:00
Dianne Hackborn
5857bceaea Merge "Clear the bitmap from the canvas in a lot of places." 2011-08-02 16:57:50 -07:00
Dianne Hackborn
6311d0a079 Clear the bitmap from the canvas in a lot of places.
Change-Id: I6b2071ac7b348c473b9bdd1b972d095aebbb4fb3
2011-08-02 16:37:58 -07:00
Romain Guy
6805545649 Add the ability to enable/disable marquee fading per device
Change-Id: I4211553455e87f0af598a2fac1d4f65f15c294fc
2011-08-02 16:33:02 -07:00
Philip Milne
e10bcdb37c Merge "Fix for http://b/issue?id=5081478" 2011-08-02 16:22:26 -07:00
Philip Milne
899d592287 Fix for http://b/issue?id=5081478
GridLayout needs to call measure on children after it knows how large children should be

Also:

. Remove deprecated methods and XML attributes.
. Stop Spaces having margins by default.
. Remove getSpacers() and findUsed()
. Change default for row/columnOrderPreserved() from false to true.
. Improve automatic index allocation mechanism to use individual maxima.

Change-Id: Id79fbb2e70a0bf2002191ec2a9746547d896de72
2011-08-02 16:01:28 -07:00
Bjorn Bringert
dbe55b722c Merge "Fix exception when a focused item is detached." 2011-08-01 13:39:30 -07:00
Mark Brophy
1ea6889136 Fix exception when a focused item is detached.
When a ListView has itemsCanFocus set, and scrolling moves the currently
focused item off the display, its focus is cleared. This is checked by
calling getDistanceToView().

However, it's possible that the view will have been recycled.  If so, it
will have been detached from the parent by calling
ViewGroup.detachViewFromParent.  Since this doesn't clear the view's
focus, we'll still try to call getDistanceFromView(), causing an
IllegalArgumentException since the view is not a descendant of the
ListView anymore.

Check whether the view is still a descendant before calling
getDistanceToView(). If it's not, we also need to clear the focus.

Bug: 4556022
Change-Id: Iebee56032223b70d714e2ec3bb7a19093ab5f81c
2011-08-01 16:32:03 +01:00
Luca Zanolin
e3f89c08f2 Sort the suggestions based based on the length of the text they are attached too.
When the suggestions are displayed, the shortest one will be at the top of the list, as they are the most relevant one.

Bug: 5006130

Change-Id: Id3ac3accce5198a6a58a0c3028ee5f77957ceac6
2011-08-01 09:57:25 +01:00
Svetoslav Ganov
0ef92056b7 Merge "Improving accessibility feedback for two state widgets." 2011-07-29 14:06:44 -07:00
Gilles Debunne
9ba79560bf Merge "New interaction model for suggestions" 2011-07-29 11:47:12 -07:00
Amith Yamasani
44df62c441 Merge "Don't submit a query if it's whitespace only." 2011-07-29 11:28:37 -07:00
Svetoslav Ganov
7650259a59 Improving accessibility feedback for two state widgets.
1. Added population of sensible text for the state of the
   two state controls such as CheckBox, Switch, etc. This
   is important since if they are in a layout manager which
   fires an accessibility event there should be a description
   of the widget.

bug:5092552

Change-Id: Ie3ca955653563496b84db379ae23a23fe88089a8
2011-07-29 10:45:05 -07:00
Adam Cohen
c9c4c2dad6 Merge "Fixing widget notifyDataSetChanged() not getting called, issue 5092676" 2011-07-28 15:36:19 -07:00
Adam Cohen
2148d43eb2 Fixing widget notifyDataSetChanged() not getting called, issue 5092676
Change-Id: I61a034a77c0c9d07aba71bfabe7a0864ce92c2e9
2011-07-28 15:00:38 -07:00
Gilles Debunne
646f856ec8 New interaction model for suggestions
Double tap and long press both start a text selection mode. The previous 'Paste'
popup window associated with insertion handle is now also used in selection mode.
It offers a new 'Replace' option that will popup the suggestion list.

The HC paste/side/nopaste layout are no longer used. For the new action popup
window, I also chose not to make the new background / text appearance styles
themable in order to avoid the same problem in case this design evolves again.

Known problems:
the popup is not moved when the TextView is scrolled.
the final visual style may change
the "ADD TO DICT" option is missing from the suggestion list
no interaction with the spell checker
- There are different bugs open for each of these

Change-Id: I167841f5ac017227fe4efa616eb935247250871a
2011-07-28 13:59:31 -07:00
Adam Powell
ccdd4ee44f Fix bug 5087980 - MenuItem#expandActionView should work from within
onCreateOptionsMenu

Initialize menu presenters early enough to respond to expanding an
action view within onCreateOptionsMenu.

Have SearchView show the IME as an async post to handle attempts to
show it while the UI is still in initial setup.

Change-Id: I77f3a94ed4397737edb5a7a15bf54993b6723f5e
2011-07-27 21:08:28 -07:00
Scott Main
812634c236 cherrypick Change-Id: I213711f4b5d867ba91c961a2f098b6cc415cfcb3
docs: clarify framelayout class summary, issue 5055437

Conflicts:

	core/java/android/view/View.java
	core/java/android/widget/FrameLayout.java

Change-Id: Ia446d2d4cc798757d7aea104cfaf75fc2315dc50
2011-07-27 13:22:35 -07:00
Amith Yamasani
6a7421ba94 Don't submit a query if it's whitespace only.
Just to maintain backward compatibility. It's not documented that a space
is not a valid query, but it does make sense to expect that.
Bug: 5079755

Also avoid showing an x by an empty query, by having the SearchDialog simulate an ActionBar.

Change-Id: I3a9332286a439b659e179a249587c491ef29e5c1
2011-07-27 11:55:53 -07:00
Amith Yamasani
84935dc2c0 Merge "Make sure that suggestions are queried on focus or tapping." 2011-07-27 10:54:15 -07:00
Amith Yamasani
377fe39329 Merge "Handle callbacks to CollapsibleActionViews that are in an actionLayout." 2011-07-27 10:53:25 -07:00
Gilles Debunne
a94b9ad23a Merge "Bug 4987014: a tap outside dismisses the text suggestion popup" 2011-07-27 09:31:02 -07:00
Svetoslav Ganov
05f0e1edb1 Merge "Updated the layout for the activity chooser view." 2011-07-26 20:09:44 -07:00
Adam Powell
523a1289af Merge "Fix bug 5051894 - drags/flings at the beginning/end of ListViews are often dropped" 2011-07-26 19:59:42 -07:00
Adam Powell
044a46bda5 Fix bug 5051894 - drags/flings at the beginning/end of ListViews are
often dropped

Fix some weirdness in transitioning between overscroll states.

Change-Id: Ie0c2ba75cc60c340e654df58dee675ed1426edb9
2011-07-26 18:41:53 -07:00
Svetoslav Ganov
bfbbcf5677 Updated the layout for the activity chooser view.
1. Updated the laoout to size the buttons properly.

Change-Id: I58f9beeca23af8b0471cf7f7ae9ca717223221aa
2011-07-26 18:36:56 -07:00
Amith Yamasani
10da590839 Handle callbacks to CollapsibleActionViews that are in an actionLayout.
Also, the onActionViewCollapsed needs to be called before detaching
the action view, so that the action view can dismiss the keyboard properly.

Fixes the Gmail search case where the keyboard doesn't disappear on hitting
the "up" affordance after a search.

Change-Id: I3c2f3f90f0edf6473404e6ceae3fa08866cad736
2011-07-26 18:15:08 -07:00
Amith Yamasani
f28d187574 Make sure that suggestions are queried on focus or tapping.
Bug: 3110831
Change-Id: Ic74a7eac1c5aa7d07c8a2e3f1ad19e026c990153
2011-07-26 12:21:03 -07:00
Gilles Debunne
2888524e03 Bug 4987014: a tap outside dismisses the text suggestion popup
Change-Id: I61f5a3c981770393aa861c88d989c653ea00a067
2011-07-25 18:59:06 -07:00
Adam Cohen
84e35d995f Merge "Fixing old bug with AdapterViewFlipper" 2011-07-25 13:54:02 -07:00
Philip Milne
496aa6d4d9 Merge "Fix for http://b/issue?id=5064532" 2011-07-25 13:43:09 -07:00
Philip Milne
5125e21bc0 Fix for http://b/issue?id=5064532
5064532: GridLayout with initial "stretchy" row and "gone" view in last row doesn't stretch properly

Also:

. Infer stretchibility from whether or not gravity is defined.
. Make algorithms for handling flexibility within cell groups consistent
  with those acting between cells groups (via constraint system).
. Hide and deprecate methods taking flexibility argument.
. Hide and deprecate CAN_STRETCH constant.

Both deprecated features will be removed after references are removed from platform.

Change-Id: Iabf2bf19f35cf30b8ec49c99b49a0550fd495125
2011-07-25 12:12:10 -07:00
Amith Yamasani
c018496ab2 Merge "Implement CollapsibleActionView on SearchView." 2011-07-25 12:07:32 -07:00
Svetoslav Ganov
0d1d962720 Merge "Switch state text not added to accessibility events." 2011-07-25 11:23:56 -07:00
Svetoslav Ganov
63bce03cc6 Switch state text not added to accessibility events.
1. Adding the text to the events now.

bug:5071053

Change-Id: If36afb1f5327720fc002b8c49e5d7b00c5f189f7
2011-07-23 19:52:22 -07:00
Adam Powell
0bd1d0a152 Fix bug 5060033 - No text-editing toolbar when in a dialog
Fix a bug that caused standalone action mode bars to not appear
properly or account for system insets such as the status bar.

Add public API to View to toggle the fitsSystemWindows attribute.

Change-Id: I5d7669425b930c5d23f9df26a45f544b706e8242
2011-07-22 19:39:00 -07:00
Adam Cohen
4725660292 Fixing old bug with AdapterViewFlipper
Change-Id: I3eda7f2451aaf8c75dd38d6d68fdcc04c03d2ee6
2011-07-22 16:28:21 -07:00
Amith Yamasani
763bc07652 Implement CollapsibleActionView on SearchView.
Automatically handle expanding and collapsing in an ActionBar using
the new callback for Collapsible ActionViews.

Also clear the query text when collapsing.
Make sure that the 'x' doesn't show when in expanded mode with no text.

Change-Id: I7cba009c7cc9a1c264ec11c76315353cbde55c6c
2011-07-22 14:14:59 -07:00
Adam Powell
fc302cdeed Fix bug 5037537 - Revert "ListView focus bugfix."
This reverts commit a86127fe26.
2011-07-21 18:43:12 -07:00
Fabrice Di Meglio
b72dedfa5e Merge "Fix CheckTextView padding" 2011-07-21 16:12:43 -07:00
Fabrice Di Meglio
aff599b4ab Fix CheckTextView padding
- fix for bug #5051724 and bug #5051674
- override resolvePadding for doing correct padding resolution

Change-Id: Id8c7bf4afa24ff2169fd1bd7f5024a342279aab2
2011-07-21 15:24:09 -07:00
Gilles Debunne
d2bea20965 Merge "Bug 4534376: Suggestion popup is not clipped." 2011-07-21 13:33:13 -07:00
Svetoslav Ganov
6179ea3196 Adding accessibility support to the Status Bar.
1. Added content description to pretty much all animals
   in the zoo including buttons in the navigation bar,
   notifications and status icons for battery, signal,
   data, etc.

2. Rectored to avoid ovelaying views since they block
   touch exploratino. In general overlaying views
   cause trouble for touch exploration and accessibility
   in general.

3. Avoid sending accessibility events in case the user is
   touching outside of the StatauBAr panels to avoid
   confusion.

4. Added records to accessibility events in the places where
   this would help the presentation. So the event comes from
   a given "leaf" view and its predecessor is adding a record
   to the event for itself to provide more cotext. It is up
   to the accessiiblity service to choose how to present that.

bug:4686943

Change-Id: I1c1bd123d828fb10911bca92130e9a05c1f020b3
2011-07-21 12:04:54 -07:00
Svetoslav Ganov
d578be2784 Merge "Activity selections not always persisted by AcitivtyChooserView." 2011-07-21 11:48:57 -07:00
Svetoslav Ganov
8dbace2dc9 Activity selections not always persisted by AcitivtyChooserView.
1. ActivityChooserModel was delegating the rsponsibility for reading
   and persisting data to its clients i.e. ActivityChooserView and
   the latter was persisting on detach from window. However, it is
   not guaranteed that this callback will be received leading to
   lack of presistence sometimes. Now the model is responsible for
   loading and persisting thus voiding the posisbility a misbehaved
   client to cause data loss.

bug:5061638

Change-Id: Ia2b7bb659f7b9abe8869c94b3eaa726ddd4e4fad
2011-07-21 11:36:36 -07:00
Gilles Debunne
31a41d35f6 Bug 4534376: Suggestion popup is not clipped.
This happened when the popup was larger than the screen because of a very long suggestion.
The text will now be ellipsized with a marquee (better than using 2 lines I believe).

Also removed the up layout that was intended to be used when the popup did not fit vertically.
The popup is moved up instead if needed.

Change-Id: Ie741610e74ade10c691614f1c30d0e17b213c698
2011-07-21 10:49:50 -07:00
Gilles Debunne
317ab3427a Merge "Suggestions are dismissed by back key" 2011-07-20 17:51:36 -07:00
Jim Miller
83261239b0 Merge "Fix 5056699: GridLayout should maintain static indices for "gone" views." 2011-07-20 15:19:19 -07:00
Jim Miller
6235b47cba Fix 5056699: GridLayout should maintain static indices for "gone" views.
GridLayout currently ignores views with visibility="gone" when accounting for rows/columns.
Instead it should count views with visibility="gone" as rows/columns with row/height equal to 0.

This also makes it consistent with other ViewGroups like LinearLayout where "gone" views
don't change order and are still present (but hidden) within a container.

Change-Id: I289d4ee6275d5b49b1e1d79985484216bbf48089
2011-07-20 15:13:49 -07:00
Gilles Debunne
caed51bcc2 Merge "Insertion handles fades out after being positionned" 2011-07-20 09:12:41 -07:00