Commit Graph

296 Commits

Author SHA1 Message Date
Grace Kloba
9217c45829 When we destroy a WebView, RESUME_TIMERS/PAUSE_TIMERS may be still in the queue.
We need to pass them to WebViewCore as they are per process base. If we drop
them, the counter in the JWebCoreJavaBridge can be out of order.

Part 2 of fixing http://b/issue?id=2087410
2009-09-01 14:58:10 -07:00
Android (Google) Code Review
169ae05f9f Merge change 23439 into eclair
* changes:
  if exception getMessage() is null, don't add it to the error
2009-09-01 10:14:10 -07:00
Cary Clark
4e441b711a if exception getMessage() is null, don't add it to the error
Consolidate the error message construction, allowing the
exception getMessage() to fail.
2009-09-01 13:01:33 -04:00
Android (Google) Code Review
5e2a385c0d Merge change 23395 into eclair
* changes:
  When we get 304 and switch to cacheLoader, need to set mFromCache to be true. So that the cache loading will not create a new mCacheResult which overwrites the old cache data.
2009-09-01 09:15:45 -07:00
Android (Google) Code Review
05a6f3cde5 Merge change 23434 into eclair
* changes:
  Fix a docs comment to match the parameter name.
2009-09-01 07:20:18 -07:00
Patrick Scott
447811c64f Fix a docs comment to match the parameter name. 2009-09-01 09:57:20 -04:00
Cary Clark
278ce05b52 accelerate consecutive flings
Use the fact that the scroller keeps track of the current velocity
to accelerate subsequent flings. The current velocity is added to
the new velocity if the flings are in the same general direction
and if the fling animation hasn't been aborted.

This makes it easier to move to the top or bottom of very large
pages (either in overview mode or reading mode) by taking
consecutive flings as a cue from the user that they want to
page faster. The user can stop the fling with any action as
before.

fixes http://b/issue?id=2066090
2009-09-01 09:34:21 -04:00
Patrick Scott
05c9ed9ce1 Fix the documentation for onReceivedError.
This change adds the EventHandler error codes to WebViewClient for the public
api. Previously, the api was ambiguous about the value of the errorCode
parameter and falsely documented that the values are HTTP status codes.
2009-09-01 08:37:22 -04:00
Android (Google) Code Review
0c63711338 Merge change 23427 into eclair
* changes:
  Moves GoogleLocationSettingManager to its correct location.
2009-09-01 05:23:26 -07:00
Steve Block
b599315910 Moves GoogleLocationSettingManager to its correct location.
This fixes bug http://b/issue?id=2089259.
2009-09-01 10:18:38 +01:00
Grace Kloba
ef32ee3db8 When we get 304 and switch to cacheLoader, need to set mFromCache to be true.
So that the cache loading will not create a new mCacheResult which overwrites
the old cache data.
2009-08-31 18:43:48 -07:00
Cary Clark
6d45accc71 don't layout when setting size from zoom if only height changed
(companion change in external/webkit)
Add a boolean parameter to WebViewCore.java nativeSizeSize().
If set, only layout if the width has also changed.
If clear, layout if the height alone has changed.
Layout is clear when called from zoom setup, and set otherwise.
2009-08-28 12:46:10 -04:00
Grace Kloba
ce761d3219 Only add model in the UA for the release build 2009-08-27 15:24:59 -07:00
Steve Block
09b0ca1cee Sets default value of 'enableGeolocation' to true. This allows WebKit's DumpRenderTree to function correctly. Note that when Geolocation is used in the browser, this default value is overridden by the browser's default anyway. 2009-08-27 16:17:20 +01:00
Android (Google) Code Review
7537e3dc91 Merge change 22453 into eclair
* changes:
  Sets or clears Geolocation permissions for Google origins when the 'Location & privacy - Share with Google' sysetm setting is changed.
2009-08-27 07:43:36 -07:00
Steve Block
d875ce6dac Sets or clears Geolocation permissions for Google origins when the 'Location & privacy - Share with Google' sysetm setting is changed.
This fixes bug http://b/issue?id=1933893
2009-08-26 12:51:14 +01:00
Ben Murdoch
d497d87650 Pass the estimated size of new HTML 5 databases to the ChromeClient so it can use that amount to figure an initial default quota.
Change-Id:Ic9372b0c86472b42ba5d0b964aaff1e2bbfe3efa
2009-08-26 12:39:55 +01:00
Dianne Hackborn
4a51c20ce6 I am getting tired of the java doc warnings, so fix them.
Change-Id: I2205eebae419eaf4a0992c9f5b7cd807eb843fe1
2009-08-24 17:37:32 -07:00
Leon Scroggins
b2359262b4 Implement new title bar hiding/showing behavior.
Remove the code that hides the title bar when the page finishes loading.
When the user double taps, if it did not result in changing the viewing
mode (i.e. on a mobile site), send a message to the client so we can
toggle the title bar's visibility.  Required for a change to
packages/apps/Browser

Change-Id: I0040fd183ce5673a4069e943f38eb31599c0ca7d
2009-08-24 16:55:42 -04:00
Android (Google) Code Review
840b856d2a Merge change 22452 into eclair
* changes:
  don't center zoom on size change if zoom is in progress
2009-08-24 11:47:53 -07:00
Cary Clark
a91874d1f9 don't center zoom on size change if zoom is in progress
The onSizeChange code is called when the device is rotated and
when the title bar is hidden. In the latter case, it is in response
to the zooming transition from overview mode to reading mode, and
the zoom center should not be recomputed.

http://b/issue?id=2060720
2009-08-24 14:08:43 -04:00
Android (Google) Code Review
d507ff2129 Merge change 22449 into eclair
* changes:
  Check for a null history item to avoid crashing.
2009-08-24 11:00:30 -07:00
Patrick Scott
af31c3a42d Check for a null history item to avoid crashing.
The history item may be null if this page is loaded through loadDataWithBaseURL
so we cannot count on the item being non-null.

Bug: 2073490
2009-08-24 13:59:55 -04:00
Android (Google) Code Review
ba9f5f3f6b Merge change 22440 into eclair
* changes:
  Java-side changes to persist Geolocation permissions between browser sessions.
2009-08-24 10:56:10 -07:00
Patrick Scott
4e9718d6ae Fix synchronous xml requests with ssl errors.
Use the in-memory ssl preference table before posting a message to the WebCore
thread. Since the WebCore thread is blocked waiting for the ssl resource, we
cannot query the user for their preference. If the table does not contain the
user's decision, bail on the request to avoid a deadlock.

Also mark a few of the ssl handler's method's as synchronized. This was reported
by findbugs.
2009-08-24 12:02:51 -04:00
Android (Google) Code Review
7fdab7f967 Merge change 22377 into eclair
* changes:
  The new webkit won't keep RAM cache if http header has "no-store". So remove it from StreamLoader. And fix the code where we only want to cache network  result.
2009-08-24 08:45:06 -07:00
Steve Block
9d3273f622 Java-side changes to persist Geolocation permissions between browser sessions.
This fixes bug http://b/issue?id=2054365.
2009-08-24 11:59:42 +01:00
Steve Block
06cd751b05 Adds Java-side of logic to make Geolocation obey Browser 'Enable Location' setting.
This fixes bug http://b/issue?id=2067559.
2009-08-24 10:59:57 +01:00
Grace Kloba
c3fa098ff6 The new webkit won't keep RAM cache if http header has "no-store". So remove
it from StreamLoader. And fix the code where we only want to cache network  result.
2009-08-21 17:31:11 -07:00
Derek Sollenberger
37eb3c3515 removing old gears code and correcting simple method typo 2009-08-18 14:22:26 -04:00
Android (Google) Code Review
db33d4bbae Merge change 21468 into eclair
* changes:
  Couple of fixes for viewport.
2009-08-18 10:51:49 -07:00
Grace Kloba
7a02d6e457 Couple of fixes for viewport.
http://b/issue?id=2053685. This is a tricky one. When Browser is restarted,
we may get first layout even before viewport tag is parsed. This is rare,
but it happens to Google Reader site. So we need to setup the viewport explicitly
if it happens after first layout. There is a pairing webkit change.

http://b/issue?id=2054131. When Google talk is loaded, it goes through an auth
redirect site which means first layout is called with standardLoad as false.
In this case, even the final site uses viewport tag to get mobile experience,
the intermediate one doesn't. To make sure most of the mobile sites, who
define their viewport width as device width, work correctly, we always update
the mRestoreState when we set viewport.

http://b/issue?id=2054121. When Browser is first started or restarted, the
mCurrentViewWidth is 0 as we don't know the WebView's width yet. As we can't
send VIEW_SIZE_CHANGED message directly, we reset WebView's mLastWidthSent
so that VIEW_SIZE_CHANGED will be sent from WebView when it's width is available.
2009-08-18 10:10:51 -07:00
Android (Google) Code Review
9befde04c3 Merge change 21648 into eclair
* changes:
  Remove the hack to include Gears as it is gone now.
2009-08-18 08:44:18 -07:00
Grace Kloba
325eabdc85 Remove the hack to include Gears as it is gone now. 2009-08-17 18:17:53 -07:00
Grace Kloba
d7660ccb7b Fix 2058938. As zoom control is uesd in overview mode to switch to reading
mode, we also want to hide it after double tap is done.
2009-08-17 17:13:01 -07:00
Android (Google) Code Review
86192c614c Merge change 21442 into eclair
* changes:
  Fix a cookie bug. If "secure" is in the end of the string, it was ignored.
2009-08-17 09:19:23 -07:00
Grace Kloba
dbdad99813 Fix a cookie bug. If "secure" is in the end of the string, it was ignored. 2009-08-16 00:05:01 -07:00
Leon Scroggins
f58ffac202 Hide the title bar when zoomed in. 2009-08-14 14:47:27 -04:00
Steve Block
a8dfe24da0 Adds the ability to configure the mock Geolocation service from DumpRenderTree. 2009-08-14 16:43:28 +01:00
Patrick Scott
68e5300477 The local loaders assume the url given to them is decoded.
Decode the url before passing down to the local loaders since they do not decode
the url themselves. This was creating a crash on youtube.com since the data url
was percent-encoded and failing to parse from base64.
2009-08-14 08:15:30 -04:00
Grace Kloba
455e3af1f8 Fix #2048199. Enable zoom control in the overview mode. When "+" is pressed,
treat it as double click in the middle of the page.
2009-08-13 15:27:52 -07:00
Cary Clark
543221fc4b handle false results in file.delete
found by findbugs
http://b/issue?id=1856614
2009-08-13 15:04:47 -04:00
Leon Scroggins
6679f2f708 Pass clicks to webkit's textfield to determine the new selection.
Requires a corresponding change to external/webkit.  We were previously
letting WebTextView handle clicks, determine the change in selection,
and pass that down to webkit.  This sometimes resulted in a different
placement of the caret if the WebTextView and the webkit-rendered
textfield did not line up exactly.  Now, we pass the click directly
to webkit, which determines the new selection and passes that info
back to the WebTextView.  This also has the benefit of letting
the WebTextView reflect changes in the selection that originated from
webkit. Also remove some unused parameters.
2009-08-13 14:21:24 -04:00
Andrei Popescu
385df699a6 remove Gears 2009-08-13 13:07:48 +01:00
Android (Google) Code Review
f2c9b2c0b4 Merge change 20706
* changes:
  Improve Browser performance by 1-2%. To address domain sanity bug, http://b/issue?id=1022797, we decoded/encoded the url for each request. As the url can be long, getBytes() and String.init are taking 1.5% in nytimes.com and 2.4% in cnn.com. By doing a simple URL encoding test, we can shave 1-2 secs thread time during loading.
2009-08-12 09:27:01 -07:00
Android (Google) Code Review
97732c41c3 Merge change 20744
* changes:
  Adds Java side of browser GeolocationService.
2009-08-12 07:26:48 -07:00
Steve Block
67e1eb6864 Adds Java side of browser GeolocationService. 2009-08-12 15:23:11 +01:00
Android (Google) Code Review
ce6182fa49 Merge change 20788
* changes:
  make private inner classes static
2009-08-11 14:04:32 -07:00
Cary Clark
7ec19876c9 make private inner classes static
bug found by findbugs
http://b/issue?id=1856695
2009-08-11 16:57:43 -04:00
Android (Google) Code Review
2b7d44ed84 Merge change 20781
* changes:
  replace 'new String()' with ""
2009-08-11 13:14:16 -07:00