Commit Graph

59 Commits

Author SHA1 Message Date
TreeHugger Robot
587b60282e Merge "frameworks/base: Add APCT tests to the device-tests suite." 2017-03-16 17:35:12 +00:00
Julia Reynolds
9bfba59417 Better deletions
- Allow apps to delete notification groups (which cascade to delete all
channels therein)
- Allow apps to get their groups, so they know what they might want to
delete
- Don't throw if someone tries to delete something that already doesn't
exist.

Change-Id: I5f6e25497c5da1e57b52737586e86097332f88f9
Fixes: 36245468
Fixes: 36127382
Test: runtest systemui-notification, cts
2017-03-16 14:32:50 +00:00
Julia Reynolds
41103f4212 Support for showing deleted channel count in settings.
Bug: 36119790
Test: runtest systemui-notification
Change-Id: Ie30243314d64ded66267d0dc85cc0ad940d917f8
2017-03-16 14:24:17 +00:00
Julia Reynolds
1d97e6a0c1 Remove resource id channel/group name fields
Apps can listen for the LOCALE_CHANGED broadcast to
change names if needed.

Fixes: 35336590
Test: runtest systemui-notification, cts, manual
Change-Id: I62d2778f61e99200692755a6f268828a374837e6
2017-03-16 14:20:28 +00:00
Simran Basi
473a16e492 frameworks/base: Add APCT tests to the device-tests suite.
This CL adds the APCT tests within this project to
a similar suite as CTS known as device-tests.

The current method of running APCT tests in the infrastructure
is unaffected.

Bug: 35882476
Test: `make dist device-tests -j` and local builds of
      continuous_instrumentation_tests & continuous_native_tests

Change-Id: Ifa382fe691842c1cd76897775b9e2a1653449eb5
2017-03-15 14:46:27 -07:00
Julia Reynolds
e866533f11 Allow blocked apps to create channels
Change-Id: I64b90332095f949af003db3db98da75b22a09c64
Fixes: 36040396
Test: runtest systemui-notification
2017-03-13 17:09:18 +00:00
Paul Duffin
2abe1be543 Use --multi-dex native to avoid dex limit
Bug: 32912773
Test: make checkbuild
Change-Id: If23b6a746494d862059ce76ef20b225a6c27c379
2017-03-11 12:26:13 +00:00
Julia Reynolds
d373d78d15 Log notification channels and groups.
Test: manual, runtest systemui-notification
Change-Id: I326a35ae87e7a3dc4b2587271056b7dd5cd11f8d
2017-03-07 15:25:27 +00:00
Julia Reynolds
03fa85ddcc Prevent creation of default channel.
Test: runtest systemui-notification
Change-Id: Id56debdca2a11bdac5ae11832eaaa04842f0a9be
2017-03-07 00:17:19 +00:00
Julia Reynolds
d528684373 Allow resid notification channel group labels.
Test: cts, runtest systemui, runtest systemui-notification, manual
Change-Id: I9e7b43c97fd04057e1a2614876af958cc2f40a99
2017-03-02 21:08:31 +00:00
Julia Reynolds
5a31193497 Allow translatable channel names.
Bug: 35336590
Test: runtest sytemui runtest systemui-notification, manual
Change-Id: I1e6ebbcc36cab22ab9b2dfde505a68513544ef52
2017-03-02 15:48:12 +00:00
Geoffrey Pitsch
2cda00e29a Merge "Channels for Frameworks notifications" 2017-03-01 17:51:23 +00:00
Julia Reynolds
4024b6696c Reduce flakes.
Test: runtest systemui-notifications
Change-Id: I48dc8be786246e6c639a14b16784a394eac49a6b
2017-03-01 15:54:52 +00:00
Geoffrey Pitsch
af759c52ce Channels for Frameworks notifications
Adapts all notifications used by system services to use channels.
Channels are initialized by SystemServer after the NotificationService
has started.

Test: runtest systemui-notification
Change-Id: I25c45293b786adb57787aeab4c2613c9d7c89dab
2017-03-01 10:17:15 -05:00
Julia Reynolds
a5d2f235ad Send ranking update on channel update.
Change-Id: I26aca0f27df0fca549d863ed6a5fac2c5b025907
Fixes: 35623384
Test: manual, runtest systemui-notification
2017-02-24 14:54:41 -05:00
Julia Reynolds
5098977b20 Change time methods to durations.
Test: cts, cts verifier, runtest systemui-notification
Change-Id: Ia612f59e91f3a3e1de14cd7217fe18ecaf61033c
2017-02-23 14:52:49 -05:00
Julia Reynolds
31b2baac8d Add missing sound to important channels.
Test: runtest systemui-notification
Change-Id: I7b091d312220e3830f2cd613b7ac08f75c5f0a8c
2017-02-22 14:49:23 -05:00
Geoffrey Pitsch
ccc0b97a5f Fix for cancel to remove both posted and enqueued notifications
Bug:34287447
Test: runtest systemui-notification
Change-Id: I7deb3a06416a6eb1b8421273f7dd5115d9b7a05c
2017-02-15 11:02:26 -05:00
Julia Reynolds
74856c4a61 Retrieving groups shouldn't have side effects
Test: runtest systemui-notification, viewing settings
Change-Id: Ib43fe6ad2af4763b633ad1690f69d17533915dbb
2017-02-08 20:35:14 +00:00
Julia Reynolds
529e3329e6 Let developers choose a light color for channels
Test: runtest systemui-notification & cts
Change-Id: Ibfab57924d0a9093af23191ebdd68ce1c0da6eca
2017-02-07 15:46:09 -05:00
Selim Cinek
d755dd0e72 Merge "Fixed test failures for notification comparator" 2017-02-07 00:43:46 +00:00
Selim Cinek
3f146d0de2 Fixed test failures for notification comparator
Test: runtest systemui-notification
Change-Id: I16e6142c99553d541d09390142cd16bbdfa724d2
2017-02-06 13:38:02 -08:00
Julia Reynolds
d94054f956 Check disqualifying notifications synchronously.
Don't wait to check on the handler.

Test: runtest systemui-notification and
platform_testing/tests/functional/notificationtests

Change-Id: Ife1ad8bc5c40420cd6682329b8135744cfe38e4a
2017-02-01 11:47:21 -05:00
Julia Reynolds
a33f5c4312 Deprecate notification fields
And move references to the deprecated fields to
NotificationRecord for testability.

Test: runtest systemui-notification
Change-Id: If3910dc78297ad66679b1efa380315127261a018
2017-02-01 09:56:00 -05:00
Julia Reynolds
033a4120a8 Remove unneeded callbacks to systemui.
Test: runtest systemui-notification
Change-Id: I80155df446be0153bbda4c28b06d3a578339237d
2017-01-31 16:50:38 -05:00
Julia Reynolds
e73724c4f9 Merge "Use TVExtender channel on tv platforms." 2017-01-31 14:06:06 +00:00
Julia Reynolds
5f20e9fedf Use TVExtender channel on tv platforms.
Test: runtest sytemui-notification
Change-Id: I107bba298034778f1d7c0ba31896c4cbbc3fabe9
2017-01-30 19:35:48 +00:00
Julia Reynolds
619a69f722 Add audio attributes to notificationchannel
Test: runtest systemui-notification, cts, manual
Change-Id: I33b5a67190409fe2fc2bc7e2cbbd67ea38bc0655
2017-01-30 08:55:31 -05:00
Julia Reynolds
f02562aeee Show channel groups in settings
Empty groups shouldn't be visible to client code.

Test: runtest systemui-notification
Change-Id: I319b035886ce1bd4b6839ebf46a2c3be7b2387cf
2017-01-27 08:51:45 -05:00
Geoffrey Pitsch
16594465a3 Fix NotificationManagerServiceTest hangs.
Bug caused by message queue going idle before the handler is added.

Bug: 34719217
Test: runtest systemui-notification
Change-Id: I03ba31e5263a43f3e3faa4a19167dbc998092dfa
2017-01-26 15:08:33 -05:00
Julia Reynolds
59e152e92e Add notification channel groups.
Test: runtest systemui-notification, cts
Change-Id: I3ed82f2b20d3f791b7cae379a49373cb41231739
2017-01-26 00:01:06 +00:00
Julia Reynolds
cf63ff1532 Snoozing API changes
- No one can snooze for an undetermined amount of time
- Only the assistant can unsnooze
- Listeners can retrieve a list of snoozed notifications

Test: runtest systemui-notification, cts verifier
Change-Id: Idfaee6d8bc15a5d41630f86f7e852468b07dc7d0
2017-01-24 16:18:52 -05:00
Julia Reynolds
924eed1ca6 Add updatable fields to Ranking
- NotificationChannel
- Badging

Test: runtest systemuinotification & cts

Change-Id: I7fd1f2dc06148927e9a4bd5b760d436e2c5e8a98
2017-01-24 08:43:38 -05:00
Geoffrey Pitsch
331a64d091 Fix cancel notification race condition bug.
Cancel should always remove notifications, regardless of whether
they've been posted internally.  Primarily accomplished by ensuring
all cancels happen on the same handler, and that they check the
enqueued list as well the main notifications list.

Also fixes snoozing for enqueued notifications, since it is
implemented via cancelling.

Test: runtest systemui-notification
Change-Id: If8295a38102f245013d29831a060fabd80716e4b
2017-01-23 12:37:03 -05:00
Julia Reynolds
4036e8d4c6 Save deleted channels.
To discourage the pattern of deleting channels and
recreating them to get around user settings.

Behavior:
- Creating a deleted channel brings back the old channel
(with it's old settings)
- Updating a deleted channel fails
- public getChannel apis should not return deleted channels

Also align data clean up done when clearing data & uninstalling
a package

Test: runtest systemui-notification, cts, cts-verifier

Change-Id: If19c20311c978fd8d3b1cb8b234dc1e68c7356be
2017-01-17 21:31:44 +00:00
Julia Reynolds
7967230de2 Send Snooze callback for Assistant
On selection of a snooze context SnoozeCriterion.

Test: runtest systemui-notification & make cts-verifier
Change-Id: Iaca567100c29295fbbf1d327195a114106909652
2017-01-12 10:40:11 -05:00
Colin Cross
e399468b88 Remove libservicestestsjni
frameworks/base/services/tests/servicestests/jni no longer exists
after I993eeaa5dec001c39389023f355f506129b356e7, remove it.

Test: m -j FrameworksServicesTests
Change-Id: I8f307373aede9e749f1b992dde0f7252bf74b065
2017-01-11 15:57:24 -08:00
Geoffrey Pitsch
9f7fd6c734 Merge "API improvements for creating NotificationChannels" 2017-01-10 16:20:13 +00:00
Geoffrey Pitsch
0353371529 API improvements for creating NotificationChannels
Remove listener for aysnchronous operation.
Allow multiple channel creation from a single call.
Silently no-op for creating existing channels.

Test: runtest systemui-notification
Change-Id: Ibc1340d21efa0c12d126bee437adcbb99141e86a
2017-01-06 16:13:04 -05:00
Julia Reynolds
aebfc4e7a3 Cannot have badge only channels
Test: runtest systemui-notification & cts
Change-Id: I256e35a79400c1d25b3d2f1c7c5f8c513242a2aa
2017-01-06 15:56:44 -05:00
Julia Reynolds
f35e3976e3 Allow apps to enable notification badging.
Test: runtest systemui-notification
Change-Id: Ia16d671d864d1eee902652e31f023e30dc6b7387
2017-01-06 10:57:51 -05:00
Julia Reynolds
7f41c150c3 Merge "Add badging support for channels." 2016-12-21 21:15:45 +00:00
Julia Reynolds
baff400fa5 Add badging support for channels.
In this iteration badges are a user opt in feature.
Known issue: all listeners will receive 'badge only' notifications.

Test: runtest systemui-notification

Change-Id: Ic7450bf4de5351cfdc72bd96ec946fe6e035035c
2016-12-21 21:12:23 +00:00
Julia Reynolds
f4af65bbd6 Don't automatically remove autogroup summaries
Unless there are no notifications left that need to be autogrouped.

Change-Id: I76f90cd083273d1babf1209e3c509d213deffa9c
Fixes: 28612382
Test: runtest systemui-notification
2016-12-20 22:08:09 +00:00
Julia Reynolds
4a02afbf04 Change notification shade ordering.
Certain ongoing and people centric notifications can now
(mostly) trump importance-based ordering.

Bug: 30374279
Test: runtest systemui-notification
Change-Id: Ieab6015174f9595c08057dc408233202035aae3e
2016-12-14 17:58:11 +00:00
TreeHugger Robot
e38cdde5af Merge "Cleanup log spam on system notification post." 2016-12-13 15:22:40 +00:00
Julia Reynolds
52e64d0162 Give assistant ability to modify channels.
Test: cts on same topic
Change-Id: Ia0db73d4d81a89e0821ba6a06f12823605dbea73
2016-12-13 14:00:01 +00:00
Julia Reynolds
19ad7477ce Cleanup log spam on system notification post.
Bug: 33209911
Test: unplug/replug adb cable, monitor log. runtest systemui-notifications
Change-Id: I294ccdcb0a353463fe0c6b52f1dbbd97f4c75079
2016-12-13 13:57:54 +00:00
Julia Reynolds
22f02b3e4a Accept adjustments from notification assistant.
Test: runtest systemui-notification & cts in same topic.
Change-Id: Icff1f89eac32b82d583eca24b0a15f67795912a1
2016-12-07 12:51:16 -05:00
Geoffrey Pitsch
aac3cba531 Merge "Listener in createNotificationChannel" 2016-12-01 19:46:09 +00:00