WebViewDatabase has a getInstance() method, so similarly
to WebStorage, WebIconDatabase etc we refactor it into a
proxy class, and move the current implementation into
WebViewDatabaseClassic.
Also clean up some JavaDoc in touched files.
Bug: 6234236
Change-Id: I71cbd8f78e60f396e96e8546073ad634797cce15
This fixes the JavaDoc style for the following classes ...
- CacheManager.java
- CookieManager.java
- GeolocationPermissions.java
- WebResourceResponse.java
- WebSettings.java
- WebStorage.java
- WebView.java
In particular, this applies the guidelines at
https://wiki.corp.google.com/twiki/bin/view/Main/APIDocumentation
This should help to ensure that future JavaDoc comments use correct style,
rather than using incorrect style for consistency.
Note that this change does not attempt to improve the content of the JavaDoc
comments. This will be done in later changes.
Bug: 5461416
Change-Id: I79e9b15a8cf3597195d58e154a7eb1bcc462944c
This allows CookieManager subclasses to correctly override all behvaior
in the base class.
Bug: 6379925
Change-Id: Ife02db24bc192bc1eabf09e0d64668716786d237
Bug #6365056
WebView enqueues a functor in the hardware renderer to handle
animations and this functor is called at a later time by the
hardware renderer. However, the functor was not removed from
the queue when WebView was removed from the window. This could
cause the hardware renderer to attempt to execute an invalid
functor and lead to a crash.
Change-Id: I9d38e80f3fdc5e29d4d0cdfa1e893c251a954508
This is a quick workaround to get tests running again, will follow up with full fix tomorrow.
Bug: 6379925
Change-Id: I96d6e27bfb8f8cd41ec08845ab0fb1e584dbc9da
There are times when we deliberately put the WebCore thread
to sleep (i.e. waiting for a user to complete a JS prompt or
dismiss an alert). In this case, we don't want the WebCore thread
watchdog to fire. Pause the watchdog before we put the WebCore thread
to sleep and resume it again when the thread wakes up.
Factor out the repeated send/pause/wait/resume code into it's own
function.
Bug: 6366520
Change-Id: I17ecf9d466ce21b25a9e5cb8ff4cb0e5fab7605b
GeolocationPermissionsClassic
CookieManagerClassic
WebIconDatabaseClassic
WebStorageClassic
Also creats a WebViewFactory top level class - this remains hidden
for now, as it's currently only used implicitly by the other
public WebView classes to create the provider instances.
Bug: 5626244
Change-Id: Id0ca1c16d8058f31a86414bbc0e8a55db4b907ba
Bug: 5416822
The overload of webkitDraw is temporary, but this gets the plumbing
in place and works correctly
Change-Id: Ib3e23b9a4a1862dd445c8dc68a3936590787a62b
Bug: 5677901
Also remove a bunch of unnecessary logic around delaying the
scroll until the page load has completed, as Browser will keep the
URL bar visible itself
Change-Id: I4b175f4ff1d741b7027a4c98f676764707f57342