From ff1bb349ff5ca7fb293c95e0bc5e0fbc80de7b1a Mon Sep 17 00:00:00 2001 From: Jimmy Chen Date: Mon, 4 Mar 2019 15:09:54 +0800 Subject: [PATCH] p2p: add annotation for WifiP2pConfig.Builder public API Bug: 126614191 Bug: 126700789 Test: Unit tests - atest FrameworksWifiTests Test: Unit tests - atest FrameworksWifiApiTests Change-Id: Ib47a1a6d7b72977d22c8402a6229de9a631d728e --- api/current.txt | 6 +++--- wifi/java/android/net/wifi/p2p/WifiP2pConfig.java | 8 +++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/api/current.txt b/api/current.txt index d8ec7780230af..959fc7ebd0260 100644 --- a/api/current.txt +++ b/api/current.txt @@ -30419,9 +30419,9 @@ package android.net.wifi.p2p { public static final class WifiP2pConfig.Builder { ctor public WifiP2pConfig.Builder(); - method public android.net.wifi.p2p.WifiP2pConfig build(); - method public android.net.wifi.p2p.WifiP2pConfig.Builder enablePersistentMode(boolean); - method public android.net.wifi.p2p.WifiP2pConfig.Builder setDeviceAddress(android.net.MacAddress); + method @NonNull public android.net.wifi.p2p.WifiP2pConfig build(); + method @NonNull public android.net.wifi.p2p.WifiP2pConfig.Builder enablePersistentMode(boolean); + method @NonNull public android.net.wifi.p2p.WifiP2pConfig.Builder setDeviceAddress(@Nullable android.net.MacAddress); method public android.net.wifi.p2p.WifiP2pConfig.Builder setGroupOperatingBand(int); method public android.net.wifi.p2p.WifiP2pConfig.Builder setGroupOperatingFrequency(int); method public android.net.wifi.p2p.WifiP2pConfig.Builder setNetworkName(String); diff --git a/wifi/java/android/net/wifi/p2p/WifiP2pConfig.java b/wifi/java/android/net/wifi/p2p/WifiP2pConfig.java index 5e1f5697c2585..d897eeb11a41d 100644 --- a/wifi/java/android/net/wifi/p2p/WifiP2pConfig.java +++ b/wifi/java/android/net/wifi/p2p/WifiP2pConfig.java @@ -17,6 +17,8 @@ package android.net.wifi.p2p; import android.annotation.IntDef; +import android.annotation.NonNull; +import android.annotation.Nullable; import android.annotation.UnsupportedAppUsage; import android.net.MacAddress; import android.net.wifi.WpsInfo; @@ -240,7 +242,7 @@ public class WifiP2pConfig implements Parcelable { * @return The builder to facilitate chaining * {@code builder.setXXX(..).setXXX(..)}. */ - public Builder setDeviceAddress(MacAddress deviceAddress) { + public @NonNull Builder setDeviceAddress(@Nullable MacAddress deviceAddress) { if (deviceAddress == null) { mDeviceAddress = MAC_ANY_ADDRESS; } else { @@ -391,7 +393,7 @@ public class WifiP2pConfig implements Parcelable { * @return The builder to facilitate chaining * {@code builder.setXXX(..).setXXX(..)}. */ - public Builder enablePersistentMode(boolean persistent) { + public @NonNull Builder enablePersistentMode(boolean persistent) { if (persistent) { mNetId = WifiP2pGroup.PERSISTENT_NET_ID; } else { @@ -404,7 +406,7 @@ public class WifiP2pConfig implements Parcelable { * Build {@link WifiP2pConfig} given the current requests made on the builder. * @return {@link WifiP2pConfig} constructed based on builder method calls. */ - public WifiP2pConfig build() { + public @NonNull WifiP2pConfig build() { if (TextUtils.isEmpty(mNetworkName)) { throw new IllegalStateException( "network name must be non-empty.");