Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add TODO comments to remove start/stopReverseTethering

Browse Source 
Change start/stopReverseTethering permission from CHANGE_NETWORK_STATE
to CONNECTIVITY_INTERNAL

Change-Id: Iac76d5af6418e6a3e2d2f77bf713466981285e1a
This commit is contained in:
Matthew Xie
2012-07-12 16:03:32 -07:00
committed by Android (Google) Code Review
parent 6fde309807
commit fe19f1234e
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
services/java/com/android/server/NetworkManagementService.java
View File

@@ -780,11 +780,12 @@ public class NetworkManagementService extends INetworkManagementService.Stub
event.checkCode(TetherStatusResult);
return event.getMessage().endsWith("started");
}
// TODO(BT) Remove
public void startReverseTethering(String iface)
throws IllegalStateException {
if (DBG) Slog.d(TAG, "startReverseTethering in");
mContext.enforceCallingOrSelfPermission(
android.Manifest.permission.CHANGE_NETWORK_STATE, "NetworkManagementService");
mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
// cmd is "tether start first_start first_stop second_start second_stop ..."
// an odd number of addrs will fail
String cmd = "tether start-reverse";
@@ -798,9 +799,10 @@ public class NetworkManagementService extends INetworkManagementService.Stub
BluetoothTetheringDataTracker.getInstance().startReverseTether(iface);
}
// TODO(BT) Remove
public void stopReverseTethering() throws IllegalStateException {
mContext.enforceCallingOrSelfPermission(
android.Manifest.permission.CHANGE_NETWORK_STATE, "NetworkManagementService");
mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
try {
mConnector.doCommand("tether stop-reverse");
} catch (NativeDaemonConnectorException e) {