Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Better test for setStorageParams." into rvc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2020-04-08 23:00:45 +00:00
committed by Android (Google) Code Review
parent 1be609a3a8 0a646ca739
commit fdcbfb8c77
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
services/incremental/test/IncrementalServiceTest.cpp
View File

@@ -137,6 +137,7 @@ public:
bool* _aidl_return) { bool* _aidl_return) {
mId = mountId; mId = mountId;
mListener = listener; mListener = listener;
mServiceConnector = control.service;
*_aidl_return = true; *_aidl_return = true;
return binder::Status::ok(); return binder::Status::ok();
} }
@@ -166,9 +167,17 @@ public:
mListener->onStatusChanged(mId, IDataLoaderStatusListener::DATA_LOADER_CREATED); mListener->onStatusChanged(mId, IDataLoaderStatusListener::DATA_LOADER_CREATED);
} }
int32_t setStorageParams(bool enableReadLogs) {
int32_t result = -1;
EXPECT_NE(mServiceConnector.get(), nullptr);
EXPECT_TRUE(mServiceConnector->setStorageParams(enableReadLogs, &result).isOk());
return result;
}
private: private:
int mId; int mId;
sp<IDataLoaderStatusListener> mListener; sp<IDataLoaderStatusListener> mListener;
sp<IIncrementalServiceConnector> mServiceConnector;
sp<IDataLoader> mDataLoader = sp<IDataLoader>(new FakeDataLoader()); sp<IDataLoader> mDataLoader = sp<IDataLoader>(new FakeDataLoader());
}; };
@@ -453,7 +462,7 @@ TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsSuccess) {
mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {}, mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {},
IncrementalService::CreateOptions::CreateNew); IncrementalService::CreateOptions::CreateNew);
ASSERT_GE(storageId, 0); ASSERT_GE(storageId, 0);
ASSERT_GE(mIncrementalService->setStorageParams(storageId, true), 0); ASSERT_GE(mDataLoaderManager->setStorageParams(true), 0);
} }
TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsSuccessAndPermissionChanged) { TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsSuccessAndPermissionChanged) {
@@ -480,7 +489,7 @@ TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsSuccessAndPermissionChang
mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {}, mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {},
IncrementalService::CreateOptions::CreateNew); IncrementalService::CreateOptions::CreateNew);
ASSERT_GE(storageId, 0); ASSERT_GE(storageId, 0);
ASSERT_GE(mIncrementalService->setStorageParams(storageId, true), 0); ASSERT_GE(mDataLoaderManager->setStorageParams(true), 0);
ASSERT_NE(nullptr, mAppOpsManager->mStoredCallback.get()); ASSERT_NE(nullptr, mAppOpsManager->mStoredCallback.get());
mAppOpsManager->mStoredCallback->opChanged(0, {}); mAppOpsManager->mStoredCallback->opChanged(0, {});
} }
@@ -503,7 +512,7 @@ TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsCheckPermissionFails) {
mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {}, mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {},
IncrementalService::CreateOptions::CreateNew); IncrementalService::CreateOptions::CreateNew);
ASSERT_GE(storageId, 0); ASSERT_GE(storageId, 0);
ASSERT_LT(mIncrementalService->setStorageParams(storageId, true), 0); ASSERT_LT(mDataLoaderManager->setStorageParams(true), 0);
} }
TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsFails) { TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsFails) {
@@ -526,7 +535,7 @@ TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsFails) {
mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {}, mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {},
IncrementalService::CreateOptions::CreateNew); IncrementalService::CreateOptions::CreateNew);
ASSERT_GE(storageId, 0); ASSERT_GE(storageId, 0);
ASSERT_LT(mIncrementalService->setStorageParams(storageId, true), 0); ASSERT_LT(mDataLoaderManager->setStorageParams(true), 0);
} }
TEST_F(IncrementalServiceTest, testMakeDirectory) { TEST_F(IncrementalServiceTest, testMakeDirectory) {