Merge "Fix filedescriptor leakage in MediaMetadataRetriever"

This commit is contained in:
Narayan Kamath
2015-06-25 08:33:49 +00:00
committed by Gerrit Code Review

View File

@@ -64,9 +64,7 @@ public class MediaMetadataRetriever
throw new IllegalArgumentException();
}
FileInputStream is = null;
try {
is = new FileInputStream(path);
try (FileInputStream is = new FileInputStream(path)) {
FileDescriptor fd = is.getFD();
setDataSource(fd, 0, 0x7ffffffffffffffL);
} catch (FileNotFoundException fileEx) {
@@ -74,12 +72,6 @@ public class MediaMetadataRetriever
} catch (IOException ioEx) {
throw new IllegalArgumentException();
}
try {
if (is != null) {
is.close();
}
} catch (Exception e) {}
}
/**